1 ackage SL::BackgroundJob::SelfTest::Transactions;
5 use parent qw(SL::BackgroundJob::SelfTest::Base);
9 use Rose::Object::MakeMethods::Generic (
10 scalar => [ qw(dbh fromdate todate) ],
18 $self->tester->plan(tests => 20);
20 $self->check_konten_mit_saldo_nicht_in_guv;
21 $self->check_bilanzkonten_mit_pos_eur;
22 $self->check_balanced_individual_transactions;
23 $self->check_verwaiste_acc_trans_eintraege;
24 $self->check_verwaiste_invoice_eintraege;
25 $self->check_ar_acc_trans_amount;
26 $self->check_ap_acc_trans_amount;
27 $self->check_netamount_laut_invoice_ar;
28 $self->check_invnumbers_unique;
29 $self->check_summe_stornobuchungen;
32 $self->check_ar_overpayments;
33 $self->check_ap_overpayments;
34 $self->check_paid_stornos;
35 $self->check_stornos_ohne_partner;
36 $self->check_overpayments;
37 $self->check_every_account_with_taxkey;
38 $self->calc_saldenvortraege;
39 $self->check_missing_tax_bookings;
45 # TODO FIXME calc dates better, unless this is wanted
47 #$self->fromdate(DateTime->new(day => 1, month => 1, year => DateTime->today->year));
48 #$self->todate($self->fromdate->clone->add(years => 1)->add(days => -1));
49 $self->fromdate(DateTime->new(day => 1, month => 1, year => 2015));
50 $self->todate($self->fromdate->clone->add(years => 1)->add(days => -1));
51 $main::lxdebug->message(0, 'hier und dort:' . $self->fromdate . ' mit ' . $self->todate);
52 $self->dbh($::form->get_standard_dbh);
55 sub check_konten_mit_saldo_nicht_in_guv {
59 SELECT c.accno, c.description, c.category, SUM(a.amount) AS Saldo
62 WHERE c.id = a.chart_id
63 and (c.category like 'I' or c.category like 'E')
66 and a.transdate >= ? and a.transdate <= ?
67 GROUP BY c.accno,c.description,c.category,c.pos_bilanz,c.pos_eur
70 my $konten_nicht_in_guv = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
72 my $correct = 0 == scalar grep { $_->{Saldo} } @$konten_nicht_in_guv;
74 $self->tester->ok($correct, "Erfolgskonten mit Saldo nicht in GuV (Saldenvortragskonten können ignoriert werden, sollten aber 0 sein)");
76 for my $konto (@$konten_nicht_in_guv) {
77 $self->tester->diag($konto);
82 sub check_bilanzkonten_mit_pos_eur {
85 my $query = qq|SELECT accno, description FROM chart WHERE (category = 'A' OR category = 'L' OR category = 'Q') AND (pos_eur IS NOT NULL OR pos_eur != 0)|;
87 my $bilanzkonten_mit_pos_eur = selectall_hashref_query($::form, $self->dbh, $query);
88 if (@$bilanzkonten_mit_pos_eur) {
89 $self->tester->ok(0, "Es gibt Bilanzkonten die der GuV/EÜR zugeordnet sind)");
90 $self->tester->diag("$_->{accno} $_->{description}") for @$bilanzkonten_mit_pos_eur;
92 $self->tester->ok(1, "Keine Bilanzkonten in der GuV");
96 sub check_balanced_individual_transactions {
100 select sum(ac.amount) as amount,trans_id,ar.invnumber as ar,ap.invnumber as ap,gl.reference as gl
102 left join ar on (ar.id = ac.trans_id)
103 left join ap on (ap.id = ac.trans_id)
104 left join gl on (gl.id = ac.trans_id)
105 where ac.transdate >= ? AND ac.transdate <= ?
106 group by trans_id,ar.invnumber,ap.invnumber,gl.reference
107 having sum(ac.amount) != 0;|;
109 my $acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
111 $self->tester->ok(0, "Es gibt unausgeglichene acc_trans-Transaktionen:");
112 for my $ac (@{ $acs }) {
113 $self->tester->diag("trans_id: $ac->{trans_id}, amount = $ac->{amount}, ar: $ac->{ar} ap: $ac->{ap} gl: $ac->{gl}");
116 $self->tester->ok(1, "Alle acc_trans Transaktionen ergeben in Summe 0, keine unausgeglichenen Transaktionen");
120 sub check_verwaiste_acc_trans_eintraege {
124 select trans_id,amount,accno,description from acc_trans a
125 left join chart c on (c.id = a.chart_id)
126 where trans_id not in (select id from gl union select id from ar union select id from ap order by id)
127 and a.transdate >= ? and a.transdate <= ? ;|;
129 my $verwaiste_acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
130 if (@$verwaiste_acs) {
131 $self->tester->ok(0, "Es gibt verwaiste acc-trans Einträge! (wo ar/ap/gl-Eintrag fehlt)");
132 $self->tester->diag($_) for @$verwaiste_acs;
134 $self->tester->ok(1, "Keine verwaisten acc-trans Einträge (wo ar/ap/gl-Eintrag fehlt)");
138 sub check_verwaiste_invoice_eintraege {
139 # this check is always run for all invoice entries in the entire database
142 select * from invoice i
143 where trans_id not in (select id from ar union select id from ap order by id) |;
145 my $verwaiste_invoice = selectall_hashref_query($::form, $self->dbh, $query);
146 if (@$verwaiste_invoice) {
147 $self->tester->ok(0, "Es gibt verwaiste invoice Einträge! (wo ar/ap-Eintrag fehlt)");
148 for my $invoice ( @{ $verwaiste_invoice }) {
149 $self->tester->diag("invoice: id: $invoice->{id} trans_id: $invoice->{trans_id} description: $invoice->{description} itime: $invoice->{itime}");
152 $self->tester->ok(1, "Keine verwaisten invoice Einträge (wo ar/ap-Eintrag fehlt)"); }
155 sub check_netamount_laut_invoice_ar {
158 select sum(round(cast(i.qty*(i.fxsellprice * (1-i.discount)) as numeric), 2))
160 left join ar a on (a.id = i.trans_id)
161 where a.transdate >= ? and a.transdate <= ?;|;
162 my ($netamount_laut_invoice) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
164 $query = qq| select sum(netamount) from ar where transdate >= ? and transdate <= ? AND invoice; |;
165 my ($netamount_laut_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
167 # should be enough to get a diff below 1. We have currently the following issues:
168 # verkaufsbericht berücksichtigt keinen rabatt
169 # fxsellprice ist mit mwst-inklusive
170 my $correct = abs($netamount_laut_invoice - $netamount_laut_ar) < 1;
172 $self->tester->ok($correct, "Summe laut Verkaufsbericht sollte gleich Summe aus Verkauf -> Berichte -> Rechnungen sein");
174 $self->tester->diag("Netto-Summe laut Verkaufsbericht (invoice): $netamount_laut_invoice");
175 $self->tester->diag("Netto-Summe laut Verkauf -> Berichte -> Rechnungen: $netamount_laut_ar");
179 sub check_invnumbers_unique {
182 my $query = qq| select invnumber,count(invnumber) as count from ar
183 where transdate >= ? and transdate <= ?
185 having count(invnumber) > 1; |;
186 my $non_unique_invnumbers = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
188 if (@$non_unique_invnumbers) {
189 $self->tester->ok(0, "Es gibt doppelte Rechnungsnummern");
190 for my $invnumber (@{ $non_unique_invnumbers }) {
191 $self->tester->diag("invnumber: $invnumber->{invnumber} $invnumber->{count}x");
194 $self->tester->ok(1, "Alle Rechnungsnummern sind eindeutig");
198 sub check_summe_stornobuchungen {
202 select sum(amount) from ar a JOIN customer c ON (a.customer_id = c.id)
204 AND a.transdate >= ? and a.transdate <= ?|;
205 my ($summe_stornobuchungen_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
208 select sum(amount) from ap a JOIN vendor c ON (a.vendor_id = c.id)
210 AND a.transdate >= ? and a.transdate <= ?|;
211 my ($summe_stornobuchungen_ap) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
213 $self->tester->ok($summe_stornobuchungen_ap == 0, 'Summe aller Einkaufsrechnungen (stornos + stornierte) soll 0 sein');
214 $self->tester->ok($summe_stornobuchungen_ar == 0, 'Summe aller Verkaufsrechnungen (stornos + stornierte) soll 0 sein');
215 $self->tester->diag("Summe Verkaufsrechnungen (ar): $summe_stornobuchungen_ar") if $summe_stornobuchungen_ar;
216 $self->tester->diag("Summe Einkaufsrechnungen (ap): $summe_stornobuchungen_ap") if $summe_stornobuchungen_ap;
223 select invnumber,paid,
224 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as accpaid ,
225 paid+(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as diff
228 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') is not null
230 AND transdate >= ? and transdate <= ?
233 my $paid_diffs_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
235 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ar;
237 $self->tester->ok(!$errors, "Vergleich ar paid mit acc_trans AR_paid");
239 for my $paid_diff_ar (@{ $paid_diffs_ar }) {
240 next if $paid_diff_ar->{diff} == 0;
241 $self->tester->diag("ar invnumber: $paid_diff_ar->{invnumber} : paid: $paid_diff_ar->{paid} acc_paid= $paid_diff_ar->{accpaid} diff: $paid_diff_ar->{diff}");
249 select invnumber,paid,
250 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as accpaid ,
251 paid-(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as diff
254 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') is not null
255 AND transdate >= ? and transdate <= ?
258 my $paid_diffs_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
260 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ap;
262 $self->tester->ok(!$errors, "Vergleich ap paid mit acc_trans AP_paid");
263 for my $paid_diff_ap (@{ $paid_diffs_ap }) {
264 next if $paid_diff_ap->{diff} == 0;
265 $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
269 sub check_ar_overpayments {
273 select invnumber,paid,amount,transdate,c.customernumber,c.name from ar left join customer c on (ar.customer_id = c.id)
274 where abs(paid) > abs(amount)
275 AND transdate >= ? and transdate <= ?
276 order by invnumber;|;
278 my $overpaids_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
280 my $correct = 0 == @$overpaids_ar;
282 $self->tester->ok($correct, "Keine Überzahlungen laut ar.paid");
283 for my $overpaid_ar (@{ $overpaids_ar }) {
284 $self->tester->diag("ar invnumber: $overpaid_ar->{invnumber} : paid: $overpaid_ar->{paid} amount= $overpaid_ar->{amount} transdate = $overpaid_ar->{transdate}");
288 sub check_ap_overpayments {
292 select invnumber,paid,amount,transdate,vc.vendornumber,vc.name from ap left join vendor vc on (ap.vendor_id = vc.id)
293 where abs(paid) > abs(amount)
294 AND transdate >= ? and transdate <= ?
295 order by invnumber;|;
297 my $overpaids_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
299 my $correct = 0 == @$overpaids_ap;
301 $self->tester->ok($correct, "Überzahlungen laut ap.paid:");
302 for my $overpaid_ap (@{ $overpaids_ap }) {
303 $self->tester->diag("ap invnumber: $overpaid_ap->{invnumber} : paid: $overpaid_ap->{paid} amount= $overpaid_ap->{amount} transdate = $overpaid_ap->{transdate}");
307 sub check_paid_stornos {
311 SELECT ar.invnumber,sum(amount - COALESCE((SELECT sum(amount)*-1
312 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
313 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id ),0)) as "open"
317 AND (ar.customer_id = customer.id)
318 AND ar.transdate >= ? and ar.transdate <= ?
319 GROUP BY ar.invnumber|;
320 my $paid_stornos = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
322 $self->tester->ok(0 == @$paid_stornos, "Keine bezahlten Stornos");
323 for my $paid_storno (@{ $paid_stornos }) {
324 $self->tester->diag("invnumber: $paid_storno->{invnumber} offen: $paid_storno->{open}");
328 sub check_stornos_ohne_partner {
332 SELECT (SELECT cast ('ar' as text)) as invoice ,ar.id,invnumber,storno,amount,transdate,type,customernumber as cv_number
334 LEFT JOIN customer c on (c.id = ar.customer_id)
335 WHERE storno_id is null AND storno is true AND ar.id not in (SELECT storno_id FROM ar WHERE storno_id is not null AND storno is true)
336 AND ar.transdate >= ? and ar.transdate <= ?
338 SELECT (SELECT cast ('ap' as text)) as invoice,ap.id,invnumber,storno,amount,transdate,type,vendornumber as cv_number
340 LEFT JOIN vendor v on (v.id = ap.vendor_id)
341 WHERE storno_id is null AND storno is true AND ap.id not in (SELECT storno_id FROM ap WHERE storno_id is not null AND storno is true)
342 AND ap.transdate >= ? and ap.transdate <= ?|;
344 my $stornos_ohne_partner = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
345 $self->fromdate, $self->todate);
347 $self->tester->ok(@$stornos_ohne_partner == 0, 'Es sollte keine Stornos ohne Partner geben');
348 if (@$stornos_ohne_partner) {
349 $self->tester->diag("Stornos ohne Partner, oder Storno über Jahreswechsel hinaus");
351 my $stornoheader = 0;
352 for my $storno (@{ $stornos_ohne_partner }) {
353 if (!$stornoheader++) {
354 $self->tester->diag(join "\t", keys %$storno);
356 $self->tester->diag(join "\t", map { $storno->{$_} } keys %$storno);
360 sub check_overpayments {
363 # Vergleich ar.paid und das was laut acc_trans bezahlt wurde
364 # "als bezahlt markieren" ohne sauberes Ausbuchen führt zu Differenzen bei offenen Forderungen
365 # geht nur auf wenn acc_trans Zahlungseingänge auch im Untersuchungszeitraum lagen
366 # Stornos werden rausgefiltert
369 invnumber,customernumber,name,ar.transdate,ar.datepaid,
371 amount-paid as "open via ar",
372 paid as "paid via ar",
373 coalesce((SELECT sum(amount)*-1 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
374 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id AND acc_trans.transdate <= ?),0) as "paid via acc_trans"
375 FROM ar left join customer c on (c.id = ar.customer_id)
378 AND transdate >= ? AND transdate <= ?|;
380 my $invoices = selectall_hashref_query($::form, $self->dbh, $query, $self->todate, $self->fromdate, $self->todate);
382 my $count_overpayments = scalar grep {
383 $_->{"paid via ar"} != $_->{"paid via acc_trans"}
384 || ( $_->{"amount"} - $_->{"paid via acc_trans"} != $_->{"open via ar"}
385 && $_->{"paid via ar"} != $_->{"paid via acc_trans"} )
388 $self->tester->ok($count_overpayments == 0, 'Vergleich ar.paid und das was laut acc_trans bezahlt wurde');
390 if ($count_overpayments) {
391 for my $invoice (@{ $invoices }) {
392 if ($invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
393 $self->tester->diag("paid via ar (@{[ $invoice->{'paid via ar'} * 1 ]}) != paid via acc_trans (@{[ $invoice->{'paid via acc_trans'} * 1 ]}) (at least until transdate!)");
394 if (defined $invoice->{datepaid}) {
395 $self->tester->diag("datepaid = $invoice->{datepaid})");
397 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
398 } elsif ( $invoice->{"amount"} - $invoice->{"paid via acc_trans"} != $invoice->{"open via ar"} && $invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
399 $self->tester->diag("amount - paid_via_acc_trans != open_via_ar");
400 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
408 sub calc_saldenvortraege {
411 my $saldenvortragskonto = '9000';
413 # Saldo Saldenvortragskonto 9000 am Jahresanfang
415 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
416 my ($saldo_9000_jahresanfang) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 1, month => 1, year => DateTime->today->year));
417 $self->tester->diag("Saldo 9000 am 01.01.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresanfang * 1 ]} (sollte 0 sein)");
419 # Saldo Saldenvortragskonto 9000 am Jahresende
421 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
422 my ($saldo_9000_jahresende) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 31, month => 12, year => DateTime->today->year));
423 $self->tester->diag("Saldo $saldenvortragskonto am 31.12.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresende * 1 ]} (sollte 0 sein)");
426 sub check_every_account_with_taxkey {
429 my $query = qq|SELECT accno, description FROM chart WHERE id NOT IN (select chart_id from taxkeys)|;
430 my $accounts_without_tk = selectall_hashref_query($::form, $self->dbh, $query);
432 if ( scalar @{ $accounts_without_tk } > 0 ){
433 $self->tester->ok(0, "Folgende Konten haben keinen gültigen Steuerschlüssel:");
435 for my $account_without_tk (@{ $accounts_without_tk } ) {
436 $self->tester->diag("Kontonummer: $account_without_tk->{accno} Beschreibung: $account_without_tk->{description}");
439 $self->tester->ok(1, "Jedes Konto hat einen gültigen Steuerschlüssel!");
443 sub check_ar_acc_trans_amount {
447 select sum(ac.amount) as amount, ar.invnumber,ar.netamount
448 from acc_trans ac left join ar on (ac.trans_id = ar.id)
449 WHERE ac.chart_link like 'AR_amount%'
450 AND ac.transdate >= ? AND ac.transdate <= ?
451 group by invnumber,netamount having sum(ac.amount) <> ar.netamount|;
453 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
455 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
456 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
458 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
459 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{amount}
460 Nebenbuch-Wert: $ar_ac_amount_nok->{netamount}");
463 $self->tester->ok(1, "Hauptbuch-Nettowert und Debitoren-Nebenbuch-Nettowert stimmen überein.");
468 sub check_ap_acc_trans_amount {
472 select sum(ac.amount) as amount, ap.invnumber,ap.netamount
473 from acc_trans ac left join ap on (ac.trans_id = ap.id)
474 WHERE ac.chart_link like 'AR_amount%'
475 AND ac.transdate >= ? AND ac.transdate <= ?
476 group by invnumber,netamount having sum(ac.amount) <> ap.netamount*-1|;
478 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
480 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
481 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
483 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
484 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{amount}
485 Nebenbuch-Wert: $ap_ac_amount_nok->{netamount}");
488 $self->tester->ok(1, "Hauptbuch-Nettowert und Kreditoren-Nebenbuch-Nettowert stimmen überein.");
494 sub check_missing_tax_bookings {
498 # check tax bookings. all taxkey <> 0 should have tax bookings in acc_trans
500 my $query = qq| select trans_id, chart.accno,transdate from acc_trans left join chart on (chart.id = acc_trans.chart_id)
501 WHERE taxkey <> 0 AND trans_id NOT IN
502 (select trans_id from acc_trans where chart_link ilike '%tax%' and trans_id IN
503 (SELECT trans_id from acc_trans where taxkey <> 0))
504 AND transdate >= ? AND transdate <= ?|;
506 my $missing_tax_bookings = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
508 if ( scalar @{ $missing_tax_bookings } > 0 ) {
509 $self->tester->ok(0, "Folgende Konten weisen Buchungen ohne Steuer auf:");
511 for my $acc_trans_nok (@{ $missing_tax_bookings } ) {
512 $self->tester->diag("Kontonummer: $acc_trans_nok->{accno} Belegdatum: $acc_trans_nok->{transdate} Trans-ID: $acc_trans_nok->{trans_id}.
513 Kann über System -> Korrekturen im Hauptbuch bereinigt werden.");
516 $self->tester->ok(1, "Hauptbuch-Nettowert und Nebenbuch-Nettowert stimmen überein.");
529 SL::BackgroundJob::SelfTest::Transactions - base tests
533 Several tests for data integrity.
541 G. Richardson E<lt>information@richardson-bueren.deE<gt>
542 Jan Büren E<lt>information@richardson-bueren.deE<gt>
543 Sven Schoeling E<lt>s.schoeling@linet-services.deE<gt>