1 package SL::BackgroundJob::SelfTest::Transactions;
5 use parent qw(SL::BackgroundJob::SelfTest::Base);
9 use Rose::Object::MakeMethods::Generic (
10 scalar => [ qw(dbh fromdate todate) ],
18 $self->tester->plan(tests => 32);
20 $self->check_konten_mit_saldo_nicht_in_guv;
21 $self->check_bilanzkonten_mit_pos_eur;
22 $self->check_balanced_individual_transactions;
23 $self->check_verwaiste_acc_trans_eintraege;
24 $self->check_verwaiste_invoice_eintraege;
25 $self->check_ar_acc_trans_amount;
26 $self->check_ap_acc_trans_amount;
27 $self->check_netamount_laut_invoice_ar;
28 $self->check_invnumbers_unique;
29 $self->check_summe_stornobuchungen;
32 $self->check_ar_overpayments;
33 $self->check_ap_overpayments;
34 $self->check_paid_stornos;
35 $self->check_stornos_ohne_partner;
36 $self->check_overpayments;
37 $self->check_every_account_with_taxkey;
38 $self->calc_saldenvortraege;
39 $self->check_missing_tax_bookings;
40 $self->check_bank_transactions_overpayments;
41 $self->check_ar_paid_acc_trans;
42 $self->check_ap_paid_acc_trans;
43 $self->check_zero_amount_paid_but_datepaid_exists;
44 $self->check_orphaned_reconciliated_links;
45 $self->check_recommended_client_settings;
46 $self->check_orphaned_bank_transaction_acc_trans_links;
47 $self->check_consistent_itimes;
53 # TODO FIXME calc dates better, unless this is wanted
54 $self->fromdate(DateTime->new(day => 1, month => 1, year => DateTime->today->year));
55 $self->todate($self->fromdate->clone->add(years => 1)->add(days => -1));
56 $self->dbh($::form->get_standard_dbh);
59 sub check_konten_mit_saldo_nicht_in_guv {
63 SELECT c.accno, c.description, c.category, SUM(a.amount) AS Saldo
66 WHERE c.id = a.chart_id
67 and (c.category like 'I' or c.category like 'E')
70 and a.transdate >= ? and a.transdate <= ?
71 GROUP BY c.accno,c.description,c.category,c.pos_bilanz,c.pos_eur
74 my $konten_nicht_in_guv = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
76 my $correct = 0 == scalar grep { $_->{Saldo} } @$konten_nicht_in_guv;
78 $self->tester->ok($correct, "Erfolgskonten mit Saldo nicht in GuV (Saldenvortragskonten können ignoriert werden, sollten aber 0 sein)");
80 for my $konto (@$konten_nicht_in_guv) {
81 $self->tester->diag($konto);
86 sub check_bilanzkonten_mit_pos_eur {
89 my $query = qq|SELECT accno, description FROM chart WHERE (category = 'A' OR category = 'L' OR category = 'Q') AND (pos_eur IS NOT NULL OR pos_eur != 0)|;
91 my $bilanzkonten_mit_pos_eur = selectall_hashref_query($::form, $self->dbh, $query);
92 if (@$bilanzkonten_mit_pos_eur) {
93 $self->tester->ok(0, "Es gibt Bilanzkonten die der GuV/EÜR zugeordnet sind)");
94 $self->tester->diag("$_->{accno} $_->{description}") for @$bilanzkonten_mit_pos_eur;
96 $self->tester->ok(1, "Keine Bilanzkonten in der GuV");
100 sub check_balanced_individual_transactions {
104 select sum(ac.amount) as amount,trans_id,ar.invnumber as ar,ap.invnumber as ap,gl.reference as gl
106 left join ar on (ar.id = ac.trans_id)
107 left join ap on (ap.id = ac.trans_id)
108 left join gl on (gl.id = ac.trans_id)
109 where ac.transdate >= ? AND ac.transdate <= ?
110 group by trans_id,ar.invnumber,ap.invnumber,gl.reference
111 having sum(ac.amount) != 0;|;
113 my $acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
115 $self->tester->ok(0, "Es gibt unausgeglichene acc_trans-Transaktionen:");
116 for my $ac (@{ $acs }) {
117 $self->tester->diag("trans_id: $ac->{trans_id}, amount = $ac->{amount}, ar: $ac->{ar} ap: $ac->{ap} gl: $ac->{gl}");
120 $self->tester->ok(1, "Alle acc_trans Transaktionen ergeben in Summe 0, keine unausgeglichenen Transaktionen");
124 sub check_verwaiste_acc_trans_eintraege {
128 select trans_id,amount,accno,description from acc_trans a
129 left join chart c on (c.id = a.chart_id)
130 where trans_id not in (select id from gl union select id from ar union select id from ap order by id)
131 and a.transdate >= ? and a.transdate <= ? ;|;
133 my $verwaiste_acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
134 if (@$verwaiste_acs) {
135 $self->tester->ok(0, "Es gibt verwaiste acc-trans Einträge! (wo ar/ap/gl-Eintrag fehlt)");
136 $self->tester->diag($_) for @$verwaiste_acs;
138 $self->tester->ok(1, "Keine verwaisten acc-trans Einträge (wo ar/ap/gl-Eintrag fehlt)");
142 sub check_verwaiste_invoice_eintraege {
143 # this check is always run for all invoice entries in the entire database
146 select * from invoice i
147 where trans_id not in (select id from ar WHERE ar.transdate >=? AND ar.transdate <=?
149 select id from ap WHERE ap.transdate >= ? and ap.transdate <= ?)
150 AND i.transdate >=? AND i.transdate <=?|;
152 my $verwaiste_invoice = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
153 $self->fromdate, $self->todate, $self->fromdate, $self->todate);
156 if (@$verwaiste_invoice) {
157 $self->tester->ok(0, "Es gibt verwaiste invoice Einträge! (wo ar/ap-Eintrag fehlt)");
158 for my $invoice ( @{ $verwaiste_invoice }) {
159 $self->tester->diag("invoice: id: $invoice->{id} trans_id: $invoice->{trans_id} description: $invoice->{description} itime: $invoice->{itime}");
162 $self->tester->ok(1, "Keine verwaisten invoice Einträge (wo ar/ap-Eintrag fehlt)"); }
165 sub check_netamount_laut_invoice_ar {
168 select sum(round(cast(i.qty*(i.fxsellprice * (1-i.discount)) as numeric), 2))
170 left join ar a on (a.id = i.trans_id)
171 where a.transdate >= ? and a.transdate <= ?;|;
172 my ($netamount_laut_invoice) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
174 $query = qq| select sum(netamount) from ar where transdate >= ? and transdate <= ? AND invoice; |;
175 my ($netamount_laut_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
177 # should be enough to get a diff below 1. We have currently the following issues:
178 # verkaufsbericht berücksichtigt keinen rabatt
179 # fxsellprice ist mit mwst-inklusive
180 my $correct = abs($netamount_laut_invoice - $netamount_laut_ar) < 1;
182 $self->tester->ok($correct, "Summe laut Verkaufsbericht sollte gleich Summe aus Verkauf -> Berichte -> Rechnungen sein");
184 $self->tester->diag("Netto-Summe laut Verkaufsbericht (invoice): $netamount_laut_invoice");
185 $self->tester->diag("Netto-Summe laut Verkauf -> Berichte -> Rechnungen: $netamount_laut_ar");
189 sub check_invnumbers_unique {
192 my $query = qq| select invnumber,count(invnumber) as count from ar
193 where transdate >= ? and transdate <= ?
195 having count(invnumber) > 1; |;
196 my $non_unique_invnumbers = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
198 if (@$non_unique_invnumbers) {
199 $self->tester->ok(0, "Es gibt doppelte Rechnungsnummern");
200 for my $invnumber (@{ $non_unique_invnumbers }) {
201 $self->tester->diag("invnumber: $invnumber->{invnumber} $invnumber->{count}x");
204 $self->tester->ok(1, "Alle Rechnungsnummern sind eindeutig");
208 sub check_summe_stornobuchungen {
212 SELECT sum(amount) from ar a WHERE a.id IN
213 (SELECT id from ap where storno is true
214 AND a.transdate >= ? and a.transdate <= ?)|;
215 my ($summe_stornobuchungen_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
218 SELECT sum(amount) from ap a WHERE a.id IN
219 (SELECT id from ap where storno is true
220 AND a.transdate >= ? and a.transdate <= ?)|;
221 my ($summe_stornobuchungen_ap) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
223 $self->tester->ok($summe_stornobuchungen_ap == 0, 'Summe aller Einkaufsrechnungen (stornos + stornierte) soll 0 sein');
224 $self->tester->ok($summe_stornobuchungen_ar == 0, 'Summe aller Verkaufsrechnungen (stornos + stornierte) soll 0 sein');
225 $self->tester->diag("Summe Verkaufsrechnungen (ar): $summe_stornobuchungen_ar") if $summe_stornobuchungen_ar;
226 $self->tester->diag("Summe Einkaufsrechnungen (ap): $summe_stornobuchungen_ap") if $summe_stornobuchungen_ap;
233 select invnumber,paid,
234 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as accpaid ,
235 paid+(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as diff
238 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') is not null
240 AND ar.id in (SELECT id from ar where transdate >= ? and transdate <= ?)
243 my $paid_diffs_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
245 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ar;
247 $self->tester->ok(!$errors, "Vergleich ar paid mit acc_trans AR_paid");
249 for my $paid_diff_ar (@{ $paid_diffs_ar }) {
250 next if $paid_diff_ar->{diff} == 0;
251 $self->tester->diag("ar invnumber: $paid_diff_ar->{invnumber} : paid: $paid_diff_ar->{paid} acc_paid= $paid_diff_ar->{accpaid} diff: $paid_diff_ar->{diff}");
259 select invnumber,paid,id,
260 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as accpaid ,
261 paid-(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as diff
264 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') is not null
265 AND ap.id in (SELECT id from ap where transdate >= ? and transdate <= ?)
268 my $paid_diffs_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
270 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ap;
272 $self->tester->ok(!$errors, "Vergleich ap paid mit acc_trans AP_paid");
273 for my $paid_diff_ap (@{ $paid_diffs_ap }) {
274 next if $paid_diff_ap->{diff} == 0;
275 $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : ID :: ID : $paid_diff_ap->{id} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
279 sub check_ar_overpayments {
283 select invnumber,paid,amount,transdate,c.customernumber,c.name from ar left join customer c on (ar.customer_id = c.id)
284 where abs(paid) > abs(amount)
285 AND transdate >= ? and transdate <= ?
286 order by invnumber;|;
288 my $overpaids_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
290 my $correct = 0 == @$overpaids_ar;
292 $self->tester->ok($correct, "Keine Überzahlungen laut ar.paid");
293 for my $overpaid_ar (@{ $overpaids_ar }) {
294 $self->tester->diag("ar invnumber: $overpaid_ar->{invnumber} : paid: $overpaid_ar->{paid} amount= $overpaid_ar->{amount} transdate = $overpaid_ar->{transdate}");
298 sub check_ap_overpayments {
302 select invnumber,paid,amount,transdate,vc.vendornumber,vc.name from ap left join vendor vc on (ap.vendor_id = vc.id)
303 where abs(paid) > abs(amount)
304 AND transdate >= ? and transdate <= ?
305 order by invnumber;|;
307 my $overpaids_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
309 my $correct = 0 == @$overpaids_ap;
311 $self->tester->ok($correct, "Überzahlungen laut ap.paid:");
312 for my $overpaid_ap (@{ $overpaids_ap }) {
313 $self->tester->diag("ap invnumber: $overpaid_ap->{invnumber} : paid: $overpaid_ap->{paid} amount= $overpaid_ap->{amount} transdate = $overpaid_ap->{transdate}");
317 sub check_paid_stornos {
321 SELECT ar.invnumber,sum(amount - COALESCE((SELECT sum(amount)*-1
322 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
323 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id ),0)) as "open"
327 AND (ar.customer_id = customer.id)
328 AND ar.transdate >= ? and ar.transdate <= ?
329 GROUP BY ar.invnumber|;
330 my $paid_stornos = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
332 $self->tester->ok(0 == @$paid_stornos, "Keine bezahlten Stornos");
333 for my $paid_storno (@{ $paid_stornos }) {
334 $self->tester->diag("invnumber: $paid_storno->{invnumber} offen: $paid_storno->{open}");
338 sub check_stornos_ohne_partner {
342 SELECT (SELECT cast ('ar' as text)) as invoice ,ar.id,invnumber,storno,amount,transdate,type,customernumber as cv_number
344 LEFT JOIN customer c on (c.id = ar.customer_id)
345 WHERE storno_id is null AND storno is true AND ar.id not in (SELECT storno_id FROM ar WHERE storno_id is not null AND storno is true)
346 AND ar.transdate >= ? and ar.transdate <= ?
348 SELECT (SELECT cast ('ap' as text)) as invoice,ap.id,invnumber,storno,amount,transdate,type,vendornumber as cv_number
350 LEFT JOIN vendor v on (v.id = ap.vendor_id)
351 WHERE storno_id is null AND storno is true AND ap.id not in (SELECT storno_id FROM ap WHERE storno_id is not null AND storno is true)
352 AND ap.transdate >= ? and ap.transdate <= ?|;
354 my $stornos_ohne_partner = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
355 $self->fromdate, $self->todate);
357 $self->tester->ok(@$stornos_ohne_partner == 0, 'Es sollte keine Stornos ohne Partner geben');
358 if (@$stornos_ohne_partner) {
359 $self->tester->diag("Stornos ohne Partner, oder Storno über Jahreswechsel hinaus");
361 my $stornoheader = 0;
362 for my $storno (@{ $stornos_ohne_partner }) {
363 if (!$stornoheader++) {
364 $self->tester->diag(join "\t", keys %$storno);
366 $self->tester->diag(join "\t", map { $storno->{$_} } keys %$storno);
370 sub check_overpayments {
373 # Vergleich ar.paid und das was laut acc_trans bezahlt wurde
374 # "als bezahlt markieren" ohne sauberes Ausbuchen führt zu Differenzen bei offenen Forderungen
375 # Berücksichtigt Zahlungseingänge im Untersuchungszeitraums und
376 # prüft weitere Zahlungen und Buchungen über trans_id (kein Zeitfilter)
380 invnumber,customernumber,name,ar.transdate,ar.datepaid,
382 amount-paid as "open via ar",
383 paid as "paid via ar",
384 coalesce((SELECT sum(amount)*-1 FROM acc_trans
385 WHERE chart_link ilike '%paid%' AND acc_trans.trans_id=ar.id),0) as "paid via acc_trans"
386 FROM ar left join customer c on (c.id = ar.customer_id)
389 AND ar.id in (SELECT trans_id from acc_trans where transdate >= ? AND transdate <= ? AND chart_link ilike '%paid%')|;
391 my $invoices = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
393 my $count_overpayments = scalar grep {
394 $_->{"paid via ar"} != $_->{"paid via acc_trans"}
395 || ( $_->{"amount"} - $_->{"paid via acc_trans"} != $_->{"open via ar"}
396 && $_->{"paid via ar"} != $_->{"paid via acc_trans"} )
399 $self->tester->ok($count_overpayments == 0, 'Vergleich ar.paid und das was laut acc_trans bezahlt wurde');
401 if ($count_overpayments) {
402 for my $invoice (@{ $invoices }) {
403 if ($invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
404 $self->tester->diag("Rechnung: $invoice->{invnumber}, Kunde $invoice->{name} Nebenbuch-Bezahlwert: (@{[ $invoice->{'paid via ar'} * 1 ]}) != Hauptbuch-Bezahlwert: (@{[ $invoice->{'paid via acc_trans'} * 1 ]}) (at least until transdate!)");
405 if (defined $invoice->{datepaid}) {
406 $self->tester->diag("datepaid = $invoice->{datepaid})");
408 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
409 } elsif ( $invoice->{"amount"} - $invoice->{"paid via acc_trans"} != $invoice->{"open via ar"} && $invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
410 $self->tester->diag("amount - paid_via_acc_trans != open_via_ar");
411 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
419 sub calc_saldenvortraege {
422 my $saldenvortragskonto = '9000';
424 # Saldo Saldenvortragskonto 9000 am Jahresanfang
426 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
427 my ($saldo_9000_jahresanfang) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 1, month => 1, year => DateTime->today->year));
428 $self->tester->diag("Saldo 9000 am 01.01.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresanfang * 1 ]} (sollte 0 sein)");
430 # Saldo Saldenvortragskonto 9000 am Jahresende
432 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
433 my ($saldo_9000_jahresende) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 31, month => 12, year => DateTime->today->year));
434 $self->tester->diag("Saldo $saldenvortragskonto am 31.12.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresende * 1 ]} (sollte 0 sein)");
437 sub check_every_account_with_taxkey {
440 my $query = qq|SELECT accno, description FROM chart WHERE id NOT IN (select chart_id from taxkeys)|;
441 my $accounts_without_tk = selectall_hashref_query($::form, $self->dbh, $query);
443 if ( scalar @{ $accounts_without_tk } > 0 ){
444 $self->tester->ok(0, "Folgende Konten haben keinen gültigen Steuerschlüssel:");
446 for my $account_without_tk (@{ $accounts_without_tk } ) {
447 $self->tester->diag("Kontonummer: $account_without_tk->{accno} Beschreibung: $account_without_tk->{description}");
450 $self->tester->ok(1, "Jedes Konto hat einen gültigen Steuerschlüssel!");
454 sub check_ar_acc_trans_amount {
458 select sum(ac.amount) as amount, ar.invnumber,ar.netamount
459 from acc_trans ac left join ar on (ac.trans_id = ar.id)
460 WHERE ac.chart_link like 'AR_amount%'
461 AND ac.transdate >= ? AND ac.transdate <= ?
462 group by invnumber,netamount having sum(ac.amount) <> ar.netamount|;
464 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
466 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
467 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
469 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
470 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{amount}
471 Nebenbuch-Wert: $ar_ac_amount_nok->{netamount}");
474 $self->tester->ok(1, "Hauptbuch-Nettowert und Debitoren-Nebenbuch-Nettowert stimmen überein.");
479 sub check_ap_acc_trans_amount {
483 select sum(ac.amount) as amount, ap.invnumber,ap.netamount
484 from acc_trans ac left join ap on (ac.trans_id = ap.id)
485 WHERE (ac.chart_link like '%AP_amount%' OR ac.chart_link like '%IC_cogs%')
486 AND ac.transdate >= ? AND ac.transdate <= ?
487 group by invnumber,trans_id,netamount having sum(ac.amount) <> ap.netamount*-1|;
489 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
491 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
492 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
494 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
495 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{amount}
496 Nebenbuch-Wert: $ap_ac_amount_nok->{netamount}");
499 $self->tester->ok(1, "Hauptbuch-Nettowert und Kreditoren-Nebenbuch-Nettowert stimmen überein.");
505 sub check_missing_tax_bookings {
509 # check tax bookings. all taxkey <> 0 should have tax bookings in acc_trans
511 my $query = qq| select trans_id, chart.accno,transdate from acc_trans left join chart on (chart.id = acc_trans.chart_id)
512 WHERE taxkey NOT IN (SELECT taxkey from tax where rate=0) AND trans_id NOT IN
513 (select trans_id from acc_trans where chart_link ilike '%tax%' and trans_id IN
514 (SELECT trans_id from acc_trans where taxkey NOT IN (SELECT taxkey from tax where rate=0)))
515 AND transdate >= ? AND transdate <= ?|;
517 my $missing_tax_bookings = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
519 if ( scalar @{ $missing_tax_bookings } > 0 ) {
520 $self->tester->ok(0, "Folgende Konten weisen Buchungen ohne Steuerverknüpfung auf:");
522 for my $acc_trans_nok (@{ $missing_tax_bookings } ) {
523 $self->tester->diag("Kontonummer: $acc_trans_nok->{accno} Belegdatum: $acc_trans_nok->{transdate} Trans-ID: $acc_trans_nok->{trans_id}.
524 Kann über System -> Korrekturen im Hauptbuch bereinigt werden. Falls es ein Zahlungskonto ist, wurde
525 ggf. ein Brutto-Skonto-Konto mit einer Netto-Rechnung verknüpft. Kann nur per SQL geändert werden.");
528 $self->tester->ok(1, "Hauptbuch-Nettowert und Nebenbuch-Nettowert stimmen überein.");
532 sub check_bank_transactions_overpayments {
536 select id,amount,invoice_amount, purpose,transdate from bank_transactions where abs(invoice_amount) > abs(amount)
537 AND transdate >= ? AND transdate <= ? order by transdate|;
539 my $overpaids_bank_transactions = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
541 my $correct = 0 == @$overpaids_bank_transactions;
543 $self->tester->ok($correct, "Keine überbuchte Banktransaktion (der zugeordnete Betrag ist nicht höher, als der Überweisungsbetrag).");
544 for my $overpaid_bank_transaction (@{ $overpaids_bank_transactions }) {
545 $self->tester->diag("Überbuchte Bankbewegung!
546 Verwendungszweck: $overpaid_bank_transaction->{purpose}
547 Transaktionsdatum: $overpaid_bank_transaction->{transdate}
548 Betrag= $overpaid_bank_transaction->{amount} Zugeordneter Betrag = $overpaid_bank_transaction->{invoice_amount}
549 Bitte kontaktieren Sie Ihren kivitendo-DB-Admin, der die Überweisung wieder zurücksetzt (Table: bank_transactions Column: invoice_amount).");
553 sub check_ar_paid_acc_trans {
557 select sum(ac.amount) as paid_amount, ar.invnumber,ar.paid
558 from acc_trans ac left join ar on (ac.trans_id = ar.id)
559 WHERE ac.chart_link like '%AR_paid%'
560 AND ac.trans_id in (SELECT trans_id from acc_trans ac where ac.transdate >= ? AND ac.transdate <= ?)
561 group by invnumber, paid having sum(ac.amount) <> ar.paid*-1|;
563 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
565 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
566 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Bezahl-Wert im Nebenbuch:");
568 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
569 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{paid_amount}
570 Nebenbuch-Wert: $ar_ac_amount_nok->{paid}");
573 $self->tester->ok(1, "Hauptbuch-Bezahlwert und Debitoren-Nebenbuch-Bezahlwert stimmen überein.");
577 sub check_ap_paid_acc_trans {
581 select sum(ac.amount) as paid_amount, ap.invnumber,ap.paid
582 from acc_trans ac left join ap on (ac.trans_id = ap.id)
583 WHERE ac.chart_link like '%AP_paid%'
584 AND ac.trans_id in (SELECT trans_id from acc_trans ac where ac.transdate >= ? AND ac.transdate <= ?)
585 group by trans_id,invnumber,paid having sum(ac.amount) <> ap.paid|;
587 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
589 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
590 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Bezahl-Wert im Nebenbuch:");
592 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
593 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{paid_amount}
594 Nebenbuch-Wert: $ap_ac_amount_nok->{paid}");
597 $self->tester->ok(1, "Hauptbuch Bezahl-Wert und Kreditoren-Nebenbuch-Bezahlwert stimmen überein.");
601 sub check_zero_amount_paid_but_datepaid_exists {
604 my $query = qq|(SELECT invnumber,datepaid from ar where datepaid is NOT NULL AND paid = 0
605 AND id not IN (select trans_id from acc_trans WHERE chart_link like '%paid%' AND acc_trans.trans_id = ar.id)
606 AND datepaid >= ? AND datepaid <= ?)
608 (SELECT invnumber,datepaid from ap where datepaid is NOT NULL AND paid = 0
609 AND id not IN (select trans_id from acc_trans WHERE chart_link like '%paid%' AND acc_trans.trans_id = ap.id)
610 AND datepaid >= ? AND datepaid <= ?)|;
612 my $datepaid_should_be_null = selectall_hashref_query($::form, $self->dbh, $query,
613 $self->fromdate, $self->todate,
614 $self->fromdate, $self->todate);
616 if ( scalar @{ $datepaid_should_be_null } > 0 ) {
617 $self->tester->ok(0, "Folgende Rechnungen haben ein Bezahl-Datum, aber keinen Bezahl-Wert im Nebenbuch:");
619 for my $datepaid_should_be_null_nok (@{ $datepaid_should_be_null } ) {
620 $self->tester->diag("Rechnungsnummer: $datepaid_should_be_null_nok->{invnumber}
621 Bezahl-Datum: $datepaid_should_be_null_nok->{datepaid}");
624 $self->tester->ok(1, "Kein Bezahl-Datum ohne Bezahl-Wert und ohne wirkliche Zahlungen gefunden (arap.datepaid, arap.paid konsistent).");
628 sub check_orphaned_reconciliated_links {
632 SELECT purpose from bank_transactions
633 WHERE cleared is true
634 AND NOT EXISTS (SELECT bank_transaction_id from reconciliation_links WHERE bank_transaction_id = bank_transactions.id)
635 AND transdate >= ? AND transdate <= ?|;
637 my $bt_cleared_no_link = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
639 if ( scalar @{ $bt_cleared_no_link } > 0 ) {
640 $self->tester->ok(0, "Verwaiste abgeglichene Bankbewegungen gefunden. Bei folgenden Bankbewegungen ist die abgleichende Verknüpfung gelöscht worden:");
642 for my $bt_orphaned (@{ $bt_cleared_no_link }) {
643 $self->tester->diag("Verwendungszweck: $bt_orphaned->{purpose}");
646 $self->tester->ok(1, "Keine verwaisten Einträge in abgeglichenen Bankbewegungen.");
650 sub check_recommended_client_settings {
655 # expand: check datev && check mark_as_paid
656 my %settings_values_nok = (
657 SL::DB::Default->get->is_changeable => 1,
658 SL::DB::Default->get->ar_changeable => 1,
659 SL::DB::Default->get->ap_changeable => 1,
660 SL::DB::Default->get->ir_changeable => 1,
661 SL::DB::Default->get->gl_changeable => 1,
664 foreach (keys %settings_values_nok) {
665 if ($_ == $settings_values_nok{$_}) {
666 $self->tester->ok(0, "Buchungskonfiguration: Mindestens ein Belegtyp ist immer änderbar.");
671 # payments more strict (avoid losing payments acc_trans_ids)
672 my $payments_ok = SL::DB::Default->get->payments_changeable == 0 ? 1 : 0;
673 $self->tester->ok(0, "Manuelle Zahlungen sind zu lange änderbar (Empfehlung: niemals).") unless $payments_ok;
675 $self->tester->ok(1, "Mandantenkonfiguration optimal eingestellt.") if ($payments_ok && $all_ok);
678 sub check_orphaned_bank_transaction_acc_trans_links {
682 SELECT purpose from bank_transactions
683 WHERE invoice_amount <> 0
684 AND NOT EXISTS (SELECT bank_transaction_id FROM bank_transaction_acc_trans WHERE bank_transaction_id = bank_transactions.id)
685 AND itime > (SELECT min(itime) from bank_transaction_acc_trans)
686 AND transdate >= ? AND transdate <= ?|;
688 my $bt_assigned_no_link = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
690 if ( scalar @{ $bt_assigned_no_link } > 0 ) {
691 $self->tester->ok(0, "Verwaiste Verknüpfungen zu Bankbewegungen gefunden. Bei folgenden Bankbewegungen ist eine interne Verknüpfung gelöscht worden:");
693 for my $bt_orphaned (@{ $bt_assigned_no_link }) {
694 $self->tester->diag("Verwendungszweck: $bt_orphaned->{purpose}");
697 $self->tester->ok(1, "Keine verwaisten Einträge in verknüpften Bankbewegungen (Richtung Bank).");
699 # check for deleted acc_trans_ids
701 SELECT purpose from bank_transactions
703 (SELECT bank_transaction_id from bank_transaction_acc_trans
704 WHERE NOT EXISTS (SELECT acc_trans.acc_trans_id FROM acc_trans WHERE acc_trans.acc_trans_id = bank_transaction_acc_trans.acc_trans_id)
705 AND transdate >= ? AND transdate <= ?)|;
707 my $bt_assigned_no_acc_trans = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
709 if ( scalar @{ $bt_assigned_no_acc_trans } > 0 ) {
710 $self->tester->ok(0, "Verwaiste Verknüpfungen zu Bankbewegungen gefunden. Bei folgenden Bankbewegungen ist eine interne Verknüpfung gelöscht worden:");
712 for my $bt_orphaned (@{ $bt_assigned_no_acc_trans }) {
713 $self->tester->diag("Verwendungszweck: $bt_orphaned->{purpose}");
716 $self->tester->ok(1, "Keine verwaisten Einträge in verknüpften Bankbewegungen (Richtung Buchung (Richtung Buchung)).");
720 sub check_consistent_itimes {
725 SELECT mtime, itime,gldate, acc_trans_id, trans_id
727 WHERE itime::date <> gldate::date
728 AND a.transdate >= ? and a.transdate <= ?|;
730 my $itimes_ac = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
732 if ( scalar @{ $itimes_ac } > 0 ) {
733 $self->tester->ok(0, "Inkonsistente Zeitstempel in der acc_trans gefunden. Bei folgenden ids:");
734 for my $bogus_time (@{ $itimes_ac }) {
735 $self->tester->diag("ID: $bogus_time->{trans_id} acc_trans_id: $bogus_time->{acc_trans_id} ");
738 $self->tester->ok(1, "Keine inkonsistenten Zeitstempel in der acc_trans.");
741 SELECT amount, itime, gldate, id
743 WHERE itime::date <> gldate::date
744 AND a.transdate >= ? and a.transdate <= ?|;
746 my $itimes_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
748 if ( scalar @{ $itimes_ap } > 0 ) {
749 $self->tester->ok(0, "Inkonsistente Zeitstempel in ap gefunden. Bei folgenden ids:");
750 for my $bogus_time (@{ $itimes_ap }) {
751 $self->tester->diag("ID: $bogus_time->{id} itime: $bogus_time->{itime} mtime: $bogus_time->{mtime} ");
754 $self->tester->ok(1, "Keine inkonsistenten Zeitstempel in ap.");
757 SELECT amount, itime, gldate, id
759 WHERE itime::date <> gldate::date
760 AND a.transdate >= ? and a.transdate <= ?|;
762 my $itimes_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
764 if ( scalar @{ $itimes_ap } > 0 ) {
765 $self->tester->ok(0, "Inkonsistente Zeitstempel in ar gefunden. Bei folgenden ids:");
766 for my $bogus_time (@{ $itimes_ar }) {
767 $self->tester->diag("ID: $bogus_time->{id} itime: $bogus_time->{itime} mtime: $bogus_time->{mtime} ");
770 $self->tester->ok(1, "Keine inkonsistenten Zeitstempel in ar.");
773 SELECT itime, gldate, id, mtime
775 WHERE itime::date <> gldate::date
776 AND a.transdate >= ? and a.transdate <= ?|;
778 my $itimes_gl = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
780 if ( scalar @{ $itimes_gl } > 0 ) {
781 $self->tester->ok(0, "Inkonsistente Zeitstempel in gl gefunden. Bei folgenden ids:");
782 for my $bogus_time (@{ $itimes_ar }) {
783 $self->tester->diag("ID: $bogus_time->{id} itime: $bogus_time->{itime} mtime: $bogus_time->{mtime} ");
786 $self->tester->ok(1, "Keine inkonsistenten Zeitstempel in gl.");
798 SL::BackgroundJob::SelfTest::Transactions - base tests
802 Several tests for data integrity.
810 G. Richardson E<lt>information@richardson-bueren.deE<gt>
811 Jan Büren E<lt>information@richardson-bueren.deE<gt>
812 Sven Schoeling E<lt>s.schoeling@linet-services.deE<gt>