1 package SL::BackgroundJob::SelfTest::Transactions;
5 use parent qw(SL::BackgroundJob::SelfTest::Base);
9 use Rose::Object::MakeMethods::Generic (
10 scalar => [ qw(dbh fromdate todate) ],
18 $self->tester->plan(tests => 24);
20 $self->check_konten_mit_saldo_nicht_in_guv;
21 $self->check_bilanzkonten_mit_pos_eur;
22 $self->check_balanced_individual_transactions;
23 $self->check_verwaiste_acc_trans_eintraege;
24 $self->check_verwaiste_invoice_eintraege;
25 $self->check_ar_acc_trans_amount;
26 $self->check_ap_acc_trans_amount;
27 $self->check_netamount_laut_invoice_ar;
28 $self->check_invnumbers_unique;
29 $self->check_summe_stornobuchungen;
32 $self->check_ar_overpayments;
33 $self->check_ap_overpayments;
34 $self->check_paid_stornos;
35 $self->check_stornos_ohne_partner;
36 $self->check_overpayments;
37 $self->check_every_account_with_taxkey;
38 $self->calc_saldenvortraege;
39 $self->check_missing_tax_bookings;
40 $self->check_bank_transactions_overpayments;
41 $self->check_ar_paid_acc_trans;
42 $self->check_ap_paid_acc_trans;
43 $self->check_zero_amount_paid_but_datepaid_exists;
49 # TODO FIXME calc dates better, unless this is wanted
50 $self->fromdate(DateTime->new(day => 1, month => 1, year => DateTime->today->year));
51 $self->todate($self->fromdate->clone->add(years => 1)->add(days => -1));
52 $self->dbh($::form->get_standard_dbh);
55 sub check_konten_mit_saldo_nicht_in_guv {
59 SELECT c.accno, c.description, c.category, SUM(a.amount) AS Saldo
62 WHERE c.id = a.chart_id
63 and (c.category like 'I' or c.category like 'E')
66 and a.transdate >= ? and a.transdate <= ?
67 GROUP BY c.accno,c.description,c.category,c.pos_bilanz,c.pos_eur
70 my $konten_nicht_in_guv = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
72 my $correct = 0 == scalar grep { $_->{Saldo} } @$konten_nicht_in_guv;
74 $self->tester->ok($correct, "Erfolgskonten mit Saldo nicht in GuV (Saldenvortragskonten können ignoriert werden, sollten aber 0 sein)");
76 for my $konto (@$konten_nicht_in_guv) {
77 $self->tester->diag($konto);
82 sub check_bilanzkonten_mit_pos_eur {
85 my $query = qq|SELECT accno, description FROM chart WHERE (category = 'A' OR category = 'L' OR category = 'Q') AND (pos_eur IS NOT NULL OR pos_eur != 0)|;
87 my $bilanzkonten_mit_pos_eur = selectall_hashref_query($::form, $self->dbh, $query);
88 if (@$bilanzkonten_mit_pos_eur) {
89 $self->tester->ok(0, "Es gibt Bilanzkonten die der GuV/EÜR zugeordnet sind)");
90 $self->tester->diag("$_->{accno} $_->{description}") for @$bilanzkonten_mit_pos_eur;
92 $self->tester->ok(1, "Keine Bilanzkonten in der GuV");
96 sub check_balanced_individual_transactions {
100 select sum(ac.amount) as amount,trans_id,ar.invnumber as ar,ap.invnumber as ap,gl.reference as gl
102 left join ar on (ar.id = ac.trans_id)
103 left join ap on (ap.id = ac.trans_id)
104 left join gl on (gl.id = ac.trans_id)
105 where ac.transdate >= ? AND ac.transdate <= ?
106 group by trans_id,ar.invnumber,ap.invnumber,gl.reference
107 having sum(ac.amount) != 0;|;
109 my $acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
111 $self->tester->ok(0, "Es gibt unausgeglichene acc_trans-Transaktionen:");
112 for my $ac (@{ $acs }) {
113 $self->tester->diag("trans_id: $ac->{trans_id}, amount = $ac->{amount}, ar: $ac->{ar} ap: $ac->{ap} gl: $ac->{gl}");
116 $self->tester->ok(1, "Alle acc_trans Transaktionen ergeben in Summe 0, keine unausgeglichenen Transaktionen");
120 sub check_verwaiste_acc_trans_eintraege {
124 select trans_id,amount,accno,description from acc_trans a
125 left join chart c on (c.id = a.chart_id)
126 where trans_id not in (select id from gl union select id from ar union select id from ap order by id)
127 and a.transdate >= ? and a.transdate <= ? ;|;
129 my $verwaiste_acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
130 if (@$verwaiste_acs) {
131 $self->tester->ok(0, "Es gibt verwaiste acc-trans Einträge! (wo ar/ap/gl-Eintrag fehlt)");
132 $self->tester->diag($_) for @$verwaiste_acs;
134 $self->tester->ok(1, "Keine verwaisten acc-trans Einträge (wo ar/ap/gl-Eintrag fehlt)");
138 sub check_verwaiste_invoice_eintraege {
139 # this check is always run for all invoice entries in the entire database
142 select * from invoice i
143 where trans_id not in (select id from ar WHERE ar.transdate >=? AND ar.transdate <=?
145 select id from ap WHERE ap.transdate >= ? and ap.transdate <= ?)
146 AND i.transdate >=? AND i.transdate <=?|;
148 my $verwaiste_invoice = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
149 $self->fromdate, $self->todate, $self->fromdate, $self->todate);
152 if (@$verwaiste_invoice) {
153 $self->tester->ok(0, "Es gibt verwaiste invoice Einträge! (wo ar/ap-Eintrag fehlt)");
154 for my $invoice ( @{ $verwaiste_invoice }) {
155 $self->tester->diag("invoice: id: $invoice->{id} trans_id: $invoice->{trans_id} description: $invoice->{description} itime: $invoice->{itime}");
158 $self->tester->ok(1, "Keine verwaisten invoice Einträge (wo ar/ap-Eintrag fehlt)"); }
161 sub check_netamount_laut_invoice_ar {
164 select sum(round(cast(i.qty*(i.fxsellprice * (1-i.discount)) as numeric), 2))
166 left join ar a on (a.id = i.trans_id)
167 where a.transdate >= ? and a.transdate <= ?;|;
168 my ($netamount_laut_invoice) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
170 $query = qq| select sum(netamount) from ar where transdate >= ? and transdate <= ? AND invoice; |;
171 my ($netamount_laut_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
173 # should be enough to get a diff below 1. We have currently the following issues:
174 # verkaufsbericht berücksichtigt keinen rabatt
175 # fxsellprice ist mit mwst-inklusive
176 my $correct = abs($netamount_laut_invoice - $netamount_laut_ar) < 1;
178 $self->tester->ok($correct, "Summe laut Verkaufsbericht sollte gleich Summe aus Verkauf -> Berichte -> Rechnungen sein");
180 $self->tester->diag("Netto-Summe laut Verkaufsbericht (invoice): $netamount_laut_invoice");
181 $self->tester->diag("Netto-Summe laut Verkauf -> Berichte -> Rechnungen: $netamount_laut_ar");
185 sub check_invnumbers_unique {
188 my $query = qq| select invnumber,count(invnumber) as count from ar
189 where transdate >= ? and transdate <= ?
191 having count(invnumber) > 1; |;
192 my $non_unique_invnumbers = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
194 if (@$non_unique_invnumbers) {
195 $self->tester->ok(0, "Es gibt doppelte Rechnungsnummern");
196 for my $invnumber (@{ $non_unique_invnumbers }) {
197 $self->tester->diag("invnumber: $invnumber->{invnumber} $invnumber->{count}x");
200 $self->tester->ok(1, "Alle Rechnungsnummern sind eindeutig");
204 sub check_summe_stornobuchungen {
208 SELECT sum(amount) from ar a WHERE a.id IN
209 (SELECT id from ap where storno is true
210 AND a.transdate >= ? and a.transdate <= ?)|;
211 my ($summe_stornobuchungen_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
214 SELECT sum(amount) from ap a WHERE a.id IN
215 (SELECT id from ap where storno is true
216 AND a.transdate >= ? and a.transdate <= ?)|;
217 my ($summe_stornobuchungen_ap) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
219 $self->tester->ok($summe_stornobuchungen_ap == 0, 'Summe aller Einkaufsrechnungen (stornos + stornierte) soll 0 sein');
220 $self->tester->ok($summe_stornobuchungen_ar == 0, 'Summe aller Verkaufsrechnungen (stornos + stornierte) soll 0 sein');
221 $self->tester->diag("Summe Verkaufsrechnungen (ar): $summe_stornobuchungen_ar") if $summe_stornobuchungen_ar;
222 $self->tester->diag("Summe Einkaufsrechnungen (ap): $summe_stornobuchungen_ap") if $summe_stornobuchungen_ap;
229 select invnumber,paid,
230 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as accpaid ,
231 paid+(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as diff
234 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') is not null
236 AND ar.id in (SELECT id from ar where transdate >= ? and transdate <= ?)
239 my $paid_diffs_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
241 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ar;
243 $self->tester->ok(!$errors, "Vergleich ar paid mit acc_trans AR_paid");
245 for my $paid_diff_ar (@{ $paid_diffs_ar }) {
246 next if $paid_diff_ar->{diff} == 0;
247 $self->tester->diag("ar invnumber: $paid_diff_ar->{invnumber} : paid: $paid_diff_ar->{paid} acc_paid= $paid_diff_ar->{accpaid} diff: $paid_diff_ar->{diff}");
255 select invnumber,paid,
256 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as accpaid ,
257 paid-(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as diff
260 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') is not null
261 AND ap.id in (SELECT id from ap where transdate >= ? and transdate <= ?)
264 my $paid_diffs_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
266 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ap;
268 $self->tester->ok(!$errors, "Vergleich ap paid mit acc_trans AP_paid");
269 for my $paid_diff_ap (@{ $paid_diffs_ap }) {
270 next if $paid_diff_ap->{diff} == 0;
271 $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
275 sub check_ar_overpayments {
279 select invnumber,paid,amount,transdate,c.customernumber,c.name from ar left join customer c on (ar.customer_id = c.id)
280 where abs(paid) > abs(amount)
281 AND transdate >= ? and transdate <= ?
282 order by invnumber;|;
284 my $overpaids_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
286 my $correct = 0 == @$overpaids_ar;
288 $self->tester->ok($correct, "Keine Überzahlungen laut ar.paid");
289 for my $overpaid_ar (@{ $overpaids_ar }) {
290 $self->tester->diag("ar invnumber: $overpaid_ar->{invnumber} : paid: $overpaid_ar->{paid} amount= $overpaid_ar->{amount} transdate = $overpaid_ar->{transdate}");
294 sub check_ap_overpayments {
298 select invnumber,paid,amount,transdate,vc.vendornumber,vc.name from ap left join vendor vc on (ap.vendor_id = vc.id)
299 where abs(paid) > abs(amount)
300 AND transdate >= ? and transdate <= ?
301 order by invnumber;|;
303 my $overpaids_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
305 my $correct = 0 == @$overpaids_ap;
307 $self->tester->ok($correct, "Überzahlungen laut ap.paid:");
308 for my $overpaid_ap (@{ $overpaids_ap }) {
309 $self->tester->diag("ap invnumber: $overpaid_ap->{invnumber} : paid: $overpaid_ap->{paid} amount= $overpaid_ap->{amount} transdate = $overpaid_ap->{transdate}");
313 sub check_paid_stornos {
317 SELECT ar.invnumber,sum(amount - COALESCE((SELECT sum(amount)*-1
318 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
319 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id ),0)) as "open"
323 AND (ar.customer_id = customer.id)
324 AND ar.transdate >= ? and ar.transdate <= ?
325 GROUP BY ar.invnumber|;
326 my $paid_stornos = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
328 $self->tester->ok(0 == @$paid_stornos, "Keine bezahlten Stornos");
329 for my $paid_storno (@{ $paid_stornos }) {
330 $self->tester->diag("invnumber: $paid_storno->{invnumber} offen: $paid_storno->{open}");
334 sub check_stornos_ohne_partner {
338 SELECT (SELECT cast ('ar' as text)) as invoice ,ar.id,invnumber,storno,amount,transdate,type,customernumber as cv_number
340 LEFT JOIN customer c on (c.id = ar.customer_id)
341 WHERE storno_id is null AND storno is true AND ar.id not in (SELECT storno_id FROM ar WHERE storno_id is not null AND storno is true)
342 AND ar.transdate >= ? and ar.transdate <= ?
344 SELECT (SELECT cast ('ap' as text)) as invoice,ap.id,invnumber,storno,amount,transdate,type,vendornumber as cv_number
346 LEFT JOIN vendor v on (v.id = ap.vendor_id)
347 WHERE storno_id is null AND storno is true AND ap.id not in (SELECT storno_id FROM ap WHERE storno_id is not null AND storno is true)
348 AND ap.transdate >= ? and ap.transdate <= ?|;
350 my $stornos_ohne_partner = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
351 $self->fromdate, $self->todate);
353 $self->tester->ok(@$stornos_ohne_partner == 0, 'Es sollte keine Stornos ohne Partner geben');
354 if (@$stornos_ohne_partner) {
355 $self->tester->diag("Stornos ohne Partner, oder Storno über Jahreswechsel hinaus");
357 my $stornoheader = 0;
358 for my $storno (@{ $stornos_ohne_partner }) {
359 if (!$stornoheader++) {
360 $self->tester->diag(join "\t", keys %$storno);
362 $self->tester->diag(join "\t", map { $storno->{$_} } keys %$storno);
366 sub check_overpayments {
369 # Vergleich ar.paid und das was laut acc_trans bezahlt wurde
370 # "als bezahlt markieren" ohne sauberes Ausbuchen führt zu Differenzen bei offenen Forderungen
371 # Berücksichtigt Zahlungseingänge im Untersuchungszeitraums und
372 # prüft weitere Zahlungen und Buchungen über trans_id (kein Zeitfilter)
376 invnumber,customernumber,name,ar.transdate,ar.datepaid,
378 amount-paid as "open via ar",
379 paid as "paid via ar",
380 coalesce((SELECT sum(amount)*-1 FROM acc_trans
381 WHERE chart_link ilike '%paid%' AND acc_trans.trans_id=ar.id),0) as "paid via acc_trans"
382 FROM ar left join customer c on (c.id = ar.customer_id)
385 AND ar.id in (SELECT trans_id from acc_trans where transdate >= ? AND transdate <= ? AND chart_link ilike '%paid%')|;
387 my $invoices = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
389 my $count_overpayments = scalar grep {
390 $_->{"paid via ar"} != $_->{"paid via acc_trans"}
391 || ( $_->{"amount"} - $_->{"paid via acc_trans"} != $_->{"open via ar"}
392 && $_->{"paid via ar"} != $_->{"paid via acc_trans"} )
395 $self->tester->ok($count_overpayments == 0, 'Vergleich ar.paid und das was laut acc_trans bezahlt wurde');
397 if ($count_overpayments) {
398 for my $invoice (@{ $invoices }) {
399 if ($invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
400 $self->tester->diag("Rechnung: $invoice->{invnumber}, Kunde $invoice->{name} Nebenbuch-Bezahlwert: (@{[ $invoice->{'paid via ar'} * 1 ]}) != Hauptbuch-Bezahlwert: (@{[ $invoice->{'paid via acc_trans'} * 1 ]}) (at least until transdate!)");
401 if (defined $invoice->{datepaid}) {
402 $self->tester->diag("datepaid = $invoice->{datepaid})");
404 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
405 } elsif ( $invoice->{"amount"} - $invoice->{"paid via acc_trans"} != $invoice->{"open via ar"} && $invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
406 $self->tester->diag("amount - paid_via_acc_trans != open_via_ar");
407 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
415 sub calc_saldenvortraege {
418 my $saldenvortragskonto = '9000';
420 # Saldo Saldenvortragskonto 9000 am Jahresanfang
422 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
423 my ($saldo_9000_jahresanfang) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 1, month => 1, year => DateTime->today->year));
424 $self->tester->diag("Saldo 9000 am 01.01.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresanfang * 1 ]} (sollte 0 sein)");
426 # Saldo Saldenvortragskonto 9000 am Jahresende
428 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
429 my ($saldo_9000_jahresende) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 31, month => 12, year => DateTime->today->year));
430 $self->tester->diag("Saldo $saldenvortragskonto am 31.12.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresende * 1 ]} (sollte 0 sein)");
433 sub check_every_account_with_taxkey {
436 my $query = qq|SELECT accno, description FROM chart WHERE id NOT IN (select chart_id from taxkeys)|;
437 my $accounts_without_tk = selectall_hashref_query($::form, $self->dbh, $query);
439 if ( scalar @{ $accounts_without_tk } > 0 ){
440 $self->tester->ok(0, "Folgende Konten haben keinen gültigen Steuerschlüssel:");
442 for my $account_without_tk (@{ $accounts_without_tk } ) {
443 $self->tester->diag("Kontonummer: $account_without_tk->{accno} Beschreibung: $account_without_tk->{description}");
446 $self->tester->ok(1, "Jedes Konto hat einen gültigen Steuerschlüssel!");
450 sub check_ar_acc_trans_amount {
454 select sum(ac.amount) as amount, ar.invnumber,ar.netamount
455 from acc_trans ac left join ar on (ac.trans_id = ar.id)
456 WHERE ac.chart_link like 'AR_amount%'
457 AND ac.transdate >= ? AND ac.transdate <= ?
458 group by invnumber,netamount having sum(ac.amount) <> ar.netamount|;
460 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
462 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
463 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
465 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
466 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{amount}
467 Nebenbuch-Wert: $ar_ac_amount_nok->{netamount}");
470 $self->tester->ok(1, "Hauptbuch-Nettowert und Debitoren-Nebenbuch-Nettowert stimmen überein.");
475 sub check_ap_acc_trans_amount {
479 select sum(ac.amount) as amount, ap.invnumber,ap.netamount
480 from acc_trans ac left join ap on (ac.trans_id = ap.id)
481 WHERE ac.chart_link like '%AP_amount%'
482 AND ac.transdate >= ? AND ac.transdate <= ?
483 group by invnumber,trans_id,netamount having sum(ac.amount) <> ap.netamount*-1|;
485 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
487 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
488 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
490 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
491 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{amount}
492 Nebenbuch-Wert: $ap_ac_amount_nok->{netamount}");
495 $self->tester->ok(1, "Hauptbuch-Nettowert und Kreditoren-Nebenbuch-Nettowert stimmen überein.");
501 sub check_missing_tax_bookings {
505 # check tax bookings. all taxkey <> 0 should have tax bookings in acc_trans
507 my $query = qq| select trans_id, chart.accno,transdate from acc_trans left join chart on (chart.id = acc_trans.chart_id)
508 WHERE taxkey NOT IN (SELECT taxkey from tax where rate=0) AND trans_id NOT IN
509 (select trans_id from acc_trans where chart_link ilike '%tax%' and trans_id IN
510 (SELECT trans_id from acc_trans where taxkey NOT IN (SELECT taxkey from tax where rate=0)))
511 AND transdate >= ? AND transdate <= ?|;
513 my $missing_tax_bookings = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
515 if ( scalar @{ $missing_tax_bookings } > 0 ) {
516 $self->tester->ok(0, "Folgende Konten weisen Buchungen ohne Steuerverknüpfung auf:");
518 for my $acc_trans_nok (@{ $missing_tax_bookings } ) {
519 $self->tester->diag("Kontonummer: $acc_trans_nok->{accno} Belegdatum: $acc_trans_nok->{transdate} Trans-ID: $acc_trans_nok->{trans_id}.
520 Kann über System -> Korrekturen im Hauptbuch bereinigt werden. Falls es ein Zahlungskonto ist, wurde
521 ggf. ein Brutto-Skonto-Konto mit einer Netto-Rechnung verknüpft. Kann nur per SQL geändert werden.");
524 $self->tester->ok(1, "Hauptbuch-Nettowert und Nebenbuch-Nettowert stimmen überein.");
528 sub check_bank_transactions_overpayments {
532 select id,amount,invoice_amount, purpose,transdate from bank_transactions where abs(invoice_amount) > abs(amount)
533 AND transdate >= ? AND transdate <= ? order by transdate|;
535 my $overpaids_bank_transactions = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
537 my $correct = 0 == @$overpaids_bank_transactions;
539 $self->tester->ok($correct, "Keine überbuchte Banktransaktion (der zugeordnete Betrag ist nicht höher, als der Überweisungsbetrag).");
540 for my $overpaid_bank_transaction (@{ $overpaids_bank_transactions }) {
541 $self->tester->diag("Überbuchte Bankbewegung!
542 Verwendungszweck: $overpaid_bank_transaction->{purpose}
543 Transaktionsdatum: $overpaid_bank_transaction->{transdate}
544 Betrag= $overpaid_bank_transaction->{amount} Zugeordneter Betrag = $overpaid_bank_transaction->{invoice_amount}
545 Bitte kontaktieren Sie Ihren kivitendo-DB-Admin, der die Überweisung wieder zurücksetzt (Table: bank_transactions Column: invoice_amount).");
549 sub check_ar_paid_acc_trans {
553 select sum(ac.amount) as paid_amount, ar.invnumber,ar.paid
554 from acc_trans ac left join ar on (ac.trans_id = ar.id)
555 WHERE ac.chart_link like '%AR_paid%'
556 AND ac.trans_id in (SELECT trans_id from acc_trans ac where ac.transdate >= ? AND ac.transdate <= ?)
557 group by invnumber, paid having sum(ac.amount) <> ar.paid*-1|;
559 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
561 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
562 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Bezahl-Wert im Nebenbuch:");
564 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
565 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{paid_amount}
566 Nebenbuch-Wert: $ar_ac_amount_nok->{paid}");
569 $self->tester->ok(1, "Hauptbuch-Bezahlwert und Debitoren-Nebenbuch-Bezahlwert stimmen überein.");
573 sub check_ap_paid_acc_trans {
577 select sum(ac.amount) as paid_amount, ap.invnumber,ap.paid
578 from acc_trans ac left join ap on (ac.trans_id = ap.id)
579 WHERE ac.chart_link like '%AP_paid%'
580 AND ac.trans_id in (SELECT trans_id from acc_trans ac where ac.transdate >= ? AND ac.transdate <= ?)
581 group by trans_id,invnumber,paid having sum(ac.amount) <> ap.paid|;
583 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
585 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
586 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Bezahl-Wert im Nebenbuch:");
588 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
589 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{paid_amount}
590 Nebenbuch-Wert: $ap_ac_amount_nok->{paid}");
593 $self->tester->ok(1, "Hauptbuch Bezahl-Wert und Kreditoren-Nebenbuch-Bezahlwert stimmen überein.");
597 sub check_zero_amount_paid_but_datepaid_exists {
600 my $query = qq|(SELECT invnumber,datepaid from ar where datepaid is NOT NULL AND paid = 0
601 AND id not IN (select trans_id from acc_trans WHERE chart_link like '%paid%' AND acc_trans.trans_id = ar.id)
602 AND datepaid >= ? AND datepaid <= ?)
604 (SELECT invnumber,datepaid from ap where datepaid is NOT NULL AND paid = 0
605 AND id not IN (select trans_id from acc_trans WHERE chart_link like '%paid%' AND acc_trans.trans_id = ap.id)
606 AND datepaid >= ? AND datepaid <= ?)|;
608 my $datepaid_should_be_null = selectall_hashref_query($::form, $self->dbh, $query,
609 $self->fromdate, $self->todate,
610 $self->fromdate, $self->todate);
612 if ( scalar @{ $datepaid_should_be_null } > 0 ) {
613 $self->tester->ok(0, "Folgende Rechnungen haben ein Bezahl-Datum, aber keinen Bezahl-Wert im Nebenbuch:");
615 for my $datepaid_should_be_null_nok (@{ $datepaid_should_be_null } ) {
616 $self->tester->diag("Rechnungsnummer: $datepaid_should_be_null_nok->{invnumber}
617 Bezahl-Datum: $datepaid_should_be_null_nok->{datepaid}");
620 $self->tester->ok(1, "Kein Bezahl-Datum ohne Bezahl-Wert und ohne wirkliche Zahlungen gefunden (arap.datepaid, arap.paid konsistent).");
632 SL::BackgroundJob::SelfTest::Transactions - base tests
636 Several tests for data integrity.
644 G. Richardson E<lt>information@richardson-bueren.deE<gt>
645 Jan Büren E<lt>information@richardson-bueren.deE<gt>
646 Sven Schoeling E<lt>s.schoeling@linet-services.deE<gt>