1 package SL::BackgroundJob::SelfTest::Transactions;
5 use parent qw(SL::BackgroundJob::SelfTest::Base);
9 use Rose::Object::MakeMethods::Generic (
10 scalar => [ qw(dbh fromdate todate) ],
18 $self->tester->plan(tests => 25);
20 $self->check_konten_mit_saldo_nicht_in_guv;
21 $self->check_bilanzkonten_mit_pos_eur;
22 $self->check_balanced_individual_transactions;
23 $self->check_verwaiste_acc_trans_eintraege;
24 $self->check_verwaiste_invoice_eintraege;
25 $self->check_ar_acc_trans_amount;
26 $self->check_ap_acc_trans_amount;
27 $self->check_netamount_laut_invoice_ar;
28 $self->check_invnumbers_unique;
29 $self->check_summe_stornobuchungen;
32 $self->check_ar_overpayments;
33 $self->check_ap_overpayments;
34 $self->check_paid_stornos;
35 $self->check_stornos_ohne_partner;
36 $self->check_overpayments;
37 $self->check_every_account_with_taxkey;
38 $self->calc_saldenvortraege;
39 $self->check_missing_tax_bookings;
40 $self->check_bank_transactions_overpayments;
41 $self->check_ar_paid_acc_trans;
42 $self->check_ap_paid_acc_trans;
43 $self->check_zero_amount_paid_but_datepaid_exists;
44 $self->check_orphaned_reconciliated_links;
50 # TODO FIXME calc dates better, unless this is wanted
51 $self->fromdate(DateTime->new(day => 1, month => 1, year => DateTime->today->year));
52 $self->todate($self->fromdate->clone->add(years => 1)->add(days => -1));
53 $self->dbh($::form->get_standard_dbh);
56 sub check_konten_mit_saldo_nicht_in_guv {
60 SELECT c.accno, c.description, c.category, SUM(a.amount) AS Saldo
63 WHERE c.id = a.chart_id
64 and (c.category like 'I' or c.category like 'E')
67 and a.transdate >= ? and a.transdate <= ?
68 GROUP BY c.accno,c.description,c.category,c.pos_bilanz,c.pos_eur
71 my $konten_nicht_in_guv = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
73 my $correct = 0 == scalar grep { $_->{Saldo} } @$konten_nicht_in_guv;
75 $self->tester->ok($correct, "Erfolgskonten mit Saldo nicht in GuV (Saldenvortragskonten können ignoriert werden, sollten aber 0 sein)");
77 for my $konto (@$konten_nicht_in_guv) {
78 $self->tester->diag($konto);
83 sub check_bilanzkonten_mit_pos_eur {
86 my $query = qq|SELECT accno, description FROM chart WHERE (category = 'A' OR category = 'L' OR category = 'Q') AND (pos_eur IS NOT NULL OR pos_eur != 0)|;
88 my $bilanzkonten_mit_pos_eur = selectall_hashref_query($::form, $self->dbh, $query);
89 if (@$bilanzkonten_mit_pos_eur) {
90 $self->tester->ok(0, "Es gibt Bilanzkonten die der GuV/EÜR zugeordnet sind)");
91 $self->tester->diag("$_->{accno} $_->{description}") for @$bilanzkonten_mit_pos_eur;
93 $self->tester->ok(1, "Keine Bilanzkonten in der GuV");
97 sub check_balanced_individual_transactions {
101 select sum(ac.amount) as amount,trans_id,ar.invnumber as ar,ap.invnumber as ap,gl.reference as gl
103 left join ar on (ar.id = ac.trans_id)
104 left join ap on (ap.id = ac.trans_id)
105 left join gl on (gl.id = ac.trans_id)
106 where ac.transdate >= ? AND ac.transdate <= ?
107 group by trans_id,ar.invnumber,ap.invnumber,gl.reference
108 having sum(ac.amount) != 0;|;
110 my $acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
112 $self->tester->ok(0, "Es gibt unausgeglichene acc_trans-Transaktionen:");
113 for my $ac (@{ $acs }) {
114 $self->tester->diag("trans_id: $ac->{trans_id}, amount = $ac->{amount}, ar: $ac->{ar} ap: $ac->{ap} gl: $ac->{gl}");
117 $self->tester->ok(1, "Alle acc_trans Transaktionen ergeben in Summe 0, keine unausgeglichenen Transaktionen");
121 sub check_verwaiste_acc_trans_eintraege {
125 select trans_id,amount,accno,description from acc_trans a
126 left join chart c on (c.id = a.chart_id)
127 where trans_id not in (select id from gl union select id from ar union select id from ap order by id)
128 and a.transdate >= ? and a.transdate <= ? ;|;
130 my $verwaiste_acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
131 if (@$verwaiste_acs) {
132 $self->tester->ok(0, "Es gibt verwaiste acc-trans Einträge! (wo ar/ap/gl-Eintrag fehlt)");
133 $self->tester->diag($_) for @$verwaiste_acs;
135 $self->tester->ok(1, "Keine verwaisten acc-trans Einträge (wo ar/ap/gl-Eintrag fehlt)");
139 sub check_verwaiste_invoice_eintraege {
140 # this check is always run for all invoice entries in the entire database
143 select * from invoice i
144 where trans_id not in (select id from ar WHERE ar.transdate >=? AND ar.transdate <=?
146 select id from ap WHERE ap.transdate >= ? and ap.transdate <= ?)
147 AND i.transdate >=? AND i.transdate <=?|;
149 my $verwaiste_invoice = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
150 $self->fromdate, $self->todate, $self->fromdate, $self->todate);
153 if (@$verwaiste_invoice) {
154 $self->tester->ok(0, "Es gibt verwaiste invoice Einträge! (wo ar/ap-Eintrag fehlt)");
155 for my $invoice ( @{ $verwaiste_invoice }) {
156 $self->tester->diag("invoice: id: $invoice->{id} trans_id: $invoice->{trans_id} description: $invoice->{description} itime: $invoice->{itime}");
159 $self->tester->ok(1, "Keine verwaisten invoice Einträge (wo ar/ap-Eintrag fehlt)"); }
162 sub check_netamount_laut_invoice_ar {
165 select sum(round(cast(i.qty*(i.fxsellprice * (1-i.discount)) as numeric), 2))
167 left join ar a on (a.id = i.trans_id)
168 where a.transdate >= ? and a.transdate <= ?;|;
169 my ($netamount_laut_invoice) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
171 $query = qq| select sum(netamount) from ar where transdate >= ? and transdate <= ? AND invoice; |;
172 my ($netamount_laut_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
174 # should be enough to get a diff below 1. We have currently the following issues:
175 # verkaufsbericht berücksichtigt keinen rabatt
176 # fxsellprice ist mit mwst-inklusive
177 my $correct = abs($netamount_laut_invoice - $netamount_laut_ar) < 1;
179 $self->tester->ok($correct, "Summe laut Verkaufsbericht sollte gleich Summe aus Verkauf -> Berichte -> Rechnungen sein");
181 $self->tester->diag("Netto-Summe laut Verkaufsbericht (invoice): $netamount_laut_invoice");
182 $self->tester->diag("Netto-Summe laut Verkauf -> Berichte -> Rechnungen: $netamount_laut_ar");
186 sub check_invnumbers_unique {
189 my $query = qq| select invnumber,count(invnumber) as count from ar
190 where transdate >= ? and transdate <= ?
192 having count(invnumber) > 1; |;
193 my $non_unique_invnumbers = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
195 if (@$non_unique_invnumbers) {
196 $self->tester->ok(0, "Es gibt doppelte Rechnungsnummern");
197 for my $invnumber (@{ $non_unique_invnumbers }) {
198 $self->tester->diag("invnumber: $invnumber->{invnumber} $invnumber->{count}x");
201 $self->tester->ok(1, "Alle Rechnungsnummern sind eindeutig");
205 sub check_summe_stornobuchungen {
209 SELECT sum(amount) from ar a WHERE a.id IN
210 (SELECT id from ap where storno is true
211 AND a.transdate >= ? and a.transdate <= ?)|;
212 my ($summe_stornobuchungen_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
215 SELECT sum(amount) from ap a WHERE a.id IN
216 (SELECT id from ap where storno is true
217 AND a.transdate >= ? and a.transdate <= ?)|;
218 my ($summe_stornobuchungen_ap) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
220 $self->tester->ok($summe_stornobuchungen_ap == 0, 'Summe aller Einkaufsrechnungen (stornos + stornierte) soll 0 sein');
221 $self->tester->ok($summe_stornobuchungen_ar == 0, 'Summe aller Verkaufsrechnungen (stornos + stornierte) soll 0 sein');
222 $self->tester->diag("Summe Verkaufsrechnungen (ar): $summe_stornobuchungen_ar") if $summe_stornobuchungen_ar;
223 $self->tester->diag("Summe Einkaufsrechnungen (ap): $summe_stornobuchungen_ap") if $summe_stornobuchungen_ap;
230 select invnumber,paid,
231 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as accpaid ,
232 paid+(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as diff
235 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') is not null
237 AND ar.id in (SELECT id from ar where transdate >= ? and transdate <= ?)
240 my $paid_diffs_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
242 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ar;
244 $self->tester->ok(!$errors, "Vergleich ar paid mit acc_trans AR_paid");
246 for my $paid_diff_ar (@{ $paid_diffs_ar }) {
247 next if $paid_diff_ar->{diff} == 0;
248 $self->tester->diag("ar invnumber: $paid_diff_ar->{invnumber} : paid: $paid_diff_ar->{paid} acc_paid= $paid_diff_ar->{accpaid} diff: $paid_diff_ar->{diff}");
256 select invnumber,paid,id,
257 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as accpaid ,
258 paid-(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as diff
261 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') is not null
262 AND ap.id in (SELECT id from ap where transdate >= ? and transdate <= ?)
265 my $paid_diffs_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
267 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ap;
269 $self->tester->ok(!$errors, "Vergleich ap paid mit acc_trans AP_paid");
270 for my $paid_diff_ap (@{ $paid_diffs_ap }) {
271 next if $paid_diff_ap->{diff} == 0;
272 $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : ID :: ID : $paid_diff_ap->{id} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
276 sub check_ar_overpayments {
280 select invnumber,paid,amount,transdate,c.customernumber,c.name from ar left join customer c on (ar.customer_id = c.id)
281 where abs(paid) > abs(amount)
282 AND transdate >= ? and transdate <= ?
283 order by invnumber;|;
285 my $overpaids_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
287 my $correct = 0 == @$overpaids_ar;
289 $self->tester->ok($correct, "Keine Überzahlungen laut ar.paid");
290 for my $overpaid_ar (@{ $overpaids_ar }) {
291 $self->tester->diag("ar invnumber: $overpaid_ar->{invnumber} : paid: $overpaid_ar->{paid} amount= $overpaid_ar->{amount} transdate = $overpaid_ar->{transdate}");
295 sub check_ap_overpayments {
299 select invnumber,paid,amount,transdate,vc.vendornumber,vc.name from ap left join vendor vc on (ap.vendor_id = vc.id)
300 where abs(paid) > abs(amount)
301 AND transdate >= ? and transdate <= ?
302 order by invnumber;|;
304 my $overpaids_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
306 my $correct = 0 == @$overpaids_ap;
308 $self->tester->ok($correct, "Überzahlungen laut ap.paid:");
309 for my $overpaid_ap (@{ $overpaids_ap }) {
310 $self->tester->diag("ap invnumber: $overpaid_ap->{invnumber} : paid: $overpaid_ap->{paid} amount= $overpaid_ap->{amount} transdate = $overpaid_ap->{transdate}");
314 sub check_paid_stornos {
318 SELECT ar.invnumber,sum(amount - COALESCE((SELECT sum(amount)*-1
319 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
320 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id ),0)) as "open"
324 AND (ar.customer_id = customer.id)
325 AND ar.transdate >= ? and ar.transdate <= ?
326 GROUP BY ar.invnumber|;
327 my $paid_stornos = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
329 $self->tester->ok(0 == @$paid_stornos, "Keine bezahlten Stornos");
330 for my $paid_storno (@{ $paid_stornos }) {
331 $self->tester->diag("invnumber: $paid_storno->{invnumber} offen: $paid_storno->{open}");
335 sub check_stornos_ohne_partner {
339 SELECT (SELECT cast ('ar' as text)) as invoice ,ar.id,invnumber,storno,amount,transdate,type,customernumber as cv_number
341 LEFT JOIN customer c on (c.id = ar.customer_id)
342 WHERE storno_id is null AND storno is true AND ar.id not in (SELECT storno_id FROM ar WHERE storno_id is not null AND storno is true)
343 AND ar.transdate >= ? and ar.transdate <= ?
345 SELECT (SELECT cast ('ap' as text)) as invoice,ap.id,invnumber,storno,amount,transdate,type,vendornumber as cv_number
347 LEFT JOIN vendor v on (v.id = ap.vendor_id)
348 WHERE storno_id is null AND storno is true AND ap.id not in (SELECT storno_id FROM ap WHERE storno_id is not null AND storno is true)
349 AND ap.transdate >= ? and ap.transdate <= ?|;
351 my $stornos_ohne_partner = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
352 $self->fromdate, $self->todate);
354 $self->tester->ok(@$stornos_ohne_partner == 0, 'Es sollte keine Stornos ohne Partner geben');
355 if (@$stornos_ohne_partner) {
356 $self->tester->diag("Stornos ohne Partner, oder Storno über Jahreswechsel hinaus");
358 my $stornoheader = 0;
359 for my $storno (@{ $stornos_ohne_partner }) {
360 if (!$stornoheader++) {
361 $self->tester->diag(join "\t", keys %$storno);
363 $self->tester->diag(join "\t", map { $storno->{$_} } keys %$storno);
367 sub check_overpayments {
370 # Vergleich ar.paid und das was laut acc_trans bezahlt wurde
371 # "als bezahlt markieren" ohne sauberes Ausbuchen führt zu Differenzen bei offenen Forderungen
372 # Berücksichtigt Zahlungseingänge im Untersuchungszeitraums und
373 # prüft weitere Zahlungen und Buchungen über trans_id (kein Zeitfilter)
377 invnumber,customernumber,name,ar.transdate,ar.datepaid,
379 amount-paid as "open via ar",
380 paid as "paid via ar",
381 coalesce((SELECT sum(amount)*-1 FROM acc_trans
382 WHERE chart_link ilike '%paid%' AND acc_trans.trans_id=ar.id),0) as "paid via acc_trans"
383 FROM ar left join customer c on (c.id = ar.customer_id)
386 AND ar.id in (SELECT trans_id from acc_trans where transdate >= ? AND transdate <= ? AND chart_link ilike '%paid%')|;
388 my $invoices = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
390 my $count_overpayments = scalar grep {
391 $_->{"paid via ar"} != $_->{"paid via acc_trans"}
392 || ( $_->{"amount"} - $_->{"paid via acc_trans"} != $_->{"open via ar"}
393 && $_->{"paid via ar"} != $_->{"paid via acc_trans"} )
396 $self->tester->ok($count_overpayments == 0, 'Vergleich ar.paid und das was laut acc_trans bezahlt wurde');
398 if ($count_overpayments) {
399 for my $invoice (@{ $invoices }) {
400 if ($invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
401 $self->tester->diag("Rechnung: $invoice->{invnumber}, Kunde $invoice->{name} Nebenbuch-Bezahlwert: (@{[ $invoice->{'paid via ar'} * 1 ]}) != Hauptbuch-Bezahlwert: (@{[ $invoice->{'paid via acc_trans'} * 1 ]}) (at least until transdate!)");
402 if (defined $invoice->{datepaid}) {
403 $self->tester->diag("datepaid = $invoice->{datepaid})");
405 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
406 } elsif ( $invoice->{"amount"} - $invoice->{"paid via acc_trans"} != $invoice->{"open via ar"} && $invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
407 $self->tester->diag("amount - paid_via_acc_trans != open_via_ar");
408 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
416 sub calc_saldenvortraege {
419 my $saldenvortragskonto = '9000';
421 # Saldo Saldenvortragskonto 9000 am Jahresanfang
423 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
424 my ($saldo_9000_jahresanfang) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 1, month => 1, year => DateTime->today->year));
425 $self->tester->diag("Saldo 9000 am 01.01.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresanfang * 1 ]} (sollte 0 sein)");
427 # Saldo Saldenvortragskonto 9000 am Jahresende
429 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
430 my ($saldo_9000_jahresende) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 31, month => 12, year => DateTime->today->year));
431 $self->tester->diag("Saldo $saldenvortragskonto am 31.12.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresende * 1 ]} (sollte 0 sein)");
434 sub check_every_account_with_taxkey {
437 my $query = qq|SELECT accno, description FROM chart WHERE id NOT IN (select chart_id from taxkeys)|;
438 my $accounts_without_tk = selectall_hashref_query($::form, $self->dbh, $query);
440 if ( scalar @{ $accounts_without_tk } > 0 ){
441 $self->tester->ok(0, "Folgende Konten haben keinen gültigen Steuerschlüssel:");
443 for my $account_without_tk (@{ $accounts_without_tk } ) {
444 $self->tester->diag("Kontonummer: $account_without_tk->{accno} Beschreibung: $account_without_tk->{description}");
447 $self->tester->ok(1, "Jedes Konto hat einen gültigen Steuerschlüssel!");
451 sub check_ar_acc_trans_amount {
455 select sum(ac.amount) as amount, ar.invnumber,ar.netamount
456 from acc_trans ac left join ar on (ac.trans_id = ar.id)
457 WHERE ac.chart_link like 'AR_amount%'
458 AND ac.transdate >= ? AND ac.transdate <= ?
459 group by invnumber,netamount having sum(ac.amount) <> ar.netamount|;
461 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
463 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
464 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
466 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
467 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{amount}
468 Nebenbuch-Wert: $ar_ac_amount_nok->{netamount}");
471 $self->tester->ok(1, "Hauptbuch-Nettowert und Debitoren-Nebenbuch-Nettowert stimmen überein.");
476 sub check_ap_acc_trans_amount {
480 select sum(ac.amount) as amount, ap.invnumber,ap.netamount
481 from acc_trans ac left join ap on (ac.trans_id = ap.id)
482 WHERE ac.chart_link like '%AP_amount%'
483 AND ac.transdate >= ? AND ac.transdate <= ?
484 group by invnumber,trans_id,netamount having sum(ac.amount) <> ap.netamount*-1|;
486 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
488 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
489 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
491 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
492 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{amount}
493 Nebenbuch-Wert: $ap_ac_amount_nok->{netamount}");
496 $self->tester->ok(1, "Hauptbuch-Nettowert und Kreditoren-Nebenbuch-Nettowert stimmen überein.");
502 sub check_missing_tax_bookings {
506 # check tax bookings. all taxkey <> 0 should have tax bookings in acc_trans
508 my $query = qq| select trans_id, chart.accno,transdate from acc_trans left join chart on (chart.id = acc_trans.chart_id)
509 WHERE taxkey NOT IN (SELECT taxkey from tax where rate=0) AND trans_id NOT IN
510 (select trans_id from acc_trans where chart_link ilike '%tax%' and trans_id IN
511 (SELECT trans_id from acc_trans where taxkey NOT IN (SELECT taxkey from tax where rate=0)))
512 AND transdate >= ? AND transdate <= ?|;
514 my $missing_tax_bookings = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
516 if ( scalar @{ $missing_tax_bookings } > 0 ) {
517 $self->tester->ok(0, "Folgende Konten weisen Buchungen ohne Steuerverknüpfung auf:");
519 for my $acc_trans_nok (@{ $missing_tax_bookings } ) {
520 $self->tester->diag("Kontonummer: $acc_trans_nok->{accno} Belegdatum: $acc_trans_nok->{transdate} Trans-ID: $acc_trans_nok->{trans_id}.
521 Kann über System -> Korrekturen im Hauptbuch bereinigt werden. Falls es ein Zahlungskonto ist, wurde
522 ggf. ein Brutto-Skonto-Konto mit einer Netto-Rechnung verknüpft. Kann nur per SQL geändert werden.");
525 $self->tester->ok(1, "Hauptbuch-Nettowert und Nebenbuch-Nettowert stimmen überein.");
529 sub check_bank_transactions_overpayments {
533 select id,amount,invoice_amount, purpose,transdate from bank_transactions where abs(invoice_amount) > abs(amount)
534 AND transdate >= ? AND transdate <= ? order by transdate|;
536 my $overpaids_bank_transactions = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
538 my $correct = 0 == @$overpaids_bank_transactions;
540 $self->tester->ok($correct, "Keine überbuchte Banktransaktion (der zugeordnete Betrag ist nicht höher, als der Überweisungsbetrag).");
541 for my $overpaid_bank_transaction (@{ $overpaids_bank_transactions }) {
542 $self->tester->diag("Überbuchte Bankbewegung!
543 Verwendungszweck: $overpaid_bank_transaction->{purpose}
544 Transaktionsdatum: $overpaid_bank_transaction->{transdate}
545 Betrag= $overpaid_bank_transaction->{amount} Zugeordneter Betrag = $overpaid_bank_transaction->{invoice_amount}
546 Bitte kontaktieren Sie Ihren kivitendo-DB-Admin, der die Überweisung wieder zurücksetzt (Table: bank_transactions Column: invoice_amount).");
550 sub check_ar_paid_acc_trans {
554 select sum(ac.amount) as paid_amount, ar.invnumber,ar.paid
555 from acc_trans ac left join ar on (ac.trans_id = ar.id)
556 WHERE ac.chart_link like '%AR_paid%'
557 AND ac.trans_id in (SELECT trans_id from acc_trans ac where ac.transdate >= ? AND ac.transdate <= ?)
558 group by invnumber, paid having sum(ac.amount) <> ar.paid*-1|;
560 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
562 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
563 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Bezahl-Wert im Nebenbuch:");
565 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
566 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{paid_amount}
567 Nebenbuch-Wert: $ar_ac_amount_nok->{paid}");
570 $self->tester->ok(1, "Hauptbuch-Bezahlwert und Debitoren-Nebenbuch-Bezahlwert stimmen überein.");
574 sub check_ap_paid_acc_trans {
578 select sum(ac.amount) as paid_amount, ap.invnumber,ap.paid
579 from acc_trans ac left join ap on (ac.trans_id = ap.id)
580 WHERE ac.chart_link like '%AP_paid%'
581 AND ac.trans_id in (SELECT trans_id from acc_trans ac where ac.transdate >= ? AND ac.transdate <= ?)
582 group by trans_id,invnumber,paid having sum(ac.amount) <> ap.paid|;
584 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
586 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
587 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Bezahl-Wert im Nebenbuch:");
589 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
590 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{paid_amount}
591 Nebenbuch-Wert: $ap_ac_amount_nok->{paid}");
594 $self->tester->ok(1, "Hauptbuch Bezahl-Wert und Kreditoren-Nebenbuch-Bezahlwert stimmen überein.");
598 sub check_zero_amount_paid_but_datepaid_exists {
601 my $query = qq|(SELECT invnumber,datepaid from ar where datepaid is NOT NULL AND paid = 0
602 AND id not IN (select trans_id from acc_trans WHERE chart_link like '%paid%' AND acc_trans.trans_id = ar.id)
603 AND datepaid >= ? AND datepaid <= ?)
605 (SELECT invnumber,datepaid from ap where datepaid is NOT NULL AND paid = 0
606 AND id not IN (select trans_id from acc_trans WHERE chart_link like '%paid%' AND acc_trans.trans_id = ap.id)
607 AND datepaid >= ? AND datepaid <= ?)|;
609 my $datepaid_should_be_null = selectall_hashref_query($::form, $self->dbh, $query,
610 $self->fromdate, $self->todate,
611 $self->fromdate, $self->todate);
613 if ( scalar @{ $datepaid_should_be_null } > 0 ) {
614 $self->tester->ok(0, "Folgende Rechnungen haben ein Bezahl-Datum, aber keinen Bezahl-Wert im Nebenbuch:");
616 for my $datepaid_should_be_null_nok (@{ $datepaid_should_be_null } ) {
617 $self->tester->diag("Rechnungsnummer: $datepaid_should_be_null_nok->{invnumber}
618 Bezahl-Datum: $datepaid_should_be_null_nok->{datepaid}");
621 $self->tester->ok(1, "Kein Bezahl-Datum ohne Bezahl-Wert und ohne wirkliche Zahlungen gefunden (arap.datepaid, arap.paid konsistent).");
625 sub check_orphaned_reconciliated_links {
629 SELECT purpose from bank_transactions
630 WHERE cleared is true
631 AND id not in (SELECT bank_transaction_id from reconciliation_links)
632 AND transdate >= ? AND transdate <= ?|;
634 my $bt_cleared_no_link = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
636 if ( scalar @{ $bt_cleared_no_link } > 0 ) {
637 $self->tester->ok(0, "Verwaiste abgeglichene Bankbewegungen gefunden. Bei folgenden Bankbewegungen ist die abgleichende Verknüpfung gelöscht worden:");
639 for my $bt_orphaned (@{ $bt_cleared_no_link }) {
640 $self->tester->diag("Verwendungszweck: $bt_orphaned->{purpose}");
643 $self->tester->ok(1, "Keine verwaisten Einträge in abgeglichenen Bankbewegungen.");
656 SL::BackgroundJob::SelfTest::Transactions - base tests
660 Several tests for data integrity.
668 G. Richardson E<lt>information@richardson-bueren.deE<gt>
669 Jan Büren E<lt>information@richardson-bueren.deE<gt>
670 Sven Schoeling E<lt>s.schoeling@linet-services.deE<gt>