1 package SL::BackgroundJob::SelfTest::Transactions;
5 use parent qw(SL::BackgroundJob::SelfTest::Base);
9 use Rose::Object::MakeMethods::Generic (
10 scalar => [ qw(dbh fromdate todate) ],
18 $self->tester->plan(tests => 20);
20 $self->check_konten_mit_saldo_nicht_in_guv;
21 $self->check_bilanzkonten_mit_pos_eur;
22 $self->check_balanced_individual_transactions;
23 $self->check_verwaiste_acc_trans_eintraege;
24 $self->check_verwaiste_invoice_eintraege;
25 $self->check_ar_acc_trans_amount;
26 $self->check_ap_acc_trans_amount;
27 $self->check_netamount_laut_invoice_ar;
28 $self->check_invnumbers_unique;
29 $self->check_summe_stornobuchungen;
32 $self->check_ar_overpayments;
33 $self->check_ap_overpayments;
34 $self->check_paid_stornos;
35 $self->check_stornos_ohne_partner;
36 $self->check_overpayments;
37 $self->check_every_account_with_taxkey;
38 $self->calc_saldenvortraege;
39 $self->check_missing_tax_bookings;
45 # TODO FIXME calc dates better, unless this is wanted
46 $self->fromdate(DateTime->new(day => 1, month => 1, year => DateTime->today->year));
47 $self->todate($self->fromdate->clone->add(years => 1)->add(days => -1));
48 $self->dbh($::form->get_standard_dbh);
51 sub check_konten_mit_saldo_nicht_in_guv {
55 SELECT c.accno, c.description, c.category, SUM(a.amount) AS Saldo
58 WHERE c.id = a.chart_id
59 and (c.category like 'I' or c.category like 'E')
62 and a.transdate >= ? and a.transdate <= ?
63 GROUP BY c.accno,c.description,c.category,c.pos_bilanz,c.pos_eur
66 my $konten_nicht_in_guv = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
68 my $correct = 0 == scalar grep { $_->{Saldo} } @$konten_nicht_in_guv;
70 $self->tester->ok($correct, "Erfolgskonten mit Saldo nicht in GuV (Saldenvortragskonten können ignoriert werden, sollten aber 0 sein)");
72 for my $konto (@$konten_nicht_in_guv) {
73 $self->tester->diag($konto);
78 sub check_bilanzkonten_mit_pos_eur {
81 my $query = qq|SELECT accno, description FROM chart WHERE (category = 'A' OR category = 'L' OR category = 'Q') AND (pos_eur IS NOT NULL OR pos_eur != 0)|;
83 my $bilanzkonten_mit_pos_eur = selectall_hashref_query($::form, $self->dbh, $query);
84 if (@$bilanzkonten_mit_pos_eur) {
85 $self->tester->ok(0, "Es gibt Bilanzkonten die der GuV/EÜR zugeordnet sind)");
86 $self->tester->diag("$_->{accno} $_->{description}") for @$bilanzkonten_mit_pos_eur;
88 $self->tester->ok(1, "Keine Bilanzkonten in der GuV");
92 sub check_balanced_individual_transactions {
96 select sum(ac.amount) as amount,trans_id,ar.invnumber as ar,ap.invnumber as ap,gl.reference as gl
98 left join ar on (ar.id = ac.trans_id)
99 left join ap on (ap.id = ac.trans_id)
100 left join gl on (gl.id = ac.trans_id)
101 where ac.transdate >= ? AND ac.transdate <= ?
102 group by trans_id,ar.invnumber,ap.invnumber,gl.reference
103 having sum(ac.amount) != 0;|;
105 my $acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
107 $self->tester->ok(0, "Es gibt unausgeglichene acc_trans-Transaktionen:");
108 for my $ac (@{ $acs }) {
109 $self->tester->diag("trans_id: $ac->{trans_id}, amount = $ac->{amount}, ar: $ac->{ar} ap: $ac->{ap} gl: $ac->{gl}");
112 $self->tester->ok(1, "Alle acc_trans Transaktionen ergeben in Summe 0, keine unausgeglichenen Transaktionen");
116 sub check_verwaiste_acc_trans_eintraege {
120 select trans_id,amount,accno,description from acc_trans a
121 left join chart c on (c.id = a.chart_id)
122 where trans_id not in (select id from gl union select id from ar union select id from ap order by id)
123 and a.transdate >= ? and a.transdate <= ? ;|;
125 my $verwaiste_acs = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
126 if (@$verwaiste_acs) {
127 $self->tester->ok(0, "Es gibt verwaiste acc-trans Einträge! (wo ar/ap/gl-Eintrag fehlt)");
128 $self->tester->diag($_) for @$verwaiste_acs;
130 $self->tester->ok(1, "Keine verwaisten acc-trans Einträge (wo ar/ap/gl-Eintrag fehlt)");
134 sub check_verwaiste_invoice_eintraege {
135 # this check is always run for all invoice entries in the entire database
138 select * from invoice i
139 where trans_id not in (select id from ar WHERE ar.transdate >=? AND ar.transdate <=?
141 select id from ap WHERE ap.transdate >= ? and ap.transdate <= ?)
142 AND i.transdate >=? AND i.transdate <=?|;
144 my $verwaiste_invoice = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
145 $self->fromdate, $self->todate, $self->fromdate, $self->todate);
148 if (@$verwaiste_invoice) {
149 $self->tester->ok(0, "Es gibt verwaiste invoice Einträge! (wo ar/ap-Eintrag fehlt)");
150 for my $invoice ( @{ $verwaiste_invoice }) {
151 $self->tester->diag("invoice: id: $invoice->{id} trans_id: $invoice->{trans_id} description: $invoice->{description} itime: $invoice->{itime}");
154 $self->tester->ok(1, "Keine verwaisten invoice Einträge (wo ar/ap-Eintrag fehlt)"); }
157 sub check_netamount_laut_invoice_ar {
160 select sum(round(cast(i.qty*(i.fxsellprice * (1-i.discount)) as numeric), 2))
162 left join ar a on (a.id = i.trans_id)
163 where a.transdate >= ? and a.transdate <= ?;|;
164 my ($netamount_laut_invoice) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
166 $query = qq| select sum(netamount) from ar where transdate >= ? and transdate <= ? AND invoice; |;
167 my ($netamount_laut_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
169 # should be enough to get a diff below 1. We have currently the following issues:
170 # verkaufsbericht berücksichtigt keinen rabatt
171 # fxsellprice ist mit mwst-inklusive
172 my $correct = abs($netamount_laut_invoice - $netamount_laut_ar) < 1;
174 $self->tester->ok($correct, "Summe laut Verkaufsbericht sollte gleich Summe aus Verkauf -> Berichte -> Rechnungen sein");
176 $self->tester->diag("Netto-Summe laut Verkaufsbericht (invoice): $netamount_laut_invoice");
177 $self->tester->diag("Netto-Summe laut Verkauf -> Berichte -> Rechnungen: $netamount_laut_ar");
181 sub check_invnumbers_unique {
184 my $query = qq| select invnumber,count(invnumber) as count from ar
185 where transdate >= ? and transdate <= ?
187 having count(invnumber) > 1; |;
188 my $non_unique_invnumbers = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
190 if (@$non_unique_invnumbers) {
191 $self->tester->ok(0, "Es gibt doppelte Rechnungsnummern");
192 for my $invnumber (@{ $non_unique_invnumbers }) {
193 $self->tester->diag("invnumber: $invnumber->{invnumber} $invnumber->{count}x");
196 $self->tester->ok(1, "Alle Rechnungsnummern sind eindeutig");
200 sub check_summe_stornobuchungen {
204 select sum(amount) from ar a JOIN customer c ON (a.customer_id = c.id)
206 AND a.transdate >= ? and a.transdate <= ?|;
207 my ($summe_stornobuchungen_ar) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
210 select sum(amount) from ap a JOIN vendor c ON (a.vendor_id = c.id)
212 AND a.transdate >= ? and a.transdate <= ?|;
213 my ($summe_stornobuchungen_ap) = selectfirst_array_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
215 $self->tester->ok($summe_stornobuchungen_ap == 0, 'Summe aller Einkaufsrechnungen (stornos + stornierte) soll 0 sein');
216 $self->tester->ok($summe_stornobuchungen_ar == 0, 'Summe aller Verkaufsrechnungen (stornos + stornierte) soll 0 sein');
217 $self->tester->diag("Summe Verkaufsrechnungen (ar): $summe_stornobuchungen_ar") if $summe_stornobuchungen_ar;
218 $self->tester->diag("Summe Einkaufsrechnungen (ap): $summe_stornobuchungen_ap") if $summe_stornobuchungen_ap;
225 select invnumber,paid,
226 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as accpaid ,
227 paid+(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') as diff
230 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ar.id and c.link like '%AR_paid%') is not null
232 AND transdate >= ? and transdate <= ?
235 my $paid_diffs_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
237 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ar;
239 $self->tester->ok(!$errors, "Vergleich ar paid mit acc_trans AR_paid");
241 for my $paid_diff_ar (@{ $paid_diffs_ar }) {
242 next if $paid_diff_ar->{diff} == 0;
243 $self->tester->diag("ar invnumber: $paid_diff_ar->{invnumber} : paid: $paid_diff_ar->{paid} acc_paid= $paid_diff_ar->{accpaid} diff: $paid_diff_ar->{diff}");
251 select invnumber,paid,
252 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as accpaid ,
253 paid-(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as diff
256 (select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') is not null
257 AND transdate >= ? and transdate <= ?
260 my $paid_diffs_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
262 my $errors = scalar grep { $_->{diff} != 0 } @$paid_diffs_ap;
264 $self->tester->ok(!$errors, "Vergleich ap paid mit acc_trans AP_paid");
265 for my $paid_diff_ap (@{ $paid_diffs_ap }) {
266 next if $paid_diff_ap->{diff} == 0;
267 $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
271 sub check_ar_overpayments {
275 select invnumber,paid,amount,transdate,c.customernumber,c.name from ar left join customer c on (ar.customer_id = c.id)
276 where abs(paid) > abs(amount)
277 AND transdate >= ? and transdate <= ?
278 order by invnumber;|;
280 my $overpaids_ar = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
282 my $correct = 0 == @$overpaids_ar;
284 $self->tester->ok($correct, "Keine Überzahlungen laut ar.paid");
285 for my $overpaid_ar (@{ $overpaids_ar }) {
286 $self->tester->diag("ar invnumber: $overpaid_ar->{invnumber} : paid: $overpaid_ar->{paid} amount= $overpaid_ar->{amount} transdate = $overpaid_ar->{transdate}");
290 sub check_ap_overpayments {
294 select invnumber,paid,amount,transdate,vc.vendornumber,vc.name from ap left join vendor vc on (ap.vendor_id = vc.id)
295 where abs(paid) > abs(amount)
296 AND transdate >= ? and transdate <= ?
297 order by invnumber;|;
299 my $overpaids_ap = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
301 my $correct = 0 == @$overpaids_ap;
303 $self->tester->ok($correct, "Überzahlungen laut ap.paid:");
304 for my $overpaid_ap (@{ $overpaids_ap }) {
305 $self->tester->diag("ap invnumber: $overpaid_ap->{invnumber} : paid: $overpaid_ap->{paid} amount= $overpaid_ap->{amount} transdate = $overpaid_ap->{transdate}");
309 sub check_paid_stornos {
313 SELECT ar.invnumber,sum(amount - COALESCE((SELECT sum(amount)*-1
314 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
315 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id ),0)) as "open"
319 AND (ar.customer_id = customer.id)
320 AND ar.transdate >= ? and ar.transdate <= ?
321 GROUP BY ar.invnumber|;
322 my $paid_stornos = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
324 $self->tester->ok(0 == @$paid_stornos, "Keine bezahlten Stornos");
325 for my $paid_storno (@{ $paid_stornos }) {
326 $self->tester->diag("invnumber: $paid_storno->{invnumber} offen: $paid_storno->{open}");
330 sub check_stornos_ohne_partner {
334 SELECT (SELECT cast ('ar' as text)) as invoice ,ar.id,invnumber,storno,amount,transdate,type,customernumber as cv_number
336 LEFT JOIN customer c on (c.id = ar.customer_id)
337 WHERE storno_id is null AND storno is true AND ar.id not in (SELECT storno_id FROM ar WHERE storno_id is not null AND storno is true)
338 AND ar.transdate >= ? and ar.transdate <= ?
340 SELECT (SELECT cast ('ap' as text)) as invoice,ap.id,invnumber,storno,amount,transdate,type,vendornumber as cv_number
342 LEFT JOIN vendor v on (v.id = ap.vendor_id)
343 WHERE storno_id is null AND storno is true AND ap.id not in (SELECT storno_id FROM ap WHERE storno_id is not null AND storno is true)
344 AND ap.transdate >= ? and ap.transdate <= ?|;
346 my $stornos_ohne_partner = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate,
347 $self->fromdate, $self->todate);
349 $self->tester->ok(@$stornos_ohne_partner == 0, 'Es sollte keine Stornos ohne Partner geben');
350 if (@$stornos_ohne_partner) {
351 $self->tester->diag("Stornos ohne Partner, oder Storno über Jahreswechsel hinaus");
353 my $stornoheader = 0;
354 for my $storno (@{ $stornos_ohne_partner }) {
355 if (!$stornoheader++) {
356 $self->tester->diag(join "\t", keys %$storno);
358 $self->tester->diag(join "\t", map { $storno->{$_} } keys %$storno);
362 sub check_overpayments {
365 # Vergleich ar.paid und das was laut acc_trans bezahlt wurde
366 # "als bezahlt markieren" ohne sauberes Ausbuchen führt zu Differenzen bei offenen Forderungen
367 # geht nur auf wenn acc_trans Zahlungseingänge auch im Untersuchungszeitraum lagen
368 # Stornos werden rausgefiltert
371 invnumber,customernumber,name,ar.transdate,ar.datepaid,
373 amount-paid as "open via ar",
374 paid as "paid via ar",
375 coalesce((SELECT sum(amount)*-1 FROM acc_trans LEFT JOIN chart ON (acc_trans.chart_id=chart.id)
376 WHERE link ilike '%paid%' AND acc_trans.trans_id=ar.id AND acc_trans.transdate <= ?),0) as "paid via acc_trans"
377 FROM ar left join customer c on (c.id = ar.customer_id)
380 AND transdate >= ? AND transdate <= ?|;
382 my $invoices = selectall_hashref_query($::form, $self->dbh, $query, $self->todate, $self->fromdate, $self->todate);
384 my $count_overpayments = scalar grep {
385 $_->{"paid via ar"} != $_->{"paid via acc_trans"}
386 || ( $_->{"amount"} - $_->{"paid via acc_trans"} != $_->{"open via ar"}
387 && $_->{"paid via ar"} != $_->{"paid via acc_trans"} )
390 $self->tester->ok($count_overpayments == 0, 'Vergleich ar.paid und das was laut acc_trans bezahlt wurde');
392 if ($count_overpayments) {
393 for my $invoice (@{ $invoices }) {
394 if ($invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
395 $self->tester->diag("paid via ar (@{[ $invoice->{'paid via ar'} * 1 ]}) != paid via acc_trans (@{[ $invoice->{'paid via acc_trans'} * 1 ]}) (at least until transdate!)");
396 if (defined $invoice->{datepaid}) {
397 $self->tester->diag("datepaid = $invoice->{datepaid})");
399 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
400 } elsif ( $invoice->{"amount"} - $invoice->{"paid via acc_trans"} != $invoice->{"open via ar"} && $invoice->{"paid via ar"} != $invoice->{"paid via acc_trans"}) {
401 $self->tester->diag("amount - paid_via_acc_trans != open_via_ar");
402 $self->tester->diag("Überzahlung bei Rechnung: $invoice->{invnumber}") if $invoice->{"paid via acc_trans"} > $invoice->{amount};
410 sub calc_saldenvortraege {
413 my $saldenvortragskonto = '9000';
415 # Saldo Saldenvortragskonto 9000 am Jahresanfang
417 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
418 my ($saldo_9000_jahresanfang) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 1, month => 1, year => DateTime->today->year));
419 $self->tester->diag("Saldo 9000 am 01.01.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresanfang * 1 ]} (sollte 0 sein)");
421 # Saldo Saldenvortragskonto 9000 am Jahresende
423 select sum(amount) from acc_trans where chart_id = (select id from chart where accno = ?) and transdate <= ?|;
424 my ($saldo_9000_jahresende) = selectfirst_array_query($::form, $self->dbh, $query, $saldenvortragskonto, DateTime->new(day => 31, month => 12, year => DateTime->today->year));
425 $self->tester->diag("Saldo $saldenvortragskonto am 31.12.@{[DateTime->today->year]}: @{[ $saldo_9000_jahresende * 1 ]} (sollte 0 sein)");
428 sub check_every_account_with_taxkey {
431 my $query = qq|SELECT accno, description FROM chart WHERE id NOT IN (select chart_id from taxkeys)|;
432 my $accounts_without_tk = selectall_hashref_query($::form, $self->dbh, $query);
434 if ( scalar @{ $accounts_without_tk } > 0 ){
435 $self->tester->ok(0, "Folgende Konten haben keinen gültigen Steuerschlüssel:");
437 for my $account_without_tk (@{ $accounts_without_tk } ) {
438 $self->tester->diag("Kontonummer: $account_without_tk->{accno} Beschreibung: $account_without_tk->{description}");
441 $self->tester->ok(1, "Jedes Konto hat einen gültigen Steuerschlüssel!");
445 sub check_ar_acc_trans_amount {
449 select sum(ac.amount) as amount, ar.invnumber,ar.netamount
450 from acc_trans ac left join ar on (ac.trans_id = ar.id)
451 WHERE ac.chart_link like 'AR_amount%'
452 AND ac.transdate >= ? AND ac.transdate <= ?
453 group by invnumber,netamount having sum(ac.amount) <> ar.netamount|;
455 my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
457 if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
458 $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
460 for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
461 $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{amount}
462 Nebenbuch-Wert: $ar_ac_amount_nok->{netamount}");
465 $self->tester->ok(1, "Hauptbuch-Nettowert und Debitoren-Nebenbuch-Nettowert stimmen überein.");
470 sub check_ap_acc_trans_amount {
474 select sum(ac.amount) as amount, ap.invnumber,ap.netamount
475 from acc_trans ac left join ap on (ac.trans_id = ap.id)
476 WHERE ac.chart_link like 'AR_amount%'
477 AND ac.transdate >= ? AND ac.transdate <= ?
478 group by invnumber,netamount having sum(ac.amount) <> ap.netamount*-1|;
480 my $ap_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
482 if ( scalar @{ $ap_amount_not_ac_amount } > 0 ) {
483 $self->tester->ok(0, "Folgende Eingangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
485 for my $ap_ac_amount_nok (@{ $ap_amount_not_ac_amount } ) {
486 $self->tester->diag("Rechnungsnummer: $ap_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ap_ac_amount_nok->{amount}
487 Nebenbuch-Wert: $ap_ac_amount_nok->{netamount}");
490 $self->tester->ok(1, "Hauptbuch-Nettowert und Kreditoren-Nebenbuch-Nettowert stimmen überein.");
496 sub check_missing_tax_bookings {
500 # check tax bookings. all taxkey <> 0 should have tax bookings in acc_trans
502 my $query = qq| select trans_id, chart.accno,transdate from acc_trans left join chart on (chart.id = acc_trans.chart_id)
503 WHERE taxkey <> 0 AND trans_id NOT IN
504 (select trans_id from acc_trans where chart_link ilike '%tax%' and trans_id IN
505 (SELECT trans_id from acc_trans where taxkey <> 0))
506 AND transdate >= ? AND transdate <= ?|;
508 my $missing_tax_bookings = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
510 if ( scalar @{ $missing_tax_bookings } > 0 ) {
511 $self->tester->ok(0, "Folgende Konten weisen Buchungen ohne Steuer auf:");
513 for my $acc_trans_nok (@{ $missing_tax_bookings } ) {
514 $self->tester->diag("Kontonummer: $acc_trans_nok->{accno} Belegdatum: $acc_trans_nok->{transdate} Trans-ID: $acc_trans_nok->{trans_id}.
515 Kann über System -> Korrekturen im Hauptbuch bereinigt werden.");
518 $self->tester->ok(1, "Hauptbuch-Nettowert und Nebenbuch-Nettowert stimmen überein.");
531 SL::BackgroundJob::SelfTest::Transactions - base tests
535 Several tests for data integrity.
543 G. Richardson E<lt>information@richardson-bueren.deE<gt>
544 Jan Büren E<lt>information@richardson-bueren.deE<gt>
545 Sven Schoeling E<lt>s.schoeling@linet-services.deE<gt>