1 use Test::More tests => 105;
9 use Support::TestSetup;
11 use List::Util qw(sum);
13 use SL::DB::Buchungsgruppe;
21 use SL::DB::BankAccount;
22 use SL::DB::PaymentTerm;
23 use SL::DB::PurchaseInvoice;
24 use SL::DB::BankTransaction;
25 use SL::Controller::BankTransaction;
29 my ($customer, $vendor, $currency_id, $unit, $tax, $tax7, $tax_9, $payment_terms, $bank_account);
30 my ($transdate1, $transdate2, $currency);
31 my ($ar_chart,$bank,$ar_amount_chart, $ap_chart, $ap_amount_chart);
32 my ($ar_transaction, $ap_transaction);
36 SL::DB::Manager::BankTransaction->delete_all(all => 1);
37 SL::DB::Manager::InvoiceItem->delete_all(all => 1);
38 SL::DB::Manager::InvoiceItem->delete_all(all => 1);
39 SL::DB::Manager::Invoice->delete_all(all => 1);
40 SL::DB::Manager::PurchaseInvoice->delete_all(all => 1);
41 SL::DB::Manager::Part->delete_all(all => 1);
42 SL::DB::Manager::Customer->delete_all(all => 1);
43 SL::DB::Manager::Vendor->delete_all(all => 1);
44 SL::DB::Manager::BankAccount->delete_all(all => 1);
45 SL::DB::Manager::PaymentTerm->delete_all(all => 1);
46 SL::DB::Manager::Currency->delete_all(where => [ name => 'CUR' ]);
49 sub save_btcontroller_to_string {
51 open(my $outputFH, '>', \$output) or die;
52 my $oldFH = select $outputFH;
54 my $bt_controller = SL::Controller::BankTransaction->new;
55 $bt_controller->action_save_invoices;
63 Support::TestSetup::login();
66 reset_state(); # initialise customers/vendors/bank/currency/...
70 test_overpayment_with_partialpayment();
74 test_partial_payment();
76 test_ap_transaction();
77 test_neg_ap_transaction();
78 test_ap_payment_transaction();
79 test_ap_payment_part_transaction();
80 test_neg_sales_invoice();
82 # remove all created data at end of test
87 ###### functions for setting up data
92 $params{$_} ||= {} for qw(unit customer tax vendor);
96 $transdate1 = DateTime->today;
97 $transdate2 = DateTime->today->add(days => 5);
99 $tax = SL::DB::Manager::Tax->find_by(taxkey => 3, rate => 0.19, %{ $params{tax} }) || croak "No tax";
100 $tax7 = SL::DB::Manager::Tax->find_by(taxkey => 2, rate => 0.07) || croak "No tax for 7\%";
101 $tax_9 = SL::DB::Manager::Tax->find_by(taxkey => 9, rate => 0.19, %{ $params{tax} }) || croak "No tax";
103 $currency_id = $::instance_conf->get_currency_id;
105 $bank_account = SL::DB::BankAccount->new(
106 account_number => '123',
111 chart_id => SL::DB::Manager::Chart->find_by(description => 'Bank')->id,
112 name => SL::DB::Manager::Chart->find_by(description => 'Bank')->description,
115 $customer = SL::Dev::CustomerVendor::create_customer(
116 name => 'Test Customer',
117 iban => 'DE12500105170648489890',
119 account_number => '648489890',
120 mandate_date_of_signature => $transdate1,
121 mandator_id => 'foobar',
123 bank_code => 'G1235',
124 depositor => 'Test Customer',
125 customernumber => 'CUST1704',
128 $payment_terms = SL::Dev::Payment::create_payment_terms;
130 $vendor = SL::Dev::CustomerVendor::create_vendor(
131 name => 'Test Vendor',
132 payment_id => $payment_terms->id,
133 iban => 'DE12500105170648489890',
135 account_number => '648489890',
137 bank_code => 'G1235',
138 depositor => 'Test Vendor',
139 vendornumber => 'VEND1704',
142 $ar_chart = SL::DB::Manager::Chart->find_by( accno => '1400' ); # Forderungen
143 $ap_chart = SL::DB::Manager::Chart->find_by( accno => '1600' ); # Verbindlichkeiten
144 $bank = SL::DB::Manager::Chart->find_by( accno => '1200' ); # Bank
145 $ar_amount_chart = SL::DB::Manager::Chart->find_by( accno => '8400' ); # Erlöse
146 $ap_amount_chart = SL::DB::Manager::Chart->find_by( accno => '3400' ); # Wareneingang 19%
150 sub test_ar_transaction {
153 my $amount = $params{amount} || $::form->round_amount(100 * 1.19,2);
154 my $invoice = SL::DB::Invoice->new(
156 invnumber => $params{invnumber} || undef, # let it use its own invnumber
158 netamount => $netamount,
159 transdate => $transdate1,
161 customer_id => $customer->id,
162 taxzone_id => $customer->taxzone_id,
163 currency_id => $currency_id,
165 payment_id => $params{payment_id} || undef,
166 notes => 'test_ar_transaction',
168 $invoice->add_ar_amount_row(
169 amount => $invoice->netamount,
170 chart => $ar_amount_chart,
174 $invoice->create_ar_row(chart => $ar_chart);
177 is($invoice->currency_id , $currency_id , 'currency_id has been saved');
178 is($invoice->netamount , 100 , 'ar amount has been converted');
179 is($invoice->amount , 119 , 'ar amount has been converted');
180 is($invoice->taxincluded , 0 , 'ar transaction doesn\'t have taxincluded');
182 is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ar_amount_chart->id , trans_id => $invoice->id)->amount , '100.00000' , $ar_amount_chart->accno . ': has been converted for currency');
183 is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ar_chart->id , trans_id => $invoice->id)->amount , '-119.00000' , $ar_chart->accno . ': has been converted for currency');
188 sub test_ap_transaction {
190 my $testname = 'test_ap_transaction';
193 my $amount = $::form->round_amount($netamount * 1.19,2);
194 my $invoice = SL::DB::PurchaseInvoice->new(
196 invnumber => $params{invnumber} || $testname,
198 netamount => $netamount,
199 transdate => $transdate1,
201 vendor_id => $vendor->id,
202 taxzone_id => $vendor->taxzone_id,
203 currency_id => $currency_id,
205 notes => 'test_ap_transaction',
207 $invoice->add_ap_amount_row(
208 amount => $invoice->netamount,
209 chart => $ap_amount_chart,
210 tax_id => $tax_9->id,
213 $invoice->create_ap_row(chart => $ap_chart);
216 is($invoice->currency_id , $currency_id , "$testname: currency_id has been saved");
217 is($invoice->netamount , 100 , "$testname: ap amount has been converted");
218 is($invoice->amount , 119 , "$testname: ap amount has been converted");
219 is($invoice->taxincluded , 0 , "$testname: ap transaction doesn\'t have taxincluded");
221 is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ap_amount_chart->id , trans_id => $invoice->id)->amount , '-100.00000' , $ap_amount_chart->accno . ': has been converted for currency');
222 is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ap_chart->id , trans_id => $invoice->id)->amount , '119.00000' , $ap_chart->accno . ': has been converted for currency');
231 my $testname = 'test1';
233 $ar_transaction = test_ar_transaction(invnumber => 'salesinv1');
235 my $bt = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction) or die "Couldn't create bank_transaction";
237 $::form->{invoice_ids} = {
238 $bt->id => [ $ar_transaction->id ]
241 save_btcontroller_to_string();
243 $ar_transaction->load;
245 is($ar_transaction->paid , '119.00000' , "$testname: salesinv1 was paid");
246 is($ar_transaction->closed , 1 , "$testname: salesinv1 is closed");
247 is($bt->invoice_amount , '119.00000' , "$testname: bt invoice amount was assigned");
251 sub test_skonto_exact {
253 my $testname = 'test_skonto_exact';
255 $ar_transaction = test_ar_transaction(invnumber => 'salesinv skonto',
256 payment_id => $payment_terms->id,
259 my $bt = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction,
260 bank_chart_id => $bank->id,
261 amount => $ar_transaction->amount_less_skonto
262 ) or die "Couldn't create bank_transaction";
264 $::form->{invoice_ids} = {
265 $bt->id => [ $ar_transaction->id ]
267 $::form->{invoice_skontos} = {
268 $bt->id => [ 'with_skonto_pt' ]
271 save_btcontroller_to_string();
273 $ar_transaction->load;
275 is($ar_transaction->paid , '119.00000' , "$testname: salesinv skonto was paid");
276 is($ar_transaction->closed , 1 , "$testname: salesinv skonto is closed");
277 is($bt->invoice_amount , '113.05000' , "$testname: bt invoice amount was assigned");
281 sub test_two_invoices {
283 my $testname = 'test_two_invoices';
285 my $ar_transaction_1 = test_ar_transaction(invnumber => 'salesinv_1');
286 my $ar_transaction_2 = test_ar_transaction(invnumber => 'salesinv_2');
288 my $bt = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction_1,
289 amount => ($ar_transaction_1->amount + $ar_transaction_2->amount),
290 purpose => "Rechnungen " . $ar_transaction_1->invnumber . " und " . $ar_transaction_2->invnumber,
291 bank_chart_id => $bank->id,
292 ) or die "Couldn't create bank_transaction";
294 my ($agreement, $rule_matches) = $bt->get_agreement_with_invoice($ar_transaction_1);
295 is($agreement, 16, "points for ar_transaction_1 in test_two_invoices ok");
297 $::form->{invoice_ids} = {
298 $bt->id => [ $ar_transaction_1->id, $ar_transaction_2->id ]
301 save_btcontroller_to_string();
303 $ar_transaction_1->load;
304 $ar_transaction_2->load;
307 is($ar_transaction_1->paid , '119.00000' , "$testname: salesinv_1 was paid");
308 is($ar_transaction_1->closed , 1 , "$testname: salesinv_1 is closed");
309 is($ar_transaction_2->paid , '119.00000' , "$testname: salesinv_2 was paid");
310 is($ar_transaction_2->closed , 1 , "$testname: salesinv_2 is closed");
311 is($bt->invoice_amount , '238.00000' , "$testname: bt invoice amount was assigned");
315 sub test_overpayment {
317 my $testname = 'test_overpayment';
319 $ar_transaction = test_ar_transaction(invnumber => 'salesinv overpaid');
322 my $bt = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction,
323 bank_chart_id => $bank->id,
325 ) or die "Couldn't create bank_transaction";
327 $::form->{invoice_ids} = {
328 $bt->id => [ $ar_transaction->id ]
331 save_btcontroller_to_string();
333 $ar_transaction->load;
336 is($ar_transaction->paid , '135.00000' , "$testname: 'salesinv overpaid' was overpaid");
337 is($bt->invoice_amount , '135.00000' , "$testname: bt invoice amount was assigned overpaid amount");
338 { local $TODO = 'this currently fails because closed ignores over-payments, see commit d90966c7';
339 is($ar_transaction->closed , 0 , "$testname: 'salesinv overpaid' is open (via 'closed' method')");
341 is($ar_transaction->open_amount == 0 ? 1 : 0 , 0 , "$testname: 'salesinv overpaid is open (via amount-paid)");
345 sub test_overpayment_with_partialpayment {
347 # two payments on different days, 10 and 119. If there is only one invoice we want it be overpaid.
348 my $testname = 'test_overpayment_with_partialpayment';
350 $ar_transaction = test_ar_transaction(invnumber => 'salesinv overpaid partial');
352 my $bt_1 = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction,
353 bank_chart_id => $bank->id,
355 ) or die "Couldn't create bank_transaction";
356 my $bt_2 = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction,
358 transdate => DateTime->today->add(days => 5),
359 bank_chart_id => $bank->id,
360 ) or die "Couldn't create bank_transaction";
362 $::form->{invoice_ids} = {
363 $bt_1->id => [ $ar_transaction->id ]
365 save_btcontroller_to_string();
367 $::form->{invoice_ids} = {
368 $bt_2->id => [ $ar_transaction->id ]
370 save_btcontroller_to_string();
372 $ar_transaction->load;
376 is($ar_transaction->paid , '129.00000' , "$testname: 'salesinv overpaid partial' was overpaid");
377 is($bt_1->invoice_amount , '10.00000' , "$testname: bt_1 invoice amount was assigned overpaid amount");
378 is($bt_2->invoice_amount , '119.00000' , "$testname: bt_2 invoice amount was assigned overpaid amount");
382 sub test_partial_payment {
384 my $testname = 'test_partial_payment';
386 $ar_transaction = test_ar_transaction(invnumber => 'salesinv partial payment');
389 my $bt = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction,
390 bank_chart_id => $bank->id,
392 ) or die "Couldn't create bank_transaction";
394 $::form->{invoice_ids} = {
395 $bt->id => [ $ar_transaction->id ]
398 save_btcontroller_to_string();
400 $ar_transaction->load;
403 is($ar_transaction->paid , '100.00000' , "$testname: 'salesinv partial payment' was partially paid");
404 is($bt->invoice_amount , '100.00000' , "$testname: bt invoice amount was assigned partially paid amount");
408 sub test_credit_note {
410 my $testname = 'test_credit_note';
412 my $part1 = SL::Dev::Part::create_part( partnumber => 'T4254')->save;
413 my $part2 = SL::Dev::Part::create_service(partnumber => 'Serv1')->save;
414 my $credit_note = SL::Dev::Record::create_credit_note(
416 customer => $customer,
418 invoiceitems => [ SL::Dev::Record::create_invoice_item(part => $part1, qty => 3, sellprice => 70),
419 SL::Dev::Record::create_invoice_item(part => $part2, qty => 10, sellprice => 50),
422 my $bt = SL::Dev::Payment::create_bank_transaction(record => $credit_note,
423 amount => $credit_note->amount,
424 bank_chart_id => $bank->id,
425 transdate => DateTime->today->add(days => 10),
427 my ($agreement, $rule_matches) = $bt->get_agreement_with_invoice($credit_note);
428 is($agreement, 13, "points for credit note ok");
429 is($rule_matches, 'remote_account_number(3) exact_amount(4) wrong_sign(-1) depositor_matches(2) remote_name(2) payment_within_30_days(1) datebonus14(2) ', "rules_matches for credit note ok");
431 $::form->{invoice_ids} = {
432 $bt->id => [ $credit_note->id ]
435 save_btcontroller_to_string();
439 is($credit_note->amount , '-844.90000', "$testname: amount ok");
440 is($credit_note->netamount, '-710.00000', "$testname: netamount ok");
441 is($credit_note->paid , '-844.90000', "$testname: paid ok");
444 sub test_neg_ap_transaction {
446 my $testname = 'test_neg_ap_transaction';
448 my $amount = $::form->round_amount($netamount * 1.19,2);
449 my $invoice = SL::DB::PurchaseInvoice->new(
451 invnumber => $params{invnumber} || 'test_neg_ap_transaction',
453 netamount => $netamount,
454 transdate => $transdate1,
456 vendor_id => $vendor->id,
457 taxzone_id => $vendor->taxzone_id,
458 currency_id => $currency_id,
460 notes => 'test_neg_ap_transaction',
462 $invoice->add_ap_amount_row(
463 amount => $invoice->netamount,
464 chart => $ap_amount_chart,
465 tax_id => $tax_9->id,
468 $invoice->create_ap_row(chart => $ap_chart);
471 is($invoice->netamount, -20 , "$testname: netamount ok");
472 is($invoice->amount , -23.8, "$testname: amount ok");
474 my $bt = SL::Dev::Payment::create_bank_transaction(record => $invoice,
475 amount => $invoice->amount,
476 bank_chart_id => $bank->id,
477 transdate => DateTime->today->add(days => 10),
479 my ($agreement, $rule_matches) = $bt->get_agreement_with_invoice($invoice);
480 is($agreement, 15, "points for negative ap transaction ok");
482 $::form->{invoice_ids} = {
483 $bt->id => [ $invoice->id ]
486 save_btcontroller_to_string();
491 is($invoice->amount , '-23.80000', "$testname: amount ok");
492 is($invoice->netamount, '-20.00000', "$testname: netamount ok");
493 is($invoice->paid , '-23.80000', "$testname: paid ok");
494 is($bt->invoice_amount, '23.80000', "$testname: bt invoice amount for ap was assigned");
499 sub test_ap_payment_transaction {
501 my $testname = 'test_ap_payment_transaction';
503 my $amount = $::form->round_amount($netamount * 1.19,2);
504 my $invoice = SL::DB::PurchaseInvoice->new(
506 invnumber => $params{invnumber} || $testname,
508 netamount => $netamount,
509 transdate => $transdate1,
511 vendor_id => $vendor->id,
512 taxzone_id => $vendor->taxzone_id,
513 currency_id => $currency_id,
517 $invoice->add_ap_amount_row(
518 amount => $invoice->netamount,
519 chart => $ap_amount_chart,
520 tax_id => $tax_9->id,
523 $invoice->create_ap_row(chart => $ap_chart);
526 is($invoice->netamount, 115 , "$testname: netamount ok");
527 is($invoice->amount , 136.85, "$testname: amount ok");
529 my $bt = SL::Dev::Payment::create_bank_transaction(record => $invoice,
530 amount => $invoice->amount,
531 bank_chart_id => $bank->id,
532 transdate => DateTime->today->add(days => 10),
534 $::form->{invoice_ids} = {
535 $bt->id => [ $invoice->id ]
538 save_btcontroller_to_string();
543 is($invoice->amount , '136.85000', "$testname: amount ok");
544 is($invoice->netamount, '115.00000', "$testname: netamount ok");
545 is($bt->amount, '-136.85000', "$testname: bt amount ok");
546 is($invoice->paid , '136.85000', "$testname: paid ok");
547 is($bt->invoice_amount, '-136.85000', "$testname: bt invoice amount for ap was assigned");
552 sub test_ap_payment_part_transaction {
554 my $testname = 'test_ap_payment_p_transaction';
556 my $amount = $::form->round_amount($netamount * 1.19,2);
557 my $invoice = SL::DB::PurchaseInvoice->new(
559 invnumber => $params{invnumber} || $testname,
561 netamount => $netamount,
562 transdate => $transdate1,
564 vendor_id => $vendor->id,
565 taxzone_id => $vendor->taxzone_id,
566 currency_id => $currency_id,
570 $invoice->add_ap_amount_row(
571 amount => $invoice->netamount,
572 chart => $ap_amount_chart,
573 tax_id => $tax_9->id,
576 $invoice->create_ap_row(chart => $ap_chart);
579 is($invoice->netamount, 115 , "$testname: netamount ok");
580 is($invoice->amount , 136.85, "$testname: amount ok");
582 my $bt = SL::Dev::Payment::create_bank_transaction(record => $invoice,
583 amount => $invoice->amount-100,
584 bank_chart_id => $bank->id,
585 transdate => DateTime->today->add(days => 10),
587 $::form->{invoice_ids} = {
588 $bt->id => [ $invoice->id ]
591 save_btcontroller_to_string();
596 is($invoice->amount , '136.85000', "$testname: amount ok");
597 is($invoice->netamount, '115.00000', "$testname: netamount ok");
598 is($bt->amount, '-36.85000', "$testname: bt amount ok");
599 is($invoice->paid , '36.85000', "$testname: paid ok");
600 is($bt->invoice_amount, '-36.85000', "$testname: bt invoice amount for ap was assigned");
602 my $bt2 = SL::Dev::Payment::create_bank_transaction(record => $invoice,
604 bank_chart_id => $bank->id,
605 transdate => DateTime->today->add(days => 10),
607 $::form->{invoice_ids} = {
608 $bt2->id => [ $invoice->id ]
611 save_btcontroller_to_string();
615 is($invoice->amount , '136.85000', "$testname: amount ok");
616 is($invoice->netamount, '115.00000', "$testname: netamount ok");
617 is($bt2->amount, '-100.00000',"$testname: bt amount ok");
618 is($invoice->paid , '136.85000', "$testname: paid ok");
619 is($bt2->invoice_amount,'-100.00000', "$testname: bt invoice amount for ap was assigned");
624 sub test_neg_sales_invoice {
626 my $testname = 'test_neg_sales_invoice';
628 my $part1 = SL::Dev::Part::create_part( partnumber => 'Funkenhaube öhm')->save;
629 my $part2 = SL::Dev::Part::create_service(partnumber => 'Service-Pauschale Pasch!')->save;
631 my $neg_sales_inv = SL::Dev::Record::create_sales_invoice(
632 invnumber => '20172201',
633 customer => $customer,
635 invoiceitems => [ SL::Dev::Record::create_invoice_item(part => $part1, qty => 3, sellprice => 70),
636 SL::Dev::Record::create_invoice_item(part => $part2, qty => 10, sellprice => -50),
639 my $bt = SL::Dev::Payment::create_bank_transaction(record => $neg_sales_inv,
640 amount => $neg_sales_inv->amount,
641 bank_chart_id => $bank->id,
642 transdate => DateTime->today,
644 $::form->{invoice_ids} = {
645 $bt->id => [ $neg_sales_inv->id ]
648 save_btcontroller_to_string();
650 $neg_sales_inv->load;
652 is($neg_sales_inv->amount , '-345.10000', "$testname: amount ok");
653 is($neg_sales_inv->netamount, '-290.00000', "$testname: netamount ok");
654 is($neg_sales_inv->paid , '-345.10000', "$testname: paid ok");
655 is($bt->amount , '-345.10000', "$testname: bt amount ok");
656 is($bt->invoice_amount , '-345.10000', "$testname: bt invoice_amount ok");