t/bank/bank_transactions.t

   1 use Test::More;
   2
   3 use strict;
   4
   5 use lib 't';
   6 use utf8;
   7
   8 use Carp;
   9 use Support::TestSetup;
  10 use Test::Exception;
  11 use List::Util qw(sum);
  12
  13 use SL::DB::Buchungsgruppe;
  14 use SL::DB::Currency;
  15 use SL::DB::Customer;
  16 use SL::DB::Vendor;
  17 use SL::DB::Invoice;
  18 use SL::DB::Unit;
  19 use SL::DB::TaxZone;
  20 use SL::DB::BankAccount;
  21 use SL::DB::PaymentTerm;
  22 use SL::DB::PurchaseInvoice;
  23 use SL::DB::BankTransaction;
  24 use SL::Controller::BankTransaction;
  25 use SL::Dev::ALL;
  26 use Data::Dumper;
  27
  28 my ($customer, $vendor, $currency_id, $unit, $tax, $tax7, $tax_9, $payment_terms, $bank_account);
  29 my ($transdate1, $transdate2, $currency);
  30 my ($ar_chart,$bank,$ar_amount_chart, $ap_chart, $ap_amount_chart);
  31 my ($ar_transaction, $ap_transaction);
  32
  33 sub clear_up {
  34
  35   SL::DB::Manager::BankTransaction->delete_all(all => 1);
  36   SL::DB::Manager::InvoiceItem->delete_all(all => 1);
  37   SL::DB::Manager::InvoiceItem->delete_all(all => 1);
  38   SL::DB::Manager::Invoice->delete_all(all => 1);
  39   SL::DB::Manager::PurchaseInvoice->delete_all(all => 1);
  40   SL::DB::Manager::Customer->delete_all(all => 1);
  41   SL::DB::Manager::Vendor->delete_all(all => 1);
  42   SL::DB::Manager::BankAccount->delete_all(all => 1);
  43   SL::DB::Manager::PaymentTerm->delete_all(all => 1);
  44   SL::DB::Manager::Currency->delete_all(where => [ name => 'CUR' ]);
  45 };
  46
  47
  48 # starting test:
  49 Support::TestSetup::login();
  50
  51 reset_state(); # initialise customers/vendors/bank/currency/...
  52
  53 test1();
  54 test_overpayment_with_partialpayment();
  55 test_overpayment();
  56 test_skonto_exact();
  57 test_two_invoices();
  58 test_partial_payment();
  59
  60 # remove all created data at end of test
  61 clear_up();
  62
  63 done_testing();
  64
  65 ###### functions for setting up data
  66
  67 sub reset_state {
  68   my %params = @_;
  69
  70   $params{$_} ||= {} for qw(unit customer tax vendor);
  71
  72   clear_up();
  73
  74   $transdate1 = DateTime->today;
  75   $transdate2 = DateTime->today->add(days => 5);
  76
  77   $tax             = SL::DB::Manager::Tax->find_by(taxkey => 3, rate => 0.19, %{ $params{tax} }) || croak "No tax";
  78   $tax7            = SL::DB::Manager::Tax->find_by(taxkey => 2, rate => 0.07)                    || croak "No tax for 7\%";
  79   $tax_9           = SL::DB::Manager::Tax->find_by(taxkey => 9, rate => 0.19, %{ $params{tax} }) || croak "No tax";
  80
  81   $currency_id     = $::instance_conf->get_currency_id;
  82
  83   $bank_account     =  SL::DB::BankAccount->new(
  84     account_number  => '123',
  85     bank_code       => '123',
  86     iban            => '123',
  87     bic             => '123',
  88     bank            => '123',
  89     chart_id        => SL::DB::Manager::Chart->find_by(description => 'Bank')->id,
  90     name            => SL::DB::Manager::Chart->find_by(description => 'Bank')->description,
  91   )->save;
  92
  93   $customer = SL::Dev::CustomerVendor::create_customer(
  94     name                      => 'Test Customer',
  95     iban                      => 'DE12500105170648489890',
  96     bic                       => 'TESTBIC',
  97     account_number            => '648489890',
  98     mandate_date_of_signature => $transdate1,
  99     mandator_id               => 'foobar',
 100     bank                      => 'Geizkasse',
 101     bank_code                 => 'G1235',
 102     depositor                 => 'Test Customer',
 103   )->save;
 104
 105   $payment_terms = SL::Dev::Payment::create_payment_terms;
 106
 107   $vendor = SL::Dev::CustomerVendor::create_vendor(
 108     name           => 'Test Vendor',
 109     payment_id     => $payment_terms->id,
 110     iban           => 'DE12500105170648489890',
 111     bic            => 'TESTBIC',
 112     account_number => '648489890',
 113     bank           => 'Geizkasse',
 114     bank_code      => 'G1235',
 115     depositor      => 'Test Vendor',
 116   )->save;
 117
 118   $ar_chart        = SL::DB::Manager::Chart->find_by( accno => '1400' ); # Forderungen
 119   $ap_chart        = SL::DB::Manager::Chart->find_by( accno => '1600' ); # Verbindlichkeiten
 120   $bank            = SL::DB::Manager::Chart->find_by( accno => '1200' ); # Bank
 121   $ar_amount_chart = SL::DB::Manager::Chart->find_by( accno => '8400' ); # Erlöse
 122   $ap_amount_chart = SL::DB::Manager::Chart->find_by( accno => '3400' ); # Wareneingang 19%
 123
 124 }
 125
 126 sub test_ar_transaction {
 127   my (%params) = @_;
 128   my $netamount = 100;
 129   my $amount    = $params{amount} || $::form->round_amount(100 * 1.19,2);
 130   my $invoice   = SL::DB::Invoice->new(
 131       invoice      => 0,
 132       invnumber    => $params{invnumber} || undef, # let it use its own invnumber
 133       amount       => $amount,
 134       netamount    => $netamount,
 135       transdate    => $transdate1,
 136       taxincluded  => 0,
 137       customer_id  => $customer->id,
 138       taxzone_id   => $customer->taxzone_id,
 139       currency_id  => $currency_id,
 140       transactions => [],
 141       payment_id   => $params{payment_id} || undef,
 142       notes        => 'test_ar_transaction',
 143   );
 144   $invoice->add_ar_amount_row(
 145     amount => $invoice->netamount,
 146     chart  => $ar_amount_chart,
 147     tax_id => $tax->id,
 148   );
 149
 150   $invoice->create_ar_row(chart => $ar_chart);
 151   $invoice->save;
 152
 153   is($invoice->currency_id , $currency_id , 'currency_id has been saved');
 154   is($invoice->netamount   , 100          , 'ar amount has been converted');
 155   is($invoice->amount      , 119          , 'ar amount has been converted');
 156   is($invoice->taxincluded , 0            , 'ar transaction doesn\'t have taxincluded');
 157
 158   is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ar_amount_chart->id , trans_id => $invoice->id)->amount , '100.00000'  , $ar_amount_chart->accno . ': has been converted for currency');
 159   is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ar_chart->id        , trans_id => $invoice->id)->amount , '-119.00000' , $ar_chart->accno . ': has been converted for currency');
 160
 161   return $invoice;
 162 };
 163
 164 sub test_ap_transaction {
 165   my (%params) = @_;
 166   my $netamount = 100;
 167   my $amount    = $::form->round_amount($netamount * 1.19,2);
 168   my $invoice   = SL::DB::PurchaseInvoice->new(
 169       invoice      => 0,
 170       invnumber    => $params{invnumber} || 'test_ap_transaction',
 171       amount       => $amount,
 172       netamount    => $netamount,
 173       transdate    => $transdate1,
 174       taxincluded  => 0,
 175       vendor_id    => $vendor->id,
 176       taxzone_id   => $vendor->taxzone_id,
 177       currency_id  => $currency_id,
 178       transactions => [],
 179       notes        => 'test_ap_transaction',
 180   );
 181   $invoice->add_ap_amount_row(
 182     amount     => $invoice->netamount,
 183     chart      => $ap_amount_chart,
 184     tax_id     => $tax_9->id,
 185   );
 186
 187   $invoice->create_ap_row(chart => $ap_chart);
 188   $invoice->save;
 189
 190   is($invoice->currency_id , $currency_id , 'currency_id has been saved');
 191   is($invoice->netamount   , 100          , 'ap amount has been converted');
 192   is($invoice->amount      , 119          , 'ap amount has been converted');
 193   is($invoice->taxincluded , 0            , 'ap transaction doesn\'t have taxincluded');
 194
 195   is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ap_amount_chart->id , trans_id => $invoice->id)->amount , '-100.00000' , $ap_amount_chart->accno . ': has been converted for currency');
 196   is(SL::DB::Manager::AccTransaction->find_by(chart_id => $ap_chart->id        , trans_id => $invoice->id)->amount , '119.00000'  , $ap_chart->accno . ': has been converted for currency');
 197
 198   return $invoice;
 199 };
 200
 201 ###### test cases
 202
 203 sub test1 {
 204
 205   my $testname = 'test1';
 206
 207   $ar_transaction = test_ar_transaction(invnumber => 'salesinv1');
 208
 209   my $bt = SL::Dev::Payment::create_bank_transaction(record => $ar_transaction) or die "Couldn't create bank_transaction";
 210
 211   $::form->{invoice_ids} = {
 212           $bt->id => [ $ar_transaction->id ]
 213         };
 214
 215   my $bt_controller = SL::Controller::BankTransaction->new;
 216   $bt_controller->action_save_invoices;
 217
 218   $ar_transaction->load;
 219   $bt->load;
 220   is($ar_transaction->paid   , '119.00000' , "$testname: salesinv1 was paid");
 221   is($ar_transaction->closed , 1           , "$testname: salesinv1 is closed");
 222   is($bt->invoice_amount     , '119.00000' , "$testname: bt invoice amount was assigned");
 223
 224 };
 225
 226 sub test_skonto_exact {
 227
 228   my $testname = 'test_skonto_exact';
 229
 230   $ar_transaction = test_ar_transaction(invnumber => 'salesinv skonto',
 231                                         payment_id => $payment_terms->id,
 232                                        );
 233
 234   my $bt = SL::Dev::Payment::create_bank_transaction(record        => $ar_transaction,
 235                                                      bank_chart_id => $bank->id,
 236                                                      amount        => $ar_transaction->amount_less_skonto
 237                                                     ) or die "Couldn't create bank_transaction";
 238
 239   $::form->{invoice_ids} = {
 240           $bt->id => [ $ar_transaction->id ]
 241         };
 242   $::form->{invoice_skontos} = {
 243           $bt->id => [ 'with_skonto_pt' ]
 244         };
 245
 246   my $bt_controller = SL::Controller::BankTransaction->new;
 247   $bt_controller->action_save_invoices;
 248
 249   $ar_transaction->load;
 250   $bt->load;
 251   is($ar_transaction->paid   , '119.00000' , "$testname: salesinv skonto was paid");
 252   is($ar_transaction->closed , 1           , "$testname: salesinv skonto is closed");
 253   is($bt->invoice_amount     , '113.05000' , "$testname: bt invoice amount was assigned");
 254
 255 };
 256
 257 sub test_two_invoices {
 258
 259   my $testname = 'test_two_invoices';
 260
 261   my $ar_transaction_1 = test_ar_transaction(invnumber => 'salesinv_1');
 262   my $ar_transaction_2 = test_ar_transaction(invnumber => 'salesinv_2');
 263
 264   my $bt = SL::Dev::Payment::create_bank_transaction(record        => $ar_transaction_1,
 265                                                      amount        => ($ar_transaction_1->amount + $ar_transaction_2->amount),
 266                                                      purpose       => "Rechnungen " . $ar_transaction_1->invnumber . " und " . $ar_transaction_2->invnumber,
 267                                                      bank_chart_id => $bank->id,
 268                                                     ) or die "Couldn't create bank_transaction";
 269
 270   $::form->{invoice_ids} = {
 271           $bt->id => [ $ar_transaction_1->id, $ar_transaction_2->id ]
 272         };
 273
 274   my $bt_controller = SL::Controller::BankTransaction->new;
 275   $bt_controller->action_save_invoices;
 276
 277   $ar_transaction_1->load;
 278   $ar_transaction_2->load;
 279   $bt->load;
 280
 281   is($ar_transaction_1->paid   , '119.00000' , "$testname: salesinv_1 was paid");
 282   is($ar_transaction_1->closed , 1           , "$testname: salesinv_1 is closed");
 283   is($ar_transaction_2->paid   , '119.00000' , "$testname: salesinv_2 was paid");
 284   is($ar_transaction_2->closed , 1           , "$testname: salesinv_2 is closed");
 285   is($bt->invoice_amount       , '238.00000' , "$testname: bt invoice amount was assigned");
 286
 287 };
 288
 289 sub test_overpayment {
 290
 291   my $testname = 'test_overpayment';
 292
 293   $ar_transaction = test_ar_transaction(invnumber => 'salesinv overpaid');
 294
 295   # amount 135 > 119
 296   my $bt = SL::Dev::Payment::create_bank_transaction(record        => $ar_transaction,
 297                                                      bank_chart_id => $bank->id,
 298                                                      amount        => 135
 299                                                     ) or die "Couldn't create bank_transaction";
 300
 301   $::form->{invoice_ids} = {
 302           $bt->id => [ $ar_transaction->id ]
 303         };
 304
 305   my $bt_controller = SL::Controller::BankTransaction->new;
 306   $bt_controller->action_save_invoices;
 307
 308   $ar_transaction->load;
 309   $bt->load;
 310
 311   is($ar_transaction->paid                     , '135.00000' , "$testname: 'salesinv overpaid' was overpaid");
 312   is($bt->invoice_amount                       , '135.00000' , "$testname: bt invoice amount was assigned overpaid amount");
 313 { local $TODO = 'this currently fails because closed ignores over-payments, see commit d90966c7';
 314   is($ar_transaction->closed                   , 0           , "$testname: 'salesinv overpaid' is open (via 'closed' method')");
 315 }
 316   is($ar_transaction->open_amount == 0 ? 1 : 0 , 0           , "$testname: 'salesinv overpaid is open (via amount-paid)");
 317
 318 };
 319
 320 sub test_overpayment_with_partialpayment {
 321
 322   # two payments on different days, 10 and 119. If there is only one invoice we want it be overpaid.
 323   my $testname = 'test_overpayment_with_partialpayment';
 324
 325   $ar_transaction = test_ar_transaction(invnumber => 'salesinv overpaid partial');
 326
 327   my $bt_1 = SL::Dev::Payment::create_bank_transaction(record        => $ar_transaction,
 328                                                        bank_chart_id => $bank->id,
 329                                                        amount        =>  10
 330                                                       ) or die "Couldn't create bank_transaction";
 331   my $bt_2 = SL::Dev::Payment::create_bank_transaction(record        => $ar_transaction,
 332                                                        amount        => 119,
 333                                                        transdate     => DateTime->today->add(days => 5),
 334                                                        bank_chart_id => $bank->id,
 335                                                       ) or die "Couldn't create bank_transaction";
 336
 337   $::form->{invoice_ids} = {
 338           $bt_1->id => [ $ar_transaction->id ]
 339         };
 340   my $bt_controller_1 = SL::Controller::BankTransaction->new;
 341   $bt_controller_1->action_save_invoices;
 342
 343   $::form->{invoice_ids} = {
 344           $bt_2->id => [ $ar_transaction->id ]
 345         };
 346   my $bt_controller_2 = SL::Controller::BankTransaction->new;
 347   $bt_controller_2->action_save_invoices;
 348
 349   $ar_transaction->load;
 350   $bt_1->load;
 351   $bt_2->load;
 352
 353   is($ar_transaction->paid , '129.00000' , "$testname: 'salesinv overpaid partial' was overpaid");
 354   is($bt_1->invoice_amount ,  '10.00000' , "$testname: bt_1 invoice amount was assigned overpaid amount");
 355   is($bt_2->invoice_amount , '119.00000' , "$testname: bt_2 invoice amount was assigned overpaid amount");
 356
 357 };
 358
 359 sub test_partial_payment {
 360
 361   my $testname = 'test_partial_payment';
 362
 363   $ar_transaction = test_ar_transaction(invnumber => 'salesinv partial payment');
 364
 365   # amount 100 < 119
 366   my $bt = SL::Dev::Payment::create_bank_transaction(record        => $ar_transaction,
 367                                                      bank_chart_id => $bank->id,
 368                                                      amount        => 100
 369                                                     ) or die "Couldn't create bank_transaction";
 370
 371   $::form->{invoice_ids} = {
 372           $bt->id => [ $ar_transaction->id ]
 373         };
 374
 375   my $bt_controller = SL::Controller::BankTransaction->new;
 376   $bt_controller->action_save_invoices;
 377
 378   $ar_transaction->load;
 379   $bt->load;
 380
 381   is($ar_transaction->paid , '100.00000' , "$testname: 'salesinv partial payment' was partially paid");
 382   is($bt->invoice_amount   , '100.00000' , "$testname: bt invoice amount was assigned partially paid amount");
 383
 384 };
 385
 386 1;