WHERE chart_id = ?|;
do_query($form, $dbh, $query, $form->{id});
- # delete chart of account record
- $query = qq|DELETE FROM chart
- WHERE id = ?|;
- do_query($form, $dbh, $query, $form->{id});
-
# delete account taxkeys
$query = qq|DELETE FROM taxkeys
WHERE chart_id = ?|;
do_query($form, $dbh, $query, $form->{id});
+ # delete chart of account record
+ # last step delete chart, because we have a constraint
+ # to taxkeys
+ $query = qq|DELETE FROM chart
+ WHERE id = ?|;
+ do_query($form, $dbh, $query, $form->{id});
+
# commit and redirect
my $rc = $dbh->commit;
$dbh->disconnect;
my ($query, @values);
- if ($form->{revtrans}) {
- $query = qq|UPDATE defaults SET closedto = NULL, revtrans = '1'|;
+ # is currently NEVER trueish (no more hidden revtrans in $form)
+ # if ($form->{revtrans}) {
+ # $query = qq|UPDATE defaults SET closedto = NULL, revtrans = '1'|;
+ # -> therefore you can only set this to false (which is already the default)
+ # and this flag is currently only checked in gl.pl. TOOD Can probably be removed
- } elsif ($form->{closedto}) {
$query = qq|UPDATE defaults SET closedto = ?, max_future_booking_interval = ?, revtrans = '0'|;
- @values = (conv_date($form->{closedto}), conv_date($form->{max_future_booking_interval}));
-
- } else {
- $query = qq|UPDATE defaults SET closedto = NULL, revtrans = '0'|;
- }
+ @values = (conv_date($form->{closedto}), conv_i($form->{max_future_booking_interval}));
# set close in defaults
do_query($form, $dbh, $query, @values);