my $buysell = $form->{vc} eq 'customer' ? "buy" : "sell";
my $arap = $form->{arap} eq "ar" ? "ar" : "ap";
- my $curr_null = $form->{curreny} ? '' : ' OR a.curr IS NULL'; # fix: after sql-injection fix, curr is inserted as NULL, before that as ''
-
my $query =
qq|SELECT a.id, a.invnumber, a.transdate, a.amount, a.paid, a.curr | .
- qq|FROM $arap a | .
- qq|WHERE (a.${vc}_id = ?) AND (a.curr = ? $curr_null) AND NOT (a.amount = paid)| .
- qq|ORDER BY a.id|;
+ qq|FROM $arap a | .
+ qq|WHERE (a.${vc}_id = ?) AND (COALESCE(a.curr, '') = ?) AND NOT (a.amount = a.paid)| .
+ qq|ORDER BY a.id|;
my $sth = prepare_execute_query($form, $dbh, $query,
conv_i($form->{"${vc}_id"}),
- $form->{currency});
+ "$form->{currency}");
$form->{PR} = [];
while (my $ref = $sth->fetchrow_hashref("NAME_lc")) {
}
$sth->finish;
+
+ $query = <<SQL;
+ SELECT COUNT(*)
+ FROM $arap
+ WHERE (${vc}_id = ?)
+ AND (COALESCE(curr, '') <> ?)
+ AND (amount <> paid)
+SQL
+ ($form->{openinvoices_other_currencies}) = selectfirst_array_query($form, $dbh, $query, conv_i($form->{"${vc}_id"}), "$form->{currency}");
+
$dbh->disconnect;
$main::lxdebug->leave_sub();
qq|INSERT INTO acc_trans (trans_id, chart_id, transdate, amount, | .
qq| cleared, fx_transaction) | .
qq|VALUES (?, (SELECT id FROM chart WHERE accno = ?), ?, ?, ?, ?)|;
- @values = (conv_i($form->{"id_$i"}), $paymentaccno,
+ @values = (conv_i($form->{"id_$i"}), $paymentaccno,
conv_date($form->{datepaid}), ($amount * $ml * -1), '0',
'1');
do_query($form, $dbh, $query, @values);
# update AR/AP transaction
$query = qq|UPDATE $arap SET $paid, datepaid = ? WHERE id = ?|;
- @values = (conv_date($form->{datepaid}), conv_i($form->{"id_$i"}));
+ @values = (conv_date($form->{datepaid}), conv_i($form->{"id_$i"}));
do_query($form, $dbh, $query, @values);
# saving the history
$form->{id} = $form->{"id_$i"};
# Hier werden negativen Zahlungseingänge abgefangen
# Besser: in Oberfläche schon prüfen
# Zahlungsein- und ausgänge sind immer positiv
- $dbh->rollback;
+ $dbh->rollback;
$rc = 0;
}
if ($form->round_amount($paymentamount, 2) == 0) {