my $transfer_type = delete $params{transfer_type} // 'stock';
my $transfer_type = delete $params{transfer_type} // 'stock';
- my $transfer_type_obj = SL::DB::Manager::TransferType->find_by( direction => 'in', description => $transfer_type ) or die "Can't find transfer_type with direction in and descriptin " . $params{transfer_type};
+ my $transfer_type_obj = SL::DB::Manager::TransferType->find_by(
+ direction => 'in',
+ description => $transfer_type,
+ ) or die "Can't find transfer_type with direction in and description " . $params{transfer_type};
my $transfer_type = delete $params{transfer_type} // 'shipped';
my $transfer_type = delete $params{transfer_type} // 'shipped';
- my $transfer_type_obj = SL::DB::Manager::TransferType->find_by( direction => 'out', description => $transfer_type ) or die "Can't find transfer_type with direction in and descriptin " . $params{transfer_type};
+ my $transfer_type_obj = SL::DB::Manager::TransferType->find_by(
+ direction => 'out',
+ description => $transfer_type,
+ ) or die "Can't find transfer_type with direction in and description " . $params{transfer_type};
- die "first argument must be a sales delivery order Rose DB object" unless ref($sales_delivery_order) eq 'SL::DB::DeliveryOrder' and $sales_delivery_order->is_sales;
+ die "first argument must be a sales delivery order Rose DB object"
die "the delivery order has already been delivered" if $sales_delivery_order->delivered;
die "the delivery order has already been delivered" if $sales_delivery_order->delivered;
@@ -266,7+282,9 @@ sub transfer_sales_delivery_order {
sub transfer_purchase_delivery_order {
my ($purchase_delivery_order) = @_;
sub transfer_purchase_delivery_order {
my ($purchase_delivery_order) = @_;
- die "first argument must be a purchase delivery order Rose DB object" unless ref($purchase_delivery_order) eq 'SL::DB::DeliveryOrder' and not $purchase_delivery_order->is_sales;
+ die "first argument must be a purchase delivery order Rose DB object"