- // Special handling of the NULL $options['users'] field (this used to mean "all users").
- if (!$options['users']) {
- if ($user->can('view_reports') || $user->can('view_all_reports') || $user->isClient()) {
- if ($user->can('view_reports') || $user->can('view_all_reports')) {
- $max_rank = $user->rank-1;
- if ($user->can('view_all_reports')) $max_rank = 512;
- if ($user->can('view_own_reports'))
- $user_options = array('max_rank'=>$max_rank,'include_self'=>true);
- else
- $user_options = array('max_rank'=>$max_rank);
- $users = $user->getUsers($user_options); // Active and inactive users.
- } elseif ($user->isClient()) {
- $users = ttTeamHelper::getUsersForClient(); // Active and inactive users for clients.
- }
- foreach ($users as $single_user) {
- $user_ids[] = $single_user['id'];
- }
- $options['users'] = implode(',', $user_ids);
- }
- } else {
- // TODO: add checking the existing user list for potentially changed access rights for user.
- }
+ // Avoid complications with impersonated users, possibly from subgroups.
+ // Note: this may happen when cron.php is called by a browser who already impersonates.
+ // This is not supposed to happen in automatic cron job.
+ if ($user->behalf_id)
+ continue; // Skip processing on behalf situations entirely.
+
+ // TODO: write a new function ttFavReportHelper::adjustOptions that will use
+ // a $user object recycled above. Put user handling below into it.
+ // Also adjust remaining options for potentially changed user access rights and group properties.
+ // For example, tracking mode may have changed, but fav report options are still old...
+ // This needs to be fixed.
+ $options = ttFavReportHelper::adjustOptions($options);