projects
/
timetracker.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
A bit of ongoing cleanup after roles revamp.
[timetracker.git]
/
mobile
/
expense_delete.php
diff --git
a/mobile/expense_delete.php
b/mobile/expense_delete.php
index
48051b4
..
a6f0989
100644
(file)
--- a/
mobile/expense_delete.php
+++ b/
mobile/expense_delete.php
@@
-31,17
+31,23
@@
import('form.Form');
import('DateAndTime');
import('ttExpenseHelper');
import('DateAndTime');
import('ttExpenseHelper');
-// Access check.
-if (!
ttAccessAllowed('track_own_expenses') || !$user->isPluginEnabled('ex'
)) {
+// Access check
s
.
+if (!
(ttAccessAllowed('track_own_expenses') || ttAccessAllowed('track_expenses')
)) {
header('Location: access_denied.php');
exit();
}
header('Location: access_denied.php');
exit();
}
-
-$cl_id = $request->getParameter('id');
+if (!$user->isPluginEnabled('ex')) {
+ header('Location: feature_disabled.php');
+ exit();
+}
+$cl_id = (int)$request->getParameter('id');
+// Get the expense item we are deleting.
$expense_item = ttExpenseHelper::getItem($cl_id, $user->getActiveUser());
$expense_item = ttExpenseHelper::getItem($cl_id, $user->getActiveUser());
-
-// Prohibit deleting invoiced records.
-if ($expense_item['invoice_id']) die($i18n->get('error.sys'));
+if (!$expense_item || $expense_item['invoice_id']) {
+ // Prohibit deleting not ours or invoiced items.
+ header('Location: access_denied.php');
+ exit();
+}
if ($request->isPost()) {
if ($request->getParameter('delete_button')) { // Delete button pressed.
if ($request->isPost()) {
if ($request->getParameter('delete_button')) { // Delete button pressed.