projects
/
timetracker.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
A bit of ongoing cleanup after roles revamp.
[timetracker.git]
/
mobile
/
time_delete.php
diff --git
a/mobile/time_delete.php
b/mobile/time_delete.php
index
33ba614
..
399895c
100644
(file)
--- a/
mobile/time_delete.php
+++ b/
mobile/time_delete.php
@@
-32,17
+32,19
@@
import('ttUserHelper');
import('ttTimeHelper');
import('DateAndTime');
import('ttTimeHelper');
import('DateAndTime');
-// Access check.
+// Access check
s
.
if (!ttAccessAllowed('track_own_time')) {
header('Location: access_denied.php');
exit();
}
if (!ttAccessAllowed('track_own_time')) {
header('Location: access_denied.php');
exit();
}
-
-$cl_id = $request->getParameter('id');
+$cl_id = (int)$request->getParameter('id');
$time_rec = ttTimeHelper::getRecord($cl_id, $user->getActiveUser());
$time_rec = ttTimeHelper::getRecord($cl_id, $user->getActiveUser());
-
-// Prohibit deleting invoiced records.
-if ($time_rec['invoice_id']) die($i18n->get('error.sys'));
+if (!$time_rec || $time_rec['invoice_id']) {
+ // Prohibit deleting not ours or invoiced records.
+ header('Location: access_denied.php');
+ exit();
+}
+// End of access checks.
// Escape comment for presentation.
$time_rec['comment'] = htmlspecialchars($time_rec['comment']);
// Escape comment for presentation.
$time_rec['comment'] = htmlspecialchars($time_rec['comment']);