$self->_setup;
- $self->tester->plan(tests => 24);
+ $self->tester->plan(tests => 26);
$self->check_konten_mit_saldo_nicht_in_guv;
$self->check_bilanzkonten_mit_pos_eur;
$self->check_ar_paid_acc_trans;
$self->check_ap_paid_acc_trans;
$self->check_zero_amount_paid_but_datepaid_exists;
+ $self->check_orphaned_reconciliated_links;
+ $self->check_recommended_client_settings;
}
sub _setup {
my ($self) = @_;
my $query = qq|
- select invnumber,paid,
+ select invnumber,paid,id,
(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as accpaid ,
paid-(select sum(amount) from acc_trans a left join chart c on (c.id = a.chart_id) where trans_id = ap.id and c.link like '%AP_paid%') as diff
from ap
$self->tester->ok(!$errors, "Vergleich ap paid mit acc_trans AP_paid");
for my $paid_diff_ap (@{ $paid_diffs_ap }) {
next if $paid_diff_ap->{diff} == 0;
- $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
+ $self->tester->diag("ap invnumber: $paid_diff_ap->{invnumber} : ID :: ID : $paid_diff_ap->{id} : paid: $paid_diff_ap->{paid} acc_paid= $paid_diff_ap->{accpaid} diff: $paid_diff_ap->{diff}");
}
}
my $query = qq|
select sum(ac.amount) as amount, ap.invnumber,ap.netamount
from acc_trans ac left join ap on (ac.trans_id = ap.id)
- WHERE ac.chart_link like '%AP_amount%'
+ WHERE ac.chart_link like '%AP_amount%' OR ac.chart_link like '%IC_cogs%'
AND ac.transdate >= ? AND ac.transdate <= ?
group by invnumber,trans_id,netamount having sum(ac.amount) <> ap.netamount*-1|;
}
}
+sub check_orphaned_reconciliated_links {
+ my ($self) = @_;
+
+ my $query = qq|
+ SELECT purpose from bank_transactions
+ WHERE cleared is true
+ AND id not in (SELECT bank_transaction_id from reconciliation_links)
+ AND transdate >= ? AND transdate <= ?|;
+
+ my $bt_cleared_no_link = selectall_hashref_query($::form, $self->dbh, $query, $self->fromdate, $self->todate);
+
+ if ( scalar @{ $bt_cleared_no_link } > 0 ) {
+ $self->tester->ok(0, "Verwaiste abgeglichene Bankbewegungen gefunden. Bei folgenden Bankbewegungen ist die abgleichende Verknüpfung gelöscht worden:");
+
+ for my $bt_orphaned (@{ $bt_cleared_no_link }) {
+ $self->tester->diag("Verwendungszweck: $bt_orphaned->{purpose}");
+ }
+ } else {
+ $self->tester->ok(1, "Keine verwaisten Einträge in abgeglichenen Bankbewegungen.");
+ }
+}
+
+sub check_recommended_client_settings {
+ my ($self) = @_;
+
+ my $all_ok = 1;
+
+ # expand: check datev && check mark_as_paid
+ my %settings_values_nok = (
+ SL::DB::Default->get->is_changeable => 1,
+ SL::DB::Default->get->ar_changeable => 1,
+ SL::DB::Default->get->ap_changeable => 1,
+ SL::DB::Default->get->ir_changeable => 1,
+ SL::DB::Default->get->gl_changeable => 1,
+ );
+
+ foreach (keys %settings_values_nok) {
+ if ($_ == $settings_values_nok{$_}) {
+ $self->tester->ok(0, "Buchungskonfiguration: Mindestens ein Belegtyp ist immer änderbar.");
+ undef $all_ok;
+ }
+ }
+
+ # payments more strict (avoid losing payments acc_trans_ids)
+ my $payments_ok = SL::DB::Default->get->payments_changeable == 0 ? 1 : 0;
+ $self->tester->ok(0, "Manuelle Zahlungen sind zu lange änderbar (Empfehlung: niemals).") unless $payments_ok;
+
+ $self->tester->ok(1, "Mandantenkonfiguration optimal eingestellt.") if ($payments_ok && $all_ok);
+}
1;
__END__