use SL::Helper::Flash;
use SL::Locale::String;
use SL::DB::TaxzoneChart;
-use SL::Controller::ClientConfig;
use SL::DB::Default;
use Rose::Object::MakeMethods::Generic (
my ($self, %params) = @_;
$self->render('buchungsgruppen/form', %params,
- TAXZONES => SL::DB::Manager::TaxZone->get_all_sorted(),
- ACCOUNTS => SL::Controller::ClientConfig->init_accounts(),
- account_label => sub { "$_[0]{accno}--$_[0]{description}" });
+ TAXZONES => SL::DB::Manager::TaxZone->get_all_sorted());
}
sub action_edit {
my ($self) = @_;
- # Allow editing of Buchungsgruppe if it isn't assigned to any parts. The
- # variable is checked in the template, which toggles between L.select_tag and
- # text.
-
- my $number_of_parts_with_buchungsgruppe = SL::DB::Manager::Part->get_objects_count(where => [ buchungsgruppen_id => $self->config->id]);
+ # Allow editing of the charts of the Buchungsgruppe if it isn't assigned to
+ # any parts. This is checked inside the template via the Buchungsgruppen
+ # orphaned method, where an IF-ELSE statement toggles between L.select_tag
+ # and text.
$self->show_form(title => t8('Edit Buchungsgruppe'),
- linked_parts => $number_of_parts_with_buchungsgruppe,
CHARTLIST => SL::DB::TaxzoneChart->get_all_accounts_by_buchungsgruppen_id($self->config->id));
}
# constraint, if Buchungsgruppe is connected to a part
my $db = $self->{config}->db;
- $db->do_transaction(sub {
+ $db->do_transaction(sub {
my $taxzone_charts = SL::DB::Manager::TaxzoneChart->get_all(where => [ buchungsgruppen_id => $self->config->id ]);
foreach my $taxzonechart ( @{$taxzone_charts} ) { $taxzonechart->delete };
$self->config->delete();
my $params = delete($::form->{config}) || { };
delete $params->{id};
- $self->config->assign_attributes(%{ $params });
+ my @errors;
- my @errors = $self->config->validate;
+ my $db = $self->config->db;
+ $db->do_transaction( sub {
- if (@errors) {
- flash('error', @errors);
- $self->show_form(title => $is_new ? t8('Add taxzone') : t8('Edit taxzone'));
- return;
- }
+ $self->config->assign_attributes(%{ $params }); # assign description and inventory_accno_id
+
+ @errors = $self->config->validate; # check for description and inventory_accno_id
+
+ if (@errors) {
+ die "foo" . @errors . "\n";
+ };
- $self->config->save;
+ $self->config->save;
- # check whether there are any assigned parts
- my $number_of_parts_with_buchungsgruppe = SL::DB::Manager::Part->get_objects_count(where => [ buchungsgruppen_id => $self->config->id]);
+ # Save or update taxzone_charts for new or unused Buchungsgruppen
+ if ($is_new or $self->config->orphaned) {
+ my $taxzones = SL::DB::Manager::TaxZone->get_all_sorted();
- # Save or update taxzone_charts:
- if ($is_new or $number_of_parts_with_buchungsgruppe == 0) {
- my $taxzones = SL::DB::Manager::TaxZone->get_all_sorted();
+ foreach my $tz (@{ $taxzones }) {
- foreach my $tz (@{ $taxzones }) {
- my $taxzone_chart = SL::DB::Manager::TaxzoneChart->find_by_or_create(buchungsgruppen_id => $self->config->id, taxzone_id => $tz->id);
- $taxzone_chart->taxzone_id($tz->id);
- $taxzone_chart->buchungsgruppen_id($self->config->id);
- $taxzone_chart->income_accno_id($::form->{"income_accno_id_" . $tz->id});
- $taxzone_chart->expense_accno_id($::form->{"expense_accno_id_" . $tz->id});
- $taxzone_chart->save;
+ my $income_accno_id = $::form->{"income_accno_id_" . $tz->id};
+ my $expense_accno_id = $::form->{"expense_accno_id_" . $tz->id};
+
+ my ($income_accno, $expense_accno);
+ $income_accno = SL::DB::Manager::Chart->find_by( id => $income_accno_id ) if $income_accno_id;
+ $expense_accno = SL::DB::Manager::Chart->find_by( id => $expense_accno_id ) if $expense_accno_id;
+
+ push(@errors, t8('Tax zone #1 needs a valid income account' , $tz->description)) unless $income_accno;
+ push(@errors, t8('Tax zone #1 needs a valid expense account' , $tz->description)) unless $expense_accno;
+
+ my $taxzone_chart = SL::DB::Manager::TaxzoneChart->find_by_or_create(buchungsgruppen_id => $self->config->id, taxzone_id => $tz->id);
+ $taxzone_chart->taxzone_id($tz->id);
+ $taxzone_chart->buchungsgruppen_id($self->config->id);
+ $taxzone_chart->income_accno_id($income_accno->id);
+ $taxzone_chart->expense_accno_id($expense_accno->id);
+ $taxzone_chart->save;
+ }
}
- }
+ } ) || die @errors ? join("\n", @errors) . "\n" : $db->error . "\n";
+ # die with rollback of taxzone save if saving of any of the taxzone_charts fails
+ # only show the $db->error if we haven't already identified the likely error ourselves
flash_later('info', $is_new ? t8('The Buchungsgruppe has been created.') : t8('The Buchungsgruppe has been saved.'));
$self->redirect_to(action => 'list');