use SL::Helper::Csv;
+use SL::DBUtils;
use SL::DB::Buchungsgruppe;
use SL::DB::CustomVariable;
use SL::DB::CustomVariableConfig;
use SL::DB::Translation;
use SL::DB::Unit;
+use List::MoreUtils qw(none);
+
use parent qw(SL::Controller::CsvImport::Base);
use Rose::Object::MakeMethods::Generic
translation_columns all_pricegroups) ],
);
+sub set_profile_defaults {
+ my ($self) = @_;
+
+ my $bugru = SL::DB::Manager::Buchungsgruppe->find_by(description => { like => 'Standard%19%' });
+
+ $self->controller->profile->_set_defaults(
+ sellprice_places => 2,
+ sellprice_adjustment => 0,
+ sellprice_adjustment_type => 'percent',
+ article_number_policy => 'update_prices',
+ shoparticle_if_missing => '0',
+ parts_type => 'part',
+ default_buchungsgruppe => ($bugru ? $bugru->id : undef),
+ apply_buchungsgruppe => 'all',
+ );
+};
+
+
sub init_class {
my ($self) = @_;
$self->class('SL::DB::Part');
sub init_parts_by {
my ($self) = @_;
- my $parts_by = { id => { map { ( $_->id => $_ ) } grep { !$_->assembly } @{ $self->existing_objects } },
- partnumber => { part => { },
- service => { } } };
-
- foreach my $part (@{ $self->existing_objects }) {
- next if $part->assembly;
- $parts_by->{partnumber}->{ $part->type }->{ $part->partnumber } = $part;
+# my $parts_by = { id => { map { ( $_->id => $_ ) } grep { !$_->assembly } @{ $self->existing_objects } },
+# partnumber => { part => { },
+# service => { } } };
+#
+# foreach my $part (@{ $self->existing_objects }) {
+# next if $part->assembly;
+# $parts_by->{partnumber}->{ $part->type }->{ $part->partnumber } = $part;
+# }
+
+ my $parts_by = {};
+ my $sth = prepare_execute_query($::form, $::form->get_standard_dbh, 'SELECT partnumber FROM parts');
+ while (my ($partnumber) = $sth->fetchrow_array()) {
+ $parts_by->{partnumber}{$partnumber} = 1;
}
return $parts_by;
return unless @{ $self->controller->data };
+ $self->controller->track_progress(phase => 'building data', progress => 0);
+
$self->makemodel_columns({});
+ my $i;
+ my $num_data = scalar @{ $self->controller->data };
foreach my $entry (@{ $self->controller->data }) {
+ $self->controller->track_progress(progress => $i/$num_data * 100) if $i % 100 == 0;
+
$self->check_buchungsgruppe($entry);
$self->check_type($entry);
$self->check_unit($entry);
$self->handle_cvars($entry);
$self->handle_makemodel($entry);
$self->set_various_fields($entry);
+ } continue {
+ $i++;
}
$self->add_columns(qw(type)) if $self->settings->{parts_type} eq 'mixed';
$self->add_columns(map { "${_}_id" } grep { exists $self->controller->data->[0]->{raw_data}->{$_} } qw (price_factor payment partsgroup));
$self->add_columns(qw(shop)) if $self->settings->{shoparticle_if_missing};
$self->add_cvar_raw_data_columns;
- map { $self->add_raw_data_columns("pricegroup_${_}") } (1..scalar(@{ $self->all_pricegroups }));
+ map { $self->add_raw_data_columns("pricegroup_${_}") if exists $self->controller->data->[0]->{raw_data}->{"pricegroup_$_"} } (1..scalar(@{ $self->all_pricegroups }));
map { $self->add_raw_data_columns($_) if exists $self->controller->data->[0]->{raw_data}->{$_} } @{ $self->translation_columns };
- map { $self->add_raw_data_columns("make_${_}", "model_${_}") } sort { $a <=> $b } keys %{ $self->makemodel_columns };
+ map { $self->add_raw_data_columns("make_${_}", "model_${_}", "lastcost_${_}") } sort { $a <=> $b } keys %{ $self->makemodel_columns };
}
-sub check_duplicates {
- my ($self, %params) = @_;
-
- my $normalizer = sub { my $name = $_[0]; $name =~ s/[\s,\.\-]//g; return $name; };
- my $name_maker = sub { return $normalizer->($_[0]->description) };
-
- my %by_name;
- if ('check_db' eq $self->controller->profile->get('duplicates')) {
- %by_name = map { ( $name_maker->($_) => 'db' ) } @{ $self->existing_objects };
- }
-
- foreach my $entry (@{ $self->controller->data }) {
- next if @{ $entry->{errors} };
-
- my $name = $name_maker->($entry->{object});
-
- if (!$by_name{ $name }) {
- $by_name{ $name } = 'csv';
-
- } else {
- push @{ $entry->{errors} }, $by_name{ $name } eq 'db' ? $::locale->text('Duplicate in database') : $::locale->text('Duplicate in CSV file');
- }
- }
+sub get_duplicate_check_fields {
+ return {
+ partnumber => {
+ label => $::locale->text('Part Number'),
+ default => 0
+ },
+
+ description => {
+ label => $::locale->text('Description'),
+ default => 1,
+ maker => sub {
+ my $desc = shift->description;
+ $desc =~ s/[\s,\.\-]//g;
+ return $desc;
+ }
+ },
+ };
}
sub check_buchungsgruppe {
my $object = $entry->{object};
- $entry->{part} = $self->parts_by->{partnumber}->{ $object->type }->{ $object->partnumber };
+ if ($object->partnumber && $self->parts_by->{partnumber}{$object->partnumber}) {
+ $entry->{part} = SL::DB::Manager::Part->find_by(partnumber => $object->partnumber);
+ }
- if ($self->settings->{article_number_policy} eq 'update_prices') {
- if ($entry->{part}) {
- map { $entry->{part}->$_( $object->$_ ) } qw(sellprice listprice lastcost);
+ if ($entry->{part}) {
+ if ($self->settings->{article_number_policy} eq 'update_prices') {
+ if ($self->settings->{parts_type} eq 'mixed' && $entry->{part}->type ne $object->type) {
+ push(@{$entry->{errors}}, $::locale->text('Skipping due to existing entry in database with different type'));
+ } else {
+ map { $entry->{part}->$_( $object->$_ ) if defined $object->$_ } qw(sellprice listprice lastcost);
- # merge prices
- my %prices_by_pricegroup_id = map { $_->pricegroup->id => $_ } $entry->{part}->prices, $object->prices;
- $entry->{part}->prices(grep { $_ } map { $prices_by_pricegroup_id{$_->id} } @{ $self->all_pricegroups });
+ # merge prices
+ my %prices_by_pricegroup_id = map { $_->pricegroup->id => $_ } $entry->{part}->prices, $object->prices;
+ $entry->{part}->prices(grep { $_ } map { $prices_by_pricegroup_id{$_->id} } @{ $self->all_pricegroups });
- push @{ $entry->{information} }, $::locale->text('Updating prices of existing entry in database');
- $entry->{object_to_save} = $entry->{part};
- }
+ push @{ $entry->{information} }, $::locale->text('Updating prices of existing entry in database');
+ $entry->{object_to_save} = $entry->{part};
+ }
+ } elsif ( $self->settings->{article_number_policy} eq 'skip' ) {
+ push(@{$entry->{errors}}, $::locale->text('Skipping due to existing entry in database'));
+ } else {
+ $object->partnumber('####');
+ push(@{$entry->{errors}}, $::locale->text('Skipping, for assemblies are not importable (yet)')) if $object->type eq 'assembly';
+ }
} else {
- $object->partnumber('####') if $entry->{part};
+ push(@{$entry->{errors}}, $::locale->text('Skipping, for assemblies are not importable (yet)')) if $object->type eq 'assembly';
}
}
sub handle_prices {
my ($self, $entry) = @_;
- foreach my $column (qw(sellprice listprice lastcost)) {
- next unless $self->controller->headers->{used}->{ $column };
-
+ foreach my $column (qw(sellprice)) {
+ my $object = $entry->{object_to_save} || $entry->{object};
my $adjustment = $self->settings->{sellprice_adjustment};
- my $value = $entry->{object}->$column;
+ my $value = $object->$column;
$value = $self->settings->{sellprice_adjustment_type} eq 'percent' ? $value * (100 + $adjustment) / 100 : $value + $adjustment;
- $entry->{object}->$column($::form->round_amount($value, $self->settings->{sellprice_places}));
+ $object->$column($::form->round_amount($value, $self->settings->{sellprice_places}));
}
}
my ($self, $entry) = @_;
my $bg = $self->bg_by->{id}->{ $entry->{object}->buchungsgruppen_id };
- $bg ||= SL::DB::Buchungsgruppe->new(inventory_accno_id => 1, income_accno_id_0 => 1, expense_accno_id_0 => 1);
+ $bg ||= SL::DB::Buchungsgruppe->new(inventory_accno_id => 1); # does this case ever occur?
my $type = $self->settings->{parts_type};
if ($type eq 'mixed') {
$type = $entry->{raw_data}->{type} =~ m/^p/i ? 'part'
: $entry->{raw_data}->{type} =~ m/^s/i ? 'service'
+ : $entry->{raw_data}->{type} =~ m/^a/i ? 'assembly'
: undef;
}
- $entry->{object}->income_accno_id( $bg->income_accno_id_0 );
- $entry->{object}->expense_accno_id( $bg->expense_accno_id_0 );
+ $entry->{object}->assembly($type eq 'assembly');
+
+ # when saving income_accno_id or expense_accno_id use ids from the selected
+ # $bg according to the default tax_zone (the one with the highest sort
+ # order). Alternatively one could use the ids from defaults, but they might
+ # not all be set.
+
+ $entry->{object}->income_accno_id( $bg->income_accno_id( SL::DB::Manager::TaxZone->get_default->id ) );
+
+ if ($type eq 'part' || $type eq 'service') {
+ $entry->{object}->expense_accno_id( $bg->expense_accno_id( SL::DB::Manager::TaxZone->get_default->id ) );
+ }
if ($type eq 'part') {
$entry->{object}->inventory_accno_id( $bg->inventory_accno_id );
+ }
- } elsif ($type ne 'service') {
+ if (none { $_ eq $type } qw(part service assembly)) {
push @{ $entry->{errors} }, $::locale->text('Error: Invalid part type');
return 0;
}
sub handle_makemodel {
my ($self, $entry) = @_;
+ my $object = $entry->{object};
+ my $found_any;
my @makemodels;
- foreach my $idx (map { substr $_, 5 } grep { m/^make_\d+$/ && $entry->{raw_data}->{$_} } keys %{ $entry->{raw_data} }) {
+ foreach my $idx (sort map { substr $_, 5 } grep { m/^make_\d+$/ && $entry->{raw_data}->{$_} } keys %{ $entry->{raw_data} }) {
my $vendor = $entry->{raw_data}->{"make_${idx}"};
$vendor = $self->vc_by->{id}-> { $vendor }
|| $self->vc_by->{number}->{vendors}->{ $vendor }
push @{ $entry->{errors} }, $::locale->text('Error: Invalid vendor in column make_#1', $idx);
} else {
- push @makemodels, SL::DB::MakeModel->new(make => $vendor->id,
- model => $entry->{raw_data}->{"model_${idx}"});
+ $found_any = 1;
+ push @makemodels, SL::DB::MakeModel->new(make => $vendor->id,
+ model => $entry->{raw_data}->{"model_${idx}"},
+ lastcost_as_number => $entry->{raw_data}->{"lastcost_${idx}"});
+
$self->makemodel_columns->{$idx} = 1;
$entry->{raw_data}->{"make_${idx}"} = $vendor->name;
}
}
- $entry->{object}->makemodels(\@makemodels);
- $entry->{object}->makemodel(scalar(@makemodels) ? 1 : 0);
+ $object->makemodels(\@makemodels);
+ $object->makemodel(scalar(@makemodels) ? 1 : 0);
+
+ if ( !$entry->{part} || $self->settings->{article_number_policy} ne 'update_prices' ) {
+ return;
+ }
+
+ my %old_makemodels_by_mm = map { $_->make . $; . $_->model => $_ } $entry->{part}->makemodels;
+ my @new_makemodels;
+
+ foreach my $makemodel ($object->makemodels()) {
+ my $makemodel_orig = $old_makemodels_by_mm{$makemodel->make,$makemodel->model};
+ $found_any = 1;
+
+ if ($makemodel_orig) {
+ $makemodel_orig->model($makemodel->model);
+ $makemodel_orig->lastcost($makemodel->lastcost);
+
+ } else {
+ push @new_makemodels, $makemodel;
+ }
+ }
+
+ $entry->{part}->makemodels([ $entry->{part}->makemodels, @new_makemodels ]) if @new_makemodels;
+
+ # reindex makemodels
+ my $i = 0;
+ $_->sortorder(++$i) for @{ $entry->{part}->makemodels };
+
+ $self->save_with_cascade(1) if $found_any;
}
sub set_various_fields {
my $profile = $self->SUPER::init_profile;
delete @{$profile}{qw(alternate assembly bom expense_accno_id income_accno_id inventory_accno_id makemodel priceupdate stockable type)};
+ $profile->{"pricegroup_$_"} = '' for 1 .. scalar @{ $_[0]->all_pricegroups };
+
return $profile;
}
{ name => 'image', description => $::locale->text('Image') },
{ name => 'lastcost', description => $::locale->text('Last Cost') },
{ name => 'listprice', description => $::locale->text('List Price') },
- { name => 'make_X', description => $::locale->text('Make (with X being a number)') },
+ { name => 'make_X', description => $::locale->text('Make (vendor\'s database ID, number or name; with X being a number)') . ' [1]' },
{ name => 'microfiche', description => $::locale->text('Microfiche') },
- { name => 'model_X', description => $::locale->text('Model (with X being a number)') },
+ { name => 'model_X', description => $::locale->text('Model (with X being a number)') . ' [1]' },
+ { name => 'lastcost_X', description => $::locale->text('Lastcost (with X being a number)') . ' [1]' },
{ name => 'not_discountable', description => $::locale->text('Not Discountable') },
{ name => 'notes', description => $::locale->text('Notes') },
{ name => 'obsolete', description => $::locale->text('Obsolete') },
- { name => 'onhand', description => $::locale->text('On Hand') },
+ { name => 'onhand', description => $::locale->text('On Hand') . ' [2]' },
{ name => 'partnumber', description => $::locale->text('Part Number') },
{ name => 'partsgroup_id', description => $::locale->text('Partsgroup (database ID)') },
{ name => 'partsgroup', description => $::locale->text('Partsgroup (name)') },
{ name => 'rop', description => $::locale->text('ROP') },
{ name => 'sellprice', description => $::locale->text('Sellprice') },
{ name => 'shop', description => $::locale->text('Shopartikel') },
- { name => 'type', description => $::locale->text('Article type (see below)') },
+ { name => 'type', description => $::locale->text('Article type') . ' [3]' },
{ name => 'unit', description => $::locale->text('Unit (if missing or empty default unit will be used)') },
{ name => 've', description => $::locale->text('Verrechnungseinheit') },
{ name => 'weight', description => $::locale->text('Weight') },
projects / kivitendo-erp.git / blobdiff