flash_later('info', $::locale->text('The order has been deleted'));
my @redirect_params = (
- action => 'edit',
+ action => 'add',
type => $self->type,
);
$item->assign_attributes(%$attr);
$item->longdescription($item->part->notes) if $is_new && !defined $attr->{longdescription};
+ # item fields that currently can't be set in in row but are needed:
+ $item->lastcost($item->part->lastcost) if $is_new;
return $item;
}
my ($self) = @_;
my $errors = [];
- my $db = $self->order->db;
+ my $db = $self->order->db;
- $db->do_transaction(
+ $db->with_transaction(
sub {
my @spoolfiles = grep { $_ } map { $_->spoolfile } @{ SL::DB::Manager::Status->get_all(where => [ trans_id => $self->order->id ]) };
$self->order->delete;
my ($self) = @_;
my $errors = [];
- my $db = $self->order->db;
+ my $db = $self->order->db;
- $db->do_transaction(
- sub {
- SL::DB::OrderItem->new(id => $_)->delete for @{$self->item_ids_to_delete};
- $self->order->save(cascade => 1);
+ $db->with_transaction(sub {
+ SL::DB::OrderItem->new(id => $_)->delete for @{$self->item_ids_to_delete};
+ $self->order->save(cascade => 1);
}) || push(@{$errors}, $db->error);
return $errors;
=back
-=item *
+=item * C<js/kivi.Order.js>
-js/kivi.Order.js: java script functions
+java script functions
=back
=item * force project if enabled in client config
+=item * history
+
+=item * mtime check
+
=back
=head1 KNOWN BUGS AND CAVEATS
=item *
-C<position> is not displayed until an order is saved
-
-=item *
-
Customer discount is not displayed as a valid discount in price source popup
(this might be a bug in price sources)
Sorting does not include C<position>, neither does reordering.
+This behavior was implemented intentionally. But we can discuss, which behavior
+should be implemented.
+
=item *
-C<show_smulti_items_dialog> does not use the currently inserted string for filtering.
+C<show_multi_items_dialog> does not use the currently inserted string for
+filtering.
+
+=item * Performance
+
+Rendering a 50 items order takes twice as long as the old code.
+
+90% of that is rendering the (hidden) second rows, and 50% of those again are
+checks for is_valid and C<INCLUDE> on the cvar input template.
+
+Suggestion: fetch second rows when asked for.
=back