Order Controller - lastcost von Positionen mit speichern

[kivitendo-erp.git] / SL / Controller / Order.pm

diff --git a/SL/Controller/Order.pm b/SL/Controller/Order.pm
index a32581d..8023aa2 100644 (file)
--- a/SL/Controller/Order.pm
+++ b/SL/Controller/Order.pm
@@ -783,6 +783,8 @@ sub _make_item {
 
   $item->assign_attributes(%$attr);
   $item->longdescription($item->part->notes) if $is_new && !defined $attr->{longdescription};
+  # item fields that currently can't be set in in row but are needed:
+  $item->lastcost($item->part->lastcost);
 
   return $item;
 }
@@ -1204,10 +1206,6 @@ java script functions
 
 =item *
 
-C<position> is not displayed until an order is saved
-
-=item *
-
 Customer discount is not displayed as a valid discount in price source popup
 (this might be a bug in price sources)
 
@@ -1236,9 +1234,22 @@ Table header is not sticky in the scrolling area.
 
 Sorting does not include C<position>, neither does reordering.
 
+This behavior was implemented intentionally. But we can discuss, which behavior
+should be implemented.
+
 =item *
 
-C<show_smulti_items_dialog> does not use the currently inserted string for filtering.
+C<show_multi_items_dialog> does not use the currently inserted string for
+filtering.
+
+=item * Performance
+
+Rendering a 50 items order takes twice as long as the old code.
+
+90% of that is rendering the (hidden) second rows, and 50% of those again are
+checks for is_valid and C<INCLUDE> on the cvar input template.
+
+Suggestion: fetch second rows when asked for.
 
 =back