BankTransaction: Fall SEPA-Export. Weitere Code-QS und TODO Anmerkung

[kivitendo-erp.git] / SL / DB / BankTransaction.pm

diff --git a/SL/DB/BankTransaction.pm b/SL/DB/BankTransaction.pm
index e91651a..6ad0348 100644 (file)
--- a/SL/DB/BankTransaction.pm
+++ b/SL/DB/BankTransaction.pm
@@ -151,7 +151,7 @@ sub get_agreement_with_invoice {
   my $cvname;
   $cvname = $invoice->customer->name if $invoice->is_sales;
   $cvname = $invoice->vendor->name   if ! $invoice->is_sales;
-  if ( $cvname && $self->purpose =~ /\b$cvname\b/i ) {
+  if ( $cvname && $self->purpose =~ /\b\Q$cvname\E\b/i ) {
     $agreement += $points{cust_vend_name_in_purpose};
     $rule_matches .= 'cust_vend_name_in_purpose(' . $points{'cust_vend_name_in_purpose'} . ') ';
   };
@@ -209,27 +209,28 @@ sub get_agreement_with_invoice {
     };
   };
 
-#  # if there is exactly one non-executed sepa_export_item for the invoice
-#  if ( my $seis = $invoice->find_sepa_export_items({ executed => 0 }) ) {
-#    if ( scalar @$seis == 1 ) {
-#      my $sei = $seis->[0];
-#
-#      # test for amount and id matching only, sepa transfer date and bank
-#      # transaction date needn't match
-#      my $arap = $invoice->is_sales ? 'ar' : 'ap';
-#      if (    abs($self->amount) == ($sei->amount)
-#          && $invoice->id        == $sei->arap_id
-#         ) {
-#        $agreement += $points{sepa_export_item};
-#          $rule_matches .= 'sepa_export_item(' . $points{'sepa_export_item'} . ') ';
-#      };
-#    } else {
-#      # zero or more than one sepa_export_item, do nothing for this invoice
-#      # zero: do nothing, no sepa_export_item exists, no match
-#      # more than one: does this ever apply? Currently you can't create sepa
-#      # exports for invoices that already have a non-executed sepa_export
-#    };
-#  };
+  # if there is exactly one non-executed sepa_export_item for the invoice
+  if ( my $seis = $invoice->find_sepa_export_items({ executed => 0 }) ) {
+    if (scalar @$seis == 1) {
+      my $sei = $seis->[0];
+
+      # test for amount and id matching only, sepa transfer date and bank
+      # transaction date needn't match
+      my $arap = $invoice->is_sales ? 'ar' : 'ap';
+
+      if (abs($self->amount) == ($sei->amount) && $invoice->id == $sei->arap_id) {
+        $agreement    += $points{sepa_export_item};
+        $rule_matches .= 'sepa_export_item(' . $points{'sepa_export_item'} . ') ';
+      }
+    } else {
+      # zero or more than one sepa_export_item, do nothing for this invoice
+      # zero: do nothing, no sepa_export_item exists, no match
+      # more than one: does this ever apply? Currently you can't create sepa
+      # exports for invoices that already have a non-executed sepa_export
+      # TODO: Catch the more than one case. User is allowed to split
+      # payments for one invoice item in one sepa export.
+    }
+  }
 
   return ($agreement,$rule_matches);
 };