use SL::DB::MetaSetup::BankTransaction;
use SL::DB::Manager::BankTransaction;
use SL::DB::Helper::LinkedRecords;
+use Carp;
require SL::DB::Invoice;
require SL::DB::PurchaseInvoice;
return [ @linked_invoices ];
}
+sub is_batch_transaction {
+ $_[0]->transaction_code eq "191";
+}
+
+
sub get_agreement_with_invoice {
my ($self, $invoice) = @_;
- die "first argument is not an invoice object"
+ carp "get_agreement_with_invoice needs an invoice object as its first argument"
unless ref($invoice) eq 'SL::DB::Invoice' or ref($invoice) eq 'SL::DB::PurchaseInvoice';
my %points = (
skonto_exact_amount => 5,
wrong_sign => -1,
sepa_export_item => 5,
+ batch_sepa_transaction => 20,
);
my ($agreement,$rule_matches);
+ if ( $self->is_batch_transaction && $self->{sepa_export_ok}) {
+ $agreement += $points{batch_sepa_transaction};
+ $rule_matches .= 'batch_sepa_transaction(' . $points{'batch_sepa_transaction'} . ') ';
+ }
+
# compare banking arrangements
my ($iban, $bank_code, $account_number);
$bank_code = $invoice->customer->bank_code if $invoice->is_sales;
if ( $invoice->skonto_date && abs(abs($invoice->amount_less_skonto) - abs($self->amount)) < 0.01) {
$agreement += $points{skonto_exact_amount};
$rule_matches .= 'skonto_exact_amount(' . $points{'skonto_exact_amount'} . ') ';
+ $invoice->{skonto_type} = 'with_skonto_pt';
};
#search invoice number in purpose
my $cvname;
$cvname = $invoice->customer->name if $invoice->is_sales;
$cvname = $invoice->vendor->name if ! $invoice->is_sales;
- if ( $cvname && $self->purpose =~ /\b$cvname\b/i ) {
+ if ( $cvname && $self->purpose =~ /\b\Q$cvname\E\b/i ) {
$agreement += $points{cust_vend_name_in_purpose};
$rule_matches .= 'cust_vend_name_in_purpose(' . $points{'cust_vend_name_in_purpose'} . ') ';
};
# if there is exactly one non-executed sepa_export_item for the invoice
if ( my $seis = $invoice->find_sepa_export_items({ executed => 0 }) ) {
- if ( scalar @$seis == 1 ) {
+ if (scalar @$seis == 1) {
my $sei = $seis->[0];
# test for amount and id matching only, sepa transfer date and bank
# transaction date needn't match
my $arap = $invoice->is_sales ? 'ar' : 'ap';
- if ( abs($self->amount) == ($sei->amount)
- && $invoice->id == $sei->arap_id
- ) {
- $agreement += $points{sepa_export_item};
- $rule_matches .= 'sepa_export_item(' . $points{'sepa_export_item'} . ') ';
- };
+
+ if (abs($self->amount) == ($sei->amount) && $invoice->id == $sei->arap_id) {
+ $agreement += $points{sepa_export_item};
+ $rule_matches .= 'sepa_export_item(' . $points{'sepa_export_item'} . ') ';
+ }
} else {
# zero or more than one sepa_export_item, do nothing for this invoice
# zero: do nothing, no sepa_export_item exists, no match
# more than one: does this ever apply? Currently you can't create sepa
# exports for invoices that already have a non-executed sepa_export
- };
- };
+ # TODO: Catch the more than one case. User is allowed to split
+ # payments for one invoice item in one sepa export.
+ }
+ }
return ($agreement,$rule_matches);
};