package SL::DB::CustomVariable;
use strict;
+
+use List::MoreUtils qw(any);
+
use SL::DB::MetaSetup::CustomVariable;
__PACKAGE__->meta->initialize;
my $unparsed = delete $self->{__unparsed_value};
if ($type =~ m{^(?:customer|vendor|part|number)}) {
- return $self->number_value(defined($unparsed) ? $unparsed * 1 : undef);
+ return $self->number_value(!defined($unparsed) ? undef
+ : (any { ref($unparsed) eq $_ } qw(SL::DB::Customer SL::DB::Vendor SL::DB::Part)) ? $unparsed->id * 1
+ : $unparsed * 1);
}
if ($type =~ m{^(?:bool)}) {
}
if ($type =~ m{^(?:date|timestamp)}) {
- return $self->timestamp_value(defined($unparsed) ? DateTime->from_kivitendo($unparsed) : undef);
+ return $self->timestamp_value(!defined($unparsed) ? undef : ref($unparsed) eq 'DateTime' ? $unparsed->clone : DateTime->from_kivitendo($unparsed));
}
# text, textfield, select
goto &bool_value if $type eq 'bool';
goto ×tamp_value if $type eq 'timestamp';
- goto &number_value if $type eq 'number';
+
+ if ($type eq 'number') {
+ return defined($self->number_value) ? $self->number_value * 1 : undef;
+ }
if ( $type eq 'customer' ) {
require SL::DB::Customer;
require SL::DB::CustomVariableValidity;
- my $query = [config_id => $self->config_id, trans_id => $self->trans_id];
- return (SL::DB::Manager::CustomVariableValidity->get_all_count(query => $query) == 0) ? 1 : 0;
+ # only base level custom variables can be invalid. ovverloaded ones could potentially clash on trans_id, so disallow them
+ return 1 if $self->sub_module;
+
+ $self->{is_valid} //= do {
+ my $query = [config_id => $self->config_id, trans_id => $self->trans_id];
+ (SL::DB::Manager::CustomVariableValidity->get_all_count(query => $query) == 0) ? 1 : 0;
+ }
}
1;