Scriptname steht nicht mehr in $form

[kivitendo-erp.git] / SL / Dispatcher.pm

diff --git a/SL/Dispatcher.pm b/SL/Dispatcher.pm
index 6dc741f..b4f75ba 100644 (file)
--- a/SL/Dispatcher.pm
+++ b/SL/Dispatcher.pm
@@ -15,6 +15,7 @@ use SL::LXDebug;
 use SL::Locale;
 use SL::Common;
 use Form;
+use List::Util qw(first);
 use Moose;
 use Rose::DB;
 use Rose::DB::Object;
@@ -69,6 +70,7 @@ sub pre_startup_setup {
     $::userspath  = "users";
     $::templates  = "templates";
     $::memberfile = "users/members";
+    $::menufile   = "menu.ini";
     $::sendmail   = "| /usr/sbin/sendmail -t";
     $::lxdebug    = LXDebug->new;
     $::auth       = SL::Auth->new;
@@ -100,10 +102,10 @@ sub require_main_code {
     };
     $::form->error($EVAL_ERROR) if ($EVAL_ERROR);
   }
-  if ($::form->{login} && -f "bin/mozilla/$::form->{login}_$::form->{script}") {
+  if ($::form->{login} && -f "bin/mozilla/$::form->{login}_$script") {
     eval {
       package main;
-      require "bin/mozilla/$::form->{login}_$::form->{script}";
+      require "bin/mozilla/$::form->{login}_$script";
     };
     $::form->error($EVAL_ERROR) if ($EVAL_ERROR);
   }
@@ -114,7 +116,7 @@ sub handle_request {
   $::lxdebug->begin_request;
 
   my $interface = lc(shift || 'cgi');
-  my $script_name;
+  my ($script_name, $action);
 
   if ($interface =~ m/^(?:fastcgi|fcgid|fcgi)$/) {
     $script_name = $ENV{SCRIPT_NAME};
@@ -124,12 +126,16 @@ sub handle_request {
     $script_name = $0;
   }
 
+  $::cgi         = CGI->new('');
+  $::locale      = Locale->new($::language);
+  $::form        = Form->new;
+  %::called_subs = ();
+
+  eval { ($script_name, $action) = _route_request($script_name); 1; } or return;
+
   my ($script, $path, $suffix) = fileparse($script_name, ".pl");
   require_main_code($script, $suffix);
 
-  $::cgi            = CGI->new('');
-  $::locale         = Locale->new($::language);
-  $::form           = Form->new;
   $::form->{script} = $script . $suffix;
 
   pre_request_checks();
@@ -139,7 +145,7 @@ sub handle_request {
       $::form->{titlebar} = "Lx-Office " . $::locale->text('Version') . " $::form->{version}";
       ::run($::auth->restore_session);
 
-    } elsif ($::form->{action}) {
+    } elsif ($action) {
       # copy from am.pl routines
       $::form->error($::locale->text('System currently down for maintenance!')) if -e "$main::userspath/nologin" && $script ne 'admin';
 
@@ -159,10 +165,10 @@ sub handle_request {
       delete $::form->{password};
 
       map { $::form->{$_} = $::myconfig{$_} } qw(stylesheet charset)
-        unless $::form->{action} eq 'save' && $::form->{type} eq 'preferences';
+        unless $action eq 'save' && $::form->{type} eq 'preferences';
 
       $::form->set_standard_title;
-      ::call_sub('::' . $::locale->findsub($::form->{action}));
+      ::call_sub('::' . $::locale->findsub($action));
 
     } else {
       $::form->error($::locale->text('action= not defined!'));
@@ -195,6 +201,42 @@ sub unrequire_bin_mozilla {
   }
 }
 
+sub _route_request {
+  my $script_name = shift;
+
+  return $script_name =~ m/dispatcher\.pl$/ ? _route_dispatcher_request() : ($script_name, $::form->{action});
+}
+
+sub _route_dispatcher_request {
+  my $name_re = qr{[a-z]\w*};
+  my ($script_name, $action);
+
+  eval {
+    die "Unroutable request -- inavlid module name.\n" if !$::form->{M} || ($::form->{M} !~ m/^${name_re}$/);
+    $script_name = $::form->{M} . '.pl';
+
+    if ($::form->{A}) {
+      $action = $::form->{A};
+
+    } else {
+      $action = first { m/^A_${name_re}$/ } keys %{ $::form };
+      die "Unroutable request -- inavlid action name.\n" if !$action;
+
+      delete $::form->{$action};
+      $action = substr $action, 2;
+    }
+
+    delete @{$::form}{qw(M A)};
+
+    1;
+  } or do {
+    $::form->{label_error} = $::cgi->pre($EVAL_ERROR);
+    show_error('generic/error');
+  };
+
+  return ($script_name, $action);
+}
+
 package main;
 
 use strict;