strictness

[kivitendo-erp.git] / SL / Drafts.pm

diff --git a/SL/Drafts.pm b/SL/Drafts.pm
index 96d4d91..49c7fcd 100644 (file)
--- a/SL/Drafts.pm
+++ b/SL/Drafts.pm
@@ -14,6 +14,8 @@ use YAML;
 use SL::Common;
 use SL::DBUtils;
 
+use strict;
+
 sub get_module {
   $main::lxdebug->enter_sub();
 
@@ -34,12 +36,14 @@ sub get_module {
   return ($module, $submodule);
 }
 
+my @dont_save = qw(login password stylesheet action);
+
 sub save {
   $main::lxdebug->enter_sub();
 
   my ($self, $myconfig, $form, $draft_id, $draft_description) = @_;
 
-  my ($dbh, $sth, $query, %saved, @dont_save, $dumped);
+  my ($dbh, $sth, $query, %saved, $dumped);
 
   $dbh = $form->dbconnect_noauto($myconfig);
 
@@ -54,7 +58,6 @@ sub save {
     do_query($form, $dbh, $query, $draft_id, $module, $submodule);
   }
 
-  @dont_save = qw(login password action);
   map({ $saved{$_} = $form->{$_};
         delete($form->{$_}); } @dont_save);
 
@@ -90,7 +93,6 @@ sub load {
 
   $sth = prepare_execute_query($form, $dbh, $query, $draft_id);
 
-  my @values;
   if (my $ref = $sth->fetchrow_hashref()) {
     @values = ($ref->{form}, $ref->{id}, $ref->{description});
   }
@@ -141,7 +143,7 @@ sub list {
     qq|LEFT JOIN employee e ON d.employee_id = e.id | .
     qq|WHERE (d.module = ?) AND (d.submodule = ?) | .
     qq|ORDER BY d.itime|;
-  my @values = ($module, $submodule);
+  @values = ($module, $submodule);
 
   $sth = prepare_execute_query($form, $dbh, $query, @values);