use Data::Dumper;
use SL::DBUtils;
+use strict;
+
sub delete_transaction {
my ($self, $myconfig, $form) = @_;
$main::lxdebug->enter_sub();
$form->{taxincluded} = 0;
}
- my ($query, $sth);
+ my ($query, $sth, @values, $taxkey, $rate, $posted);
if ($form->{id}) {
# connect to database
my $dbh = $form->dbconnect($myconfig);
- my ($query, $sth, $source, $null);
+ my ($query, $sth, $source, $null, $space);
my ($glwhere, $arwhere, $apwhere) = ("1 = 1", "1 = 1", "1 = 1");
my (@glvalues, @arvalues, @apvalues);
push(@apvalues, '%' . $form->{source} . '%');
}
+ # default Datumseinschränkung falls nicht oder falsch übergeben (sollte nie passieren)
+ $form->{datesort} = 'transdate' unless $form->{datesort} =~ /^(transdate|gldate)$/;
+
if ($form->{datefrom}) {
- $glwhere .= " AND ac.transdate >= ?";
- $arwhere .= " AND ac.transdate >= ?";
- $apwhere .= " AND ac.transdate >= ?";
+ $glwhere .= " AND ac.$form->{datesort} >= ?";
+ $arwhere .= " AND ac.$form->{datesort} >= ?";
+ $apwhere .= " AND ac.$form->{datesort} >= ?";
push(@glvalues, $form->{datefrom});
push(@arvalues, $form->{datefrom});
push(@apvalues, $form->{datefrom});
}
if ($form->{dateto}) {
- $glwhere .= " AND ac.transdate <= ?";
- $arwhere .= " AND ac.transdate <= ?";
- $apwhere .= " AND ac.transdate <= ?";
+ $glwhere .= " AND ac.$form->{datesort} <= ?";
+ $arwhere .= " AND ac.$form->{datesort} <= ?";
+ $apwhere .= " AND ac.$form->{datesort} <= ?";
push(@glvalues, $form->{dateto});
push(@arvalues, $form->{dateto});
push(@apvalues, $form->{dateto});
push(@arvalues, '%' . $form->{description} . '%');
push(@apvalues, '%' . $form->{description} . '%');
}
+
+ if ($form->{employee} =~ /--/) {
+ ($form->{employee_id},$form->{employee_name}) = split(/--/,$form->{employee});
+ #if ($form->{employee_id}) {
+ $glwhere .= " AND g.employee_id = ? ";
+ $arwhere .= " AND a.employee_id = ? ";
+ $apwhere .= " AND a.employee_id = ? ";
+ push(@glvalues, conv_i($form->{employee_id}));
+ push(@arvalues, conv_i($form->{employee_id}));
+ push(@apvalues, conv_i($form->{employee_id}));
+ }
if ($form->{notes}) {
$glwhere .= " AND g.notes ILIKE ?";
push(@apvalues, $project_id, $project_id);
}
- my ($project_columns, %project_join);
+ my ($project_columns, $project_join);
if ($form->{"l_projectnumbers"}) {
$project_columns = qq|, ac.project_id, pr.projectnumber|;
$project_join = qq|LEFT JOIN project pr ON (ac.project_id = pr.id)|;
qq|SELECT SUM(ac.amount)
FROM acc_trans ac
LEFT JOIN chart c ON (ac.chart_id = c.id)
- WHERE (c.accno = ?) AND (ac.transdate < ?)|;
+ WHERE (c.accno = ?) AND (ac.$form->{datesort} < ?)|;
($form->{balance}) = selectrow_query($form, $dbh, $query, $form->{accno}, conv_date($form->{datefrom}));
}
}
- my $false = ($myconfig->{dbdriver} eq 'Pg') ? FALSE: q|'0'|;
+ my $false = ($myconfig->{dbdriver} eq 'Pg') ? "FALSE" : q|'0'|;
my %sort_columns = (
'id' => [ qw(id) ],
'transdate' => [ qw(transdate id) ],
+ 'gldate' => [ qw(gldate id) ],
'reference' => [ qw(lower_reference id) ],
'description' => [ qw(lower_description id) ],
'accno' => [ qw(accno transdate id) ],
'source' => { 'gl' => 'ac.source', 'arap' => 'ac.source', },
'description' => { 'gl' => 'g.description', 'arap' => 'ct.name', },
);
-
+
+ # sortdir = sort direction (ascending or descending)
my $sortdir = !defined $form->{sortdir} ? 'ASC' : $form->{sortdir} ? 'ASC' : 'DESC';
- my $sortkey = $sort_columns{$form->{sort}} ? $form->{sort} : 'transdate';
+ my $sortkey = $sort_columns{$form->{sort}} ? $form->{sort} : $form->{datesort}; # default used to be transdate
my $sortorder = join ', ', map { "$_ $sortdir" } @{ $sort_columns{$sortkey} };
my %columns_for_sorting = ( 'gl' => '', 'arap' => '', );
map { $columns_for_sorting{$_} .= sprintf(', lower(%s) AS lower_%s', $lowered_columns{$column}->{$_}, $column) } qw(gl arap);
}
- my $query =
+ $query =
qq|SELECT
ac.acc_trans_id, g.id, 'gl' AS type, $false AS invoice, g.reference, ac.taxkey, c.link,
- g.description, ac.transdate, ac.source, ac.trans_id,
- ac.amount, c.accno, g.notes, t.chart_id
+ g.description, ac.transdate, ac.gldate, ac.source, ac.trans_id,
+ ac.amount, c.accno, g.notes, t.chart_id,
+ CASE WHEN (COALESCE(e.name, '') = '') THEN e.login ELSE e.name END AS employee
$project_columns
$columns_for_sorting{gl}
- FROM gl g, acc_trans ac $project_join, chart c
+ FROM gl g
+ LEFT JOIN employee e ON (g.employee_id = e.id),
+ acc_trans ac $project_join, chart c
LEFT JOIN tax t ON (t.chart_id = c.id)
WHERE $glwhere
AND (ac.chart_id = c.id)
UNION
SELECT ac.acc_trans_id, a.id, 'ar' AS type, a.invoice, a.invnumber, ac.taxkey, c.link,
- ct.name, ac.transdate, ac.source, ac.trans_id,
- ac.amount, c.accno, a.notes, t.chart_id
+ ct.name, ac.transdate, ac.gldate, ac.source, ac.trans_id,
+ ac.amount, c.accno, a.notes, t.chart_id,
+ CASE WHEN (COALESCE(e.name, '') = '') THEN e.login ELSE e.name END AS employee
$project_columns
$columns_for_sorting{arap}
- FROM ar a, acc_trans ac $project_join, customer ct, chart c
+ FROM ar a
+ LEFT JOIN employee e ON (a.employee_id = e.id),
+ acc_trans ac $project_join, customer ct, chart c
LEFT JOIN tax t ON (t.chart_id=c.id)
WHERE $arwhere
AND (ac.chart_id = c.id)
UNION
SELECT ac.acc_trans_id, a.id, 'ap' AS type, a.invoice, a.invnumber, ac.taxkey, c.link,
- ct.name, ac.transdate, ac.source, ac.trans_id,
- ac.amount, c.accno, a.notes, t.chart_id
+ ct.name, ac.transdate, ac.gldate, ac.source, ac.trans_id,
+ ac.amount, c.accno, a.notes, t.chart_id,
+ CASE WHEN (COALESCE(e.name, '') = '') THEN e.login ELSE e.name END AS employee
$project_columns
$columns_for_sorting{arap}
- FROM ap a, acc_trans ac $project_join, vendor ct, chart c
+ FROM ap a
+ LEFT JOIN employee e ON (a.employee_id = e.id),
+ acc_trans ac $project_join, vendor ct, chart c
LEFT JOIN tax t ON (t.chart_id=c.id)
WHERE $apwhere
AND (ac.chart_id = c.id)
AND (a.id = ac.trans_id)
ORDER BY $sortorder, acc_trans_id $sortdir|;
+# ORDER BY gldate DESC, id DESC, acc_trans_id DESC
my @values = (@glvalues, @arvalues, @apvalues);
# Show all $query in Debuglevel LXDebug::QUERY
- $callingdetails = (caller (0))[3];
- dump_query(LXDebug::QUERY, "$callingdetails", $query, @values);
+ my $callingdetails = (caller (0))[3];
+ dump_query(LXDebug->QUERY(), "$callingdetails", $query, @values);
$sth = prepare_execute_query($form, $dbh, $query, @values);
my $trans_id = "";
my $trans_id2 = "";
+ my $balance;
my ($i, $j, $k, $l, $ref, $ref2);
$form->{GL} = [];
- while (my $ref0 = $sth->fetchrow_hashref(NAME_lc)) {
+ while (my $ref0 = $sth->fetchrow_hashref("NAME_lc")) {
$trans_id = $ref0->{id};
} else { # following lines of a booking, line increasing
$ref2 = $ref0;
- $trans_old = $trans_id2;
+# $trans_old = $trans_id2; # doesn't seem to be used anymore
$trans_id2 = $ref2->{id};
$balance =
if ($form->{id}) {
$query =
qq|SELECT g.reference, g.description, g.notes, g.transdate, g.storno, g.storno_id,
- d.description AS department, e.name AS employee, g.taxincluded, g.gldate,
+ d.description AS department, e.name AS employee, g.taxincluded, g.gldate,
g.ob_transaction, g.cb_transaction
FROM gl g
LEFT JOIN department d ON (d.id = g.department_id)
# now copy acc_trans entries
$query = qq|SELECT * FROM acc_trans WHERE trans_id = ?|;
- my $rowref = selectall_hashref_query($form, $dbh, $query, $id);
+ my $rowref = selectall_hashref_query($form, $dbh, $query, $id);
for my $row (@$rowref) {
- delete @$row{qw(itime mtime)};
+ delete @$row{qw(itime mtime acc_trans_id)};
$query = sprintf 'INSERT INTO acc_trans (%s) VALUES (%s)', join(', ', keys %$row), join(', ', map '?', values %$row);
$row->{trans_id} = $new_id;
$row->{amount} *= -1;
projects / kivitendo-erp.git / blobdiff