Bugfix: Warengruppe => sql fehler

[kivitendo-erp.git] / SL / OE.pm

diff --git a/SL/OE.pm b/SL/OE.pm
index 5da1478..37f6be4 100644 (file)
--- a/SL/OE.pm
+++ b/SL/OE.pm
@@ -215,13 +215,13 @@ sub save {
     do_query($form, $dbh, $query, $form->{id}, $form->{employee_id});
   }
 
-  my $amount;
-  my $linetotal;
-  my $discount;
+  my $amount    = 0;
+  my $linetotal = 0;
+  my $discount  = 0;
   my $project_id;
   my $reqdate;
   my $taxrate;
-  my $taxamount;
+  my $taxamount = 0;
   my $fxsellprice;
   my %taxbase;
   my @taxaccounts;
@@ -330,7 +330,6 @@ sub save {
       # get pricegroup_id and save ist
       ($null, my $pricegroup_id) = split(/--/, $form->{"sellprice_pg_$i"});
       $pricegroup_id *= 1;
-      $subtotal = $form->{"subtotal_$i"} * 1;
 
       # save detail record in orderitems table
       @values = ();
@@ -356,7 +355,7 @@ sub save {
            $form->{"unit_$i"}, conv_date($reqdate), conv_i($form->{"project_id_$i"}),
            $form->{"serialnumber_$i"}, $form->{"ship_$i"}, conv_i($pricegroup_id),
            $form->{"ordnumber_$i"}, conv_date($form->{"transdate_$i"}),
-           $form->{"cusordnumber_$i"}, $subtotal,
+           $form->{"cusordnumber_$i"}, $form->{"subtotal_$i"} ? 't' : 'f',
            $form->{"marge_percent_$i"}, $form->{"marge_absolut_$i"},
            $form->{"lastcost_$i"});
       do_query($form, $dbh, $query, @values);
@@ -390,45 +389,20 @@ sub save {
     ? $exchangerate
     : $form->parse_amount($myconfig, $form->{exchangerate});
 
-  my $quotation;
-
-  # fill in subject if there is none
-  if ($form->{type} =~ /_order$/) {
-    $quotation = '0';
-    $form->{subject} = qq|$form->{label} $form->{ordnumber}|
-      unless $form->{subject};
-  } else {
-    $quotation = '1';
-    $form->{subject} = qq|$form->{label} $form->{quonumber}|
-      unless $form->{subject};
-  }
-
-  # if there is a message stuff it into the intnotes
-  my $cc  = "Cc: $form->{cc}\\r\n"   if $form->{cc};
-  my $bcc = "Bcc: $form->{bcc}\\r\n" if $form->{bcc};
-  my $now = scalar localtime;
-  $form->{intnotes} .= qq|\r
-\r| if $form->{intnotes};
-
-  $form->{intnotes} .= qq|[email]\r
-Date: $now
-To: $form->{email}\r
-$cc${bcc}Subject: $form->{subject}\r
-\r
-Message: $form->{message}\r| if $form->{message};
+  my $quotation = $form->{type} =~ /_order$/ ? 'f' : 't';
 
   ($null, $form->{department_id}) = split(/--/, $form->{department});
 
   # save OE record
   $query =
-    qq|UPDATE oe set | .
-    qq|ordnumber = ?, quonumber = ?, cusordnumber = ?, transdate = ?, vendor_id = ?, | .
-    qq|customer_id = ?, amount = ?, netamount = ?, reqdate = ?, taxincluded = ?, | .
-    qq|shippingpoint = ?, shipvia = ?, notes = ?, intnotes = ?, curr = ?, closed = ?, | .
-    qq|delivered = ?, proforma = ?, quotation = ?, department_id = ?, language_id = ?, | .
-    qq|taxzone_id = ?, shipto_id = ?, payment_id = ?, delivery_vendor_id = ?, delivery_customer_id = ?, | .
-    qq|globalproject_id = ?, employee_id = ?, salesman_id = ?, cp_id = ?, transaction_description = ?, marge_total = ?, marge_percent = ?| .
-    qq|WHERE id = ?|;
+    qq|UPDATE oe SET
+         ordnumber = ?, quonumber = ?, cusordnumber = ?, transdate = ?, vendor_id = ?,
+         customer_id = ?, amount = ?, netamount = ?, reqdate = ?, taxincluded = ?,
+         shippingpoint = ?, shipvia = ?, notes = ?, intnotes = ?, curr = ?, closed = ?,
+         delivered = ?, proforma = ?, quotation = ?, department_id = ?, language_id = ?,
+         taxzone_id = ?, shipto_id = ?, payment_id = ?, delivery_vendor_id = ?, delivery_customer_id = ?,
+         globalproject_id = ?, employee_id = ?, salesman_id = ?, cp_id = ?, transaction_description = ?, marge_total = ?, marge_percent = ?
+       WHERE id = ?|;
 
   @values = ($form->{ordnumber}, $form->{quonumber},
              $form->{cusordnumber}, conv_date($form->{transdate}),
@@ -436,7 +410,7 @@ Message: $form->{message}\r| if $form->{message};
              $amount, $netamount, conv_date($reqdate),
              $form->{taxincluded} ? 't' : 'f', $form->{shippingpoint},
              $form->{shipvia}, $form->{notes}, $form->{intnotes},
-             $form->{currency}, $form->{closed} ? 't' : 'f',
+             substr($form->{currency}, 0, 3), $form->{closed} ? 't' : 'f',
              $form->{delivered} ? "t" : "f", $form->{proforma} ? 't' : 'f',
              $quotation, conv_i($form->{department_id}),
              conv_i($form->{language_id}), conv_i($form->{taxzone_id}),
@@ -446,7 +420,7 @@ Message: $form->{message}\r| if $form->{message};
              conv_i($form->{globalproject_id}), conv_i($form->{employee_id}),
              conv_i($form->{salesman_id}), conv_i($form->{cp_id}),
              $form->{transaction_description},
-             $form->{marge_total}, $form->{marge_percent},
+             $form->{marge_total} * 1, $form->{marge_percent} * 1,
              conv_i($form->{id}));
   do_query($form, $dbh, $query, @values);