X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;ds=sidebyside;f=SL%2FController%2FTaxzones.pm;h=72c772fd6915ed2a11e4a6e2364c980e644018a1;hb=f15f5e4321df31d2279edb480e9c7fc15c3af31c;hp=5f19ea6d3acfb7d74ac2237a7b74ef33eecd0004;hpb=f5c454e3855012bdb1928f3e4c4964403d4d8163;p=kivitendo-erp.git diff --git a/SL/Controller/Taxzones.pm b/SL/Controller/Taxzones.pm index 5f19ea6d3..72c772fd6 100644 --- a/SL/Controller/Taxzones.pm +++ b/SL/Controller/Taxzones.pm @@ -4,21 +4,19 @@ use strict; use parent qw(SL::Controller::Base); -#use List::Util qw(first); - use SL::DB::TaxZone; use SL::Helper::Flash; use SL::Locale::String; use SL::DB::Manager::Buchungsgruppe; use SL::DB::Manager::TaxzoneChart; -use SL::Controller::ClientConfig; use Rose::Object::MakeMethods::Generic ( scalar => [ qw(config) ], + 'scalar --get_set_init' => [ qw(defaults) ], ); __PACKAGE__->run_before('check_auth'); -__PACKAGE__->run_before('load_config', only => [ qw(edit update) ]); #destroy +__PACKAGE__->run_before('load_config', only => [ qw(edit update delete) ]); # # actions @@ -29,7 +27,7 @@ sub action_list { my $taxzones = SL::DB::Manager::TaxZone->get_all_sorted(); - $::form->header; + $self->setup_list_action_bar; $self->render('taxzones/list', title => t8('List of tax zones'), TAXZONES => $taxzones); @@ -45,16 +43,15 @@ sub action_new { sub show_form { my ($self, %params) = @_; + $self->setup_show_form_action_bar; $self->render('taxzones/form', %params, - BUCHUNGSGRUPPEN => SL::DB::Manager::Buchungsgruppe->get_all_sorted, - ACCOUNTS => SL::Controller::ClientConfig->init_accounts, - account_label => sub { "$_[0]{accno}--$_[0]{description}" }); + BUCHUNGSGRUPPEN => SL::DB::Manager::Buchungsgruppe->get_all_sorted); } sub action_edit { my ($self) = @_; - $self->show_form(title => t8('Edit custom variable'), + $self->show_form(title => t8('Edit taxzone'), CHARTLIST => SL::DB::TaxzoneChart->get_all_accounts_by_taxzone_id($self->config->id)); } @@ -71,6 +68,25 @@ sub action_update { $self->create_or_update; } +sub action_delete { + my ($self) = @_; + + # allow deletion of unused tax zones. Will fail, due to database + # constraints, if tax zone is used anywhere + + $self->{config}->db->with_transaction(sub { + my $taxzone_charts = SL::DB::Manager::TaxzoneChart->get_all(where => [ taxzone_id => $self->config->id ]); + foreach my $taxzonechart ( @{$taxzone_charts} ) { $taxzonechart->delete }; + $self->config->delete(); + flash_later('info', $::locale->text('The tax zone has been deleted.')); + + 1; + }) || flash_later('error', $::locale->text('The tax zone is in use and cannot be deleted.')); + + $self->redirect_to(action => 'list'); + +} + sub action_reorder { my ($self) = @_; @@ -102,37 +118,116 @@ sub create_or_update { my $is_new = !$self->config->id; my $params = delete($::form->{config}) || { }; + delete $params->{id}; - $self->config->assign_attributes(%{ $params }); + my @errors; - my @errors = $self->config->validate; + my $db = $self->config->db; + if (!$db->with_transaction(sub { - if (@errors) { - flash('error', @errors); - $self->show_form(title => $is_new ? t8('Add taxzone') : t8('Edit taxzone')); - return; - } + # always allow editing of description and obsolete + $self->config->assign_attributes( %{$params} ) ; + + push(@errors, $self->config->validate); # check for description + + if (@errors) { + die @errors . "\n"; + }; + + $self->config->save; - $self->config->save; + if ( $is_new or $self->config->orphaned ) { + # Save taxzone_charts + my $buchungsgruppen = SL::DB::Manager::Buchungsgruppe->get_all_sorted(); - #Save taxzone_charts for new taxzones: - if ($is_new) { - my $buchungsgruppen = SL::DB::Manager::Buchungsgruppe->get_all_sorted(); + foreach my $bg (@{ $buchungsgruppen }) { + my $income_accno_id = $::form->{"income_accno_id_" . $bg->id}; + my $expense_accno_id = $::form->{"expense_accno_id_" . $bg->id}; - foreach my $bg (@{ $buchungsgruppen }) { - my $taxzone_chart = SL::DB::Manager::TaxzoneChart->find_by_or_create(buchungsgruppen_id => $bg->id, taxzone_id => $self->config->id); + my ($income_accno, $expense_accno); + $income_accno = SL::DB::Manager::Chart->find_by( id => $income_accno_id ) if $income_accno_id; + $expense_accno = SL::DB::Manager::Chart->find_by( id => $expense_accno_id ) if $expense_accno_id; - $taxzone_chart->taxzone_id($self->config->id); - $taxzone_chart->buchungsgruppen_id($bg->id); - $taxzone_chart->income_accno_id($::form->{"income_accno_id_" . $bg->id}); - $taxzone_chart->expense_accno_id($::form->{"expense_accno_id_" . $bg->id}); - $taxzone_chart->save; + push(@errors, t8('Booking group #1 needs a valid income account' , $bg->description)) unless $income_accno; + push(@errors, t8('Booking group #1 needs a valid expense account', $bg->description)) unless $expense_accno; + + my $taxzone_chart = SL::DB::Manager::TaxzoneChart->find_by_or_create(buchungsgruppen_id => $bg->id, taxzone_id => $self->config->id); + # if taxzonechart doesn't exist an empty new TaxzoneChart object is + # created by find_by_or_create, so we have to assign buchungsgruppe and + # taxzone again for the new case to work + $taxzone_chart->taxzone_id($self->config->id); + $taxzone_chart->buchungsgruppen_id($bg->id); + $taxzone_chart->income_accno_id($income_accno->id); + $taxzone_chart->expense_accno_id($expense_accno->id); + $taxzone_chart->save; + } } + + 1; + })) { + die @errors ? join("\n", @errors) . "\n" : $db->error . "\n"; + # die with rollback of taxzone save if saving of any of the taxzone_charts fails + # only show the $db->error if we haven't already identified the likely error ourselves } flash_later('info', $is_new ? t8('The taxzone has been created.') : t8('The taxzone has been saved.')); $self->redirect_to(action => 'list'); } +# +# initializers +# + +sub init_defaults { SL::DB::Default->get }; + +# +# helpers +# + +sub setup_show_form_action_bar { + my ($self) = @_; + + my $is_new = !$self->config->id; + + for my $bar ($::request->layout->get('actionbar')) { + $bar->add( + action => [ + t8('Save'), + submit => [ '#form', { action => 'Taxzones/' . ($is_new ? 'create' : 'update') } ], + checks => [ 'kivi.validate_form' ], + accesskey => 'enter', + ], + + action => [ + t8('Delete'), + submit => [ '#form', { action => 'Taxzones/delete' } ], + confirm => t8('Do you really want to delete this object?'), + disabled => $is_new ? t8('This object has not been saved yet.') + : !$self->config->orphaned ? t8('The object is in use and cannot be deleted.') + : undef, + ], + + link => [ + t8('Abort'), + link => $self->url_for(action => 'list'), + ], + ); + } + $::request->layout->add_javascripts('kivi.Validator.js'); +} + +sub setup_list_action_bar { + my ($self) = @_; + + for my $bar ($::request->layout->get('actionbar')) { + $bar->add( + link => [ + t8('Add'), + link => $self->url_for(action => 'new'), + ], + ); + } +} + 1;