X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;ds=sidebyside;f=SL%2FDB%2FPart.pm;h=2a74b74c6225bdba0d686a4d5fd07f411e6ac2be;hb=3873daa9d435d39692982b1f1532ee770f9d0239;hp=a0f9c1034c93b1cbcfc57e7b8da8b92f58808203;hpb=0a8ac1f354bb604a0e0988d3d2e43fe8a7f0386d;p=kivitendo-erp.git diff --git a/SL/DB/Part.pm b/SL/DB/Part.pm index a0f9c1034..2a74b74c6 100644 --- a/SL/DB/Part.pm +++ b/SL/DB/Part.pm @@ -146,17 +146,17 @@ sub get_taxkey { my $taxzone = $params{ defined($params{taxzone}) ? 'taxzone' : 'taxzone_id' } * 1; my $tk_info = $::request->cache('get_taxkey'); - $tk_info->{$taxzone} ||= { }; - $tk_info->{$taxzone}->{$is_sales} ||= { }; + $tk_info->{$self->id} //= {}; + $tk_info->{$self->id}->{$taxzone} //= { }; + my $cache = $tk_info->{$self->id}->{$taxzone}->{$is_sales} //= { }; - if (!exists $tk_info->{$taxzone}->{$is_sales}->{$date}) { - $tk_info->{$taxzone}->{$is_sales}->{$date} = + if (!exists $cache->{$date}) { + $cache->{$date} = $self->get_chart(type => $is_sales ? 'income' : 'expense', taxzone => $taxzone) - ->load ->get_active_taxkey($date); } - return $tk_info->{$taxzone}->{$is_sales}->{$date}; + return $cache->{$date}; } sub get_chart { @@ -165,18 +165,19 @@ sub get_chart { my $type = (any { $_ eq $params{type} } qw(income expense inventory)) ? $params{type} : croak("Invalid 'type' parameter '$params{type}'"); my $taxzone = $params{ defined($params{taxzone}) ? 'taxzone' : 'taxzone_id' } * 1; - my $charts = $::request->cache('get_chart_id/by_taxzones'); + my $charts = $::request->cache('get_chart_id/by_part_id_and_taxzone')->{$self->id} //= {}; my $all_charts = $::request->cache('get_chart_id/by_id'); $charts->{$taxzone} ||= { }; if (!exists $charts->{$taxzone}->{$type}) { - my $bugru = $self->buchungsgruppe; + require SL::DB::Buchungsgruppe; + my $bugru = SL::DB::Buchungsgruppe->load_cached($self->buchungsgruppen_id); my $chart_id = ($type eq 'inventory') ? ($self->inventory_accno_id ? $bugru->inventory_accno_id : undef) - : $bugru->call_sub("${type}_accno_id_${taxzone}"); + : $bugru->call_sub("${type}_accno_id", $taxzone); if ($chart_id) { - my $chart = $all_charts->{$chart_id} // SL::DB::Chart->new(id => $chart_id)->load; + my $chart = $all_charts->{$chart_id} // SL::DB::Chart->load_cached($chart_id)->load; $all_charts->{$chart_id} = $chart; $charts->{$taxzone}->{$type} = $chart; } @@ -204,7 +205,7 @@ sub get_simple_stock { sub bin { require SL::DB::Bin; SL::DB::Manager::Bin ->find_by_or_create(id => $_[0]->{bin_id}) } } -sub long_description { +sub displayable_name { join ' ', grep $_, map $_[0]->$_, qw(partnumber description); } @@ -317,7 +318,7 @@ This function looks up the income (for trueish values of C<$params{is_sales}>) or expense (for falsish values of C<$params{is_sales}>) account for the current part. It uses the part's associated buchungsgruppe and uses the fields belonging to the tax -zone given by C<$params{taxzone}> (range 0..3). +zone given by C<$params{taxzone}>. The information retrieved by the function is cached. @@ -329,8 +330,7 @@ C<$params{type}> and tax zone C<$params{taxzone}> the three key words C, C and C. This function uses the part's associated buchungsgruppe and uses the -fields belonging to the tax zone given by C<$params{taxzone}> (range -0..3). +fields belonging to the tax zone given by C<$params{taxzone}>. The information retrieved by the function is cached.