X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FCVar.pm;h=f006fd9ca563fb81159e1ec947b150d546001b3b;hb=2acbe8c6c3c8a988e712deb438adf0dc40c3daaf;hp=cdc05b5abf183825cb9045529333fbb702f315b5;hpb=8f29628f54e8b6669cdefa6e43e2f54220760c3c;p=kivitendo-erp.git diff --git a/SL/CVar.pm b/SL/CVar.pm index cdc05b5ab..f006fd9ca 100644 --- a/SL/CVar.pm +++ b/SL/CVar.pm @@ -2,7 +2,9 @@ package CVar; use strict; +use List::MoreUtils qw(any); use List::Util qw(first); +use Scalar::Util qw(blessed); use Data::Dumper; use SL::DBUtils; @@ -25,49 +27,45 @@ sub get_configs { push @values, $params{module}; } - my $query = qq|SELECT * FROM custom_variable_configs $where ORDER BY sortkey|; + my $query = <{CVAR_CONFIGS} = {} unless 'HASH' eq ref $::form->{CVAR_CONFIGS}; + if (!$::form->{CVAR_CONFIGS}->{$params{module}}) { + my $configs = selectall_hashref_query($form, $dbh, $query, @values); - foreach my $config (@{ $configs }) { - if ($config->{type} eq 'select') { - $config->{OPTIONS} = [ map { { 'value' => $_ } } split(m/\#\#/, $config->{options}) ]; - - } elsif ($config->{type} eq 'number') { - $config->{precision} = $1 if ($config->{options} =~ m/precision=(\d+)/i); - - } - - $self->_unpack_flags($config); - } - - $main::lxdebug->leave_sub(); - - return $configs; -} - -sub get_config { - $main::lxdebug->enter_sub(); + foreach my $config (@{ $configs }) { + if ($config->{type} eq 'select') { + $config->{OPTIONS} = [ map { { 'value' => $_ } } split(m/\#\#/, $config->{options}) ]; - my $self = shift; - my %params = @_; + } elsif ($config->{type} eq 'number') { + $config->{precision} = $1 if ($config->{options} =~ m/precision=(\d+)/i); - Common::check_params(\%params, qw(id)); + } elsif ($config->{type} eq 'textfield') { + $config->{width} = 30; + $config->{height} = 5; + $config->{width} = $1 if ($config->{options} =~ m/width=(\d+)/i); + $config->{height} = $1 if ($config->{options} =~ m/height=(\d+)/i); - my $myconfig = \%main::myconfig; - my $form = $main::form; + } elsif ($config->{type} eq 'text') { + $config->{maxlength} = $1 if ($config->{options} =~ m/maxlength=(\d+)/i); - my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); + } - my $query = qq|SELECT * FROM custom_variable_configs WHERE id = ?|; + $self->_unpack_flags($config); - my $config = selectfirst_hashref_query($form, $dbh, $query, conv_i($params{id})) || { }; + my $cvar_config = SL::DB::CustomVariableConfig->new(id => $config->{id})->load; + @{$config->{'partsgroups'}} = map {$_->id} @{$cvar_config->partsgroups}; - $self->_unpack_flags($config); + } + $::form->{CVAR_CONFIGS}->{$params{module}} = $configs; + } $main::lxdebug->leave_sub(); - return $config; + return $::form->{CVAR_CONFIGS}->{$params{module}}; } sub _unpack_flags { @@ -87,95 +85,6 @@ sub _unpack_flags { $main::lxdebug->leave_sub(); } -sub save_config { - $main::lxdebug->enter_sub(); - - my $self = shift; - my %params = @_; - - Common::check_params(\%params, qw(module config)); - - my $myconfig = \%main::myconfig; - my $form = $main::form; - - my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); - - my $q_id = qq|SELECT nextval('custom_variable_configs_id')|; - my $h_id = prepare_query($form, $dbh, $q_id); - - my $q_new = - qq|INSERT INTO custom_variable_configs (name, description, type, default_value, options, searchable, includeable, included_by_default, module, flags, id, sortkey) - VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, - (SELECT COALESCE(MAX(sortkey) + 1, 1) FROM custom_variable_configs))|; - my $h_new = prepare_query($form, $dbh, $q_new); - - my $q_update = - qq|UPDATE custom_variable_configs SET - name = ?, description = ?, - type = ?, default_value = ?, - options = ?, searchable = ?, - includeable = ?, included_by_default = ?, - module = ?, flags = ? - WHERE id = ?|; - my $h_update = prepare_query($form, $dbh, $q_update); - - my @configs; - if ('ARRAY' eq ref $params{config}) { - @configs = @{ $params{config} }; - } else { - @configs = ($params{config}); - } - - foreach my $config (@configs) { - my ($h_actual, $q_actual); - - if (!$config->{id}) { - do_statement($form, $h_id, $q_id); - ($config->{id}) = $h_id->fetchrow_array(); - - $h_actual = $h_new; - $q_actual = $q_new; - - } else { - $h_actual = $h_update; - $q_actual = $q_update; - } - - do_statement($form, $h_actual, $q_actual, @{$config}{qw(name description type default_value options)}, - $config->{searchable} ? 't' : 'f', $config->{includeable} ? 't' : 'f', $config->{included_by_default} ? 't' : 'f', - $params{module}, $config->{flags}, conv_i($config->{id})); - } - - $h_id->finish(); - $h_new->finish(); - $h_update->finish(); - - $dbh->commit(); - - $main::lxdebug->leave_sub(); -} - -sub delete_config { - $main::lxdebug->enter_sub(); - - my $self = shift; - my %params = @_; - - Common::check_params(\%params, qw(id)); - - my $myconfig = \%main::myconfig; - my $form = $main::form; - - my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); - - do_query($form, $dbh, qq|DELETE FROM custom_variables WHERE config_id = ?|, conv_i($params{id})); - do_query($form, $dbh, qq|DELETE FROM custom_variable_configs WHERE id = ?|, conv_i($params{id})); - - $dbh->commit(); - - $main::lxdebug->leave_sub(); -} - sub get_custom_variables { $main::lxdebug->enter_sub(); @@ -191,21 +100,15 @@ sub get_custom_variables { my $trans_id = $params{trans_id} ? 'OR (v.trans_id = ?) ' : ''; - my $q_cfg = - qq|SELECT id, name, description, type, default_value, options, - date_trunc('seconds', localtimestamp) AS current_timestamp, current_date AS current_date - FROM custom_variable_configs - WHERE module = ? - ORDER BY sortkey|; + my $sub_module = $params{sub_module} ? $params{sub_module} : ''; my $q_var = qq|SELECT text_value, timestamp_value, timestamp_value::date AS date_value, number_value, bool_value FROM custom_variables - WHERE (config_id = ?) AND (trans_id = ?)|; - $q_var .= qq| AND (sub_module = ?)| if $params{sub_module}; + WHERE (config_id = ?) AND (trans_id = ?) AND (sub_module = ?)|; my $h_var = prepare_query($form, $dbh, $q_var); - my $custom_variables = selectall_hashref_query($form, $dbh, $q_cfg, $params{module}); + my $custom_variables = $self->get_configs(module => $params{module}); foreach my $cvar (@{ $custom_variables }) { if ($cvar->{type} eq 'textfield') { @@ -225,26 +128,30 @@ sub get_custom_variables { $cvar->{OPTIONS} = [ map { { 'value' => $_ } } split(m/\#\#/, $cvar->{options}) ]; } - my $act_var; + my ($act_var, $valid); if ($params{trans_id}) { - my @values = (conv_i($cvar->{id}), conv_i($params{trans_id})); - push @values, $params{sub_module} if $params{sub_module}; + my @values = (conv_i($cvar->{id}), conv_i($params{trans_id}), $sub_module); do_statement($form, $h_var, $q_var, @values); $act_var = $h_var->fetchrow_hashref(); - $act_var->{valid} = $self->get_custom_variables_validity(config_id => $cvar->{id}, trans_id => $params{trans_id}); + $valid = $self->get_custom_variables_validity(config_id => $cvar->{id}, trans_id => $params{trans_id}); + } else { + $valid = !$cvar->{flag_defaults_to_invalid}; } if ($act_var) { $cvar->{value} = $cvar->{type} eq 'date' ? $act_var->{date_value} : $cvar->{type} eq 'timestamp' ? $act_var->{timestamp_value} : $cvar->{type} eq 'number' ? $act_var->{number_value} + : $cvar->{type} eq 'customer' ? $act_var->{number_value} + : $cvar->{type} eq 'vendor' ? $act_var->{number_value} + : $cvar->{type} eq 'part' ? $act_var->{number_value} : $cvar->{type} eq 'bool' ? $act_var->{bool_value} : $act_var->{text_value}; - $cvar->{valid} = $act_var->{valid}; + $cvar->{valid} = $valid; } else { - $cvar->{valid} = 1; + $cvar->{valid} = $valid // 1; if ($cvar->{type} eq 'date') { if ($cvar->{default_value} eq 'NOW') { @@ -273,6 +180,15 @@ sub get_custom_variables { if ($cvar->{type} eq 'number') { $cvar->{value} = $form->format_amount($myconfig, $cvar->{value} * 1, $cvar->{precision}); + } elsif ($cvar->{type} eq 'customer') { + require SL::DB::Customer; + $cvar->{value} = SL::DB::Manager::Customer->find_by(id => $cvar->{value} * 1); + } elsif ($cvar->{type} eq 'vendor') { + require SL::DB::Vendor; + $cvar->{value} = SL::DB::Manager::Vendor->find_by(id => $cvar->{value} * 1); + } elsif ($cvar->{type} eq 'part') { + require SL::DB::Part; + $cvar->{value} = SL::DB::Manager::Part->find_by(id => $cvar->{value} * 1); } } @@ -334,20 +250,24 @@ sub save_custom_variables { } elsif ($config->{type} eq 'bool') { push @values, $value ? 't' : 'f', undef, undef, undef; + } elsif (any { $config->{type} eq $_ } qw(customer vendor part)) { + push @values, undef, undef, undef, $value * 1; } do_statement($form, $sth, $query, @values); - unless ($params{always_valid}) { - $self->save_custom_variables_validity(trans_id => $params{trans_id}, config_id => $config->{id}, - validity => ($params{variables}->{"$params{name_prefix}cvar_$config->{name}$params{name_postfix}_valid"} ? 1 : 0) - ); - }; + if ($params{save_validity}) { + my $valid_index = "$params{name_prefix}cvar_$config->{name}$params{name_postfix}_valid"; + $self->save_custom_variables_validity(trans_id => $params{trans_id}, + config_id => $config->{id}, + validity => ($params{variables}{$valid_index} || $params{always_valid} ? 1 : 0) + ); + } } $sth->finish(); - $dbh->commit(); + $dbh->commit() unless $params{dbh}; $main::lxdebug->leave_sub(); } @@ -363,13 +283,20 @@ sub render_inputs { my $myconfig = \%main::myconfig; my $form = $main::form; - my %options = ( name_prefix => "$params{name_prefix}", - name_postfix => "$params{name_postfix}", - hide_non_editable => $params{hide_non_editable}, + my %options = ( name_prefix => "$params{name_prefix}", + name_postfix => "$params{name_postfix}", + hide_non_editable => $params{hide_non_editable}, show_disabled_message => $params{show_disabled_message}, ); + # should this cvar be filtered by partsgroups? foreach my $var (@{ $params{variables} }) { + if ($var->{flag_partsgroup_filter}) { + if (!$params{partsgroup_id} || (!grep {$params{partsgroup_id} == $_} @{ $var->{partsgroups} })) { + $var->{partsgroup_filtered} = 1; + } + } + $var->{HTML_CODE} = $form->parse_html_template('amcvar/render_inputs', { var => $var, %options }); $var->{VALID_BOX} = $form->parse_html_template('amcvar/render_checkboxes', { var => $var, %options }); } @@ -392,6 +319,7 @@ sub render_search_options { $params{include_prefix} = 'l_' unless defined($params{include_prefix}); $params{include_value} ||= '1'; + $params{filter_prefix} ||= ''; my $filter = $form->parse_html_template('amcvar/search_filter', \%params); my $include = $form->parse_html_template('amcvar/search_include', \%params); @@ -487,6 +415,17 @@ sub build_filter_query { $not = 'NOT' if ($params{filter}->{$name} eq 'no'); push @sub_where, qq|COALESCE(cvar.bool_value, false) = TRUE|; + } elsif (any { $config->{type} eq $_ } qw(customer vendor)) { + next unless $params{filter}->{$name}; + + my $table = $config->{type}; + push @sub_where, qq|cvar.number_value * 1 IN (SELECT id FROM $table WHERE name ILIKE ?)|; + push @sub_values, "%$params{filter}->{$name}%"; + } elsif ($config->{type} eq 'part') { + next unless $params{filter}->{$name}; + + push @sub_where, qq|cvar.number_value * 1 IN (SELECT id FROM parts WHERE partnumber ILIKE ?)|; + push @sub_values, "%$params{filter}->{$name}%"; } if (@sub_where) { @@ -560,6 +499,9 @@ sub add_custom_variables_to_report { $cfg->{type} eq 'date' ? $ref->{date_value} : $cfg->{type} eq 'timestamp' ? $ref->{timestamp_value} : $cfg->{type} eq 'number' ? $form->format_amount($myconfig, $ref->{number_value} * 1, $cfg->{precision}) + : $cfg->{type} eq 'customer' ? (SL::DB::Manager::Customer->find_by(id => 1*$ref->{number_value}) || SL::DB::Customer->new)->name + : $cfg->{type} eq 'vendor' ? (SL::DB::Manager::Vendor->find_by(id => 1*$ref->{number_value}) || SL::DB::Vendor->new)->name + : $cfg->{type} eq 'part' ? (SL::DB::Manager::Part->find_by(id => 1*$ref->{number_value}) || SL::DB::Part->new)->partnumber : $cfg->{type} eq 'bool' ? ($ref->{bool_value} ? $locale->text('Yes') : $locale->text('No')) : $ref->{text_value}; } @@ -633,8 +575,8 @@ sub save_custom_variables_validity { my $sth = prepare_query($form, $dbh, $query); unless ($params{validity}) { - foreach my $config_id (listify $params{config_id}) { - foreach my $trans_id (listify $params{trans_id}) { + foreach my $config_id (listify($params{config_id})) { + foreach my $trans_id (listify($params{trans_id})) { do_statement($form, $sth, $query, conv_i($config_id), conv_i($trans_id)); } } @@ -642,7 +584,7 @@ sub save_custom_variables_validity { $sth->finish(); - $dbh->commit(); + $dbh->commit() unless $params{dbh}; $main::lxdebug->leave_sub(); } @@ -660,7 +602,7 @@ sub get_custom_variables_validity { my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); - my $query = qq|SELECT COUNT(*) FROM custom_variables_validity WHERE config_id = ? AND trans_id = ?|; + my $query = qq|SELECT id FROM custom_variables_validity WHERE config_id = ? AND trans_id = ? LIMIT 1|; my ($invalid) = selectfirst_array_query($form, $dbh, $query, conv_i($params{config_id}), conv_i($params{trans_id})); @@ -669,6 +611,49 @@ sub get_custom_variables_validity { return !$invalid; } +sub custom_variables_validity_by_trans_id { + $main::lxdebug->enter_sub(2); + + my $self = shift; + my %params = @_; + + return sub { 0 } unless $params{trans_id}; + + my $myconfig = \%main::myconfig; + my $form = $main::form; + + my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); + + my $query = qq|SELECT DISTINCT config_id FROM custom_variables_validity WHERE trans_id = ?|; + + my %invalids = map { +($_->{config_id} => 1) } selectall_hashref_query($form, $dbh, $query, $params{trans_id}); + + $main::lxdebug->leave_sub(2); + + return sub { !$invalids{+shift} }; +} + +sub parse { + my ($self, $value, $config) = @_; + + return $::form->parse_amount(\%::myconfig, $value) if $config->{type} eq 'number'; + return DateTime->from_lxoffice($value) if $config->{type} eq 'date'; + return !ref $value ? SL::DB::Manager::Customer->find_by(id => $value * 1) : $value if $config->{type} eq 'customer'; + return !ref $value ? SL::DB::Manager::Vendor->find_by(id => $value * 1) : $value if $config->{type} eq 'vendor'; + return !ref $value ? SL::DB::Manager::Part->find_by(id => $value * 1) : $value if $config->{type} eq 'part'; + return $value; +} + +sub format_to_template { + my ($self, $value, $config) = @_; + # stupid template expects everything formated. except objects + # do not use outside of print routines for legacy templates + + return $::form->format_amount(\%::myconfig, $value) if $config->{type} eq 'number'; + return $value->to_lxoffice if $config->{type} eq 'date' && blessed $value && $value->can('to_lxoffice'); + return $value; +} + 1; __END__ @@ -682,10 +667,6 @@ SL::CVar.pm - Custom Variables module # dealing with configs my $all_configs = CVar->get_configs() - my $config = CVar->get_config(id => '1234') - - CVar->save_config($config); - CVar->delete->config($config) # dealing with custom vars