X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FController%2FCsvImport%2FOrder.pm;h=e26421bd881b031f18d2ce88349957384c11a5d0;hb=03ba13d2594f31e7af5eb3868435495c750ef1cb;hp=c3c5c5c87d788246a93a724d839f15d4d95ea037;hpb=2d902bf3b65f7ae1dc502ce809ed1c08c81d17be;p=kivitendo-erp.git diff --git a/SL/Controller/CsvImport/Order.pm b/SL/Controller/CsvImport/Order.pm index c3c5c5c87..e26421bd8 100644 --- a/SL/Controller/CsvImport/Order.pm +++ b/SL/Controller/CsvImport/Order.pm @@ -26,7 +26,7 @@ use parent qw(SL::Controller::CsvImport::BaseMulti); use Rose::Object::MakeMethods::Generic ( - 'scalar --get_set_init' => [ qw(settings languages_by parts_by contacts_by ct_shiptos_by price_factors_by pricegroups_by units_by) ], + 'scalar --get_set_init' => [ qw(settings languages_by all_parts parts_by part_counts_by contacts_by ct_shiptos_by price_factors_by pricegroups_by units_by) ], ); @@ -133,9 +133,11 @@ sub setup_displayable_columns { { name => 'taxincluded', description => $::locale->text('Tax Included') }, { name => 'customer', description => $::locale->text('Customer (name)') }, { name => 'customernumber', description => $::locale->text('Customer Number') }, + { name => 'customer_gln', description => $::locale->text('Customer GLN') }, { name => 'customer_id', description => $::locale->text('Customer (database ID)') }, { name => 'vendor', description => $::locale->text('Vendor (name)') }, { name => 'vendornumber', description => $::locale->text('Vendor Number') }, + { name => 'vendor_gln', description => $::locale->text('Vendor GLN') }, { name => 'vendor_id', description => $::locale->text('Vendor (database ID)') }, { name => 'language_id', description => $::locale->text('Language (database ID)') }, { name => 'language', description => $::locale->text('Language (name)') }, @@ -160,6 +162,7 @@ sub setup_displayable_columns { { name => 'cusordnumber', description => $::locale->text('Customer Order Number') }, { name => 'description', description => $::locale->text('Description') }, { name => 'discount', description => $::locale->text('Discount') }, + { name => 'ean', description => $::locale->text('EAN') }, { name => 'lastcost', description => $::locale->text('Lastcost') }, { name => 'longdescription', description => $::locale->text('Long Description') }, { name => 'marge_percent', description => $::locale->text('Margepercent') }, @@ -191,11 +194,27 @@ sub init_languages_by { return { map { my $col = $_; ( $col => { map { ( $_->$col => $_ ) } @{ $self->all_languages } } ) } qw(id description article_code) }; } +sub init_all_parts { + my ($self) = @_; + + return SL::DB::Manager::Part->get_all; +} + sub init_parts_by { my ($self) = @_; - my $all_parts = SL::DB::Manager::Part->get_all; - return { map { my $col = $_; ( $col => { map { ( $_->$col => $_ ) } @{ $all_parts } } ) } qw(id partnumber ean description) }; + return { map { my $col = $_; ( $col => { map { ( $_->$col => $_ ) } @{ $self->all_parts } } ) } qw(id partnumber ean description) }; +} + +sub init_part_counts_by { + my ($self) = @_; + + my $part_counts_by; + + $part_counts_by->{ean}-> {$_->ean}++ for @{ $self->all_parts }; + $part_counts_by->{description}->{$_->description}++ for @{ $self->all_parts }; + + return $part_counts_by; } sub init_contacts_by { @@ -300,10 +319,10 @@ sub handle_order { my $object = $entry->{object}; my $vc_obj; - if (any { $entry->{raw_data}->{$_} } qw(customer customernumber customer_id)) { + if (any { $entry->{raw_data}->{$_} } qw(customer customernumber customer_gln customer_id)) { $self->check_vc($entry, 'customer_id'); $vc_obj = SL::DB::Customer->new(id => $object->customer_id)->load if $object->customer_id; - } elsif (any { $entry->{raw_data}->{$_} } qw(vendor vendornumber vendor_id)) { + } elsif (any { $entry->{raw_data}->{$_} } qw(vendor vendornumber vendor_gln vendor_id)) { $self->check_vc($entry, 'vendor_id'); $vc_obj = SL::DB::Vendor->new(id => $object->vendor_id)->load if $object->vendor_id; } else { @@ -325,6 +344,7 @@ sub handle_order { foreach (qw(payment_id delivery_term_id language_id taxzone_id currency_id)) { $object->$_($vc_obj->$_) unless $object->$_; } + $object->intnotes($vc_obj->notes) unless $object->intnotes; } $self->handle_salesman($entry); @@ -372,6 +392,7 @@ sub handle_item { $self->handle_unit($entry); $self->handle_sellprice($entry); + $self->handle_discount($entry); # copy from part if not given $object->description($part_obj->description) unless $object->description; @@ -379,7 +400,6 @@ sub handle_item { $object->lastcost($part_obj->lastcost) unless defined $object->lastcost; # set to 0 if not given - $object->discount(0) unless $object->discount; $object->ship(0) unless $object->ship; $self->check_project($entry, global => 0); @@ -429,10 +449,20 @@ sub handle_sellprice { } } +sub handle_discount { + my ($self, $entry) = @_; + + my $object = $entry->{object}; + + $object->discount($object->discount/100.0) if $object->discount; + $object->discount(0) unless $object->discount; +} + sub check_part { my ($self, $entry) = @_; my $object = $entry->{object}; + my $is_ambiguous; # Check whether or not part ID is valid. if ($object->parts_id && !$self->parts_by->{id}->{ $object->parts_id }) { @@ -459,13 +489,36 @@ sub check_part { return 0; } - $object->parts_id($part->id); + if ($self->part_counts_by->{description}->{ $entry->{raw_data}->{description} } > 1) { + $is_ambiguous = 1; + } else { + $object->parts_id($part->id); + } + } + + # Map ean to ID if given. + if (!$object->parts_id && $entry->{raw_data}->{ean}) { + my $part = $self->parts_by->{ean}->{ $entry->{raw_data}->{ean} }; + if (!$part) { + push @{ $entry->{errors} }, $::locale->text('Error: Invalid part'); + return 0; + } + + if ($self->part_counts_by->{ean}->{ $entry->{raw_data}->{ean} } > 1) { + $is_ambiguous = 1; + } else { + $object->parts_id($part->id); + } } if ($object->parts_id) { $entry->{info_data}->{partnumber} = $self->parts_by->{id}->{ $object->parts_id }->partnumber; } else { - push @{ $entry->{errors} }, $::locale->text('Error: Part not found'); + if ($is_ambiguous) { + push @{ $entry->{errors} }, $::locale->text('Error: Part is ambiguous'); + } else { + push @{ $entry->{errors} }, $::locale->text('Error: Part not found'); + } return 0; }