X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FController%2FRequirementSpec.pm;h=68969e61b31e2bcc209a059b73e28f87facab170;hb=5e55cce6abaf16fb9425bcdc5a669eaaddca3319;hp=fc5a81562f7802f7a2ce083ff47a13394ca869bb;hpb=237aee7f7b1ed637b3e329e575887f5d4015ee7d;p=kivitendo-erp.git diff --git a/SL/Controller/RequirementSpec.pm b/SL/Controller/RequirementSpec.pm index fc5a81562..68969e61b 100644 --- a/SL/Controller/RequirementSpec.pm +++ b/SL/Controller/RequirementSpec.pm @@ -7,7 +7,6 @@ use parent qw(SL::Controller::Base); use File::Spec (); -use SL::ClientJS; use SL::Common (); use SL::Controller::Helper::GetModels; use SL::Controller::Helper::ReportGenerator; @@ -21,6 +20,7 @@ use SL::DB::RequirementSpecRisk; use SL::DB::RequirementSpecStatus; use SL::DB::RequirementSpecType; use SL::DB::RequirementSpec; +use SL::Helper::CreatePDF qw(); use SL::Helper::Flash; use SL::Locale::String; use SL::Template::LaTeX; @@ -28,11 +28,12 @@ use SL::Template::LaTeX; use Rose::Object::MakeMethods::Generic ( scalar => [ qw(requirement_spec_item visible_item visible_section) ], - 'scalar --get_set_init' => [ qw(requirement_spec customers types statuses complexities risks projects project_types project_statuses default_project_type default_project_status copy_source js - current_text_block_output_position models) ], + 'scalar --get_set_init' => [ qw(requirement_spec customers types statuses complexities risks projects project_types project_statuses default_project_type default_project_status copy_source + current_text_block_output_position models time_based_units html_template cvar_configs includeable_cvar_configs include_cvars) ], ); __PACKAGE__->run_before('setup'); +__PACKAGE__->run_before('set_default_filter_args', only => [ qw(list) ]); my %sort_columns = ( customer => t8('Customer'), @@ -62,7 +63,7 @@ sub action_new { $self->requirement_spec(SL::DB::RequirementSpec->new(is_template => $::form->{is_template})); if ($self->copy_source) { - $self->requirement_spec->$_($self->copy_source->$_) for qw(type_id status_id customer_id title hourly_rate) + $self->requirement_spec->$_($self->copy_source->$_) for qw(type_id status_id customer_id title hourly_rate is_template) } $self->render('requirement_spec/new', title => $self->requirement_spec->is_template ? t8('Create a new requirement spec template') : t8('Create a new requirement spec')); @@ -82,7 +83,7 @@ sub action_ajax_edit { $self->js ->hide('#basic_settings') ->after('#basic_settings', $html) - ->render($self); + ->render; } sub action_ajax_edit_project_link { @@ -93,7 +94,7 @@ sub action_ajax_edit_project_link { $self->js ->hide('#basic_settings') ->after('#basic_settings', $html) - ->render($self); + ->render; } sub action_ajax_show_time_and_cost_estimate { @@ -114,13 +115,13 @@ sub action_ajax_edit_time_and_cost_estimate { ->after('#time_cost_estimate', $html) ->on('#time_cost_estimate INPUT[type=text]', 'keydown', 'kivi.requirement_spec.time_cost_estimate_input_key_down') ->action_if($first && $first->id, 'focus', '#time_and_cost_estimate_form_complexity_id_' . $first->id) - ->render($self); + ->render; } sub action_ajax_save_time_and_cost_estimate { my ($self) = @_; - $self->requirement_spec->db->do_transaction(sub { + $self->requirement_spec->db->with_transaction(sub { # Make Emacs happy 1; foreach my $attributes (@{ $::form->{requirement_spec_items} || [] }) { @@ -138,7 +139,7 @@ sub action_ajax_save_time_and_cost_estimate { my $html = $self->render('requirement_spec/_show_time_and_cost_estimate', { output => 0 }, initially_hidden => !!$::form->{keep_open}); $self->js->replaceWith('#time_cost_estimate', $html); - return $self->js->render($self) if $::form->{keep_open}; + return $self->js->render if $::form->{keep_open}; $self->js->remove('#time_cost_estimate_form_container'); @@ -147,7 +148,7 @@ sub action_ajax_save_time_and_cost_estimate { $self->js->html('#column-content', $html); } - $self->js->render($self); + $self->js->render; } sub action_show { @@ -198,7 +199,7 @@ sub action_destroy { sub action_revert_to { my ($self, %params) = @_; - return $self->js->error(t8('Cannot revert a versioned copy.'))->render($self) if $self->requirement_spec->working_copy_id; + return $self->js->error(t8('Cannot revert a versioned copy.'))->render if $self->requirement_spec->working_copy_id; my $versioned_copy = SL::DB::RequirementSpec->new(id => $::form->{versioned_copy_id})->load; @@ -206,8 +207,8 @@ sub action_revert_to { my $version = $versioned_copy->versions->[0]; $version->update_attributes(working_copy_id => $self->requirement_spec->id); - flash_later('info', t8('The requirement spec has been reverted to version #1.', $self->requirement_spec->version->version_number)); - $self->js->redirect_to($self->url_for(action => 'show', id => $self->requirement_spec->id))->render($self); + flash_later('info', t8('The requirement spec has been reverted to version #1.', $versioned_copy->version->version_number)); + $self->js->redirect_to($self->url_for(action => 'show', id => $self->requirement_spec->id))->render; } sub action_create_pdf { @@ -230,10 +231,34 @@ sub action_create_pdf { unlink $result{file_name}; } +sub action_create_html { + my ($self, %params) = @_; + + my $base_name = $self->requirement_spec->type->template_file_name || 'requirement_spec'; + my @pictures = $self->prepare_pictures_for_printing; + my $content = SL::Helper::CreatePDF->create_parsed_file( + template => "${base_name}.html", + format => 'html', + template_type => 'HTML', + variables => { + SELF => $self, + rspec => $self->requirement_spec, + }); + + # $content is now a scalar of bytes, but $self->render() expects a + # scalar of characters. + $content = Encode::decode('utf-8', $content); + + $self->render(\$content, { layout => 0, process => 0 }); +} + sub action_select_template_to_paste { my ($self) = @_; - my @templates = grep { @{ $_->sections } || @{ $_->text_blocks } } @{ SL::DB::Manager::RequirementSpec->get_all(where => [ is_template => 1 ], sort_by => 'lower(title)') }; + my @templates = @{ SL::DB::Manager::RequirementSpec->get_all( + where => [ is_template => 1, SL::DB::Manager::RequirementSpec->not_empty_filter ], + sort_by => 'lower(requirement_specs.title)', + ) }; $self->render('requirement_spec/select_template_to_paste', { layout => 0 }, TEMPLATES => \@templates); } @@ -243,7 +268,7 @@ sub action_paste_template { my $template = SL::DB::RequirementSpec->new(id => $::form->{template_id})->load; my %result = $self->requirement_spec->paste_template($template); - return $self->js->error($self->requirement_spec->error)->render($self) if !%result; + return $self->js->error($self->requirement_spec->error)->render if !%result; $self->render_pasted_text_block($_) for sort { $a->position <=> $b->position } @{ $result{text_blocks} }; $self->render_pasted_section($_) for sort { $a->position <=> $b->position } @{ $result{sections} }; @@ -252,7 +277,40 @@ sub action_paste_template { $self->render_first_pasted_section_as_list($result{sections}->[0]); } - $self->invalidate_version->render($self); + my $parts_list = $self->render('requirement_spec_part/show', { output => 0 }); + $self->js + ->replaceWith('#additional_parts_list_container', $parts_list) + ->show( '#additional_parts_list_container') + ->remove( '#additional_parts_form_container'); + + $self->invalidate_version->render; +} + +sub action_renumber_sections { + my ($self) = @_; + + my %numbers = map { ($_ => 1) } qw(section function_block); + my %formats = map { my $method = "${_}_number_format"; ($_ => $self->requirement_spec->type->$method) } qw(section function_block); + my @items = @{ $self->requirement_spec->sections_sorted }; + + $self->requirement_spec->db->with_transaction(sub { + while (@items) { + my $item = shift @items; + my $type = $item->parent_id ? 'function_block' : 'section'; + + $item->update_attributes(fb_number => SL::PrefixedNumber->new(number => $formats{$type} || 0)->set_to($numbers{$type})); + + $numbers{$type}++; + + unshift @items, @{ $item->children_sorted }; + } + + $self->requirement_spec->invalidate_version unless $self->requirement_spec->is_template; + + 1; + }); + + $self->redirect_to(action => 'show', id => $self->requirement_spec->id); } # @@ -264,13 +322,12 @@ sub setup { $::auth->assert('requirement_spec_edit'); $::request->{layout}->use_stylesheet("${_}.css") for qw(jquery.contextMenu requirement_spec); - $::request->{layout}->use_javascript("${_}.js") for qw(jquery.jstree jquery/jquery.contextMenu jquery/jquery.hotkeys requirement_spec ckeditor/ckeditor ckeditor/adapters/jquery); + $::request->{layout}->use_javascript("${_}.js") for qw(jquery.jstree jquery/jquery.contextMenu jquery/jquery.hotkeys requirement_spec ckeditor/ckeditor ckeditor/adapters/jquery autocomplete_part autocomplete_customer); $self->init_visible_section; return 1; } -sub init_js { SL::ClientJS->new } sub init_complexities { SL::DB::Manager::RequirementSpecComplexity->get_all_sorted } sub init_default_project_status { SL::DB::Manager::ProjectStatus->find_by(name => 'planning') } sub init_default_project_type { SL::DB::ProjectType->new(id => 1)->load } @@ -279,7 +336,9 @@ sub init_project_types { SL::DB::Manager::ProjectType->get_all_sorted sub init_projects { SL::DB::Manager::Project->get_all_sorted } sub init_risks { SL::DB::Manager::RequirementSpecRisk->get_all_sorted } sub init_statuses { SL::DB::Manager::RequirementSpecStatus->get_all_sorted } +sub init_time_based_units { SL::DB::Manager::Unit->time_based_units } sub init_types { SL::DB::Manager::RequirementSpecType->get_all_sorted } +sub init_cvar_configs { SL::DB::Manager::CustomVariableConfig->get_all_sorted(where => [ module => 'RequirementSpecs' ]) } sub init_customers { my ($self) = @_; @@ -305,6 +364,17 @@ sub init_current_text_block_output_position { $self->current_text_block_output_position($::form->{current_content_type} !~ m/^(?:text-blocks|tb)-(front|back)/ ? -1 : $1 eq 'front' ? 0 : 1); } +sub init_includeable_cvar_configs { + my ($self) = @_; + return [ grep { $_->includeable } @{ $self->cvar_configs } ]; +} + +sub init_include_cvars { + my ($self) = @_; + return $::form->{include_cvars} if $::form->{include_cvars} && (ref($::form->{include_cvars}) eq 'HASH'); + return { map { ($_->name => ($_->includeable && $_->included_by_default)) } @{ $self->cvar_configs } }; +} + # # helpers # @@ -313,9 +383,24 @@ sub create_or_update { my $self = shift; my $is_new = !$self->requirement_spec->id; my $params = delete($::form->{requirement_spec}) || { }; + my $cvars = delete($::form->{cvars}) || { }; + + # Forcefully make it clear to Rose which custom_variables exist (or don't), so that the ones added with »add_custom_variables« are visible when calling »custom_variables«. + if ($is_new) { + $params->{custom_variables} = []; + } else { + $self->requirement_spec->custom_variables; + } $self->requirement_spec->assign_attributes(%{ $params }); + foreach my $var (@{ $self->requirement_spec->cvars_by_config }) { + my $value = $cvars->{ $var->config->name }; + $value = $::form->parse_amount(\%::myconfig, $value) if $var->config->type eq 'number'; + + $var->value($value); + } + my $title = $is_new && $self->requirement_spec->is_template ? t8('Create a new requirement spec template') : $is_new ? t8('Create a new requirement spec') : $self->requirement_spec->is_template ? t8('Edit requirement spec template') @@ -324,7 +409,7 @@ sub create_or_update { my @errors = $self->requirement_spec->validate; if (@errors) { - return $self->js->error(@errors)->render($self) if $::request->is_ajax; + return $self->js->error(@errors)->render if $::request->is_ajax; flash('error', @errors); $self->render('requirement_spec/new', title => $title); @@ -332,16 +417,17 @@ sub create_or_update { } my $db = $self->requirement_spec->db; - if (!$db->do_transaction(sub { + if (!$db->with_transaction(sub { if ($self->copy_source) { $self->requirement_spec($self->copy_source->create_copy(%{ $params })); } else { - $self->requirement_spec->save; + $self->requirement_spec->save(cascade => 1); } + 1; })) { $::lxdebug->message(LXDebug::WARN(), "Error: " . $db->error); @errors = ($::locale->text('Saving failed. Error message from the database: #1', $db->error)); - return $self->js->error(@errors)->render($self) if $::request->is_ajax; + return $self->js->error(@errors)->render if $::request->is_ajax; $self->requirement_spec->id(undef) if $is_new; flash('error', @errors); @@ -358,7 +444,7 @@ sub create_or_update { ->replaceWith('#basic_settings', $basics_html) ->remove('#basic_settings_form') ->flash('info', $info) - ->render($self); + ->render; } flash_later('info', $info); @@ -398,7 +484,21 @@ sub prepare_report { ); } - map { $column_defs{$_}->{text} ||= $::locale->text( $self->models->get_sort_spec->{$_}->{title} ) } keys %column_defs; + $column_defs{$_}->{text} ||= $::locale->text( $self->models->get_sort_spec->{$_}->{title} ) for keys %column_defs; + + if (!$is_template) { + my %cvar_column_defs = map { + my $cfg = $_; + (('cvar_' . $cfg->name) => { + sub => sub { my $var = $_[0]->cvar_by_name($cfg->name); $var ? $var->value_as_text : '' }, + text => $cfg->description, + visible => $self->include_cvars->{ $cfg->name } ? 1 : 0, + }) + } @{ $self->includeable_cvar_configs }; + + push @columns, map { 'cvar_' . $_->name } @{ $self->includeable_cvar_configs }; + %column_defs = (%column_defs, %cvar_column_defs); + } $report->set_options( std_column_visibility => 1, @@ -446,6 +546,18 @@ sub render_pasted_text_block { ->jstree->open_node( '#tree', "#tb-${front_back}"); } +sub set_default_filter_args { + my ($self) = @_; + + if (!$::form->{filter} && !$::form->{is_template}) { + $::form->{filter} = { + status_id => [ map { $_->{id} } grep { $_->name ne 'done' } @{ $self->statuses } ], + }; + } + + return 1; +} + sub render_pasted_section { my ($self, $item, $parent_id) = @_; @@ -499,7 +611,7 @@ sub update_project_link_none_keep_existing { ->replaceWith('#basic_settings', $self->render('requirement_spec/_show_basic_settings', { output => 0 })) ->remove('#project_link_form') ->flash('info', t8('The project link has been updated.')) - ->render($self); + ->render; } sub update_project_link_new { @@ -507,7 +619,7 @@ sub update_project_link_new { return $self->js ->replaceWith('#project_link_form', $self->render('requirement_spec/_new_project_form', { output => 0 })) - ->render($self); + ->render; } sub update_project_link_create { @@ -521,16 +633,16 @@ sub update_project_link_create { my @errors = $project->validate; - return $self->js->error(@errors)->render($self) if @errors; + return $self->js->error(@errors)->render if @errors; my $db = $self->requirement_spec->db; - if (!$db->do_transaction(sub { + if (!$db->with_transaction(sub { $project->save; $self->requirement_spec->update_attributes(project_id => $project->id); })) { $::lxdebug->message(LXDebug::WARN(), "Error: " . $db->error); - return $self->js->error(t8('Saving failed. Error message from the database: #1', $db->error))->render($self); + return $self->js->error(t8('Saving failed. Error message from the database: #1', $db->error))->render; } return $self->invalidate_version @@ -538,7 +650,7 @@ sub update_project_link_create { ->remove('#project_link_form') ->flash('info', t8('The project has been created.')) ->flash('info', t8('The project link has been updated.')) - ->render($self); + ->render; } sub init_models { @@ -563,4 +675,11 @@ sub init_models { ); } +sub init_html_template { + my ($self) = @_; + my $base_name = $self->requirement_spec->type->template_file_name || 'requirement_spec'; + my $template = SL::Helper::CreatePDF->find_template(name => $base_name, extension => 'html'); + return !!$template; +} + 1;