X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDB%2FDeliveryOrder.pm;h=45d658876023f2efbe8890d5008e3cf09682b6e2;hb=2b9a68bb2041ebde41a7c52db436efc8dde06350;hp=411132bc4f4bc4bc774ab15bb74a6bad3cf53d5f;hpb=1f2a5b4c5f9ed16e455971d139cf5a1a14212228;p=kivitendo-erp.git diff --git a/SL/DB/DeliveryOrder.pm b/SL/DB/DeliveryOrder.pm index 411132bc4..45d658876 100644 --- a/SL/DB/DeliveryOrder.pm +++ b/SL/DB/DeliveryOrder.pm @@ -17,10 +17,12 @@ use SL::DB::Helper::TransNumberGenerator; use SL::DB::Part; use SL::DB::Unit; +use SL::DB::DeliveryOrder::TypeData qw(:types); + use SL::Helper::Number qw(_format_total _round_total); use List::Util qw(first); -use List::MoreUtils qw(any); +use List::MoreUtils qw(any pairwise); use Math::Round qw(nhimult); __PACKAGE__->meta->add_relationship(orderitems => { type => 'one to many', @@ -77,7 +79,11 @@ sub sales_order { } sub type { - return shift->customer_id ? 'sales_delivery_order' : 'purchase_delivery_order'; + goto &order_type; +} + +sub is_type { + return shift->type eq shift; } sub displayable_type { @@ -105,6 +111,10 @@ sub date { goto &transdate; } +sub number { + goto &donumber; +} + sub _clone_orderitem_cvar { my ($cvar) = @_; @@ -127,11 +137,11 @@ sub new_from { } my %args = ( map({ ( $_ => $source->$_ ) } qw(cp_id currency_id customer_id cusordnumber delivery_term_id department_id employee_id globalproject_id intnotes language_id notes - ordnumber payment_id reqdate salesman_id shippingpoint shipvia taxincluded taxzone_id transaction_description vendor_id + ordnumber payment_id reqdate salesman_id shippingpoint shipvia taxincluded taxzone_id transaction_description vendor_id billing_address_id )), closed => 0, - is_sales => !!$source->customer_id, delivered => 0, + order_type => $params{type}, transdate => DateTime->today_local, ); @@ -146,12 +156,19 @@ sub new_from { $args{shipto_id} = $source->shipto_id; } + # infer type from legacy fields if not given + $args{order_type} //= $source->customer_id ? 'sales_delivery_order' + : $source->vendor_id ? 'purchase_delivery_order' + : $source->is_sales ? 'sales_delivery_order' + : croak "need some way to set delivery order type from source"; + my $delivery_order = $class->new(%args); $delivery_order->assign_attributes(%{ $params{attributes} }) if $params{attributes}; my $items = delete($params{items}) || $source->items_sorted; my %item_parents; - my @items = map { + # do not copy items when converting to supplier delivery order + my @items = $delivery_order->is_type(SUPPLIER_DELIVERY_ORDER_TYPE) ? () : map { my $source_item = $_; my $source_item_id = $_->$item_parent_id_column; my @custom_variables = map { _clone_orderitem_cvar($_) } @{ $source_item->custom_variables }; @@ -185,39 +202,31 @@ sub new_from_time_recordings { croak("Unsupported object type in sources") if any { ref($_) ne 'SL::DB::TimeRecording' } @$sources; croak("Cannot create delivery order from source records of different customers") if any { $_->customer_id != $sources->[0]->customer_id } @$sources; - my %args = ( - is_sales => 1, - delivered => 0, - customer_id => $sources->[0]->customer_id, - taxzone_id => $sources->[0]->customer->taxzone_id, - currency_id => $sources->[0]->customer->currency_id, - employee_id => SL::DB::Manager::Employee->current->id, - salesman_id => SL::DB::Manager::Employee->current->id, - items => [], - ); - my $delivery_order = $class->new(%args); - $delivery_order->assign_attributes(%{ $params{attributes} }) if $params{attributes}; - # - one item per part (article) # - qty is sum of duration # - description goes to item longdescription # - ordered and summed by date # - each description goes to an ordered list # - (as time recording descriptions are formatted text by now, use stripped text) - # - merge same descriptions (todo) + # - merge same descriptions # - ### config - my $default_partnummer = 6; - my $default_part_id = SL::DB::Manager::Part->find_by(partnumber => $default_partnummer)->id; + my $default_part_id = $params{default_part_id} ? $params{default_part_id} + : $params{default_partnumber} ? SL::DB::Manager::Part->find_by(partnumber => $params{default_partnumber})->id + : undef; + my $override_part_id = $params{override_part_id} ? $params{override_part_id} + : $params{override_partnumber} ? SL::DB::Manager::Part->find_by(partnumber => $params{override_partnumber})->id + : undef; # check parts and collect entries my %part_by_part_id; my $entries; foreach my $source (@$sources) { - my $part_id = $source->part_id ? $source->part_id - : $default_part_id ? $default_part_id - : undef; + next if !$source->duration; + + my $part_id = $override_part_id; + $part_id ||= $source->part_id; + $part_id ||= $default_part_id; die 'article not found for entry "' . $source->displayable_times . '"' if !$part_id; @@ -226,18 +235,21 @@ sub new_from_time_recordings { die 'article unit must be time based for entry "' . $source->displayable_times . '"' if !$part_by_part_id{$part_id}->unit_obj->is_time_based; } - my $date = $source->start_time->to_kivitendo; - $entries->{$part_id}->{$date}->{duration} += $source->{rounding} ? - nhimult(0.25, ($source->duration_in_hours)) - : _round_total($source->duration_in_hours); + my $date = $source->date->to_kivitendo; + $entries->{$part_id}->{$date}->{duration} += $params{rounding} + ? nhimult(0.25, ($source->duration_in_hours)) + : _round_total($source->duration_in_hours); # add content if not already in description - my $new_description = $source->description_as_stripped_html; + my $new_description = '' . $source->description_as_stripped_html; + $entries->{$part_id}->{$date}->{content} ||= ''; $entries->{$part_id}->{$date}->{content} .= '