X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDB%2FHelper%2FPriceTaxCalculator.pm;h=15850d558946b1bb748f4a6d14bb5af333f9cba8;hb=a6485c5822e13b6d0bda4bff0a003bfc569f778c;hp=a3c42d2e9bee457bbb164dc9c95a8a71daefc996;hpb=612d23d1bf4615b77a18c3f9e791e3f8ff75c38e;p=kivitendo-erp.git diff --git a/SL/DB/Helper/PriceTaxCalculator.pm b/SL/DB/Helper/PriceTaxCalculator.pm index a3c42d2e9..15850d558 100644 --- a/SL/DB/Helper/PriceTaxCalculator.pm +++ b/SL/DB/Helper/PriceTaxCalculator.pm @@ -29,7 +29,8 @@ sub calculate_prices_and_taxes { last_incex_chart_id => undef, units_by_name => \%units_by_name, price_factors_by_id => \%price_factors_by_id, - taxes => { }, + taxes_by_chart_id => { }, + taxes_by_tax_id => { }, amounts => { }, amounts_cogs => { }, allocated => { }, @@ -53,7 +54,7 @@ sub calculate_prices_and_taxes { $self->netamount( 0); $self->marge_total(0); - SL::DB::Manager::Chart->cache_taxkeys(date => $self->transdate); + SL::DB::Manager::Chart->cache_taxkeys(date => $self->effective_tax_point); my $idx = 0; foreach my $item (@{ $self->items_sorted }) { @@ -65,7 +66,7 @@ sub calculate_prices_and_taxes { return $self unless wantarray; - return map { ($_ => $data{$_}) } qw(taxes amounts amounts_cogs allocated exchangerate assembly_items items rounding); + return map { ($_ => $data{$_}) } qw(taxes_by_chart_id taxes_by_tax_id amounts amounts_cogs allocated exchangerate assembly_items items rounding); } sub _get_exchangerate { @@ -109,7 +110,7 @@ sub _calculate_item { $data->{invoicediff} += $sellprice * (1 - $item->discount) * $item->qty * $data->{exchangerate} / $item->price_factor - $linetotal if $self->taxincluded; - my $taxkey = $part->get_taxkey(date => $self->transdate, is_sales => $data->{is_sales}, taxzone => $self->taxzone_id); + my $taxkey = $part->get_taxkey(date => $self->effective_tax_point, is_sales => $data->{is_sales}, taxzone => $self->taxzone_id); my $tax_rate = $taxkey->tax->rate; my $tax_amount = undef; @@ -122,8 +123,10 @@ sub _calculate_item { } if ($taxkey->tax->chart_id) { - $data->{taxes}->{ $taxkey->tax->chart_id } ||= 0; - $data->{taxes}->{ $taxkey->tax->chart_id } += $tax_amount; + $data->{taxes_by_chart_id}->{ $taxkey->tax->chart_id } ||= 0; + $data->{taxes_by_chart_id}->{ $taxkey->tax->chart_id } += $tax_amount; + $data->{taxes_by_tax_id}->{ $taxkey->tax_id } ||= 0; + $data->{taxes_by_tax_id}->{ $taxkey->tax_id } += $tax_amount; } elsif ($tax_amount) { die "tax_amount != 0 but no chart_id for taxkey " . $taxkey->id . " tax " . $taxkey->tax->id; } @@ -180,10 +183,10 @@ sub _calculate_amounts { my ($self, $data, %params) = @_; my $tax_diff = 0; - foreach my $chart_id (keys %{ $data->{taxes} }) { - my $rounded = _round($data->{taxes}->{$chart_id} * $data->{exchangerate}, 2); - $tax_diff += $data->{taxes}->{$chart_id} * $data->{exchangerate} - $rounded if $self->taxincluded; - $data->{taxes}->{$chart_id} = $rounded; + foreach my $chart_id (keys %{ $data->{taxes_by_chart_id} }) { + my $rounded = _round($data->{taxes_by_chart_id}->{$chart_id} * $data->{exchangerate}, 2); + $tax_diff += $data->{taxes_by_chart_id}->{$chart_id} * $data->{exchangerate} - $rounded if $self->taxincluded; + $data->{taxes_by_chart_id}->{$chart_id} = $rounded; } $self->netamount(sum map { $_->{amount} } values %{ $data->{amounts} }); @@ -199,7 +202,7 @@ sub _calculate_amounts { _dbg("Sna " . $self->netamount . " idiff " . $data->{invoicediff} . " tdiff ${tax_diff}"); - my $tax = sum values %{ $data->{taxes} }; + my $tax = sum values %{ $data->{taxes_by_chart_id} }; $amount = $netamount + $tax; my $grossamount = _round($amount, 2, 1); $data->{rounding} = _round($grossamount - $amount, 2); @@ -335,9 +338,14 @@ In array context a hash with the following keys is returned: =over 2 -=item C +=item C A hash reference with the calculated taxes. The keys are chart IDs, +the values the rounded calculated taxes. + +=item C + +A hash reference with the calculated taxes. The keys are tax IDs, the values the calculated taxes. =item C