X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDB%2FOrderItem.pm;h=e7b9179f64592b97f9d8487e4440c369658a7363;hb=0e04ddd7e3ff23d051838617844698a39f680969;hp=862a215a15d4895dd7d6e12ac30c0a39d3a3a819;hpb=0845c4b7d7a969d68cd55a15780c0af2fbe4d2db;p=kivitendo-erp.git diff --git a/SL/DB/OrderItem.pm b/SL/DB/OrderItem.pm index 862a215a1..e7b9179f6 100644 --- a/SL/DB/OrderItem.pm +++ b/SL/DB/OrderItem.pm @@ -3,28 +3,28 @@ package SL::DB::OrderItem; use strict; use List::Util qw(sum); -use SL::AM; use SL::DB::MetaSetup::OrderItem; use SL::DB::Manager::OrderItem; +use SL::DB::DeliveryOrderItemsStock; +use SL::DB::Helper::ActsAsList; +use SL::DB::Helper::LinkedRecords; +use SL::DB::Helper::RecordItem; use SL::DB::Helper::CustomVariables ( sub_module => 'orderitems', cvars_alias => 1, overloads => { - parts_id => 'SL::DB::Part', - }, -); - -__PACKAGE__->meta->add_relationship( - unit_obj => { - type => 'many to one', - class => 'SL::DB::Unit', - column_map => { unit => 'name' }, + parts_id => { + class => 'SL::DB::Part', + module => 'IC', + } }, ); __PACKAGE__->meta->initialize; +__PACKAGE__->configure_acts_as_list(group_by => [qw(trans_id)]); + sub is_price_update_available { my $self = shift; return $self->origprice > $self->part->sellprice; @@ -33,10 +33,155 @@ sub is_price_update_available { sub shipped_qty { my ($self) = @_; - my $d_orders = $self->order->linked_records(direction => 'to', to => 'SL::DB::DeliveryOrder'); + my $d_orders = $self->order->linked_records(direction => 'to', to => 'SL::DB::DeliveryOrder', with_objects => [ 'orderitems' ]); my @doi = grep { $_->parts_id == $self->parts_id } map { $_->orderitems } @$d_orders; return sum(map { AM->convert_unit($_->unit => $self->unit) * $_->qty } @doi); } +sub linked_delivery_order_items { + my ($self) = @_; + + return $self->linked_records(direction => 'to', to => 'SL::DB::DeliveryOrderItem'); +} + +sub delivered_qty { + # checks for delivery_order_stock_id entries, which have been converted to inventory entries + # uses several rose relationships + # doesn't differentiate between sales and orders + + my ($self) = @_; + my $delivered_qty = 0; + foreach my $doi ( @{$self->linked_delivery_order_items} ) { + next unless scalar @{$doi->delivery_order_stock_entries}; + $delivered_qty += sum map { $_->inventory ? $_->qty : 0 } @{$doi->delivery_order_stock_entries}; + }; + return $delivered_qty; +}; + +sub delivered_qty_sql { + # checks for delivery_order_stock_id entries, which have been converted to inventory entries + my ($self) = @_; + +my $query = <db->dbh, $query, $self->id); + + return $delivered_qty; +}; + +sub delivered_qty_sql_multi { + # checks for delivery_order_stock_id entries, which have been converted to inventory entries + my ($self) = @_; + +my $query = <db->dbh, $query, $self->id); + + return $delivered_qty; +}; + +sub record { goto &order } + 1; + +__END__ + +=pod + +=head1 NAME + +SL::DB::OrderItems: Rose model for orderitems + +=head1 FUNCTIONS + +=over 4 + +=item C + +=item C + +returns the number of orderitems which are already linked to Delivery Orders. +The linked key is parts_id and not orderitems (id) -> delivery_order_items (id). +Therefore this function is not safe for identical parts_id. +Sample call: +C<$::form-Eformat_amount(\%::myconfig, $_[0]-Eshipped_qty);> + +=item C + +Returns the amount of this orderitem that has been delivered, meaning it +appears in a delivery order AND has been transferred. The delivery order items +are found by direct record_links from orderitems to delivery order items. +Delivery order items that were added manually and not via the record workflow +will therefore not be calculated correctly. + +Orders that were created before the individual items were linked (this feature +was added in kivitendo 3.2.0) will therefore return incorrect results. + +=item C + +Does the same as delivered_qty, but via sql. + + + +=item C + +Returns the amount of the orderitem that has actually been shipped, not just where delivery_order_items exist (how delivered_qty works). + +Doesn't deal with different units yet. + +=back + +=head1 TODO + +Older versions of OrderItem.pm had more functions which where used for calculating the +qty for the different states of the Delivery Order. +For example to get the qty in already marked as delivered Delivery Orders: + +C + +return $self-E_delivered_qty; + + sub _delivered_qty { + (..) + my @d_orders_delivered = grep { $_-Edelivered } @$d_orders; + my @doi_delivered = grep { $_-Eparts_id == $self-Eparts_id } map { $_-Eorderitems } @d_orders_delivered; + } + +In general the function C and all (project) related functions should be marked deprecate, + because of the better linked item to item data in the record_links table. + +=head1 AUTHORS + +G. Richardson Egrichardson@kivitendo-premium.deE + +=cut + +