X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDB%2FPeriodicInvoicesConfig.pm;h=8013cd94092e156de6d2a0a4cee0e4afd36bfc17;hb=44310118d55217b2456a2ceab51b14c0bfb77bbc;hp=9bd5e1d7e860b4a27b6ec75afc61cad2b1955742;hpb=66f46ee95d136a6815326740768d4d40ace5d579;p=kivitendo-erp.git

diff --git a/SL/DB/PeriodicInvoicesConfig.pm b/SL/DB/PeriodicInvoicesConfig.pm
index 9bd5e1d7e..8013cd940 100644
--- a/SL/DB/PeriodicInvoicesConfig.pm
+++ b/SL/DB/PeriodicInvoicesConfig.pm
@@ -60,30 +60,30 @@ sub handle_automatic_extension {
   return $end_date;
 }
 
-sub get_previous_invoice_date {
+sub get_previous_billed_period_start_date {
   my $self  = shift;
 
   my $query = <<SQL;
-    SELECT MAX(ar.transdate)
+    SELECT MAX(period_start_date)
     FROM periodic_invoices
-    LEFT JOIN ar ON (ar.id = periodic_invoices.ar_id)
-    WHERE periodic_invoices.config_id = ?
+    WHERE config_id = ?
 SQL
 
-  my ($max_transdate) = $self->dbh->selectrow_array($query, undef, $self->id);
+  my ($date) = $self->dbh->selectrow_array($query, undef, $self->id);
 
-  return undef unless $max_transdate;
-  return ref $max_transdate ? $max_transdate : $self->db->parse_date($max_transdate);
+  return undef unless $date;
+  return ref $date ? $date : $self->db->parse_date($date);
 }
 
 sub calculate_invoice_dates {
   my ($self, %params) = @_;
 
   my $period_len = $self->get_period_length;
-  my $cur_date   = $self->first_billing_date        || $self->start_date;
-  my $end_date   = $self->end_date                  || DateTime->today_local->add(years => 10);
-  my $start_date = $params{past_dates} ? undef : $self->get_previous_invoice_date;
-  $start_date    = $start_date         ? $start_date->subtract(days => 1) : $cur_date->clone;
+  my $cur_date   = $self->first_billing_date || $self->start_date;
+  my $end_date   = $self->terminated ? $self->end_date : undef;
+  $end_date    //= DateTime->today_local->add(years => 100);
+  my $start_date = $params{past_dates} ? undef                       : $self->get_previous_billed_period_start_date;
+  $start_date    = $start_date         ? $start_date->add(days => 1) : $cur_date->clone;
 
   $start_date    = max($start_date, $params{start_date}) if $params{start_date};
   $end_date      = min($end_date,   $params{end_date})   if $params{end_date};