X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDB%2FShopOrder.pm;h=6a53387b52de4df62441a347c604b157f83bc0c5;hb=e6349b94e3541e363e8c40dcd938d65a272ec51c;hp=4e125fbc9f3bdf4f962e89e72910ea5b9aae10d2;hpb=51504ef44a8f49be8baa983e8a37c301acb9a937;p=kivitendo-erp.git diff --git a/SL/DB/ShopOrder.pm b/SL/DB/ShopOrder.pm index 4e125fbc9..6a53387b5 100644 --- a/SL/DB/ShopOrder.pm +++ b/SL/DB/ShopOrder.pm @@ -9,6 +9,7 @@ use SL::DBUtils; use SL::DB::Shop; use SL::DB::MetaSetup::ShopOrder; use SL::DB::Manager::ShopOrder; +use SL::DB::PaymentTerm; use SL::DB::Helper::LinkedRecords; use SL::Locale::String qw(t8); use Carp; @@ -47,7 +48,8 @@ sub convert_to_sales_order { }else{ my $current_order_item = SL::DB::OrderItem->new( parts_id => $part->id, - description => $part->description, + description => $_->description, # description from the shop + longdescription => $part->notes, # longdescription from parts. TODO locales qty => $_->quantity, sellprice => $_->price, unit => $part->unit, @@ -95,7 +97,7 @@ sub convert_to_sales_order { intnotes => $customer->notes, salesman_id => $employee->id, taxincluded => $self->tax_included, - payment_id => $customer->payment_id, + payment_id => $self->payment_id, taxzone_id => $customer->taxzone_id, currency_id => $customer->currency_id, transaction_description => $shop->transaction_description, @@ -122,7 +124,7 @@ sub check_for_existing_customers { my $zipcode = $self->billing_street ne '' ? $self->billing_zipcode : ''; my $email = $self->billing_street ne '' ? $self->billing_email : ''; - if($self->check_trgm) { + if(check_trgm($::form->get_standard_dbh())) { # Fuzzysearch for street to find e.g. "Dorfstrasse - Dorfstr. - Dorfstraße" my $fs_query = <billing_zipcode, $street, $self->billing_zipcode, $self->billing_email); + my @values = ($lastname, $company, $self->billing_zipcode, $street, $self->billing_zipcode, $self->billing_email, $self->billing_email); $customers = SL::DB::Manager::Customer->get_objects_from_sql( sql => $fs_query, @@ -150,20 +152,24 @@ SQL # If trgm extension is not installed $customers = SL::DB::Manager::Customer->get_all( where => [ - or => [ - and => [ - or => [ 'name' => { ilike => $lastname }, - 'name' => { ilike => $company }, - ], - 'zipcode' => { ilike => $zipcode }, + or => [ + and => [ + or => [ 'name' => { ilike => $lastname }, + 'name' => { ilike => $company }, + ], + 'zipcode' => { ilike => $zipcode }, ], - and => [ - and => [ 'street' => { ilike => $street_not_fuzzy }, - 'zipcode' => { ilike => $zipcode }, + and => [ + and => [ 'street' => { ilike => $street_not_fuzzy }, + 'zipcode' => { ilike => $zipcode }, ], ], - or => [ 'email' => { ilike => $email } ], - ], + or => [ + 'email' => { ilike => $email }, + 'invoice_mail' => { ilike => $email }, + ], + ], + and => [ obsolete => 'F' ] ], ); } @@ -171,12 +177,24 @@ SQL return $customers; } +sub check_for_open_invoices { + my ($self) = @_; + my $open_invoices = SL::DB::Manager::Invoice->get_all_count( + query => [customer_id => $self->{kivi_customer_id}, + paid => {lt_sql => 'amount'}, + ], + ); + return $open_invoices; +} + sub get_customer{ my ($self, %params) = @_; my $shop = SL::DB::Manager::Shop->find_by(id => $self->shop_id); my $customer_proposals = $self->check_for_existing_customers; my $name = $self->billing_firstname . " " . $self->billing_lastname; my $customer = 0; + my $default_payment = SL::DB::Manager::PaymentTerm->get_first(); + my $payment_id = $default_payment ? $default_payment->id : undef; if(!scalar(@{$customer_proposals})){ my %address = ( 'name' => $name, 'department_1' => $self->billing_company, @@ -185,6 +203,7 @@ sub get_customer{ 'zipcode' => $self->billing_zipcode, 'city' => $self->billing_city, 'email' => $self->billing_email, + 'invoice_mail' => $self->billing_email, 'country' => $self->billing_country, 'greeting' => $self->billing_greeting, 'fax' => $self->billing_fax, @@ -195,7 +214,7 @@ sub get_customer{ 'pricegroup_id' => (split '\/',$shop->price_source)[0] eq "pricegroup" ? (split '\/',$shop->price_source)[1] : undef, 'taxzone_id' => $shop->taxzone_id, 'currency' => $::instance_conf->get_currency_id, - #'payment_id' => 7345,# TODO hardcoded + 'payment_id' => $payment_id, ); $customer = SL::DB::Customer->new(%address); @@ -220,6 +239,7 @@ sub get_customer{ obsolete => 'F', ); } + $customer->update_attributes(invoice_mail => $self->billing_email) if $customer->invoice_mail ne $self->billing_email; return $customer; } @@ -235,17 +255,6 @@ sub compare_to { return $result || ($self->id <=> $other->id); } -sub check_trgm { - my ( $self ) = @_; - - my $dbh = $::form->get_standard_dbh(); - my $sql = "SELECT installed_version FROM pg_available_extensions WHERE name = 'pg_trgm'"; - my @version = selectall_hashref_query($::form, $dbh, $sql); - - return 1 if($version[0]->{installed_version}); - return 0; -} - sub has_differing_delivery_address { my ($self) = @_; ($self->billing_firstname // '') ne ($self->delivery_firstname // '') || @@ -294,10 +303,6 @@ When it is 0 get customer creates a new customer object of the shop order billin =item C -=item C - -Checks if the postgresextension pg_trgm is installed and return 0 or 1. - =back =head1 TODO