X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDBUpgrade2.pm;h=0b14eca5bb2a3c439aa3ab9c4aa81f0f44b8bccf;hb=43816cb7289ee9225c3bb229d077bd87a75562cc;hp=fea2168009ea43a6cab44c118a26f8508c0956b4;hpb=1f0d7da266e23a443c47aaa2dbab844e6be50ee4;p=kivitendo-erp.git diff --git a/SL/DBUpgrade2.pm b/SL/DBUpgrade2.pm index fea216800..0b14eca5b 100644 --- a/SL/DBUpgrade2.pm +++ b/SL/DBUpgrade2.pm @@ -56,9 +56,10 @@ sub parse_dbupdate_controls { $file =~ s|.*/||; my $control = { - "priority" => 1000, - "depends" => [], - "locales" => [], + priority => 1000, + depends => [], + required_by => [], + locales => [], }; while () { @@ -71,8 +72,8 @@ sub parse_dbupdate_controls { my @fields = split(/\s*:\s*/, $_, 2); next unless (scalar(@fields) == 2); - if ($fields[0] eq "depends") { - push(@{$control->{"depends"}}, split(/\s+/, $fields[1])); + if ($fields[0] =~ m{^(?:depends|required_by)$}) { + push(@{$control->{$fields[0]}}, split(/\s+/, $fields[1])); } elsif ($fields[0] eq "locales") { push @{$control->{locales}}, $fields[1]; } else { @@ -100,7 +101,7 @@ sub parse_dbupdate_controls { delete @{$control}{qw(depth applied)}; - my @unknown_keys = grep { !m{^ (?: depends | description | file | ignore | locales | may_fail | priority | tag ) $}x } keys %{ $control }; + my @unknown_keys = grep { !m{^ (?: depends | required_by | description | file | ignore | locales | may_fail | priority | superuser_privileges | tag ) $}x } keys %{ $control }; if (@unknown_keys) { _control_error($form, $file_name, sprintf($locale->text("Unknown control fields: #1", join(' ', sort({ lc $a cmp lc $b } @unknown_keys))))); } @@ -114,6 +115,15 @@ sub parse_dbupdate_controls { close(IN); } + foreach my $name (keys %all_controls) { + my $control = $all_controls{$name}; + + foreach my $dependency (@{ delete $control->{required_by} }) { + _control_error($form, $control->{"file"}, sprintf($locale->text("Unknown dependency '%s'."), $dependency)) if (!defined($all_controls{$dependency})); + push @{ $all_controls{$dependency}->{depends} }, $name; + } + } + foreach my $control (values(%all_controls)) { foreach my $dependency (@{$control->{"depends"}}) { _control_error($form, $control->{"file"}, sprintf($locale->text("Unknown dependency '%s'."), $dependency)) if (!defined($all_controls{$dependency})); @@ -320,14 +330,6 @@ sub unapplied_upgrade_scripts { return grep { !$_->{applied} } @all_scripts; } -sub update2_available { - my ($self, $dbh) = @_; - - my @unapplied_scripts = $self->unapplied_upgrade_scripts($dbh); - - return !!@unapplied_scripts; -} - sub apply_admin_dbupgrade_scripts { my ($self, $called_from_admin) = @_; @@ -657,14 +659,6 @@ to the database that is checked. Requires that the scripts have been parsed. -=item C - -Returns trueish if at least one upgrade script hasn't been applied to -a database yet. C<$dbh> is an open handle to the database that is -checked. - -Requires that the scripts have been parsed. - =back =head1 BUGS