X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FDBUpgrade2.pm;h=8cde113ea3b3978ccbf7bf2c1c294bc9c7e2fc6c;hb=4ff0cb665f86bee77700b285591a56a5e089cd8e;hp=514448f6dd6411e0f9a69bf30a1d620c1130961e;hpb=4fd8bdbfb46b8b63a7d05457959b98c4956d1dbd;p=kivitendo-erp.git diff --git a/SL/DBUpgrade2.pm b/SL/DBUpgrade2.pm index 514448f6d..8cde113ea 100644 --- a/SL/DBUpgrade2.pm +++ b/SL/DBUpgrade2.pm @@ -103,20 +103,26 @@ sub _check_for_loops { push(@path, $tag); - _control_error($form, $file_name, - $main::locale->text("Dependency loop detected:") . - " " . join(" -> ", @path)) - if ($controls->{$tag}->{"loop"}); - - $controls->{$tag}->{"loop"} = 1; - map({ _check_for_loops($form, $file_name, $controls, $_, @path); } - @{$controls->{$tag}->{"depends"}}); + my $ctrl = $controls->{$tag}; + + if ($ctrl->{"loop"} == 1) { + # Not done yet. + _control_error($form, $file_name, + $main::locale->text("Dependency loop detected:") . + " " . join(" -> ", @path)) + } elsif ($ctrl->{"loop"} == 0) { + # Not checked yet. + $ctrl->{"loop"} = 1; + map({ _check_for_loops($form, $file_name, $controls, $_, @path); } + @{ $ctrl->{"depends"} }); + $ctrl->{"loop"} = 2; + } } sub _control_error { my ($form, $file_name, $message) = @_; - my $form = $main::form; + $form = $main::form; my $locale = $main::locale; $form->error(sprintf($locale->text("Error in database control file '%s': %s"),