X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FIC.pm;h=b9ad62c585a3b33d90792a3c9063bb085aae50e4;hb=6f2893dcf199d5e5147cc2020c2ab6984f4274dc;hp=02d6b529b26daea539c56509bf70a890391494d6;hpb=728729b6163701a522eff7f5396a2fc44a80fb64;p=kivitendo-erp.git

diff --git a/SL/IC.pm b/SL/IC.pm
index 02d6b529b..b9ad62c58 100644
--- a/SL/IC.pm
+++ b/SL/IC.pm
@@ -1,4 +1,4 @@
-#=====================================================================
+  #=====================================================================
 # LX-Office ERP
 # Copyright (C) 2004
 # Based on SQL-Ledger Version 2.1.9
@@ -33,9 +33,16 @@
 #======================================================================
 
 package IC;
+
 use Data::Dumper;
+use List::MoreUtils qw(all any uniq);
+use YAML;
+
+use SL::CVar;
 use SL::DBUtils;
 
+use strict;
+
 sub get_part {
   $main::lxdebug->enter_sub();
 
@@ -63,8 +70,7 @@ sub get_part {
   # copy to $form variables
   map { $form->{$_} = $ref->{$_} } (keys %{$ref});
 
-  my %oid = ('Pg'     => 'a.oid',
-             'Oracle' => 'a.rowid');
+  $form->{onhand} *= 1;
 
   # part or service item
   $form->{item} = ($form->{inventory_accno}) ? 'part' : 'service';
@@ -74,17 +80,18 @@ sub get_part {
     # retrieve assembly items
     $query =
       qq|SELECT p.id, p.partnumber, p.description,
-           p.sellprice, p.weight, a.qty, a.bom, p.unit,
-           pg.partsgroup
+           p.sellprice, p.lastcost, p.weight, a.qty, a.bom, p.unit,
+           pg.partsgroup, p.price_factor_id, pfac.factor AS price_factor
          FROM parts p
          JOIN assembly a ON (a.parts_id = p.id)
          LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
+         LEFT JOIN price_factors pfac ON pfac.id = p.price_factor_id
          WHERE (a.id = ?)
-         ORDER BY $oid{$myconfig->{dbdriver}}|;
+         ORDER BY a.oid|;
     $sth = prepare_execute_query($form, $dbh, $query, conv_i($form->{id}));
 
     $form->{assembly_rows} = 0;
-    while (my $ref = $sth->fetchrow_hashref(NAME_lc)) {
+    while (my $ref = $sth->fetchrow_hashref("NAME_lc")) {
       $form->{assembly_rows}++;
       foreach my $key (keys %{$ref}) {
         $form->{"${key}_$form->{assembly_rows}"} = $ref->{$key};
@@ -120,8 +127,6 @@ sub get_part {
   while (($form->{"klass_$i"}, $form->{"pricegroup_id_$i"},
           $form->{"price_$i"}, $form->{"pricegroup_$i"})
          = $sth->fetchrow_array()) {
-    $form->{"price_$i"} = $form->round_amount($form->{"price_$i"}, 5);
-    $form->{"price_$i"} = $form->format_amount($myconfig, $form->{"price_$i"}, -2);
     push @pricegroups, $form->{"pricegroup_id_$i"};
     $i++;
   }
@@ -133,7 +138,7 @@ sub get_part {
   $form->{PRICEGROUPS} = selectall_hashref_query($form, $dbh, $query);
 
   #find not used pricegroups
-  while ($tmp = pop(@{ $form->{PRICEGROUPS} })) {
+  while (my $tmp = pop(@{ $form->{PRICEGROUPS} })) {
     my $in_use = 0;
     foreach my $item (@pricegroups) {
       if ($item eq $tmp->{id}) {
@@ -147,10 +152,8 @@ sub get_part {
   # if not used pricegroups are avaible
   if (@pricegroups_not_used) {
 
-    foreach $name (@pricegroups_not_used) {
+    foreach my $name (@pricegroups_not_used) {
       $form->{"klass_$i"} = "$name->{id}";
-      $form->{"price_$i"} = $form->round_amount($form->{sellprice}, 5);
-      $form->{"price_$i"} = $form->format_amount($myconfig, $form->{"price_$i"}, -2);
       $form->{"pricegroup_id_$i"} = "$name->{id}";
       $form->{"pricegroup_$i"}    = "$name->{pricegroup}";
       $i++;
@@ -166,7 +169,7 @@ sub get_part {
     if ($form->{makemodel}) {
       $query = qq|SELECT m.make, m.model FROM makemodel m | .
                qq|WHERE m.parts_id = ?|;
-      @values = ($form->{id});
+      my @values = ($form->{id});
       $sth = $dbh->prepare($query);
       $sth->execute(@values) || $form->dberror("$query (" . join(', ', @values) . ")");
 
@@ -183,10 +186,12 @@ sub get_part {
 
   # get translations
   $form->{language_values} = "";
-  $query = qq|SELECT language_id, translation FROM translation WHERE parts_id = ?|;
+  $query = qq|SELECT language_id, translation, longdescription
+              FROM translation
+              WHERE parts_id = ?|;
   my $trq = prepare_execute_query($form, $dbh, $query, conv_i($form->{id}));
-  while ($tr = $trq->fetchrow_hashref(NAME_lc)) {
-    $form->{language_values} .= "---+++---".$tr->{language_id}."--++--".$tr->{translation};
+  while (my $tr = $trq->fetchrow_hashref("NAME_lc")) {
+    $form->{language_values} .= "---+++---" . join('--++--', @{$tr}{qw(language_id translation longdescription)});
   }
   $trq->finish;
 
@@ -196,44 +201,32 @@ sub get_part {
        FROM chart c, partstax pt
        WHERE (pt.chart_id = c.id) AND (pt.parts_id = ?)|;
   $sth = prepare_execute_query($form, $dbh, $query, conv_i($form->{id}));
-  while (($key) = $sth->fetchrow_array) {
+  while (my ($key) = $sth->fetchrow_array) {
     $form->{amount}{$key} = $key;
   }
 
   $sth->finish;
 
   # is it an orphan
-  $query =
-    qq|SELECT i.parts_id
-       FROM invoice i
-       WHERE (i.parts_id = ?)
-
-       UNION
-
-       SELECT o.parts_id
-       FROM orderitems o
-       WHERE (o.parts_id = ?)
-
-       UNION
+  my @referencing_tables = qw(invoice orderitems inventory rmaitems);
+  my %column_map         = ( );
+  my $parts_id           = conv_i($form->{id});
 
-       SELECT a.parts_id
-       FROM assembly a
-       WHERE (a.parts_id = ?)|;
-  @values = (conv_i($form->{id}), conv_i($form->{id}), conv_i($form->{id}));
-  ($form->{orphaned}) = selectrow_query($form, $dbh, $query, @values);
-  $form->{orphaned} = !$form->{orphaned};
+  $form->{orphaned}      = 1;
 
-  $form->{"unit_changeable"} = 1;
-  foreach my $table (qw(invoice assembly orderitems inventory license)) {
-    $query = qq|SELECT COUNT(*) FROM $table WHERE parts_id = ?|;
-    my ($count) = selectrow_query($form, $dbh, $query, conv_i($form->{"id"}));
+  foreach my $table (@referencing_tables) {
+    my $column  = $column_map{$table} || 'parts_id';
+    $query      = qq|SELECT $column FROM $table WHERE $column = ? LIMIT 1|;
+    my ($found) = selectrow_query($form, $dbh, $query, $parts_id);
 
-    if ($count) {
-      $form->{"unit_changeable"} = 0;
+    if ($found) {
+      $form->{orphaned} = 0;
       last;
     }
   }
 
+  $form->{"unit_changeable"} = $form->{orphaned};
+
   $dbh->disconnect;
 
   $main::lxdebug->leave_sub();
@@ -251,7 +244,7 @@ sub get_pricegroups {
   my $pricegroups = selectall_hashref_query($form, $dbh, $query);
 
   my $i = 1;
-  foreach $pg (@{ $pricegroups }) {
+  foreach my $pg (@{ $pricegroups }) {
     $form->{"klass_$i"} = "$pg->{id}";
     $form->{"price_$i"} = $form->format_amount($myconfig, $form->{"price_$i"}, -2);
     $form->{"pricegroup_id_$i"} = "$pg->{id}";
@@ -265,6 +258,8 @@ sub get_pricegroups {
   $dbh->disconnect;
 
   $main::lxdebug->leave_sub();
+
+  return $pricegroups;
 }
 
 sub retrieve_buchungsgruppen {
@@ -302,7 +297,7 @@ sub save {
 
   # undo amount formatting
   map { $form->{$_} = $form->parse_amount($myconfig, $form->{$_}) }
-    qw(rop weight listprice sellprice gv lastcost stock);
+    qw(rop weight listprice sellprice gv lastcost);
 
   my $makemodel = (($form->{make_1}) || ($form->{model_1})) ? 1 : 0;
 
@@ -310,6 +305,8 @@ sub save {
 
   my ($query, $sth);
 
+  my $priceupdate = ', priceupdate = current_date';
+
   if ($form->{id}) {
 
     # get old price
@@ -330,14 +327,8 @@ sub save {
     }
 
     if ($form->{item} eq 'assembly') {
-      if ($form->{onhand} != 0) {
-        &adjust_inventory($dbh, $form, $form->{id}, $form->{onhand} * -1);
-      }
-
       # delete assembly records
       do_query($form, $dbh, qq|DELETE FROM assembly WHERE id = ?|, conv_i($form->{id}));
-
-      $form->{onhand} += $form->{stock};
     }
 
     # delete tax records
@@ -346,6 +337,11 @@ sub save {
     # delete translations
     do_query($form, $dbh, qq|DELETE FROM translation WHERE parts_id = ?|, conv_i($form->{id}));
 
+    # Check whether or not the prices have changed. If they haven't
+    # then 'priceupdate' should not be updated.
+    my $previous_values = selectfirst_hashref_query($form, $dbh, qq|SELECT * FROM parts WHERE id = ?|, conv_i($form->{id})) || {};
+    $priceupdate        = '' if (all { $previous_values->{$_} == $form->{$_} } qw(sellprice lastcost listprice));
+
   } else {
     my ($count) = selectrow_query($form, $dbh, qq|SELECT COUNT(*) FROM parts WHERE partnumber = ?|, $form->{partnumber});
     if ($count) {
@@ -354,10 +350,9 @@ sub save {
     }
 
     ($form->{id}) = selectrow_query($form, $dbh, qq|SELECT nextval('id')|);
-    do_query($form, $dbh, qq|INSERT INTO parts (id, partnumber) VALUES (?, '')|, $form->{id});
+    do_query($form, $dbh, qq|INSERT INTO parts (id, partnumber, unit) VALUES (?, '', '')|, $form->{id});
 
     $form->{orphaned} = 1;
-    $form->{onhand} = $form->{stock} if $form->{item} eq 'assembly';
     if ($form->{partnumber} eq "" && $form->{"item"} eq "service") {
       $form->{partnumber} = $form->update_defaults($myconfig, "servicenumber");
     }
@@ -369,7 +364,7 @@ sub save {
   my $partsgroup_id = 0;
 
   if ($form->{partsgroup}) {
-    ($partsgroup, $partsgroup_id) = split(/--/, $form->{partsgroup});
+    (my $partsgroup, $partsgroup_id) = split(/--/, $form->{partsgroup});
   }
 
   my ($subq_inventory, $subq_expense, $subq_income);
@@ -402,7 +397,6 @@ sub save {
          sellprice = ?,
          lastcost = ?,
          weight = ?,
-         priceupdate = ?,
          unit = ?,
          notes = ?,
          formel = ?,
@@ -420,9 +414,12 @@ sub save {
          ve = ?,
          gv = ?,
          ean = ?,
+         has_sernumber = ?,
          not_discountable = ?,
          microfiche = ?,
-         partsgroup_id = ?
+         partsgroup_id = ?,
+         price_factor_id = ?
+         $priceupdate
        WHERE id = ?|;
   @values = ($form->{partnumber},
              $form->{description},
@@ -432,7 +429,6 @@ sub save {
              $form->{sellprice},
              $form->{lastcost},
              $form->{weight},
-             conv_date($form->{priceupdate}),
              $form->{unit},
              $form->{notes},
              $form->{formel},
@@ -448,9 +444,11 @@ sub save {
              conv_i($form->{ve}),
              conv_i($form->{gv}),
              $form->{ean},
+             $form->{has_sernumber} ? 't' : 'f',
              $form->{not_discountable} ? 't' : 'f',
              $form->{microfiche},
              conv_i($partsgroup_id),
+             conv_i($form->{price_factor_id}),
              conv_i($form->{id})
   );
   do_query($form, $dbh, $query, @values);
@@ -459,7 +457,7 @@ sub save {
   do_query($form, $dbh, qq|DELETE FROM translation WHERE parts_id = ?|, conv_i($form->{id}));
 
   if ($form->{language_values} ne "") {
-    foreach $item (split(/---\+\+\+---/, $form->{language_values})) {
+    foreach my $item (split(/---\+\+\+---/, $form->{language_values})) {
       my ($language_id, $translation, $longdescription) = split(/--\+\+--/, $item);
       if ($translation ne "") {
         $query = qq|INSERT into translation (parts_id, language_id, translation, longdescription)
@@ -475,22 +473,20 @@ sub save {
 
   # insert price records only if different to sellprice
   for my $i (1 .. $form->{price_rows}) {
-    if ($form->{"price_$i"} eq "0") {
+    my $price = $form->parse_amount($myconfig, $form->{"price_$i"});
+    if ($price == 0) {
       $form->{"price_$i"} = $form->{sellprice};
     }
     if (
-        (   $form->{"price_$i"}
+        (   $price
          || $form->{"klass_$i"}
          || $form->{"pricegroup_id_$i"})
-        and $form->{"price_$i"} != $form->{sellprice}
+        and $price != $form->{sellprice}
       ) {
       #$klass = $form->parse_amount($myconfig, $form->{"klass_$i"});
-      $price = $form->parse_amount($myconfig, $form->{"price_$i"});
-      $pricegroup_id =
-        $form->parse_amount($myconfig, $form->{"pricegroup_id_$i"});
       $query = qq|INSERT INTO prices (parts_id, pricegroup_id, price) | .
                qq|VALUES(?, ?, ?)|;
-      @values = (conv_i($form->{id}), conv_i($pricegroup_id), $price);
+      @values = (conv_i($form->{id}), conv_i($form->{"pricegroup_id_$i"}), $price);
       do_query($form, $dbh, $query, @values);
     }
   }
@@ -499,23 +495,23 @@ sub save {
   unless ($form->{item} eq 'service') {
     for my $i (1 .. $form->{makemodel_rows}) {
       if (($form->{"make_$i"}) || ($form->{"model_$i"})) {
-        map { $form->{"${_}_$i"} =~ s/\'/\'\'/g } qw(make model);
 
         $query = qq|INSERT INTO makemodel (parts_id, make, model) | .
-		             qq|VALUES (?, ?, ?)|;
-		    @values = (conv_i($form->{id}), $form->{"make_$i"}, $form->{"model_$i"});
+                 qq|VALUES (?, ?, ?)|;
+        @values = (conv_i($form->{id}), conv_i($form->{"make_$i"}), $form->{"model_$i"});
+
         do_query($form, $dbh, $query, @values);
       }
     }
   }
 
   # insert taxes
-  foreach $item (split(/ /, $form->{taxaccounts})) {
+  foreach my $item (split(/ /, $form->{taxaccounts})) {
     if ($form->{"IC_tax_$item"}) {
       $query =
         qq|INSERT INTO partstax (parts_id, chart_id)
            VALUES (?, (SELECT id FROM chart WHERE accno = ?))|;
-			@values = (conv_i($form->{id}), $item);
+      @values = (conv_i($form->{id}), $item);
       do_query($form, $dbh, $query, @values);
     }
   }
@@ -529,53 +525,41 @@ sub save {
       if ($form->{"qty_$i"} != 0) {
         $form->{"bom_$i"} *= 1;
         $query = qq|INSERT INTO assembly (id, parts_id, qty, bom) | .
-		             qq|VALUES (?, ?, ?, ?)|;
-		    @values = (conv_i($form->{id}), conv_i($form->{"id_$i"}), conv_i($form->{"qty_$i"}), $form->{"bom_$i"} ? 't' : 'f');
+                 qq|VALUES (?, ?, ?, ?)|;
+        @values = (conv_i($form->{id}), conv_i($form->{"id_$i"}), conv_i($form->{"qty_$i"}), $form->{"bom_$i"} ? 't' : 'f');
         do_query($form, $dbh, $query, @values);
       }
     }
 
-    # adjust onhand for the parts
-    if ($form->{onhand} != 0) {
-      &adjust_inventory($dbh, $form, $form->{id}, $form->{onhand});
-    }
-
-    @a = localtime;
+    my @a = localtime;
     $a[5] += 1900;
     $a[4]++;
     my $shippingdate = "$a[5]-$a[4]-$a[3]";
 
     $form->get_employee($dbh);
 
-    # add inventory record
-    $query =
-      qq|INSERT INTO inventory (warehouse_id, parts_id, qty, shippingdate, employee_id)
-         VALUES (0, ?, ?, '$shippingdate', ?)|;
-    @values = (conv_i($form->{id}), $form->{stock}, conv_i($form->{employee_id}));
-    do_query($form, $dbh, $query, @values);
-
   }
 
   #set expense_accno=inventory_accno if they are different => bilanz
-  $vendor_accno =
+  my $vendor_accno =
     ($form->{expense_accno} != $form->{inventory_accno})
     ? $form->{inventory_accno}
     : $form->{expense_accno};
 
   # get tax rates and description
-  $accno_id =
+  my $accno_id =
     ($form->{vc} eq "customer") ? $form->{income_accno} : $vendor_accno;
   $query =
     qq|SELECT c.accno, c.description, t.rate, t.taxnumber
        FROM chart c, tax t
        WHERE (c.id = t.chart_id) AND (t.taxkey IN (SELECT taxkey_id FROM chart where accno = ?))
        ORDER BY c.accno|;
-  $stw = prepare_execute_query($form, $dbh, $query, $accno_id);
+  my $stw = prepare_execute_query($form, $dbh, $query, $accno_id);
 
   $form->{taxaccount} = "";
-  while ($ptr = $stw->fetchrow_hashref(NAME_lc)) {
+  while (my $ptr = $stw->fetchrow_hashref("NAME_lc")) {
     $form->{taxaccount} .= "$ptr->{accno} ";
-    if (!($form->{taxaccount2} =~ /$ptr->{accno}/)) {
+    if (!($form->{taxaccount2} =~ /\Q$ptr->{accno}\E/)) {
       $form->{"$ptr->{accno}_rate"}        = $ptr->{rate};
       $form->{"$ptr->{accno}_description"} = $ptr->{description};
       $form->{"$ptr->{accno}_taxnumber"}   = $ptr->{taxnumber};
@@ -583,6 +567,11 @@ sub save {
     }
   }
 
+  CVar->save_custom_variables('dbh'       => $dbh,
+                              'module'    => 'IC',
+                              'trans_id'  => $form->{id},
+                              'variables' => $form);
+
   # commit
   my $rc = $dbh->commit;
   $dbh->disconnect;
@@ -608,7 +597,7 @@ sub update_assembly {
   $query =
     qq|UPDATE parts SET sellprice = sellprice + ?, weight = weight + ?
        WHERE id = ?|;
-  @values = ($qty * ($form->{sellprice} - $sellprice),
+  my @values = ($qty * ($form->{sellprice} - $sellprice),
              $qty * ($form->{weight} - $weight), conv_i($id));
   do_query($form, $dbh, $query, @values);
 
@@ -653,67 +642,6 @@ sub retrieve_assemblies {
   $main::lxdebug->leave_sub();
 }
 
-sub restock_assemblies {
-  $main::lxdebug->enter_sub();
-
-  my ($self, $myconfig, $form) = @_;
-
-  # connect to database
-  my $dbh = $form->dbconnect_noauto($myconfig);
-
-  for my $i (1 .. $form->{rowcount}) {
-
-    $form->{"qty_$i"} = $form->parse_amount($myconfig, $form->{"qty_$i"});
-
-    if ($form->{"qty_$i"} != 0) {
-      &adjust_inventory($dbh, $form, $form->{"id_$i"}, $form->{"qty_$i"});
-    }
-
-  }
-
-  my $rc = $dbh->commit;
-  $dbh->disconnect;
-
-  $main::lxdebug->leave_sub();
-
-  return $rc;
-}
-
-sub adjust_inventory {
-  $main::lxdebug->enter_sub();
-
-  my ($dbh, $form, $id, $qty) = @_;
-
-  my $query =
-    qq|SELECT p.id, p.inventory_accno_id, p.assembly, a.qty
-       FROM parts p, assembly a
-       WHERE (a.parts_id = p.id) AND (a.id = ?)|;
-  my $sth = prepare_execute_query($form, $dbh, $query, conv_i($id));
-
-  while (my $ref = $sth->fetchrow_hashref(NAME_lc)) {
-
-    my $allocate = $qty * $ref->{qty};
-
-    # is it a service item, then loop
-    $ref->{inventory_accno_id} *= 1;
-    next if (($ref->{inventory_accno_id} == 0) && !$ref->{assembly});
-
-    # adjust parts onhand
-    $form->update_balance($dbh, "parts", "onhand",
-                          qq|id = $ref->{id}|,
-                          $allocate * -1);
-  }
-
-  $sth->finish;
-
-  # update assembly
-  my $rc = $form->update_balance($dbh, "parts", "onhand", qq|id = ?|, $qty, $id);
-
-  $main::lxdebug->leave_sub();
-
-  return $rc;
-}
-
 sub delete {
   $main::lxdebug->enter_sub();
 
@@ -722,9 +650,9 @@ sub delete {
   # connect to database, turn off AutoCommit
   my $dbh = $form->dbconnect_noauto($myconfig);
 
-  my %columns = ( "assembly" => "id", "alternate" => "id", "parts" => "id" );
+  my %columns = ( "assembly" => "id", "parts" => "id" );
 
-  for my $table (qw(prices partstax makemodel inventory assembly parts)) {
+  for my $table (qw(prices partstax makemodel inventory assembly license translation parts)) {
     my $column = defined($columns{$table}) ? $columns{$table} : "parts_id";
     do_query($form, $dbh, qq|DELETE FROM $table WHERE $column = ?|, @values);
   }
@@ -761,7 +689,7 @@ sub assembly_item {
     push(@values, conv_i($form->{id}));
   }
 
-  if ($partnumber) {
+  if ($form->{partnumber}) {
     $where .= qq| ORDER BY p.partnumber|;
   } else {
     $where .= qq| ORDER BY p.description|;
@@ -771,9 +699,12 @@ sub assembly_item {
   my $dbh = $form->dbconnect($myconfig);
 
   my $query =
-    qq|SELECT p.id, p.partnumber, p.description, p.sellprice, p.weight, p.onhand, p.unit, pg.partsgroup
+    qq|SELECT p.id, p.partnumber, p.description, p.sellprice,
+       p.weight, p.onhand, p.unit, pg.partsgroup, p.lastcost,
+       p.price_factor_id, pfac.factor AS price_factor
        FROM parts p
        LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
+       LEFT JOIN price_factors pfac ON pfac.id = p.price_factor_id
        WHERE $where|;
   $form->{item_list} = selectall_hashref_query($form, $dbh, $query, @values);
 
@@ -787,390 +718,352 @@ sub assembly_item {
 # Warning, deep magic ahead.
 # This function gets all parts from the database according to the filters specified
 #
-# filter strings:
-#   partnumber ean description partsgroup serialnumber make model drawing microfiche
-#   transdatefrom transdateto sort
+# specials:
+#   sort revers  - sorting field + direction
+#   top100
+#
+# simple filter strings (every one of those also has a column flag prefixed with 'l_' associated):
+#   partnumber ean description partsgroup microfiche drawing
+#
+# column flags:
+#   l_partnumber l_description l_listprice l_sellprice l_lastcost l_priceupdate l_weight l_unit l_bin l_rop l_image l_drawing l_microfiche l_partsgroup
 #
 # exclusives:
 #   itemstatus  = active | onhand | short | obsolete | orphaned
 #   searchitems = part | assembly | service
 #
-# column flags:
-#   l_partnumber l_description l_listprice l_sellprice l_lastcost l_priceupdate l_weight l_unit l_bin l_rop l_image l_drawing l_microfiche l_partsgroup 
+# joining filters:
+#   make model                               - makemodel
+#   serialnumber transdatefrom transdateto   - invoice/orderitems
 #
 # binary flags:
-#   bought sold onorder ordered rfq quoted onhand short
-#   l_serialnumber l_linetotal l_subtotal l_soldtotal l_deliverydate
-#   revers top100
+#   bought sold onorder ordered rfq quoted   - aggreg joins with invoices/orders
+#   l_linetotal l_subtotal                   - aggreg joins to display totals (complicated) - NOT IMPLEMENTED here, implementation at frontend
+#   l_soldtotal                              - aggreg join to display total of sold quantity
+#   onhand                                   - as above, but masking the simple itemstatus results (doh!)
+#   short                                    - NOT IMPLEMENTED as form filter, only as itemstatus option
+#   l_serialnumber                           - belonges to serialnumber filter
+#   l_deliverydate                           - displays deliverydate is sold etc. flags are active
+#   l_soldtotal                              - aggreg join to display total of sold quantity, works as long as there's no bullshit in soldtotal
+#
+# not working:
+#   onhand                                   - as above, but masking the simple itemstatus results (doh!)
+#   warehouse onhand
+#   search by overrides of description
+#
+# disabled sanity checks and changes:
+#  - searchitems = assembly will no longer disable bought
+#  - searchitems = service  will no longer disable make and model, although services don't have make/model, it doesn't break the query
+#  - itemstatus  = orphaned will no longer disable onhand short bought sold onorder ordered rfq quoted transdate[from|to]
+#  - itemstatus  = obsolete will no longer disable onhand, short
+#  - allow sorting by ean
+#  - serialnumber filter also works if l_serialnumber isn't ticked
+#  - sorting will now change sorting if the requested sorting column isn't checked and doesn't get checked as a side effect
 #
 sub all_parts {
   $main::lxdebug->enter_sub();
 
   my ($self, $myconfig, $form) = @_;
+  my $dbh = $form->get_standard_dbh($myconfig);
+
+  $form->{parts}     = +{ };
+  $form->{soldtotal} = undef if $form->{l_soldtotal}; # security fix. top100 insists on putting strings in there...
+
+  my @simple_filters       = qw(partnumber ean description partsgroup microfiche drawing onhand);
+  my @makemodel_filters    = qw(make model);
+  my @invoice_oi_filters   = qw(serialnumber soldtotal);
+  my @apoe_filters         = qw(transdate);
+  my @like_filters         = (@simple_filters, @makemodel_filters, @invoice_oi_filters);
+  my @all_columns          = (@simple_filters, @makemodel_filters, @apoe_filters, qw(serialnumber));
+  my @simple_l_switches    = (@all_columns, qw(listprice sellprice lastcost priceupdate weight unit bin rop image));
+  my @oe_flags             = qw(bought sold onorder ordered rfq quoted);
+  my @qsooqr_flags         = qw(invnumber ordnumber quonumber trans_id name module qty);
+  my @deliverydate_flags   = qw(deliverydate);
+#  my @other_flags          = qw(onhand); # ToDO: implement these
+#  my @inactive_flags       = qw(l_subtotal short l_linetotal);
+
+  my @select_tokens = qw(id factor);
+  my @where_tokens  = qw(1=1);
+  my @group_tokens  = ();
+  my @bind_vars     = ();
+  my %joins_needed  = ();
+
+  my %joins = (
+    partsgroup => 'LEFT JOIN partsgroup pg      ON (pg.id       = p.partsgroup_id)',
+    makemodel  => 'LEFT JOIN makemodel mm       ON (mm.parts_id = p.id)',
+    pfac       => 'LEFT JOIN price_factors pfac ON (pfac.id     = p.price_factor_id)',
+    invoice_oi =>
+      q|LEFT JOIN (
+         SELECT parts_id, description, serialnumber, trans_id, unit, sellprice, qty,          assemblyitem,         deliverydate, 'invoice'    AS ioi, id FROM invoice UNION
+         SELECT parts_id, description, serialnumber, trans_id, unit, sellprice, qty, FALSE AS assemblyitem, NULL AS deliverydate, 'orderitems' AS ioi, id FROM orderitems
+       ) AS ioi ON ioi.parts_id = p.id|,
+    apoe       =>
+      q|LEFT JOIN (
+         SELECT id, transdate, 'ir' AS module, ordnumber, quonumber,         invnumber, FALSE AS quotation, NULL AS customer_id,         vendor_id,    NULL AS deliverydate, 'invoice'    AS ioi FROM ap UNION
+         SELECT id, transdate, 'is' AS module, ordnumber, quonumber,         invnumber, FALSE AS quotation,         customer_id, NULL AS vendor_id,            deliverydate, 'invoice'    AS ioi FROM ar UNION
+         SELECT id, transdate, 'oe' AS module, ordnumber, quonumber, NULL AS invnumber,          quotation,         customer_id,         vendor_id, reqdate AS deliverydate, 'orderitems' AS ioi FROM oe
+       ) AS apoe ON ((ioi.trans_id = apoe.id) AND (ioi.ioi = apoe.ioi))|,
+    cv         =>
+      q|LEFT JOIN (
+           SELECT id, name, 'customer' AS cv FROM customer UNION
+           SELECT id, name, 'vendor'   AS cv FROM vendor
+         ) AS cv ON cv.id = apoe.customer_id OR cv.id = apoe.vendor_id|,
+  );
+  my @join_order = qw(partsgroup makemodel invoice_oi apoe cv pfac);
+
+  my %table_prefix = (
+     deliverydate => 'apoe.', serialnumber => 'ioi.',
+     transdate    => 'apoe.', trans_id     => 'ioi.',
+     module       => 'apoe.', name         => 'cv.',
+     ordnumber    => 'apoe.', make         => 'mm.',
+     quonumber    => 'apoe.', model        => 'mm.',
+     invnumber    => 'apoe.', partsgroup   => 'pg.',
+     lastcost     => ' ',   , soldtotal    => ' ',
+     factor       => 'pfac.',
+     'SUM(ioi.qty)' => ' ',
+     description  => 'p.',
+     qty          => 'ioi.',
+     serialnumber => 'ioi.',
+     quotation    => 'apoe.',
+     cv           => 'cv.',
+     "ioi.id"     => ' ',
+     "ioi.ioi"    => ' ',
+  );
 
-  my $where = qq|1 = 1|;
-  my (@values, $var, $flds, $group, $limit);
-
-  foreach my $item (qw(partnumber drawing microfiche ean pg.partsgroup)) {
-    my $column = $item;
-    $column =~ s/.*\.//; # get rid of table prefixes
-    if ($form->{$column}) {
-      $where .= qq| AND ($item ILIKE ?)|;
-      push(@values, "%$form->{$column}%");
-    }
-  }
-
-  # special case for description
-  if ($form->{description}
-      && !(   $form->{bought}  || $form->{sold} || $form->{onorder}
-           || $form->{ordered} || $form->{rfq} || $form->{quoted})) {
-    $where .= qq| AND (p.description ILIKE ?)|;
-    push(@values, "%$form->{description}%");
-  }
-
-  # special case for serialnumber
-  if ($form->{l_serialnumber} && $form->{serialnumber}) {
-    $where .= qq| AND (serialnumber ILIKE ?)|;
-    push(@values, "%$form->{serialnumber}%");
-  }
-
-  if ($form->{searchitems} eq 'part') {
-    $where .= qq| AND (p.inventory_accno_id > 0) |;
-  }
-
-  if ($form->{searchitems} eq 'assembly') {
-    $form->{bought} = "";
-    $where .= qq| AND p.assembly|;
-  }
-
-  if ($form->{searchitems} eq 'service') {
-    $where .= qq| AND (p.inventory_accno_id IS NULL) AND NOT (p.assembly = '1')|;
-    # irrelevant for services
-    map { $form->{$_} = '' } qw(make model);
-  }
-
-  # items which were never bought, sold or on an order
-  if ($form->{itemstatus} eq 'orphaned') {
-    map { $form->{$_} = 0  } qw(onhand short bought sold onorder ordered rfq quoted);
-    map { $form->{$_} = '' } qw(transdatefrom transdateto);
-
-    $where .=
-      qq| AND (p.onhand = 0)
-          AND p.id NOT IN
-            (
-              SELECT DISTINCT parts_id FROM invoice
-              UNION
-              SELECT DISTINCT parts_id FROM assembly
-              UNION
-              SELECT DISTINCT parts_id FROM orderitems
-            )|;
-  }
-
-  my %status2condition = (
-    active   => " AND (p.obsolete = '0')",
-    obsolete => " AND (p.obsolete = '1')",
-    onhand   => " AND (p.onhand > 0)",
-    short    => " AND (p.onhand < p.rop)",
+  # if the join condition in these blocks are met, the column
+  # of the scecified table will gently override (coalesce actually) the original value
+  # use it to conditionally coalesce values from subtables
+  my @column_override = (
+    #  column name,   prefix,  joins_needed
+    [ 'description',  'ioi.',  'invoice_oi'  ],
+    [ 'deliverydate', 'ioi.',  'invoice_oi'  ],
+    [ 'transdate',    'apoe.', 'apoe'        ],
+    [ 'unit',         'ioi.',  'invoice_oi'  ],
+    [ 'sellprice',    'ioi.',  'invoice_oi'  ],
   );
-  $where .= $status2condition{$form->{itemstatus}};
 
-  $form->{onhand} = $form->{short} = 0 if ($form->{itemstatus} eq 'obsolete');
+  # careful with renames. these are HARD, and any filters done on the original column will break
+  my %renamed_columns = (
+    'factor'       => 'price_factor',
+    'SUM(ioi.qty)' => 'soldtotal',
+    'ioi.id'       => 'ioi_id',
+    'ioi.ioi'      => 'ioi',
+  );
 
-  my @subcolumns;
-  foreach my $column (qw(make model)) {
-    push @subcolumns, $column if $form->{$column};
-  }
-  if (@subcolumns) {
-    $where .= qq| AND p.id IN (SELECT DISTINCT parts_id FROM makemodel WHERE | . (join " AND ", map { "($_ ILIKE ?)"; } @subcolumns) . ")";
-    push @values, map { '%' . $form->{$_} . '%' } @subcolumns;
+  if (($form->{searchitems} eq 'assembly') && $form->{l_lastcost}) {
+    @simple_l_switches = grep { $_ ne 'lastcost' } @simple_l_switches;
+  }
+
+  my $make_token_builder = sub {
+    my $joins_needed = shift;
+    sub {
+      my ($col, $alias) = @_;
+      my @coalesce_tokens =
+        map  { ($_->[1] || 'p.') . $_->[0] }
+        grep { !$_->[2] || $joins_needed->{$_->[2]} }
+        grep {  $_->[0] eq $col }
+        @column_override, [ $col, $table_prefix{$col} ];
+
+      my $coalesce = scalar @coalesce_tokens > 1;
+      return ($coalesce
+        ? sprintf 'COALESCE(%s)', join ', ', @coalesce_tokens
+        : shift                              @coalesce_tokens)
+        . ($alias && ($coalesce || $renamed_columns{$col})
+        ?  " AS " . ($renamed_columns{$col} || $col)
+        : '');
+    }
+  };
+
+  #===== switches and simple filters ========#
+
+  # special case transdate
+  if (grep { $form->{$_} } qw(transdatefrom transdateto)) {
+    $form->{"l_transdate"} = 1;
+    push @select_tokens, 'transdate';
+    for (qw(transdatefrom transdateto)) {
+      next unless $form->{$_};
+      push @where_tokens, sprintf "transdate %s ?", /from$/ ? '>=' : '<=';
+      push @bind_vars,    $form->{$_};
+    }
   }
 
-  if ($form->{l_soldtotal}) {
-    $where .= qq| AND (p.id = i.parts_id) AND (i.qty >= 0)|;
-    $group = qq| GROUP BY p.id, p.partnumber, p.description, p.onhand, p.unit, p.bin, p.sellprice, p.listprice, p.lastcost, p.priceupdate, pg.partsgroup|;
+  foreach (@like_filters) {
+    next unless $form->{$_};
+    $form->{"l_$_"} = '1'; # show the column
+    push @where_tokens, "$table_prefix{$_}$_ ILIKE ?";
+    push @bind_vars,    "%$form->{$_}%";
+  }
+
+  foreach (@simple_l_switches) {
+    next unless $form->{"l_$_"};
+    push @select_tokens, $_;
+  }
+
+  for ($form->{searchitems}) {
+    push @where_tokens, 'p.inventory_accno_id > 0'     if /part/;
+    push @where_tokens, 'p.inventory_accno_id IS NULL' if /service/;
+    push @where_tokens, 'NOT p.assembly'               if /service/;
+    push @where_tokens, '    p.assembly'               if /assembly/;
+  }
+
+  for ($form->{itemstatus}) {
+    push @where_tokens, 'p.id NOT IN
+        (SELECT DISTINCT parts_id FROM invoice UNION
+         SELECT DISTINCT parts_id FROM assembly UNION
+         SELECT DISTINCT parts_id FROM orderitems)'    if /orphaned/;
+    push @where_tokens, 'p.onhand = 0'                 if /orphaned/;
+    push @where_tokens, 'NOT p.obsolete'               if /active/;
+    push @where_tokens, '    p.obsolete',              if /obsolete/;
+    push @where_tokens, 'p.onhand > 0',                if /onhand/;
+    push @where_tokens, 'p.onhand < p.rop',            if /short/;
+  }
+
+  my $q_assembly_lastcost =
+    qq|(SELECT SUM(a_lc.qty * p_lc.lastcost / COALESCE(pfac_lc.factor, 1))
+        FROM assembly a_lc
+        LEFT JOIN parts p_lc            ON (a_lc.parts_id        = p_lc.id)
+        LEFT JOIN price_factors pfac_lc ON (p_lc.price_factor_id = pfac_lc.id)
+        WHERE (a_lc.id = p.id)) AS lastcost|;
+  $table_prefix{$q_assembly_lastcost} = ' ';
+
+  # special case: sorting by partnumber
+  # since partnumbers are expected to be prefixed integers, a special sorting is implemented sorting first lexically by prefix and then by suffix.
+  # and yes, that expression is designed to hold that array of regexes only once, so the map is kinda messy, sorry about that.
+  # ToDO: implement proper functional sorting
+  # Nette Idee von Sven, gibt aber Probleme wenn die Artikelnummern groesser als 32bit sind. Korrekt waere es, dass Sort-Natural-Modul zu nehmen
+  # Ich lass das mal hier drin, damit die Idee erhalten bleibt jb 28.5.2009 bug 1018
+  #$form->{sort} = join ', ', map { push @select_tokens, $_; ($table_prefix{$_} = "substring(partnumber,'[") . $_ } qw|^[:digit:]]+') [:digit:]]+')::INTEGER|
+  #  if $form->{sort} eq 'partnumber';
+
+  #my $order_clause = " ORDER BY $form->{sort} $sort_order";
+
+  my $limit_clause;
+  $limit_clause = " LIMIT 100"                   if $form->{top100};
+  $limit_clause = " LIMIT " . $form->{limit} * 1 if $form->{limit} * 1;
+
+  #=== joins and complicated filters ========#
+
+  my $bsooqr        = any { $form->{$_} } @oe_flags;
+  my @bsooqr_tokens = ();
+
+  push @select_tokens, @qsooqr_flags, 'quotation', 'cv', 'ioi.id', 'ioi.ioi'  if $bsooqr;
+  push @select_tokens, @deliverydate_flags                                    if $bsooqr && $form->{l_deliverydate};
+  push @select_tokens, $q_assembly_lastcost                                   if ($form->{searchitems} eq 'assembly') && $form->{l_lastcost};
+  push @bsooqr_tokens, q|module = 'ir' AND NOT ioi.assemblyitem|              if $form->{bought};
+  push @bsooqr_tokens, q|module = 'is' AND NOT ioi.assemblyitem|              if $form->{sold};
+  push @bsooqr_tokens, q|module = 'oe' AND NOT quotation AND cv = 'customer'| if $form->{ordered};
+  push @bsooqr_tokens, q|module = 'oe' AND NOT quotation AND cv = 'vendor'|   if $form->{onorder};
+  push @bsooqr_tokens, q|module = 'oe' AND     quotation AND cv = 'customer'| if $form->{quoted};
+  push @bsooqr_tokens, q|module = 'oe' AND     quotation AND cv = 'vendor'|   if $form->{rfq};
+  push @where_tokens, join ' OR ', map { "($_)" } @bsooqr_tokens              if $bsooqr;
+
+  $joins_needed{partsgroup}  = 1;
+  $joins_needed{pfac}        = 1;
+  $joins_needed{makemodel}   = 1 if grep { $form->{$_} || $form->{"l_$_"} } @makemodel_filters;
+  $joins_needed{cv}          = 1 if $bsooqr;
+  $joins_needed{apoe}        = 1 if $joins_needed{cv}   || grep { $form->{$_} || $form->{"l_$_"} } @apoe_filters;
+  $joins_needed{invoice_oi}  = 1 if $joins_needed{apoe} || grep { $form->{$_} || $form->{"l_$_"} } @invoice_oi_filters;
+
+  # in bsoorq, use qtys instead of onhand
+  if ($joins_needed{invoice_oi}) {
+    $renamed_columns{onhand} = 'onhand_before_bsooqr';
+    $renamed_columns{qty}    = 'onhand';
+  }
+
+  # special case for description search.
+  # up in the simple filter section the description filter got interpreted as something like: WHERE description ILIKE '%$form->{description}%'
+  # now we'd like to search also for the masked description entered in orderitems and invoice, so...
+  # find the old entries in of @where_tokens and @bind_vars, and adjust them
+  if ($joins_needed{invoice_oi}) {
+    for (my ($wi, $bi) = (0)x2; $wi <= $#where_tokens; $bi++ if $where_tokens[$wi++] =~ /\?/) {
+      next unless $where_tokens[$wi] =~ /\bdescription ILIKE/;
+      splice @where_tokens, $wi, 1, 'p.description ILIKE ? OR ioi.description ILIKE ?';
+      splice @bind_vars,    $bi, 0, $bind_vars[$bi];
+      last;
+    }
   }
 
-  $limit = qq| LIMIT 100| if ($form->{top100});
-
-  # connect to database
-  my $dbh = $form->dbconnect($myconfig);
-
-  my @sort_cols = qw(id partnumber description partsgroup bin priceupdate onhand
-                     invnumber ordnumber quonumber name drawing microfiche
-                     serialnumber soldtotal deliverydate);
-
-  my $sortorder = "partnumber";
-  $sortorder = $form->{sort} if ($form->{sort} && grep({ $_ eq $form->{sort} } @sort_cols));
-  $sortorder .= " DESC" if ($form->{revers});
-
-  my $query = "";
-
+  # now the master trick: soldtotal.
   if ($form->{l_soldtotal}) {
-    $form->{soldtotal} = 'soldtotal';
-    $query =
-      qq|SELECT p.id, p.partnumber, p.description, p.onhand, p.unit, 
-           p.bin, p.sellprice, p.listprice, p.lastcost, 
-           p.priceupdate, pg.partsgroup,sum(i.qty) AS soldtotal 
-         FROM parts p 
-         LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id), invoice i
-         WHERE $where
-         $group
-         ORDER BY $sortorder $limit|;
-  } else {
-    $query =
-      qq|SELECT p.id, p.partnumber, p.description, p.onhand, p.unit,
-           p.bin, p.sellprice, p.listprice, p.lastcost, p.rop, p.weight,
-           p.priceupdate, p.image, p.drawing, p.microfiche,
-           pg.partsgroup
-         FROM parts p
-         LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-         WHERE $where
-         $group
-         ORDER BY $sortorder $limit|;
+    push @where_tokens, 'NOT ioi.qty = 0';
+    push @group_tokens, @select_tokens;
+     map { s/.*\sAS\s+//si } @group_tokens;
+    push @select_tokens, 'SUM(ioi.qty)';
   }
 
-  my @all_values = @values;
-
-  # rebuild query for bought and sold items
-  if (   $form->{bought}
-      || $form->{sold}
-      || $form->{onorder}
-      || $form->{ordered}
-      || $form->{rfq}
-      || $form->{quoted}) {
-    my $union = "";
-    $query = "";
-    @all_values = ();
+  #============= build query ================#
 
-    if ($form->{bought} || $form->{sold}) {
+  my $token_builder = $make_token_builder->(\%joins_needed);
 
-      my @invvalues = @values;
-      my $invwhere = "$where";
-      $invwhere .= qq| AND i.assemblyitem = '0'|;
+  my @sort_cols    = (@simple_filters, qw(id bin priceupdate onhand invnumber ordnumber quonumber name serialnumber soldtotal deliverydate));
+     $form->{sort} = 'id' unless grep { $form->{"l_$_"} } grep { $form->{sort} eq $_ } @sort_cols; # sort by id if unknown or invisible column
+  my $sort_order   = ($form->{revers} ? ' DESC' : ' ASC');
+  my $order_clause = " ORDER BY " . $token_builder->($form->{sort}) . ($form->{revers} ? ' DESC' : ' ASC');
 
-      if ($form->{transdatefrom}) {
-        $invwhere .= qq| AND a.transdate >= ?|;
-        push(@invvalues, $form->{transdatefrom});
-      }
-
-      if ($form->{transdateto}) {
-        $invwhere .= qq| AND a.transdate <= ?|;
-        push(@invvalues, $form->{transdateto});
-      }
-
-      if ($form->{description}) {
-        $invwhere .= qq| AND i.description ILIKE ?|;
-        push(@invvalues, '%' . $form->{description} . '%');
-      }
-
-      $flds =
-        qq|p.id, p.partnumber, i.description, i.serialnumber,
-           i.qty AS onhand, i.unit, p.bin, i.sellprice,
-           p.listprice, p.lastcost, p.rop, p.weight,
-           p.priceupdate, p.image, p.drawing, p.microfiche,
-           pg.partsgroup,
-           a.invnumber, a.ordnumber, a.quonumber, i.trans_id,
-           ct.name, i.deliverydate|;
-
-      if ($form->{bought}) {
-        $query =
-          qq|SELECT $flds, 'ir' AS module, '' AS type, 1 AS exchangerate
-             FROM invoice i
-             JOIN parts p ON (p.id = i.parts_id)
-             JOIN ap a ON (a.id = i.trans_id)
-             JOIN vendor ct ON (a.vendor_id = ct.id)
-             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-             WHERE $invwhere|;
-
-        $union = qq| UNION |;
-
-        push(@all_values, @invvalues);
-      }
-
-      if ($form->{sold}) {
-        $query .=
-          qq|$union
-
-             SELECT $flds, 'is' AS module, '' AS type, 1 As exchangerate
-             FROM invoice i
-             JOIN parts p ON (p.id = i.parts_id)
-             JOIN ar a ON (a.id = i.trans_id)
-             JOIN customer ct ON (a.customer_id = ct.id)
-             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-             WHERE $invwhere|;
-        $union = qq| UNION |;
-
-        push(@all_values, @invvalues);
-      }
-    }
-
-    if ($form->{onorder} || $form->{ordered}) {
-      my @ordvalues = @values;
-      my $ordwhere = $where . qq| AND o.quotation = '0'|;
-
-      if ($form->{transdatefrom}) {
-        $ordwhere .= qq| AND o.transdate >= ?|;
-        push(@ordvalues, $form->{transdatefrom});
-      }
-
-      if ($form->{transdateto}) {
-        $ordwhere .= qq| AND o.transdate <= ?|;
-        push(@ordvalues, $form->{transdateto});
-      }
+  my $select_clause = join ', ',    map { $token_builder->($_, 1) } @select_tokens;
+  my $join_clause   = join ' ',     @joins{ grep $joins_needed{$_}, @join_order };
+  my $where_clause  = join ' AND ', map { "($_)" } @where_tokens;
+  my $group_clause  = ' GROUP BY ' . join ', ',    map { $token_builder->($_) } @group_tokens if scalar @group_tokens;
 
-      if ($form->{description}) {
-        $ordwhere .= qq| AND oi.description ILIKE ?|;
-        push(@ordvalues, '%' . $form->{description} . '%');
-      }
-
-      if ($form->{ordered}) {
-        $query .=
-          qq|$union
-
-             SELECT p.id, p.partnumber, oi.description, oi.serialnumber AS serialnumber,
-               oi.qty AS onhand, oi.unit, p.bin, oi.sellprice,
-               p.listprice, p.lastcost, p.rop, p.weight,
-               p.priceupdate, p.image, p.drawing, p.microfiche,
-               pg.partsgroup,
-               '' AS invnumber, o.ordnumber, o.quonumber, oi.trans_id,
-               ct.name, NULL AS deliverydate,
-               'oe' AS module, 'sales_order' AS type,
-               (SELECT buy FROM exchangerate ex
-                WHERE ex.curr = o.curr AND ex.transdate = o.transdate) AS exchangerate
-             FROM orderitems oi
-             JOIN parts p ON (oi.parts_id = p.id)
-             JOIN oe o ON (oi.trans_id = o.id)
-             JOIN customer ct ON (o.customer_id = ct.id)
-             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-             WHERE $ordwhere AND (o.customer_id > 0)|;
-        $union = qq| UNION |;
-
-        push(@all_values, @ordvalues);
-      }
-
-      if ($form->{onorder}) {
-        $query .=
-          qq|$union
-
-             SELECT p.id, p.partnumber, oi.description, oi.serialnumber AS serialnumber,
-               oi.qty * -1 AS onhand, oi.unit, p.bin, oi.sellprice,
-               p.listprice, p.lastcost, p.rop, p.weight,
-               p.priceupdate, p.image, p.drawing, p.microfiche,
-               pg.partsgroup,
-               '' AS invnumber, o.ordnumber, o.quonumber, oi.trans_id,
-               ct.name, NULL AS deliverydate,
-               'oe' AS module, 'purchase_order' AS type,
-               (SELECT sell FROM exchangerate ex
-               WHERE ex.curr = o.curr AND (ex.transdate = o.transdate)) AS exchangerate
-             FROM orderitems oi
-             JOIN parts p ON (oi.parts_id = p.id)
-             JOIN oe o ON (oi.trans_id = o.id)
-             JOIN vendor ct ON (o.vendor_id = ct.id)
-             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-             WHERE $ordwhere AND (o.vendor_id > 0)|;
-        $union = qq| UNION |;
-
-        push(@all_values, @ordvalues);
-      }
-
-    }
-
-    if ($form->{rfq} || $form->{quoted}) {
-      my $quowhere = $where . qq| AND o.quotation = '1'|;
-      my @quovalues = @values;
-
-      if ($form->{transdatefrom}) {
-        $quowhere .= qq| AND o.transdate >= ?|;
-        push(@quovalues, $form->{transdatefrom});
-      }
-
-      if ($form->{transdateto}) {
-        $quowhere .= qq| AND o.transdate <= ?|;
-        push(@quovalues, $form->{transdateto});
-      }
-
-      if ($form->{description}) {
-        $quowhere .= qq| AND oi.description ILIKE ?|;
-        push(@quovalues, '%' . $form->{description} . '%');
-      }
+  my %oe_flag_to_cvar = (
+    bought   => 'invoice',
+    sold     => 'invoice',
+    onorder  => 'orderitems',
+    ordered  => 'orderitems',
+    rfq      => 'orderitems',
+    quoted   => 'orderitems',
+  );
 
-      if ($form->{quoted}) {
-        $query .=
-          qq|$union
-
-             SELECT
-               p.id, p.partnumber, oi.description, oi.serialnumber AS serialnumber,
-               oi.qty AS onhand, oi.unit, p.bin, oi.sellprice,
-               p.listprice, p.lastcost, p.rop, p.weight,
-               p.priceupdate, p.image, p.drawing, p.microfiche,
-               pg.partsgroup,
-               '' AS invnumber, o.ordnumber, o.quonumber, oi.trans_id,
-               ct.name, NULL AS deliverydate, 'oe' AS module, 'sales_quotation' AS type,
-               (SELECT buy FROM exchangerate ex
-                WHERE (ex.curr = o.curr) AND (ex.transdate = o.transdate)) AS exchangerate
-             FROM orderitems oi
-             JOIN parts p ON (oi.parts_id = p.id)
-             JOIN oe o ON (oi.trans_id = o.id)
-             JOIN customer ct ON (o.customer_id = ct.id)
-             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-             WHERE $quowhere
-             AND o.customer_id > 0|;
-        $union = qq| UNION |;
-
-        push(@all_values, @quovalues);
-      }
+  my ($cvar_where, @cvar_values) = CVar->build_filter_query(
+    module         => 'IC',
+    trans_id_field => $bsooqr ? 'ioi.id': 'p.id',
+    filter         => $form,
+    sub_module     => $bsooqr ? [ uniq grep { $oe_flag_to_cvar{$form->{$_}} } @oe_flags ] : undef,
+  );
 
-      if ($form->{rfq}) {
-        $query .=
-          qq|$union
-
-             SELECT p.id, p.partnumber, oi.description, oi.serialnumber AS serialnumber,
-               oi.qty * -1 AS onhand, oi.unit, p.bin, oi.sellprice,
-               p.listprice, p.lastcost, p.rop, p.weight,
-               p.priceupdate, p.image, p.drawing, p.microfiche,
-               pg.partsgroup,
-               '' AS invnumber, o.ordnumber, o.quonumber, oi.trans_id,
-               ct.name, NULL AS deliverydate,
-               'oe' AS module, 'request_quotation' AS type,
-               (SELECT sell FROM exchangerate ex
-               WHERE (ex.curr = o.curr) AND (ex.transdate = o.transdate)) AS exchangerate
-             FROM orderitems oi
-             JOIN parts p ON (oi.parts_id = p.id)
-             JOIN oe o ON (oi.trans_id = o.id)
-             JOIN vendor ct ON (o.vendor_id = ct.id)
-             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
-             WHERE $quowhere
-             AND o.vendor_id > 0|;
-
-        push(@all_values, @quovalues);
-      }
+  if ($cvar_where) {
+    $where_clause .= qq| AND ($cvar_where)|;
+    push @bind_vars, @cvar_values;
+  }
 
-    }
-    $query .= qq| ORDER BY  | . $sortorder;
+  my $query = <<"  SQL";
+    SELECT DISTINCT $select_clause
+    FROM parts p
+    $join_clause
+    WHERE $where_clause
+    $group_clause
+    $order_clause
+    $limit_clause
+  SQL
 
-  }
+  $form->{parts} = selectall_hashref_query($form, $dbh, $query, @bind_vars);
 
-  $form->{parts} = selectall_hashref_query($form, $dbh, $query, @all_values);
+  map { $_->{onhand} *= 1 } @{ $form->{parts} };
 
+  # post processing for assembly parts lists (bom)
+  # for each part get the assembly parts and add them into the partlist.
   my @assemblies;
-  # include individual items for assemblies
   if ($form->{searchitems} eq 'assembly' && $form->{bom}) {
     $query =
       qq|SELECT p.id, p.partnumber, p.description, a.qty AS onhand,
            p.unit, p.bin,
            p.sellprice, p.listprice, p.lastcost,
            p.rop, p.weight, p.priceupdate,
-           p.image, p.drawing, p.microfiche
-         FROM parts p, assembly a
-         WHERE (p.id = a.parts_id) AND (a.id = ?)|;
-    $sth = prepare_query($form, $dbh, $query);
+           p.image, p.drawing, p.microfiche,
+           pfac.factor
+         FROM parts p
+         INNER JOIN assembly a ON (p.id = a.parts_id)
+         $joins{pfac}
+         WHERE a.id = ?|;
+    my $sth = prepare_query($form, $dbh, $query);
 
-    foreach $item (@{ $form->{parts} }) {
+    foreach my $item (@{ $form->{parts} }) {
       push(@assemblies, $item);
       do_statement($form, $sth, $query, conv_i($item->{id}));
 
-      while ($ref = $sth->fetchrow_hashref(NAME_lc)) {
+      while (my $ref = $sth->fetchrow_hashref("NAME_lc")) {
         $ref->{assemblyitem} = 1;
+        map { $ref->{$_} /= $ref->{factor} || 1 } qw(sellprice listprice lastcost);
         push(@assemblies, $ref);
       }
       $sth->finish;
@@ -1180,57 +1073,40 @@ sub all_parts {
     $form->{parts} = \@assemblies;
   }
 
-  $dbh->disconnect;
   $main::lxdebug->leave_sub();
+
+  return wantarray ? @{ $form->{parts} } : $form->{parts};
 }
 
-sub update_prices {
+sub _create_filter_for_priceupdate {
   $main::lxdebug->enter_sub();
 
-  my ($self, $myconfig, $form) = @_;
+  my $self     = shift;
+  my $myconfig = \%main::myconfig;
+  my $form     = $main::form;
+
   my @where_values;
   my $where = '1 = 1';
-  my $var;
-
-  my $group;
-  my $limit;
 
-  my @where_values;
+  foreach my $item (qw(partnumber drawing microfiche make model pg.partsgroup)) {
+    my $column = $item;
+    $column =~ s/.*\.//;
+    next unless ($form->{$column});
 
-  if ($item ne 'make') {
-    foreach my $item (qw(partnumber drawing microfiche make model pg.partsgroup)) {
-      my $column = $item;
-      $column =~ s/.*\.//;
-      next unless ($form->{$column});
-      $where .= qq| AND $item ILIKE ?|;
-      push(@where_values, '%' . $form->{$column} . '%');
-    }
+    $where .= qq| AND $item ILIKE ?|;
+    push(@where_values, '%' . $form->{$column} . '%');
   }
 
-  # special case for description
-  if ($form->{description}
-      && !(   $form->{bought}  || $form->{sold} || $form->{onorder}
-           || $form->{ordered} || $form->{rfq} || $form->{quoted})) {
-    $where .= qq| AND (p.description ILIKE ?)|;
-    push(@where_values, '%' . $form->{description} . '%');
-  }
+  foreach my $item (qw(description serialnumber)) {
+    next unless ($form->{$item});
 
-  # special case for serialnumber
-  if ($form->{l_serialnumber} && $form->{serialnumber}) {
-    $where .= qq| AND serialnumber ILIKE ?|;
-    push(@where_values, '%' . $form->{serialnumber} . '%');
+    $where .= qq| AND (${item} ILIKE ?)|;
+    push(@where_values, '%' . $form->{$item} . '%');
   }
 
 
   # items which were never bought, sold or on an order
   if ($form->{itemstatus} eq 'orphaned') {
-    $form->{onhand}  = $form->{short}   = 0;
-    $form->{bought}  = $form->{sold}    = 0;
-    $form->{onorder} = $form->{ordered} = 0;
-    $form->{rfq}     = $form->{quoted}  = 0;
-
-    $form->{transdatefrom} = $form->{transdateto} = "";
-
     $where .=
       qq| AND (p.onhand = 0)
           AND p.id NOT IN
@@ -1241,31 +1117,93 @@ sub update_prices {
               UNION
               SELECT DISTINCT parts_id FROM orderitems
             )|;
-  }
 
-  if ($form->{itemstatus} eq 'active') {
+  } elsif ($form->{itemstatus} eq 'active') {
     $where .= qq| AND p.obsolete = '0'|;
-  }
 
-  if ($form->{itemstatus} eq 'obsolete') {
+  } elsif ($form->{itemstatus} eq 'obsolete') {
     $where .= qq| AND p.obsolete = '1'|;
-    $form->{onhand} = $form->{short} = 0;
-  }
 
-  if ($form->{itemstatus} eq 'onhand') {
+  } elsif ($form->{itemstatus} eq 'onhand') {
     $where .= qq| AND p.onhand > 0|;
-  }
 
-  if ($form->{itemstatus} eq 'short') {
+  } elsif ($form->{itemstatus} eq 'short') {
     $where .= qq| AND p.onhand < p.rop|;
+
   }
 
   foreach my $column (qw(make model)) {
-    next unless ($form->{$colum});
+    next unless ($form->{$column});
     $where .= qq| AND p.id IN (SELECT DISTINCT parts_id FROM makemodel WHERE $column ILIKE ?|;
     push(@where_values, '%' . $form->{$column} . '%');
   }
 
+  $main::lxdebug->leave_sub();
+
+  return ($where, @where_values);
+}
+
+sub get_num_matches_for_priceupdate {
+  $main::lxdebug->enter_sub();
+
+  my $self     = shift;
+
+  my $myconfig = \%main::myconfig;
+  my $form     = $main::form;
+
+  my $dbh      = $form->get_standard_dbh($myconfig);
+
+  my ($where, @where_values) = $self->_create_filter_for_priceupdate();
+
+  my $num_updated = 0;
+  my $query;
+
+  for my $column (qw(sellprice listprice)) {
+    next if ($form->{$column} eq "");
+
+    $query =
+      qq|SELECT COUNT(*)
+         FROM parts
+         WHERE id IN
+           (SELECT p.id
+            FROM parts p
+            LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
+            WHERE $where)|;
+    my ($result)  = selectfirst_array_query($form, $dbh, $query, @where_values);
+    $num_updated += $result if (0 <= $result);
+  }
+
+  $query =
+    qq|SELECT COUNT(*)
+       FROM prices
+       WHERE parts_id IN
+         (SELECT p.id
+          FROM parts p
+          LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
+          WHERE $where) AND (pricegroup_id = ?)|;
+  my $sth = prepare_query($form, $dbh, $query);
+
+  for my $i (1 .. $form->{price_rows}) {
+    next if ($form->{"price_$i"} eq "");
+
+    my ($result)  = do_statement($form, $sth, $query, @where_values, conv_i($form->{"pricegroup_id_$i"}));
+    $num_updated += $result if (0 <= $result);
+  }
+  $sth->finish();
+
+  $main::lxdebug->leave_sub();
+
+  return $num_updated;
+}
+
+sub update_prices {
+  $main::lxdebug->enter_sub();
+
+  my ($self, $myconfig, $form) = @_;
+
+  my ($where, @where_values) = $self->_create_filter_for_priceupdate();
+  my $num_updated = 0;
+
   # connect to database
   my $dbh = $form->dbconnect_noauto($myconfig);
 
@@ -1280,14 +1218,15 @@ sub update_prices {
       $operator = '*';
     }
 
-    $query =
+    my $query =
       qq|UPDATE parts SET $column = $column $operator ?
          WHERE id IN
            (SELECT p.id
             FROM parts p
             LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
             WHERE $where)|;
-    do_query($from, $dbh, $query, $value, @where_values);
+    my $result    = do_query($form, $dbh, $query, $value, @where_values);
+    $num_updated += $result if (0 <= $result);
   }
 
   my $q_add =
@@ -1312,12 +1251,15 @@ sub update_prices {
     next if ($form->{"price_$i"} eq "");
 
     my $value = $form->parse_amount($myconfig, $form->{"price_$i"});
+    my $result;
 
     if ($form->{"pricegroup_type_$i"} eq "percent") {
-      do_statement($form, $sth_multiply, $q_multiply, ($value / 100) + 1, @where_values, conv_i($form->{"pricegroup_id_$i"}));
+      $result = do_statement($form, $sth_multiply, $q_multiply, ($value / 100) + 1, @where_values, conv_i($form->{"pricegroup_id_$i"}));
     } else {
-      do_statement($form, $sth_add, $q_add, $value, @where_values, conv_i($form->{"pricegroup_id_$i"}));
+      $result = do_statement($form, $sth_add, $q_add, $value, @where_values, conv_i($form->{"pricegroup_id_$i"}));
     }
+
+    $num_updated += $result if (0 <= $result);
   }
 
   $sth_add->finish();
@@ -1328,7 +1270,7 @@ sub update_prices {
 
   $main::lxdebug->leave_sub();
 
-  return $rc;
+  return $num_updated;
 }
 
 sub create_links {
@@ -1340,6 +1282,7 @@ sub create_links {
   my $dbh = $form->dbconnect($myconfig);
 
   my @values = ('%' . $module . '%');
+  my $query;
 
   if ($form->{id}) {
     $query =
@@ -1360,9 +1303,9 @@ sub create_links {
   }
 
   my $sth = prepare_execute_query($form, $dbh, $query, @values);
-  while (my $ref = $sth->fetchrow_hashref(NAME_lc)) {
+  while (my $ref = $sth->fetchrow_hashref("NAME_lc")) {
     foreach my $key (split(/:/, $ref->{link})) {
-      if ($key =~ /$module/) {
+      if ($key =~ /\Q$module\E/) {
         if (   ($ref->{id} eq $ref->{inventory_accno_id})
             || ($ref->{id} eq $ref->{income_accno_id})
             || ($ref->{id} eq $ref->{expense_accno_id})) {
@@ -1429,7 +1372,7 @@ sub get_parts {
   my $sth = prepare_execute_query($form, $dbh, $query, @values);
 
   my $j = 0;
-  while (my $ref = $sth->fetchrow_hashref(NAME_lc)) {
+  while (my $ref = $sth->fetchrow_hashref("NAME_lc")) {
     if (($ref->{partnumber} eq "*") && ($ref->{description} eq "")) {
       next;
     }
@@ -1458,7 +1401,7 @@ sub get_soldtotal {
   my ($dbh, $id) = @_;
 
   my $query = qq|SELECT sum(qty) FROM invoice WHERE parts_id = ?|;
-  my ($sum) = selectrow_query($form, $dbh, $query, conv_i($id));
+  my ($sum) = selectrow_query($main::form, $dbh, $query, conv_i($id));
   $sum ||= 0;
 
   $main::lxdebug->leave_sub();
@@ -1476,16 +1419,20 @@ sub retrieve_languages {
 
   my @values;
   my $where;
+  my $query;
 
   if ($form->{language_values} ne "") {
     $query =
       qq|SELECT l.id, l.description, tr.translation, tr.longdescription
          FROM language l
-         LEFT OUTER JOIN translation tr ON (tr.language_id = l.id) AND (tr.parts_id = ?)|;
+         LEFT OUTER JOIN translation tr ON (tr.language_id = l.id) AND (tr.parts_id = ?)
+         ORDER BY lower(l.description)|;
     @values = (conv_i($form->{id}));
 
   } else {
-    $query = qq|SELECT id, description FROM language|;
+    $query = qq|SELECT id, description
+                FROM language
+                ORDER BY lower(description)|;
   }
 
   my $languages = selectall_hashref_query($form, $dbh, $query, @values);
@@ -1506,17 +1453,17 @@ sub follow_account_chain {
 
   my ($query, $sth);
 
-  $query =
-    qq|SELECT c.new_chart_id, date($transdate) >= c.valid_from AS is_valid, | .
-    qq|  cnew.accno | .
-    qq|FROM chart c | .
-    qq|LEFT JOIN chart cnew ON c.new_chart_id = cnew.id | .
-    qq|WHERE (c.id = ?) AND NOT c.new_chart_id ISNULL AND (c.new_chart_id > 0)|;
-  $sth = prepare_query($form, $dbh, $query);
+  $form->{ACCOUNT_CHAIN_BY_ID} ||= {
+    map { $_->{id} => $_ }
+      selectall_hashref_query($form, $dbh, <<SQL, $transdate) };
+    SELECT c.id, c.new_chart_id, date(?) >= c.valid_from AS is_valid, cnew.accno
+    FROM chart c
+    LEFT JOIN chart cnew ON c.new_chart_id = cnew.id
+    WHERE NOT c.new_chart_id IS NULL AND (c.new_chart_id > 0)
+SQL
 
   while (1) {
-    do_statement($form, $sth, $query, $accno_id);
-    $ref = $sth->fetchrow_hashref();
+    my $ref = $form->{ACCOUNT_CHAIN_BY_ID}->{$accno_id};
     last unless ($ref && $ref->{"is_valid"} &&
                  !grep({ $_ == $ref->{"new_chart_id"} } @visited_accno_ids));
     $accno_id = $ref->{"new_chart_id"};
@@ -1530,16 +1477,19 @@ sub follow_account_chain {
 }
 
 sub retrieve_accounts {
-  $main::lxdebug->enter_sub(2);
-
-  my ($self, $myconfig, $form, $parts_id, $index) = @_;
+  $main::lxdebug->enter_sub;
 
-  my ($query, $sth, $dbh);
+  my $self     = shift;
+  my $myconfig = shift;
+  my $form     = shift;
+  my $dbh      = $form->get_standard_dbh;
+  my %args     = @_;     # index => part_id
 
-  $form->{"taxzone_id"} *= 1;
+  $form->{taxzone_id} *= 1;
 
-  $dbh = $form->dbconnect($myconfig);
+  return unless grep $_, values %args; # shortfuse if no part_id supplied
 
+  # transdate madness.
   my $transdate = "";
   if ($form->{type} eq "invoice") {
     if (($form->{vc} eq "vendor") || !$form->{deliverydate}) {
@@ -1547,7 +1497,7 @@ sub retrieve_accounts {
     } else {
       $transdate = $form->{deliverydate};
     }
-  } elsif ($form->{type} eq "credit_note") {
+  } elsif (($form->{type} eq "credit_note") || ($form->{script} eq 'ir.pl')) {
     $transdate = $form->{invdate};
   } else {
     $transdate = $form->{transdate};
@@ -1558,76 +1508,176 @@ sub retrieve_accounts {
   } else {
     $transdate = $dbh->quote($transdate);
   }
+  #/transdate
+  my $inc_exp = $form->{"vc"} eq "customer" ? "income_accno_id" : "expense_accno_id";
+
+  my @part_ids = grep { $_ } values %args;
+  my $in       = join ',', ('?') x @part_ids;
+
+  my %accno_by_part = map { $_->{id} => $_ }
+    selectall_hashref_query($form, $dbh, <<SQL, @part_ids);
+    SELECT
+      p.id, p.inventory_accno_id AS is_part,
+      bg.inventory_accno_id,
+      bg.income_accno_id_$form->{taxzone_id} AS income_accno_id,
+      bg.expense_accno_id_$form->{taxzone_id} AS expense_accno_id,
+      c1.accno AS inventory_accno,
+      c2.accno AS income_accno,
+      c3.accno AS expense_accno
+    FROM parts p
+    LEFT JOIN buchungsgruppen bg ON p.buchungsgruppen_id = bg.id
+    LEFT JOIN chart c1 ON bg.inventory_accno_id = c1.id
+    LEFT JOIN chart c2 ON bg.income_accno_id_$form->{taxzone_id} = c2.id
+    LEFT JOIN chart c3 ON bg.expense_accno_id_$form->{taxzone_id} = c3.id
+    WHERE p.id IN ($in)
+SQL
+
+  my $sth_tax = prepare_query($::form, $dbh, <<SQL);
+    SELECT c.accno, t.taxdescription AS description, t.rate, t.taxnumber
+    FROM tax t
+    LEFT JOIN chart c ON c.id = t.chart_id
+    WHERE t.id IN
+      (SELECT tk.tax_id
+       FROM taxkeys tk
+       WHERE tk.chart_id = ? AND startdate <= ?
+       ORDER BY startdate DESC LIMIT 1)
+SQL
+
+  while (my ($index => $part_id) = each %args) {
+    my $ref = $accno_by_part{$part_id} or next;
+
+    $ref->{"inventory_accno_id"} = undef unless $ref->{"is_part"};
+
+    my %accounts;
+    for my $type (qw(inventory income expense)) {
+      next unless $ref->{"${type}_accno_id"};
+      ($accounts{"${type}_accno_id"}, $accounts{"${type}_accno"}) =
+        $self->follow_account_chain($form, $dbh, $transdate, $ref->{"${type}_accno_id"}, $ref->{"${type}_accno"});
+    }
 
-  $query =
-    qq|SELECT | .
-    qq|  p.inventory_accno_id AS is_part, | .
-    qq|  bg.inventory_accno_id, | .
-    qq|  bg.income_accno_id_$form->{taxzone_id} AS income_accno_id, | .
-    qq|  bg.expense_accno_id_$form->{taxzone_id} AS expense_accno_id, | .
-    qq|  c1.accno AS inventory_accno, | .
-    qq|  c2.accno AS income_accno, | .
-    qq|  c3.accno AS expense_accno | .
-    qq|FROM parts p | .
-    qq|LEFT JOIN buchungsgruppen bg ON p.buchungsgruppen_id = bg.id | .
-    qq|LEFT JOIN chart c1 ON bg.inventory_accno_id = c1.id | .
-    qq|LEFT JOIN chart c2 ON bg.income_accno_id_$form->{taxzone_id} = c2.id | .
-    qq|LEFT JOIN chart c3 ON bg.expense_accno_id_$form->{taxzone_id} = c3.id | .
-    qq|WHERE p.id = ?|;
-  my $ref = selectfirst_hashref_query($form, $dbh, $query, $parts_id);
-
-  if (!$ref) {
-    $dbh->disconnect();
-    return $main::lxdebug->leave_sub(2);
+    $form->{"${_}_accno_$index"} = $accounts{"${_}_accno"} for qw(inventory income expense);
+
+    $sth_tax->execute($accounts{$inc_exp}, quote_db_date($transdate));
+    $ref = $sth_tax->fetchrow_hashref or next;
+
+    $form->{"taxaccounts_$index"} = $ref->{"accno"};
+    $form->{"taxaccounts"} .= "$ref->{accno} "if $form->{"taxaccounts"} !~ /$ref->{accno}/;
+
+    $form->{"$ref->{accno}_${_}"} = $ref->{$_} for qw(rate description taxnumber);
   }
 
-  $ref->{"inventory_accno_id"} = undef unless ($ref->{"is_part"});
+  $sth_tax->finish;
 
-  my %accounts;
-  foreach my $type (qw(inventory income expense)) {
-    next unless ($ref->{"${type}_accno_id"});
-    ($accounts{"${type}_accno_id"}, $accounts{"${type}_accno"}) =
-      $self->follow_account_chain($form, $dbh, $transdate,
-                                  $ref->{"${type}_accno_id"},
-                                  $ref->{"${type}_accno"});
+  $::lxdebug->leave_sub;
+}
+
+sub get_basic_part_info {
+  $main::lxdebug->enter_sub();
+
+  my $self     = shift;
+  my %params   = @_;
+
+  Common::check_params(\%params, qw(id));
+
+  my @ids      = 'ARRAY' eq ref $params{id} ? @{ $params{id} } : ($params{id});
+
+  if (!scalar @ids) {
+    $main::lxdebug->leave_sub();
+    return ();
   }
 
-  map({ $form->{"${_}_accno_$index"} = $accounts{"${_}_accno"} }
-      qw(inventory income expense));
+  my $myconfig = \%main::myconfig;
+  my $form     = $main::form;
 
-  my $inc_exp = $form->{"vc"} eq "customer" ? "income" : "expense";
-  my $accno_id = $accounts{"${inc_exp}_accno_id"};
+  my $dbh      = $form->get_standard_dbh($myconfig);
 
-  $query =
-    qq|SELECT c.accno, t.taxdescription AS description, t.rate, t.taxnumber | .
-    qq|FROM tax t | .
-    qq|LEFT JOIN chart c ON c.id = t.chart_id | .
-    qq|WHERE t.id IN | .
-    qq|  (SELECT tk.tax_id | .
-    qq|   FROM taxkeys tk | .
-    qq|   WHERE tk.chart_id = ? AND startdate <= | . quote_db_date($transdate) .
-    qq|   ORDER BY startdate DESC LIMIT 1) |;
-  $ref = selectfirst_hashref_query($form, $dbh, $query, $accno_id);
-
-  unless ($ref) {
-    $main::lxdebug->leave_sub(2);
+  my $query    = qq|SELECT * FROM parts WHERE id IN (| . join(', ', ('?') x scalar(@ids)) . qq|)|;
+
+  my $info     = selectall_hashref_query($form, $dbh, $query, map { conv_i($_) } @ids);
+
+  if ('' eq ref $params{id}) {
+    $info = $info->[0] || { };
+
+    $main::lxdebug->leave_sub();
+    return $info;
+  }
+
+  my %info_map = map { $_->{id} => $_ } @{ $info };
+
+  $main::lxdebug->leave_sub();
+
+  return %info_map;
+}
+
+sub prepare_parts_for_printing {
+  $main::lxdebug->enter_sub();
+
+  my $self     = shift;
+  my %params   = @_;
+
+  my $myconfig = \%main::myconfig;
+  my $form     = $main::form;
+
+  my $dbh      = $params{dbh} || $form->get_standard_dbh($myconfig);
+
+  my $prefix   = $params{prefix} || 'id_';
+  my $rowcount = defined $params{rowcount} ? $params{rowcount} : $form->{rowcount};
+
+  my @part_ids = keys %{ { map { $_ => 1 } grep { $_ } map { $form->{"${prefix}${_}"} } (1 .. $rowcount) } };
+
+  if (!@part_ids) {
+    $main::lxdebug->leave_sub();
     return;
   }
 
-  $form->{"taxaccounts_$index"} = $ref->{"accno"};
-  if ($form->{"taxaccounts"} !~ /$ref->{accno}/) {
-    $form->{"taxaccounts"} .= "$ref->{accno} ";
+  my $placeholders = join ', ', ('?') x scalar(@part_ids);
+  my $query        = qq|SELECT mm.parts_id, mm.model, v.name AS make
+                        FROM makemodel mm
+                        LEFT JOIN vendor v ON (mm.make = v.id)
+                        WHERE mm.parts_id IN ($placeholders)|;
+
+  my %makemodel    = ();
+
+  my $sth          = prepare_execute_query($form, $dbh, $query, @part_ids);
+
+  while (my $ref = $sth->fetchrow_hashref()) {
+    $makemodel{$ref->{parts_id}} ||= [];
+    push @{ $makemodel{$ref->{parts_id}} }, $ref;
   }
-  map({ $form->{"$ref->{accno}_${_}"} = $ref->{$_}; }
-      qw(rate description taxnumber));
 
-#   $main::lxdebug->message(0, "formvars: rate " . $form->{"$ref->{accno}_rate"} .
-#                           " description " . $form->{"$ref->{accno}_description"} .
-#                           " taxnumber " . $form->{"$ref->{accno}_taxnumber"} .
-#                           " || taxaccounts_$index " . $form->{"taxaccounts_$index"} .
-#                           " || taxaccounts " . $form->{"taxaccounts"});
+  $sth->finish();
 
-  $main::lxdebug->leave_sub(2);
+  my @columns = qw(ean image microfiche drawing weight);
+
+  $query      = qq|SELECT id, | . join(', ', @columns) . qq|
+                   FROM parts
+                   WHERE id IN ($placeholders)|;
+
+  my %data    = selectall_as_map($form, $dbh, $query, 'id', \@columns, @part_ids);
+
+  map { $form->{TEMPLATE_ARRAYS}{$_} = [] } (qw(make model), @columns);
+
+  foreach my $i (1 .. $rowcount) {
+    my $id = $form->{"${prefix}${i}"};
+
+    next if (!$id);
+
+    foreach (@columns) {
+      push @{ $form->{TEMPLATE_ARRAYS}{$_} }, $data{$id}->{$_};
+    }
+
+    push @{ $form->{TEMPLATE_ARRAYS}{make} },  [];
+    push @{ $form->{TEMPLATE_ARRAYS}{model} }, [];
+
+    next if (!$makemodel{$id});
+
+    foreach my $ref (@{ $makemodel{$id} }) {
+      map { push @{ $form->{TEMPLATE_ARRAYS}{$_}->[-1] }, $ref->{$_} } qw(make model);
+    }
+  }
+
+  $main::lxdebug->leave_sub();
 }
 
+
 1;