X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FPE.pm;h=28f3ba5c11fb26d338136945cf35c80e7d12cd78;hb=03d3d025ea4c8bea085fc7cdf1fe7be0b513eb63;hp=d165a2f9ac2f8c49ea1c7fd37a86a4c10d8a383a;hpb=0884406403ce36af3484924086527ba689807329;p=kivitendo-erp.git diff --git a/SL/PE.pm b/SL/PE.pm index d165a2f9a..28f3ba5c1 100644 --- a/SL/PE.pm +++ b/SL/PE.pm @@ -38,6 +38,8 @@ use Data::Dumper; use SL::DBUtils; +use strict; + sub partsgroups { $main::lxdebug->enter_sub(); @@ -90,10 +92,11 @@ sub save_partsgroup { $form->{discount} /= 100; my @values = ($form->{partsgroup}); + my $query; if ($form->{id}) { $query = qq|UPDATE partsgroup SET partsgroup = ? WHERE id = ?|; - push(@values, $form->{id}); + push(@values, $form->{id}); } else { $query = qq|INSERT INTO partsgroup (partsgroup) VALUES (?)|; } @@ -119,7 +122,7 @@ sub get_partsgroup { qq|WHERE pg.id = ?|; my $sth = prepare_execute_query($form, $dbh, $query, $form->{id}, $form->{id}); - my $ref = $sth->fetchrow_hashref(NAME_lc); + my $ref = $sth->fetchrow_hashref("NAME_lc"); map({ $form->{$_} = $ref->{$_} } keys(%{$ref})); $sth->finish; @@ -139,7 +142,7 @@ sub delete_tuple { my $table = $form->{type} eq "pricegroup" ? "pricegroup" : "partsgroup"; - $query = qq|DELETE FROM $table WHERE id = ?|; + my $query = qq|DELETE FROM $table WHERE id = ?|; do_query($form, $dbh, $query, $form->{id}); $dbh->disconnect; @@ -169,7 +172,7 @@ sub pricegroups { my $first = 1; $where .= qq| AND id NOT IN (|; - foreach my $table (qw(invoice orderitems prices rmaitems)) { + foreach my $table (qw(invoice orderitems prices)) { $where .= "UNION " unless ($first); $first = 0; $where .= @@ -216,7 +219,7 @@ sub save_pricegroup { if ($form->{id}) { $query = qq|UPDATE pricegroup SET pricegroup = ? WHERE id = ? |; - push(@values, $form->{id}); + push(@values, $form->{id}); } else { $query = qq|INSERT INTO pricegroup (pricegroup) VALUES (?)|; } @@ -240,7 +243,7 @@ sub get_pricegroup { my $query = qq|SELECT id, pricegroup FROM pricegroup WHERE id = ?|; my $sth = prepare_execute_query($form, $dbh, $query, $form->{id}); - my $ref = $sth->fetchrow_hashref(NAME_lc); + my $ref = $sth->fetchrow_hashref("NAME_lc"); map({ $form->{$_} = $ref->{$_} } keys(%{$ref})); @@ -250,7 +253,7 @@ sub get_pricegroup { my @values = (); $query = qq|SELECT |; - foreach my $table (qw(invoice orderitems prices rmaitems)) { + foreach my $table (qw(invoice orderitems prices)) { $query .= " + " unless ($first); $first = 0; $query .= qq|(SELECT COUNT(*) FROM $table WHERE pricegroup_id = ?) |;