X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FPE.pm;h=4d7176dd22f20a70792c5ce610c7fef431662607;hb=46efaf453010f2744b53ff402b9691d2cd2382ec;hp=31a8bd507a35ea6e7583b42fcc0ddf8e0bc830ff;hpb=3d967be3d2f32e2b00f5f55769edcbf5be866ce6;p=kivitendo-erp.git diff --git a/SL/PE.pm b/SL/PE.pm index 31a8bd507..4d7176dd2 100644 --- a/SL/PE.pm +++ b/SL/PE.pm @@ -59,6 +59,9 @@ sub partsgroups { $where .= qq| AND id NOT IN | . qq| (SELECT DISTINCT partsgroup_id FROM parts | . + qq| WHERE NOT partsgroup_id ISNULL | . + qq| UNION | . + qq| SELECT DISTINCT partsgroup_id FROM custom_variable_config_partsgroups | . qq| WHERE NOT partsgroup_id ISNULL) |; } @@ -96,7 +99,7 @@ sub save_partsgroup { if ($form->{id}) { $query = qq|UPDATE partsgroup SET partsgroup = ? WHERE id = ?|; - push(@values, $form->{id}); + push(@values, $form->{id}); } else { $query = qq|INSERT INTO partsgroup (partsgroup) VALUES (?)|; } @@ -129,6 +132,12 @@ sub get_partsgroup { $dbh->disconnect; + # also not orphaned if partsgroup is selected for a cvar filter + if ($form->{orphaned}) { + my $cvar_count = scalar( @{ SL::DB::PartsGroup->new(id => $form->{id})->custom_variable_configs } ); + $form->{orphaned} = !$cvar_count; + } + $main::lxdebug->leave_sub(); } @@ -172,7 +181,7 @@ sub pricegroups { my $first = 1; $where .= qq| AND id NOT IN (|; - foreach my $table (qw(invoice orderitems prices rmaitems)) { + foreach my $table (qw(invoice orderitems prices)) { $where .= "UNION " unless ($first); $first = 0; $where .= @@ -219,7 +228,7 @@ sub save_pricegroup { if ($form->{id}) { $query = qq|UPDATE pricegroup SET pricegroup = ? WHERE id = ? |; - push(@values, $form->{id}); + push(@values, $form->{id}); } else { $query = qq|INSERT INTO pricegroup (pricegroup) VALUES (?)|; } @@ -253,7 +262,7 @@ sub get_pricegroup { my @values = (); $query = qq|SELECT |; - foreach my $table (qw(invoice orderitems prices rmaitems)) { + foreach my $table (qw(invoice orderitems prices)) { $query .= " + " unless ($first); $first = 0; $query .= qq|(SELECT COUNT(*) FROM $table WHERE pricegroup_id = ?) |;