X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FPresenter%2FPart.pm;h=9533e1d6c48a669f30cd73d7aff9841b909e925f;hb=0cb6e3af8457c1b10c356a1749269b16c5cd3328;hp=1a33a463bb01bb4a8b8da7151ac17d8889855bfb;hpb=df33875fc30c508b60af9421d0061e66cdc0d55a;p=kivitendo-erp.git diff --git a/SL/Presenter/Part.pm b/SL/Presenter/Part.pm index 1a33a463b..9533e1d6c 100644 --- a/SL/Presenter/Part.pm +++ b/SL/Presenter/Part.pm @@ -5,19 +5,43 @@ use strict; use SL::DB::Part; use Exporter qw(import); -our @EXPORT = qw(part_picker); +our @EXPORT = qw(part_picker part); + +use Carp; + +sub part { + my ($self, $part, %params) = @_; + + $params{display} ||= 'inline'; + + croak "Unknown display type '$params{display}'" unless $params{display} =~ m/^(?:inline|table-cell)$/; + + my $text = join '', ( + $params{no_link} ? '' : '', + $self->escape($part->partnumber), + $params{no_link} ? '' : '', + ); + return $self->escaped_text($text); +} sub part_picker { my ($self, $name, $value, %params) = @_; - $value = SL::DB::Manager::Part->find_by(id => $value) if !ref $value; + $value = SL::DB::Manager::Part->find_by(id => $value) if $value && !ref $value; my $id = delete($params{id}) || $self->name_to_id($name); + my $fat_set_item = delete $params{fat_set_item}; + + my @classes = $params{class} ? ($params{class}) : (); + push @classes, 'part_autocomplete'; + push @classes, 'partpicker_fat_set_item' if $fat_set_item; my $ret = - $self->input_tag($name, (ref $value && $value->can('id') ? $value->id : ''), class => 'part_autocomplete', type => 'hidden', id => $id) . + $self->input_tag($name, (ref $value && $value->can('id') ? $value->id : ''), class => "@classes", type => 'hidden', id => $id) . join('', map { $params{$_} ? $self->input_tag("", delete $params{$_}, id => "${id}_${_}", type => 'hidden') : '' } qw(column type unit convertible_unit)) . $self->input_tag("", (ref $value && $value->can('description')) ? $value->description : '', id => "${id}_name", %params); + $::request->presenter->need_reinit_widgets($id); + $self->html_tag('span', $ret, class => 'part_picker'); } @@ -29,11 +53,15 @@ __END__ =head1 NAME -SL::Presenter::Part - Part lelated presenter stuff +SL::Presenter::Part - Part related presenter stuff =head1 SYNOPSIS -see L + # Create an html link for editing/opening a part/service/assembly + my $object = my $object = SL::DB::Manager::Part->get_first; + my $html = SL::Presenter->get->part($object, display => 'inline'); + +see also L =head1 DESCRIPTION @@ -41,8 +69,29 @@ see L =head1 FUNCTIONS +=over 2 + +=item C + +Returns a rendered version (actually an instance of +L) of the part object C<$object> + +C<%params> can include: + =over 4 +=item * display + +Either C (the default) or C. At the moment both +representations are identical and produce the part's name linked +to the corresponding 'edit' action. + +=back + +=back + +=over 2 + =item C All-in-one picker widget for parts. The name will be both id and name @@ -75,16 +124,88 @@ presenter can not do this from the template. =back -=head1 BUGS +=head1 PART PICKER SPECIFICATION + +The following list of design goals were applied: =over 4 =item * -Picker icons aren't displayed with css menu, because the spritemap is not loaded. +Parts should not be perceived by the user as distinct inputs of partnumber and +description but as a single object + +=item * + +Easy to use without documentation for novice users + +=item * + +Fast to use with keyboard for experienced users + +=item * + +Possible to use without any keyboard interaction for mouse (or touchscreen) +users + +=item * + +Must not leave the current page in event of ambiguity (cf. current select_item +mechanism) + +=item * + +Should be useable with hand scanners or similar alternative keyboard devices + +=item * + +Should not require a feedback/check loop in the common case + +=item * + +Should not be constraint to exact matches =back +The implementation consists of the following parts which will be referenced later: + +=over 4 + +=item 1 + +A hidden input (id input), used to hold the id of the selected part. The only +input that gets submitted + +=item 2 + +An input (dummy input) containing a description of the currently selected part, +also used by the user to search for parts + +=item 3 + +A jquery.autocomplete mechanism attached to the dummy field + +=item 4 + +A popup layer for both feedback and input of additional data in case of +ambiguity. + +=item 5 + +An internal status of the part picker, indicating wether id input and dummy +input are consistent. After leaving the dummy input the part picker must +place itself in a consistent status. + +=item 6 + +A clickable icon (popup trigger) attached to the dummy input, which triggers the popup layer. + +=back + +=head1 BUGS + +None atm :) + =head1 AUTHOR Sven Schöling Es.schoeling@linet-services.deE