X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FSEPA.pm;h=cbea8417e317b5d1457b912665d84ca957974303;hb=c51601f019f963dcdc875469514aa40802b5c574;hp=904c78ed597418467497bc0f895c521ecd317e4a;hpb=ef294a7520ae7e452f6671676d7a8077bf74a9cf;p=kivitendo-erp.git diff --git a/SL/SEPA.pm b/SL/SEPA.pm index 904c78ed5..cbea8417e 100644 --- a/SL/SEPA.pm +++ b/SL/SEPA.pm @@ -4,7 +4,12 @@ use strict; use POSIX qw(strftime); +use Data::Dumper; use SL::DBUtils; +use SL::DB::Invoice; +use SL::DB::PurchaseInvoice; +use SL::Locale::String qw(t8); +use DateTime; sub retrieve_open_invoices { $main::lxdebug->enter_sub(); @@ -19,12 +24,26 @@ sub retrieve_open_invoices { my $arap = $params{vc} eq 'customer' ? 'ar' : 'ap'; my $vc = $params{vc} eq 'customer' ? 'customer' : 'vendor'; + my $mandate = $params{vc} eq 'customer' ? " AND COALESCE(vc.mandator_id, '') <> '' AND vc.mandate_date_of_signature IS NOT NULL " : ''; + + # in query: for customers, use payment terms from invoice, for vendors use + # payment terms from vendor settings + # currently there is no option in vendor invoices for setting payment terms, + # so the vendor settings are always used + + my $payment_term_type = $params{vc} eq 'customer' ? "${arap}" : 'vc'; + + # open_amount is not the current open amount according to bookkeeping, but + # the open amount minus the SEPA transfer amounts that haven't been closed yet my $query = qq| - SELECT ${arap}.id, ${arap}.invnumber, ${arap}.${vc}_id, ${arap}.amount AS invoice_amount, ${arap}.invoice, - vc.name AS vcname, ${arap}.duedate as duedate, + SELECT ${arap}.id, ${arap}.invnumber, ${arap}.transdate, ${arap}.${vc}_id as vc_id, ${arap}.amount AS invoice_amount, ${arap}.invoice, + (${arap}.transdate + pt.terms_skonto) as skonto_date, (pt.percent_skonto * 100) as percent_skonto, + (${arap}.amount - (${arap}.amount * pt.percent_skonto)) as amount_less_skonto, + (${arap}.amount * pt.percent_skonto) as skonto_amount, + vc.name AS vcname, vc.language_id, ${arap}.duedate as duedate, ${arap}.direct_debit, - COALESCE(vc.iban, '') <> '' AND COALESCE(vc.bic, '') <> '' AS vc_bank_info_ok, + COALESCE(vc.iban, '') <> '' AND COALESCE(vc.bic, '') <> '' ${mandate} AS vc_bank_info_ok, ${arap}.amount - ${arap}.paid - COALESCE(open_transfers.amount, 0) AS open_amount @@ -38,6 +57,8 @@ sub retrieve_open_invoices { GROUP BY sei.ap_id) AS open_transfers ON (${arap}.id = open_transfers.ap_id) + LEFT JOIN payment_terms pt ON (${payment_term_type}.payment_id = pt.id) + WHERE ${arap}.amount > (COALESCE(open_transfers.amount, 0) + ${arap}.paid) ORDER BY lower(vc.name) ASC, lower(${arap}.invnumber) ASC @@ -45,6 +66,21 @@ sub retrieve_open_invoices { my $results = selectall_hashref_query($form, $dbh, $query); + # add some more data to $results: + # create drop-down data for payment types and suggest amount to be paid according + # to open amount or skonto + + foreach my $result ( @$results ) { + my $invoice = $vc eq 'customer' ? SL::DB::Manager::Invoice->find_by( id => $result->{id} ) + : SL::DB::Manager::PurchaseInvoice->find_by( id => $result->{id} ); + + $invoice->get_payment_suggestions(sepa => 1); # consider amounts of open entries in sepa_export_items + $result->{skonto_amount} = $invoice->skonto_amount; + $result->{within_skonto_period} = $invoice->within_skonto_period; + $result->{invoice_amount_suggestion} = $invoice->{invoice_amount_suggestion}; + $result->{payment_select_options} = $invoice->{payment_select_options}; + }; + $main::lxdebug->leave_sub(); return $results; @@ -76,14 +112,18 @@ sub create_export { my $q_item_id = qq|SELECT nextval('id')|; my $h_item_id = prepare_query($form, $dbh, $q_item_id); + my $c_mandate = $params{vc} eq 'customer' ? ', vc_mandator_id, vc_mandate_date_of_signature' : ''; + my $p_mandate = $params{vc} eq 'customer' ? ', ?, ?' : ''; my $q_insert = qq|INSERT INTO sepa_export_items (id, sepa_export_id, ${arap}_id, chart_id, amount, requested_execution_date, reference, end_to_end_id, - our_iban, our_bic, vc_iban, vc_bic) + our_iban, our_bic, vc_iban, vc_bic, + skonto_amount, payment_type ${c_mandate}) VALUES (?, ?, ?, ?, ?, ?, ?, ?, - ?, ?, ?, ?)|; + ?, ?, ?, ?, + ?, ? ${p_mandate})|; my $h_insert = prepare_query($form, $dbh, $q_insert); my $q_reference = @@ -129,6 +169,19 @@ sub create_export { $transfer->{amount}, conv_date($transfer->{requested_execution_date}), $transfer->{reference}, $end_to_end_id, map { my $pfx = $_; map { $transfer->{"${pfx}_${_}"} } qw(iban bic) } qw(our vc)); + # save value of skonto_amount and payment_type + if ( $transfer->{payment_type} eq 'without_skonto' ) { + push(@values, 0); + } elsif ($transfer->{payment_type} eq 'difference_as_skonto' ) { + push(@values, $transfer->{amount}); + } elsif ($transfer->{payment_type} eq 'with_skonto_pt' ) { + push(@values, $transfer->{skonto_amount}); + } else { + die "illegal payment_type: " . $transfer->{payment_type} . "\n"; + }; + push(@values, $transfer->{payment_type}); + + push @values, $transfer->{vc_mandator_id}, conv_date($transfer->{vc_mandate_date_of_signature}) if $params{vc} eq 'customer'; do_statement($form, $h_insert, $q_insert, @values); } @@ -149,18 +202,20 @@ sub retrieve_export { my $self = shift; my %params = @_; - Common::check_params(\%params, qw(id)); + Common::check_params(\%params, qw(id vc)); my $myconfig = \%main::myconfig; my $form = $main::form; + my $vc = $params{vc} eq 'customer' ? 'customer' : 'vendor'; + my $arap = $params{vc} eq 'customer' ? 'ar' : 'ap'; my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); my ($joins, $columns); if ($params{details}) { - $columns = ', ap.invoice'; - $joins = 'LEFT JOIN ap ON (se.ap_id = ap.id)'; + $columns = ', arap.invoice'; + $joins = "LEFT JOIN ${arap} arap ON (se.${arap}_id = arap.id)"; } my $query = @@ -175,11 +230,13 @@ sub retrieve_export { if ($export->{id}) { my ($columns, $joins); + my $mandator_id = $params{vc} eq 'customer' ? ', mandator_id, mandate_date_of_signature' : ''; + if ($params{details}) { - $columns = qq|, ap.invnumber, ap.invoice, v.name AS vendor_name, c.accno AS chart_accno, c.description AS chart_description|; - $joins = qq|LEFT JOIN ap ON (sei.ap_id = ap.id) - LEFT JOIN vendor v ON (ap.vendor_id = v.id) - LEFT JOIN chart c ON (sei.chart_id = c.id)|; + $columns = qq|, arap.invnumber, arap.invoice, arap.transdate AS reference_date, vc.name AS vc_name, vc.${vc}number AS vc_number, c.accno AS chart_accno, c.description AS chart_description ${mandator_id}|; + $joins = qq|LEFT JOIN ${arap} arap ON (sei.${arap}_id = arap.id) + LEFT JOIN ${vc} vc ON (arap.${vc}_id = vc.id) + LEFT JOIN chart c ON (sei.chart_id = c.id)|; } $query = qq|SELECT sei.* @@ -187,6 +244,7 @@ sub retrieve_export { FROM sepa_export_items sei $joins WHERE sei.sepa_export_id = ?|; + $export->{items} = selectall_hashref_query($form, $dbh, $query, conv_i($params{id})); } else { @@ -302,7 +360,7 @@ sub list_exports { push @where, 'se.vc = ?'; push @values, $vc; - my $where = ' WHERE ' . join(' AND ', map { "(${_})" } @where) if (@where); + my $where = @where ? ' WHERE ' . join(' AND ', map { "(${_})" } @where) : ''; my $query = qq|SELECT se.id, se.employee_id, se.executed, se.closed, itime::date AS export_date, @@ -333,6 +391,10 @@ sub post_payment { my $myconfig = \%main::myconfig; my $form = $main::form; + my $vc = $params{vc} eq 'customer' ? 'customer' : 'vendor'; + my $arap = $params{vc} eq 'customer' ? 'ar' : 'ap'; + my $mult = $params{vc} eq 'customer' ? -1 : 1; + my $ARAP = uc $arap; my $dbh = $params{dbh} || $form->get_standard_dbh($myconfig); @@ -343,17 +405,17 @@ sub post_payment { FROM sepa_export_items sei WHERE sei.id = ?| ], - 'get_ap' => [ qq|SELECT at.chart_id + 'get_arap' => [ qq|SELECT at.chart_id FROM acc_trans at LEFT JOIN chart c ON (at.chart_id = c.id) WHERE (trans_id = ?) - AND ((c.link LIKE '%:AP') OR (c.link LIKE 'AP:%') OR (c.link = 'AP')) + AND ((c.link LIKE '%:${ARAP}') OR (c.link LIKE '${ARAP}:%') OR (c.link = '${ARAP}')) LIMIT 1| ], - 'add_acc_trans' => [ qq|INSERT INTO acc_trans (trans_id, chart_id, amount, transdate, gldate, source, memo) - VALUES (?, ?, ?, ?, current_date, ?, '')| ], + 'add_acc_trans' => [ qq|INSERT INTO acc_trans (trans_id, chart_id, amount, transdate, gldate, source, memo, taxkey, tax_id , chart_link) + VALUES (?, ?, ?, ?, current_date, ?, '', 0, (SELECT id FROM tax WHERE taxkey=0 LIMIT 1), (SELECT link FROM chart WHERE id=?))| ], - 'update_ap' => [ qq|UPDATE ap + 'update_arap' => [ qq|UPDATE ${arap} SET paid = paid + ? WHERE id = ?| ], @@ -377,6 +439,7 @@ sub post_payment { map { unshift @{ $_ }, prepare_query($form, $dbh, $_->[0]) } values %handles; foreach my $item (@items) { + my $item_id = conv_i($item->{id}); # Retrieve the item data belonging to the ID. @@ -385,16 +448,25 @@ sub post_payment { next if (!$orig_item); - # Retrieve the invoice's AP chart ID. - do_statement($form, @{ $handles{get_ap} }, $orig_item->{ap_id}); - my ($ap_chart_id) = $handles{get_ap}->[0]->fetchrow_array(); - - # Record the payment in acc_trans offsetting AP. - do_statement($form, @{ $handles{add_acc_trans} }, $orig_item->{ap_id}, $ap_chart_id, -1 * $orig_item->{amount}, $item->{execution_date}, ''); - do_statement($form, @{ $handles{add_acc_trans} }, $orig_item->{ap_id}, $orig_item->{chart_id}, $orig_item->{amount}, $item->{execution_date}, $orig_item->{reference}); - - # Update the invoice to reflect the new paid amount. - do_statement($form, @{ $handles{update_ap} }, $orig_item->{amount}, $orig_item->{ap_id}); + # fetch item_id via Rose (same id as orig_item) + my $sepa_export_item = SL::DB::Manager::SepaExportItem->find_by( id => $item_id); + + my $invoice; + + if ( $sepa_export_item->ar_id ) { + $invoice = SL::DB::Manager::Invoice->find_by( id => $sepa_export_item->ar_id); + } elsif ( $sepa_export_item->ap_id ) { + $invoice = SL::DB::Manager::PurchaseInvoice->find_by( id => $sepa_export_item->ap_id); + } else { + die "sepa_export_item needs either ar_id or ap_id\n"; + }; + + $invoice->pay_invoice(amount => $sepa_export_item->amount, + payment_type => $sepa_export_item->payment_type, + chart_id => $sepa_export_item->chart_id, + source => $sepa_export_item->reference, + transdate => $item->{execution_date}, # value from user form + ); # Update the item to reflect that it has been posted. do_statement($form, @{ $handles{finish_item} }, $item->{execution_date}, $item_id);