X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=SL%2FTransNumber.pm;h=210abc091fa253e2c16f348f6f74e2db18f65a91;hb=26ce9b7a6b8aa870ca1713101eaeda7a32da0904;hp=47cdcd0969d4b28b0d8b6cc5865a0ef0a897500a;hpb=df0d4d3fb8a275b7f96a260d403966c873123666;p=kivitendo-erp.git diff --git a/SL/TransNumber.pm b/SL/TransNumber.pm index 47cdcd096..210abc091 100644 --- a/SL/TransNumber.pm +++ b/SL/TransNumber.pm @@ -7,6 +7,7 @@ use parent qw(Rose::Object); use Carp; use List::MoreUtils qw(any none); use SL::DBUtils; +use SL::PrefixedNumber; use Rose::Object::MakeMethods::Generic ( @@ -124,24 +125,19 @@ SQL my %numbers_in_use = selectall_as_map($form, $self->dbh, $query, $filters{trans_number}, 'in_use'); - my $number; - ($number) = selectfirst_array_query($form, $self->dbh, qq|SELECT customernumberinit FROM business WHERE id = ?|, $self->business_id) if $self->business_id; - ($number) = selectfirst_array_query($form, $self->dbh, qq|SELECT $filters{numberfield} FROM defaults|) if !$number; - $number ||= ''; + my $business_number; + ($business_number) = selectfirst_array_query($form, $self->dbh, qq|SELECT customernumberinit FROM business WHERE id = ?|, $self->business_id) if $self->business_id; + my $number = $business_number; + ($number) = selectfirst_array_query($form, $self->dbh, qq|SELECT $filters{numberfield} FROM defaults|) if !$number; + $number ||= ''; + my $sequence = SL::PrefixedNumber->new(number => $number); do { - if ($number =~ m/\d+$/) { - my $new_number = substr($number, $-[0]) * 1 + 1; - my $len_diff = length($number) - $-[0] - length($new_number); - $number = substr($number, 0, $-[0]) . ($len_diff > 0 ? '0' x $len_diff : '') . $new_number; - - } else { - $number = $number . '1'; - } + $number = $sequence->get_next; } while ($numbers_in_use{$number}); if ($self->save) { - if ($self->business_id) { + if ($self->business_id && $business_number) { do_query($form, $self->dbh, qq|UPDATE business SET customernumberinit = ? WHERE id = ?|, $number, $self->business_id); } else { do_query($form, $self->dbh, qq|UPDATE defaults SET $filters{numberfield} = ?|, $number);