X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=WEB-INF%2Flib%2FttAdmin.class.php;h=f5323322e79704e85d954dac2ca2b3e2cd67c1d6;hb=75a1eedb8977b8f2db459128bab9aaf367e3b58b;hp=6a16034e3bd8d5265d551f405844267b168bf024;hpb=bde9999ab047052540e9b57ce39d7932bcb00f9d;p=timetracker.git diff --git a/WEB-INF/lib/ttAdmin.class.php b/WEB-INF/lib/ttAdmin.class.php index 6a16034e..f5323322 100644 --- a/WEB-INF/lib/ttAdmin.class.php +++ b/WEB-INF/lib/ttAdmin.class.php @@ -26,21 +26,15 @@ // | https://www.anuko.com/time_tracker/credits.htm // +----------------------------------------------------------------------+ -import('ttUser'); +import('ttRoleHelper'); // ttAdmin class is used to perform admin tasks. +// Used as namespace, as it is a collection of static functions that we call +// from admin pages to administer the site as a whole. class ttAdmin { - var $err = null; // Error object, passed to us as reference. - // We use it to communicate errors to caller. - - // Constructor. - function __construct(&$err = null) { - $this->err = $err; - } - // getSubgroups rerurns an array of subgroups for a group. - function getSubgroups($group_id) { + static function getSubgroups($group_id) { $mdb2 = getConnection(); $subgroups = array(); @@ -54,67 +48,6 @@ class ttAdmin { return $subgroups; } - // getUsers obtains user ids in a group. - function getUsers($group_id) { - $mdb2 = getConnection(); - $sql = "select id from tt_users where group_id = $group_id"; - $res = $mdb2->query($sql); - $users = array(); - if (!is_a($res, 'PEAR_Error')) { - while ($val = $res->fetchRow()) { - $users[] = $val; - } - } - return $users; - } - - // markUserDeleted marks a user and all things associated with user as deleted. - function markUserDeleted($user_id) { - $mdb2 = getConnection(); - - // Mark user binds as deleted. - $sql = "update tt_user_project_binds set status = NULL where user_id = $user_id"; - $affected = $mdb2->exec($sql); - if (is_a($affected, 'PEAR_Error')) return false; - - // Mark favorite reports as deleted. - $sql = "update tt_fav_reports set status = NULL where user_id = $user_id"; - $affected = $mdb2->exec($sql); - if (is_a($affected, 'PEAR_Error')) return false; - - // Mark user as deleted. - global $user; - $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$mdb2->quote($user->id); - $sql = "update tt_users set status = NULL $modified_part where id = $user_id"; - $affected = $mdb2->exec($sql); - if (is_a($affected, 'PEAR_Error')) return false; - - return true; - } - - // The markTasksDeleted deletes task binds and marks the tasks as deleted for a group. - function markTasksDeleted($group_id) { - $mdb2 = getConnection(); - $sql = "select id from tt_tasks where group_id = $group_id"; - $res = $mdb2->query($sql); - if (is_a($res, 'PEAR_Error')) return false; - - while ($val = $res->fetchRow()) { - // Delete task binds. - $task_id = $val['id']; - $sql = "delete from tt_project_task_binds where task_id = $task_id"; - $affected = $mdb2->exec($sql); - if (is_a($affected, 'PEAR_Error')) return false; - - // Mark task as deleted. - $sql = "update tt_tasks set status = NULL where id = $task_id"; - $affected = $mdb2->exec($sql); - if (is_a($affected, 'PEAR_Error')) return false; - } - - return true; - } - // markGroupDeleted marks a group and everything in it as deleted. // This function is called in context of a logged on admin who may // operate on any group. @@ -178,7 +111,7 @@ class ttAdmin { // Mark group deleted. global $user; - $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$mdb2->quote($user->id); + $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$user->id; $sql = "update tt_groups set status = null $modified_part where id = $group_id"; $affected = $mdb2->exec($sql); if (is_a($affected, 'PEAR_Error')) return false; @@ -186,56 +119,6 @@ class ttAdmin { return true; } - // validateGroupInfo validates group information entered by user. - function validateGroupInfo($fields) { - global $i18n; - global $auth; - - $result = true; - - if (!ttValidString($fields['new_group_name'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.group_name')); - $result = false; - } - if (!ttValidString($fields['user_name'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.manager_name')); - $result = false; - } - if (!ttValidString($fields['new_login'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.manager_login')); - $result = false; - } - - // If we change login, it must be unique. - if ($fields['new_login'] != $fields['old_login']) { - if (ttUserHelper::getUserByLogin($fields['new_login'])) { - $this->err->add($i18n->get('error.user_exists')); - $result = false; - } - } - - if (!$auth->isPasswordExternal() && ($fields['password1'] || $fields['password2'])) { - if (!ttValidString($fields['password1'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.password')); - $result = false; - } - if (!ttValidString($fields['password2'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.confirm_password')); - $result = false; - } - if ($fields['password1'] !== $fields['password2']) { - $this->err->add($i18n->get('error.not_equal'), $i18n->get('label.password'), $i18n->get('label.confirm_password')); - $result = false; - } - } - if (!ttValidEmail($fields['email'], true)) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.email')); - $result = false; - } - - return $result; - } - // updateGroup updates a (top) group with new information. static function updateGroup($fields) { $group_id = (int)$fields['group_id']; @@ -243,7 +126,7 @@ class ttAdmin { $mdb2 = getConnection(); global $user; - $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$mdb2->quote($user->id); + $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$user->id; // Update group name if it changed. if ($fields['old_group_name'] != $fields['new_group_name']) { @@ -260,64 +143,16 @@ class ttAdmin { $password_part = ', password = md5('.$mdb2->quote($fields['password1']).')'; $name_part = ', name = '.$mdb2->quote($fields['user_name']); $email_part = ', email = '.$mdb2->quote($fields['email']); - $sql = 'update tt_users set '.$login_part.$password_part.$name_part.$email_part.$modified_part.'where id = '.$user_id; + $sql = 'update tt_users set '.$login_part.$password_part.$name_part.$email_part.$modified_part.' where id = '.$user_id; $affected = $mdb2->exec($sql); if (is_a($affected, 'PEAR_Error')) return false; return true; } - // validateUserInfo validates account information entered by user. - function validateUserInfo($fields) { - global $i18n; + // updateSelf updates admin account with new information. + static function updateSelf($fields) { global $user; - global $auth; - - $result = true; - - if (!ttValidString($fields['name'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.person_name')); - $result = false; - } - if (!ttValidString($fields['login'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.login')); - $result = false; - } - // If we change login, it must be unique. - if ($fields['login'] != $user->login) { - if (ttUserHelper::getUserByLogin($fields['login'])) { - $this->err->add($i18n->get('error.user_exists')); - $result = false; - } - } - if (!$auth->isPasswordExternal() && ($fields['password1'] || $fields['password2'])) { - if (!ttValidString($fields['password1'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.password')); - $result = false; - } - if (!ttValidString($fields['password2'])) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.confirm_password')); - $result = false; - } - if ($fields['password1'] !== $fields['password2']) { - $this->err->add($i18n->get('error.not_equal'), $i18n->get('label.password'), $i18n->get('label.confirm_password')); - $result = false; - } - } - if (!ttValidEmail($fields['email'], true)) { - $this->err->add($i18n->get('error.field'), $i18n->get('label.email')); - $result = false; - } - - return $result; - } - - // updateSelf validates user input and updates admin account with new information. - function updateSelf($fields) { - if (!$this->validateUserInfo($fields)) return false; // Can't continue as user input is invalid. - - global $user; - global $i18n; $mdb2 = getConnection(); // Update self. @@ -327,26 +162,46 @@ class ttAdmin { $password_part = ', password = md5('.$mdb2->quote($fields['password1']).')'; $name_part = ', name = '.$mdb2->quote($fields['name']); $email_part = ', email = '.$mdb2->quote($fields['email']); - $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$mdb2->quote($user->id); - $sql = 'update tt_users set '.$login_part.$password_part.$name_part.$email_part.$modified_part.'where id = '.$user_id; + $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$user->id; + $sql = 'update tt_users set '.$login_part.$password_part.$name_part.$email_part.$modified_part.' where id = '.$user_id; $affected = $mdb2->exec($sql); - if (is_a($affected, 'PEAR_Error')) { - $this->err->add($i18n->get('error.db')); - return false; + return (!is_a($affected, 'PEAR_Error')); + } + + // getGroupName obtains group name. + static function getGroupName($group_id) { + $result = array(); + $mdb2 = getConnection(); + + $sql = "select name from tt_groups where id = $group_id"; + + $res = $mdb2->query($sql); + if (!is_a($res, 'PEAR_Error')) { + $val = $res->fetchRow(); + return $val['name']; } - return true; + return false; } - // getGroupDetails obtains group name and its top manager details. - static function getGroupDetails($group_id) { + // getOrgDetails obtains group name and its top manager details. + static function getOrgDetails($group_id) { $result = array(); $mdb2 = getConnection(); + // Note: current code works with properly set top manager (rank 512). + // However, we now allow export and import of subgroups, which seems to work well. + // In this situation, imported role is no longer "Top manager", and this call fails. + // Setting role id manually in database for top user to Top manager resolves the issue. + // + // TODO: assess whether it is safe / reasonable to promote role during export or import. + // The problem is that user having 'export_data' right is not necessarily top user. + // And if we do it by rank, what to do for multiple managers situation? First found? + // Leaving to manual fixing for now. $sql = "select g.name as group_name, u.id as manager_id, u.name as manager_name, u.login as manager_login, u.email as manager_email". " from tt_groups g". " inner join tt_users u on (u.group_id = g.id)". - " inner join tt_roles r on (r.id = u.role_id and r.rank = 512)". + " inner join tt_roles r on (r.id = u.role_id and r.rank = 512)". // Fails for partially imported org. See comment above. " where g.id = $group_id"; $res = $mdb2->query($sql); @@ -376,11 +231,88 @@ class ttAdmin { // Add modified info to sql for some tables, depending on table name. if ($table_name == 'tt_users') { global $user; - $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$mdb2->quote($user->id); + $modified_part = ', modified = now(), modified_ip = '.$mdb2->quote($_SERVER['REMOTE_ADDR']).', modified_by = '.$user->id; } $sql = "update $table_name set status = null $modified_part where group_id = $group_id"; $affected = $mdb2->exec($sql); return (!is_a($affected, 'PEAR_Error')); } + + // createGroup creates a new top group and returns its id. + // It is a helper function for createOrg. + static function createGroup($fields) { + global $user; + $mdb2 = getConnection(); + + $group_key = $mdb2->quote(ttRandomString()); + $name = $mdb2->quote($fields['group_name']); + $currency = $mdb2->quote($fields['currency']); + $lang = $mdb2->quote($fields['lang']); + $created = 'now()'; + $created_ip = $mdb2->quote($_SERVER['REMOTE_ADDR']); + $created_by = $user->id; + + $sql = "insert into tt_groups (group_key, name, currency, lang, created, created_ip, created_by)". + " values($group_key, $name, $currency, $lang, $created, $created_ip, $created_by)"; + $affected = $mdb2->exec($sql); + if (is_a($affected, 'PEAR_Error')) return false; + + $group_id = $mdb2->lastInsertID('tt_groups', 'id'); + + // Update org_id with group_id. + $sql = "update tt_groups set org_id = $group_id where org_id is NULL and id = $group_id"; + $affected = $mdb2->exec($sql); + if (is_a($affected, 'PEAR_Error')) return false; + + return $group_id; + } + + // createOrgManager creates a new user (top manager role) in a group. + // It is a helper function for createOrg. + static function createOrgManager($fields) { + global $user; + $mdb2 = getConnection(); + + $role_id = ttRoleHelper::getTopManagerRoleID(); + $login = $mdb2->quote($fields['login']); + $password = 'md5('.$mdb2->quote($fields['password']).')'; + $name = $mdb2->quote($fields['user_name']); + $group_id = (int) $fields['group_id']; + $org_id = $group_id; + $email = $mdb2->quote($fields['email']); + $created = 'now()'; + $created_ip = $mdb2->quote($_SERVER['REMOTE_ADDR']); + $created_by = $user->id; + + $columns = '(login, password, name, group_id, org_id, role_id, email, created, created_ip, created_by)'; + $values = "values($login, $password, $name, $group_id, $org_id, $role_id, $email, $created, $created_ip, $created_by)"; + + $sql = "insert into tt_users $columns $values"; + $affected = $mdb2->exec($sql); + return (!is_a($affected, 'PEAR_Error')); + } + + // The createOrg function creates an organization in Time Tracker. + static function createOrg($fields) { + // There are 3 steps that we need to 2 when creating a new organization. + // 1. Create a new group with null parent_id. + // 2. Create pre-defined roles in it. + // 3. Create a top manager account for new group. + + // Create a new group. + $group_id = ttAdmin::createGroup($fields); + if (!$group_id) return false; + + // Create predefined roles. + if (!ttRoleHelper::createPredefinedRoles($group_id, $fields['lang'])) + return false; + + // Create user. + $fields['group_id'] = $group_id; + if (!ttAdmin::createOrgManager($fields)) + return false; + + return true; + } }