X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=WEB-INF%2Flib%2FttTeamHelper.class.php;h=bbca70e841d495df671a4c1c05a441703067eed4;hb=074e8daef75c2b729e75f350b52935a6b7ecfba8;hp=4e39628a2e1c1e4cb1cdc1745152bab88053f826;hpb=7218f84ad58ed22a926b3ffa7a152ca7f93f0204;p=timetracker.git

diff --git a/WEB-INF/lib/ttTeamHelper.class.php b/WEB-INF/lib/ttTeamHelper.class.php
index 4e39628a..bbca70e8 100644
--- a/WEB-INF/lib/ttTeamHelper.class.php
+++ b/WEB-INF/lib/ttTeamHelper.class.php
@@ -139,25 +139,6 @@ class ttTeamHelper {
     return false;
   }
 
-  // The getAllUsers obtains all users in a given team.
-  static function getAllUsers($team_id, $all_fields = false) {
-    $mdb2 = getConnection();
-
-    if ($all_fields)
-      $sql = "select * from tt_users where team_id = $team_id order by upper(name)";
-    else
-      $sql = "select id, name from tt_users where team_id = $team_id order by upper(name)";
-    $res = $mdb2->query($sql);
-    $result = array();
-    if (!is_a($res, 'PEAR_Error')) {
-      while ($val = $res->fetchRow()) {
-        $result[] = $val;
-      }
-      return $result;
-    }
-    return false;
-  }
-
   // getActiveProjects - returns an array of active projects for team.
   static function getActiveProjects($team_id)
   {
@@ -325,21 +306,26 @@ class ttTeamHelper {
     return $result;
   }
 
-  // getAllRoles - obtains all roles defined for team.
-  static function getAllRoles($team_id) {
+  // getInactiveRolesForUser - returns an array of relevant active roles for user with rank less than self.
+  // "Relevant" means that client roles are filtered out if Client plugin is disabled.
+  static function getInactiveRolesForUser()
+  {
+    global $user;
+    $result = array();
     $mdb2 = getConnection();
 
-    $result = array();
-    $sql = "select * from tt_roles where team_id = $team_id";
+    $sql = "select id, name, description, rank, rights from tt_roles where team_id = $user->team_id and rank < $user->rank and status = 0 order by rank";
     $res = $mdb2->query($sql);
     $result = array();
     if (!is_a($res, 'PEAR_Error')) {
       while ($val = $res->fetchRow()) {
+        $val['is_client'] = in_array('track_own_time', explode(',', $val['rights'])) ? 0 : 1; // Clients do not have data entry right.
+        if ($val['is_client'] && !$user->isPluginEnabled('cl'))
+          continue; // Skip adding a client role.
         $result[] = $val;
       }
-      return $result;
     }
-    return false;
+    return $result;
   }
 
   // The getActiveClients returns an array of active clients for team.
@@ -699,7 +685,6 @@ class ttTeamHelper {
     $result = array();
     $mdb2 = getConnection();
 
-    $role_manager = ROLE_MANAGER;
     $sql = "select t.name as team_name, u.id as manager_id, u.name as manager_name, u.login as manager_login, u.email as manager_email
       from tt_teams t
       inner join tt_users u on (u.team_id = t.id)