X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=bin%2Fmozilla%2Farap.pl;h=03dd6e895d51b8e491358233763c89a12d94d298;hb=1de53cbf8a926ae3ae89bc5466ab660df82484b2;hp=7612166a52b121c09703521d70abe018f0a2f841;hpb=57bf9c89a037036fcf433de39643778854defe51;p=kivitendo-erp.git diff --git a/bin/mozilla/arap.pl b/bin/mozilla/arap.pl index 7612166a5..03dd6e895 100644 --- a/bin/mozilla/arap.pl +++ b/bin/mozilla/arap.pl @@ -59,7 +59,7 @@ sub check_name { 'request_quotation_edit | sales_quotation_edit | purchase_order_edit | cash |' . 'purchase_delivery_order_edit | sales_delivery_order_edit'); - my ($name) = @_; + my ($name, %params) = @_; $name = $name eq "customer" ? "customer" : "vendor"; @@ -99,9 +99,17 @@ sub check_name { $form->{calctax} = 1; # return one name or a list of names in $form->{name_list} - if (($i = $form->get_name(\%myconfig, $name)) > 1) { - &select_name($name); - exit; + $i = $form->get_name(\%myconfig, $name); + + if ($i > 1) { + if ($params{no_select}) { + # $locale->text('Customer') + # $locale->text('Vendor') + $form->error($locale->text("More than one #1 found matching, please be more specific.", $locale->text(ucfirst $name))); + } else { + &select_name($name); + ::end_of_request(); + } } if ($i == 1) { @@ -173,12 +181,12 @@ sub select_name { - |; + |; map { print "\n$column_data{$_}" } @column_index; print qq| - + |; my $i = 0; @@ -197,12 +205,12 @@ sub select_name { $j++; $j %= 2; print qq| - |; + |; map { print "\n$column_data{$_}" } @column_index; print qq| - + {id}> @@ -310,7 +318,7 @@ sub check_project { # check form->{project_list} how many there are $form->{rownumber} = $i; &select_project($i ? undef : 1, $nextsub); - exit; + ::end_of_request(); } if ($rows == 1) { @@ -371,7 +379,7 @@ sub select_project {
- |; + |; map { print "\n$column_data{$_}" } @column_index; @@ -486,3 +494,145 @@ sub project_selected { sub continue { call_sub($main::form->{"nextsub"}); } +1; + +__END__ + +=head1 NAME + +<<<<<<< HEAD:bin/mozilla/arap.pl +bin/mozilla/arap.pl - helper routines for invoiceing frontend. + +=head1 SYNOPSIS + +nothing yet + +=head1 DESCRIPTION + +nothing yet +======= +arap.pl - helper functions or customer/vendor retrieval + +=head1 SYNOPSIS + + check_name('vendor') + check_project(); + +=head1 DESCRIPTION + +Don't use anyting in this file without extreme care, and even then be prepared for massive headaches. + +It's a collection of helper routines that wrap the customer/vendor dropdown/textfield duality into something even complexer. +>>>>>>> 88f5a78... check_name erweitert um ein no_select flag. siehe perldoc bin/mozilla/arap.pl:bin/mozilla/arap.pl + +=head1 FUNCTIONS + +=head2 check_name customer|vendor + +<<<<<<< HEAD:bin/mozilla/arap.pl +check_name was originally meant to update the selected customer or vendor. The +way it does that has generted more hate than almost any other part of this +software. + +What it does is: + +=over 4 + +=item + +It checks if a vendor or customer is given. No failsafe, vendor fallback if +$_[0] is something fancy. + +=item + +It assumes, that there is a field named customer or vendor in $form. + +=item + +It assumes, that this field is filled with name--id, and tries to split that. +sql ledger uses that combination to get ids into the select keys. + +=item + +It looks for a field selectcustomer or selectvendor in $form. sql ledger used +to store a copy of the html select in there. (again, don't ask) + +=item + +If this field exists, it looks for a field called oldcustomer or oldvendor, in +which the old name--id string was stored in sql ledger, and compares those. + +=item + +if they don't match, it will set customer_id or vendor_id in $form, load the +entry (which will clobber everything in $form named like a column in customer +oder vendor) and return. + +=item + +If there was no select* entry, it assumes that vclimit was lower than the +number of entries, and that an input field was generated. In that case the +splitting is omitted (since users don't generally include ids in entered names) + +=item + +It looks for a *_id field, and combines it with the given input into a name--id +entry and compares it to the old* entry. (Missing any of these will instantly +break check_namea. + +=item + +If those do not match, $form->get_name is called to get matching results. +get_name only matches by *number and name, not by id, don't try to get it to do +so. + +=item + +The results are stored in $form>{name_list} but a count is returned, and +checked. + +=item + +If only one result was found, *_id, * and old* are copied into $form, the entry +is loaded (like above, clobbering) + +=item + +If there is more than one, a selection dialog is rendered + +=item + +If none is found, an error is generated. + +=back + +=head3 I built a customer/vendor box somewhere and it doesn't work, what's wrong? + +Make sure a select* field is given if and only if you render a select box. The +actual contents are ignored, but recognition fails if not present. + +Make sure old* and *_id fields are set correctly (name--id form for old*). They +are necessary in all steps and branches. + +Since get_customer and get_vendor clobber a lot of fields, make sure what +changes exactly. +======= +This function will take the contents of $form->{vendor} or $form->{customer}, try to guess if there was a selectbox or not, and search for matching customer/vendors. + +This mostly works great, except for the case when there is more than one match. +In that case check_name will display a select form, that will redirect to the +original C. Unfortunately any hidden vars or input fields will be lost +in the process unless saved before in a callback. + +If you still want to use it, you can disable this feature, like this: + + check_name('customer', no_select => 1) + +In that case multiple matches will trigger an error. + +=head1 BUGS + +=head1 AUTHOR +>>>>>>> 88f5a78... check_name erweitert um ein no_select flag. siehe perldoc bin/mozilla/arap.pl:bin/mozilla/arap.pl + +=cut