X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=bin%2Fmozilla%2Fdo.pl;h=0d5941cb0b4f5c9ed812891b6ae2e98c71ff9e5b;hb=7ad942750f0294bdbbbb6f0693bea17dcc75f18b;hp=692a4595ac700a1082179a7f1178c54f5277432d;hpb=2e8ce008611246347f9682d81e8fabf015765bf5;p=kivitendo-erp.git diff --git a/bin/mozilla/do.pl b/bin/mozilla/do.pl index 692a4595a..0d5941cb0 100644 --- a/bin/mozilla/do.pl +++ b/bin/mozilla/do.pl @@ -48,8 +48,6 @@ require "bin/mozilla/reportgenerator.pl"; use strict; -my $print_post; - 1; # end of main @@ -183,6 +181,8 @@ sub order_links { IR->get_vendor(\%myconfig, \%$form); } else { IS->get_customer(\%myconfig, \%$form); + # OFFEN tritt bug 1284 auch bei vendor auf? + $form->{discount} = $form->{customer_discount}; } $form->restore_vars(qw(payment_id language_id taxzone_id intnotes cp_id)); @@ -233,6 +233,7 @@ sub prepare_order { $form->{"reqdate_$i"} = $form->{"deliverydate_$i"} unless $form->{"reqdate_$i"}; $form->{"sellprice_$i"} = $form->format_amount(\%myconfig, $form->{"sellprice_$i"}, $decimalplaces); + $form->{"lastcost_$i"} = $form->format_amount(\%myconfig, $form->{"lastcost_$i"}, $decimalplaces); (my $dec_qty) = ($form->{"qty_$i"} =~ /\.(\d+)/); $dec_qty = length $dec_qty; @@ -364,7 +365,7 @@ sub update_delivery_order { if ($rows > 1) { select_item(); - exit; + ::end_of_request(); } else { @@ -372,6 +373,7 @@ sub update_delivery_order { $form->{"marge_price_factor_$i"} = $form->{item_list}->[0]->{price_factor}; $form->{"sellprice_$i"} = $form->format_amount(\%myconfig, $form->{"sellprice_$i"}); + $form->{"lastcost_$i"} = $form->format_amount(\%myconfig, $form->{"lastcost_$i"}); $form->{"qty_$i"} = $form->format_amount(\%myconfig, $form->{"qty_$i"}); } @@ -615,7 +617,7 @@ sub save { # if the name changed get new values if (check_name($form->{vc})) { update(); - exit; + ::end_of_request(); } $form->{id} = 0 if $form->{saveasnew}; @@ -628,19 +630,14 @@ sub save { # wird die Maske mit dem falschen Rabatt wieder aufgebaut. # Wie immer: backup_vars verwenden um nichts anderes kaputt zu # machen. jan 03.03.2010 - for my $i (1 .. $form->{rowcount}) { - $form->{"backup_discount_$i"} = $form->{"discount_$i"}; - }; + # nicht mehr notwendig da für bug 1284 der backend aufruf entsprechend + # geändert wurde DO->save(); - for my $i (1 .. $form->{rowcount}) { - $form->{"discount_$i"} = $form->{"backup_discount_$i"}; - delete $form->{"backup_discount_$i"}; - }; # saving the history if(!exists $form->{addition}) { $form->{snumbers} = qq|donumber_| . $form->{donumber}; $form->{addition} = "SAVED"; - $form->save_history($form->dbconnect(\%myconfig)); + $form->save_history; } # /saving the history @@ -648,7 +645,7 @@ sub save { if(!$form->{print_and_save}) { set_headings("edit"); update(); - exit; + ::end_of_request(); } $main::lxdebug->leave_sub(); } @@ -686,12 +683,12 @@ sub delete_delivery_order { if(!exists $form->{addition}) { $form->{snumbers} = qq|donumber_| . $form->{donumber}; $form->{addition} = "DELETED"; - $form->save_history($form->dbconnect(\%myconfig)); + $form->save_history; } # /saving the history $form->info($locale->text('Delivery Order deleted!')); - exit(); + ::end_of_request(); } $form->error($locale->text('Cannot delete delivery order!')); @@ -734,7 +731,12 @@ sub invoice { } for my $i (1 .. $form->{rowcount}) { - map { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if $form->{"${_}_${i}"} } qw(ship qty sellprice listprice basefactor); + # für bug 1284 + if ($form->{discount}){ # Falls wir einen Kundenrabatt haben + # und keinen anderen discount wert an $i ... + $form->{"discount_$i"} ||= $form->{discount}*100; # ... nehmen wir den kundenrabatt + } + map { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if $form->{"${_}_${i}"} } qw(ship qty sellprice listprice lastcost basefactor); } $form->{type} = "invoice"; @@ -767,10 +769,15 @@ sub invoice { $form->{"deliverydate_$i"} = $form->{"reqdate_$i"} unless $form->{"deliverydate_$i"}; + $form->{"sellprice_$i"} = $form->format_amount(\%myconfig, $form->{"sellprice_$i"}, $decimalplaces); + $form->{"lastcost_$i"} = + $form->format_amount(\%myconfig, $form->{"lastcost_$i"}, + $decimalplaces); + (my $dec_qty) = ($form->{"qty_$i"} =~ /\.(\d+)/); $dec_qty = length $dec_qty; $form->{"qty_$i"} = @@ -896,8 +903,6 @@ sub e_mail { $form->{print_and_save} = 1; - $print_post = 1; - my $saved_form = save_form(); save(); @@ -1002,7 +1007,7 @@ sub update_stock_in { foreach my $i (1..$form->{rowcount}) { $form->{"qty_$i"} = $form->parse_amount(\%myconfig, $form->{"qty_$i"}); - push @{ $stock_info }, { map { $_ => $form->{"${_}_${i}"} } qw(warehouse_id bin_id chargenumber qty unit) }; + push @{ $stock_info }, { map { $_ => $form->{"${_}_${i}"} } qw(warehouse_id bin_id chargenumber bestbefore qty unit) }; } display_stock_in_form($stock_info); @@ -1031,6 +1036,8 @@ sub display_stock_in_form { my %myconfig = %main::myconfig; my $locale = $main::locale; + $form->{jsscript} = 1; + $form->{title} = $locale->text('Stock'); my $part_info = IC->get_basic_part_info('id' => $form->{parts_id}); @@ -1066,7 +1073,7 @@ sub set_stock_in { next if ($form->{"qty_$i"} <= 0); - push @{ $stock_info }, { map { $_ => $form->{"${_}_${i}"} } qw(warehouse_id bin_id chargenumber qty unit) }; + push @{ $stock_info }, { map { $_ => $form->{"${_}_${i}"} } qw(warehouse_id bin_id chargenumber bestbefore qty unit) }; } $form->{stock} = YAML::Dump($stock_info); @@ -1105,7 +1112,8 @@ sub stock_out_form { foreach my $sinfo (@{ $stock_info }) { next if (($row->{bin_id} != $sinfo->{bin_id}) || ($row->{warehouse_id} != $sinfo->{warehouse_id}) || - ($row->{chargenumber} ne $sinfo->{chargenumber})); + ($row->{chargenumber} ne $sinfo->{chargenumber}) || + ($row->{bestbefore} ne $sinfo->{bestbefore})); map { $row->{"stock_$_"} = $sinfo->{$_} } qw(qty unit error); } @@ -1145,6 +1153,7 @@ sub set_stock_out { 'warehouse_id' => $form->{"warehouse_id_$i"}, 'bin_id' => $form->{"bin_id_$i"}, 'chargenumber' => $form->{"chargenumber_$i"}, + 'bestbefore' => $form->{"bestbefore_$i"}, 'qty' => $form->{"qty_$i"}, 'unit' => $form->{"unit_$i"}, 'row' => $i, @@ -1207,10 +1216,10 @@ sub transfer_in { my $do_base_qty = $form->parse_amount(\%myconfig, $form->{"qty_$i"}) * $units->{$form->{"unit_$i"}}->{factor} / $base_unit_factor; - if ($do_base_qty != $row_sum_base_qty) { - push @{ $form->{ERRORS} }, $locale->text('Error in position #1: You must either assign no stock at all or the full quantity of #2 #3.', - $i, $form->{"qty_$i"}, $form->{"unit_$i"}); - } +# if ($do_base_qty != $row_sum_base_qty) { +# push @{ $form->{ERRORS} }, $locale->text('Error in position #1: You must either assign no stock at all or the full quantity of #2 #3.', +# $i, $form->{"qty_$i"}, $form->{"unit_$i"}); +# } } if (@{ $form->{ERRORS} }) { @@ -1219,7 +1228,7 @@ sub transfer_in { update(); $main::lxdebug->leave_sub(); - exit 0; + ::end_of_request(); } } @@ -1264,7 +1273,7 @@ sub transfer_out { $request->{parts_id} = $form->{"id_$i"}; $request->{base_qty} = $request->{qty} * $units->{$request->{unit}}->{factor} / $base_unit_factor; - my $map_key = join '--', ($form->{"id_$i"}, @{$request}{qw(warehouse_id bin_id chargenumber)}); + my $map_key = join '--', ($form->{"id_$i"}, @{$request}{qw(warehouse_id bin_id chargenumber bestbefore)}); $request_map{$map_key} ||= $request; $request_map{$map_key}->{sum_base_qty} ||= 0; @@ -1278,10 +1287,10 @@ sub transfer_out { my $do_base_qty = $form->parse_amount(\%myconfig, $form->{"qty_$i"}) * $units->{$form->{"unit_$i"}}->{factor} / $base_unit_factor; - if ($do_base_qty != $row_sum_base_qty) { - push @{ $form->{ERRORS} }, $locale->text('Error in position #1: You must either assign no transfer at all or the full quantity of #2 #3.', - $i, $form->{"qty_$i"}, $form->{"unit_$i"}); - } +# if ($do_base_qty != $row_sum_base_qty) { +# push @{ $form->{ERRORS} }, $locale->text('Error in position #1: You must either assign no transfer at all or the full quantity of #2 #3.', +# $i, $form->{"qty_$i"}, $form->{"unit_$i"}); +# } } if (%request_map) { @@ -1290,7 +1299,7 @@ sub transfer_out { my @contents = DO->get_item_availability('parts_id' => \@part_ids); foreach my $inv (@contents) { - my $map_key = join '--', @{$inv}{qw(parts_id warehouse_id bin_id chargenumber)}; + my $map_key = join '--', @{$inv}{qw(parts_id warehouse_id bin_id chargenumber bestbefore)}; next unless ($request_map{$map_key}); @@ -1304,12 +1313,26 @@ sub transfer_out { my $pinfo = $part_info_map{$request->{parts_id}}; my $binfo = $bin_info_map{$request->{bin_id}}; - push @{ $form->{ERRORS} }, $locale->text("There is not enough available of '#1' at warehouse '#2', bin '#3', #4, for the transfer of #5.", - $pinfo->{description}, $binfo->{warehouse_description}, $binfo->{bin_description}, - $request->{chargenumber} ? $locale->text('chargenumber #1', $request->{chargenumber}) : $locale->text('no chargenumber'), - $form->format_amount_units('amount' => $request->{sum_base_qty}, - 'part_unit' => $pinfo->{unit}, - 'conv_units' => 'convertible_not_smaller')); + if ($main::show_best_before) { + push @{ $form->{ERRORS} }, $locale->text("There is not enough available of '#1' at warehouse '#2', bin '#3', #4, #5, for the transfer of #6.", + $pinfo->{description}, + $binfo->{warehouse_description}, + $binfo->{bin_description}, + $request->{chargenumber} ? $locale->text('chargenumber #1', $request->{chargenumber}) : $locale->text('no chargenumber'), + $request->{bestbefore} ? $locale->text('bestbefore #1', $request->{bestbefore}) : $locale->text('no bestbefore'), + $form->format_amount_units('amount' => $request->{sum_base_qty}, + 'part_unit' => $pinfo->{unit}, + 'conv_units' => 'convertible_not_smaller')); + } else { + push @{ $form->{ERRORS} }, $locale->text("There is not enough available of '#1' at warehouse '#2', bin '#3', #4, for the transfer of #5.", + $pinfo->{description}, + $binfo->{warehouse_description}, + $binfo->{bin_description}, + $request->{chargenumber} ? $locale->text('chargenumber #1', $request->{chargenumber}) : $locale->text('no chargenumber'), + $form->format_amount_units('amount' => $request->{sum_base_qty}, + 'part_unit' => $pinfo->{unit}, + 'conv_units' => 'convertible_not_smaller')); + } } } @@ -1319,7 +1342,7 @@ sub transfer_out { update(); $main::lxdebug->leave_sub(); - exit 0; + ::end_of_request(); } }