X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=bin%2Fmozilla%2Fdo.pl;h=1b7a109608060b78f6643c22ccd1c5a754f4faaf;hb=9434c14ab2cb7d10cbe20276d08771c43f9fffc1;hp=120606acdb0844ceb470ee4d905f4b2a09dddf47;hpb=1f8f0aa0be2133ce5c93b2928cb5847a56b1c1fb;p=kivitendo-erp.git diff --git a/bin/mozilla/do.pl b/bin/mozilla/do.pl index 120606acd..1b7a10960 100644 --- a/bin/mozilla/do.pl +++ b/bin/mozilla/do.pl @@ -165,7 +165,7 @@ sub order_links { $form->all_vc(\%myconfig, $form->{vc}, ($form->{vc} eq 'customer') ? "AR" : "AP"); # retrieve order/quotation - $form->{webdav} = $main::webdav; + $form->{webdav} = $::lx_office_conf{features}->{webdav}; $form->{jsscript} = 1; my $editing = $form->{id}; @@ -179,9 +179,9 @@ sub order_links { # get customer / vendor if ($form->{vc} eq 'vendor') { IR->get_vendor(\%myconfig, \%$form); + $form->{discount} = $form->{vendor_discount}; } else { IS->get_customer(\%myconfig, \%$form); - # OFFEN tritt bug 1284 auch bei vendor auf? $form->{discount} = $form->{customer_discount}; } @@ -337,7 +337,19 @@ sub update_delivery_order { $payment_id = $form->{payment_id} if $form->{payment_id}; check_name($form->{vc}); - + $form->{discount} = $form->{"$form->{vc}_discount"} if defined $form->{"$form->{vc}_discount"}; + # Problem: Wenn man ohne Erneuern einen Kunden/Lieferanten + # wechselt, wird der entsprechende Kunden/ Lieferantenrabatt + # nicht übernommen. Grundproblem: In Commit 82574e78 + # hab ich aus discount customer_discount und vendor_discount + # gemacht und entsprechend an den Oberflächen richtig hin- + # geschoben. Die damals bessere Lösung wäre gewesen: + # In den Templates nur die hidden für form-discount wieder ein- + # setzen dann wäre die Verrenkung jetzt nicht notwendig. + # TODO: Ggf. Bugfix 1284, 1575 und 817 wieder zusammenführen + # Testfälle: Kunden mit Rabatt 0 -> Rabatt 20 i.O. + # Kunde mit Rabatt 20 -> Rabatt 0 i.O. + # Kunde mit Rabatt 20 -> Rabatt 5,5 i.O. $form->{payment_id} = $payment_id if $form->{payment_id} eq ""; # for pricegroups @@ -733,9 +745,9 @@ sub invoice { for my $i (1 .. $form->{rowcount}) { # für bug 1284 - if ($form->{discount}){ # Falls wir einen Kundenrabatt haben + if ($form->{discount}){ # Falls wir einen Lieferanten-/Kundenrabatt haben # und keinen anderen discount wert an $i ... - $form->{"discount_$i"} ||= $form->{discount}*100; # ... nehmen wir den kundenrabatt + $form->{"discount_$i"} ||= $form->{discount}*100; # ... nehmen wir diesen Rabatt } map { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if $form->{"${_}_${i}"} } qw(ship qty sellprice listprice lastcost basefactor); } @@ -751,6 +763,15 @@ sub invoice { my $currency = $form->{currency}; invoice_links(); + if ($form->{ordnumber}) { + require SL::DB::Order; + if (my $order = SL::DB::Manager::Order->find_by(ordnumber => $form->{ordnumber})) { + $order->load; + $form->{orddate} = $order->transdate_as_date; + $form->{$_} = $order->$_ for qw(payment_id salesman_id taxzone_id quonumber); + } + } + $form->{currency} = $currency; $form->{exchangerate} = ""; $form->{forex} = $form->check_exchangerate(\%myconfig, $form->{currency}, $form->{invdate}, $buysell); @@ -846,15 +867,35 @@ sub invoice_multi { map { delete $form->{$_} } qw(id subject message cc bcc printed emailed queued); + # get vendor or customer discount + my $vc_discount; + my $saved_form = save_form(); + if ($form->{vc} eq 'vendor') { + IR->get_vendor(\%myconfig, \%$form); + $vc_discount = $form->{vendor_discount}; + } else { + IS->get_customer(\%myconfig, \%$form); + $vc_discount = $form->parse_amount(\%myconfig, $form->{customer_discount}); + } + restore_form($saved_form); + $form->{rowcount} = 0; foreach my $ref (@{ $form->{form_details} }) { $form->{rowcount}++; $ref->{reqdate} ||= $ref->{dord_transdate}; # copy transdates into each invoice row map { $form->{"${_}_$form->{rowcount}"} = $ref->{$_} } keys %{ $ref }; - map { $form->{"${_}_$form->{rowcount}"} = $form->format_amount(\%myconfig, $ref->{$_}) } qw(qty sellprice discount lastcost); + map { $form->{"${_}_$form->{rowcount}"} = $form->format_amount(\%myconfig, $ref->{$_}) } qw(qty sellprice lastcost); + + if ($vc_discount){ # falls wir einen Lieferanten/Kundenrabatt haben + # und keinen anderen discount wert an $i ... + $form->{"discount_$form->{rowcount}"} ||= $vc_discount; # ... nehmen wir diesen Rabatt + } + $form->{"discount_$form->{rowcount}"} = $form->{"discount_$form->{rowcount}"} * 100; #s.a. Bug 1151 # Anm.: Eine Änderung des discounts in der SL/DO.pm->retrieve (select (doi.discount * 100) as discount) ergibt in psql einen # Wert von 10.0000001490116. Ferner ist der Rabatt in der Rechnung dann bei 1.0 (?). Deswegen lasse ich das hier. jb 10.10.09 + + $form->{"discount_$form->{rowcount}"} = $form->format_amount(\%myconfig, $form->{"discount_$form->{rowcount}"}); } delete $form->{form_details}; @@ -1290,6 +1331,7 @@ sub transfer_out { foreach my $request (@{ DO->unpack_stock_information('packed' => $form->{"stock_out_$i"}) }) { $request->{parts_id} = $form->{"id_$i"}; $request->{base_qty} = $request->{qty} * $units->{$request->{unit}}->{factor} / $base_unit_factor; + $request->{project_id} = $form->{"project_id_$i"} ? $form->{"project_id_$i"} : $form->{globalproject_id}; my $map_key = join '--', ($form->{"id_$i"}, @{$request}{qw(warehouse_id bin_id chargenumber bestbefore)}); @@ -1331,7 +1373,7 @@ sub transfer_out { my $pinfo = $part_info_map{$request->{parts_id}}; my $binfo = $bin_info_map{$request->{bin_id}}; - if ($main::show_best_before) { + if ($::lx_office_conf{features}->{show_best_before}) { push @{ $form->{ERRORS} }, $locale->text("There is not enough available of '#1' at warehouse '#2', bin '#3', #4, #5, for the transfer of #6.", $pinfo->{description}, $binfo->{warehouse_description}, @@ -1363,7 +1405,6 @@ sub transfer_out { ::end_of_request(); } } - DO->transfer_in_out('direction' => 'out', 'requests' => \@all_requests);