X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=bin%2Fmozilla%2Foe.pl;h=0e469d8d3f8dee1c56aff4eaef9bbf630516925d;hb=ef92528c3f875dee2b456418adb214ccebb97361;hp=cb7402aa338238d42fd7ed387858d88595d613fc;hpb=224af4c2a3bec656a5a09a4cbc40831d5cda2526;p=kivitendo-erp.git diff --git a/bin/mozilla/oe.pl b/bin/mozilla/oe.pl index cb7402aa3..0e469d8d3 100644 --- a/bin/mozilla/oe.pl +++ b/bin/mozilla/oe.pl @@ -48,6 +48,10 @@ require "bin/mozilla/io.pl"; require "bin/mozilla/arap.pl"; require "bin/mozilla/reportgenerator.pl"; +use strict; + +our %TMPL_VAR; + 1; # end of main @@ -71,14 +75,19 @@ my $oe_access_map = { }; sub check_oe_access { + my $form = $main::form; + my $right = $oe_access_map->{$form->{type}}; $right ||= 'DOES_NOT_EXIST'; - $auth->assert($right); + $main::auth->assert($right); } sub set_headings { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my $locale = $main::locale; check_oe_access(); @@ -113,11 +122,13 @@ sub set_headings { $form->{vc} = 'customer'; } - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub add { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; check_oe_access(); @@ -131,11 +142,13 @@ sub add { &prepare_order; &display_form; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub edit { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; check_oe_access(); @@ -149,21 +162,23 @@ sub edit { # editing without stuff to edit? try adding it first if ($form->{rowcount} && !$form->{print_and_save}) { + my $id; map { $id++ if $form->{"multi_id_$_"} } (1 .. $form->{rowcount}); if (!$id) { # reset rowcount undef $form->{rowcount}; &add; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); return; } } elsif (!$form->{id}) { &add; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); return; } + my ($language_id, $printer_id); if ($form->{print_and_save}) { $form->{action} = "print"; $form->{resubmit} = 1; @@ -176,7 +191,7 @@ sub edit { &order_links; $form->{rowcount} = 0; - foreach $ref (@{ $form->{form_details} }) { + foreach my $ref (@{ $form->{form_details} }) { $form->{rowcount}++; map { $form->{"${_}_$form->{rowcount}"} = $ref->{$_} } keys %{$ref}; } @@ -190,11 +205,15 @@ sub edit { &display_form; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub order_links { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); @@ -202,7 +221,7 @@ sub order_links { $form->all_vc(\%myconfig, $form->{vc}, ($form->{vc} eq 'customer') ? "AR" : "AP"); # retrieve order/quotation - $form->{webdav} = $webdav; + $form->{webdav} = $main::webdav; $form->{jsscript} = 1; my $editing = $form->{id}; @@ -232,7 +251,7 @@ sub order_links { $form->{employee} = "$form->{employee}--$form->{employee_id}"; # build vendor/customer drop down comatibility... don't ask - if (@{ $form->{"all_$form->{vc}"} }) { + if (@{ $form->{"all_$form->{vc}"} || [] }) { $form->{"select$form->{vc}"} = 1; $form->{$form->{vc}} = qq|$form->{$form->{vc}}--$form->{"$form->{vc}_id"}|; } @@ -243,11 +262,14 @@ sub order_links { $form->{"old$form->{vc}"} .= qq|--$form->{"$form->{vc}_id"}| } - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub prepare_order { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; check_oe_access(); @@ -260,20 +282,27 @@ sub prepare_order { $form->{"reqdate_$i"} ||= $form->{"deliverydate_$i"}; $form->{"discount_$i"} = $form->format_amount(\%myconfig, $form->{"discount_$i"} * ($format_discounts ? 100 : 1)); $form->{"sellprice_$i"} = $form->format_amount(\%myconfig, $form->{"sellprice_$i"}); + $form->{"lastcost_$i"} = $form->format_amount(\%myconfig, $form->{"lastcost_$i"}); $form->{"qty_$i"} = $form->format_amount(\%myconfig, $form->{"qty_$i"}); } - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub form_header { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); my @custom_hiddens; + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; + my $cgi = $main::cgi; + check_oe_access(); - # Container for template variables. Unfortunately this has to be visible in form_footer too, so not my. - our %TMPL_VAR = (); + # Container for template variables. Unfortunately this has to be + # visible in form_footer too, so package local level and not my here. + %TMPL_VAR = (); $form->{defaultcurrency} = $form->get_default_currency(\%myconfig); @@ -325,8 +354,8 @@ sub form_header { push @custom_hiddens, "select$form->{vc}"; # currencies and exchangerate - @values = map { $_ } @{ $form->{ALL_CURRENCIES} }; - %labels = map { $_ => $_ } @{ $form->{ALL_CURRENCIES} }; + my @values = map { $_ } @{ $form->{ALL_CURRENCIES} }; + my %labels = map { $_ => $_ } @{ $form->{ALL_CURRENCIES} }; $form->{currency} = $form->{defaultcurrency} unless $form->{currency}; $TMPL_VAR{show_exchangerate} = $form->{currency} ne $form->{defaultcurrency}; $TMPL_VAR{currencies} = NTI($cgi->popup_menu('-name' => 'currency', '-default' => $form->{"currency"}, @@ -335,7 +364,7 @@ sub form_header { push @custom_hiddens, "exchangerate" if $form->{forex}; # credit remaining - $creditwarning = (($form->{creditlimit} != 0) && ($form->{creditremaining} < 0) && !$form->{update}) ? 1 : 0; + my $creditwarning = (($form->{creditlimit} != 0) && ($form->{creditremaining} < 0) && !$form->{update}) ? 1 : 0; $TMPL_VAR{is_credit_remaining_negativ} = ($form->{creditremaining} =~ /-/) ? "0" : "1"; # business @@ -343,7 +372,7 @@ sub form_header { push @custom_hiddens, "customer_klass" if $form->{vc} eq 'customer'; - $credittext = $locale->text('Credit Limit exceeded!!!'); + my $credittext = $locale->text('Credit Limit exceeded!!!'); my $follow_up_vc = $form->{ $form->{vc} eq 'customer' ? 'customer' : 'vendor' }; $follow_up_vc =~ s/--\d*\s*$//; @@ -358,10 +387,10 @@ sub form_header { } } - $onload = ($form->{resubmit} && ($form->{format} eq "html")) ? "window.open('about:blank','Beleg'); document.oe.target = 'Beleg';document.oe.submit()" + my $onload = ($form->{resubmit} && ($form->{format} eq "html")) ? "window.open('about:blank','Beleg'); document.oe.target = 'Beleg';document.oe.submit()" : ($form->{resubmit}) ? "document.oe.submit()" : ($creditwarning) ? "alert('$credittext')" - : "focus()"; + : ""; $onload .= qq|;setupDateFormat('|. $myconfig{dateformat} .qq|', '|. $locale->text("Falsches Datumsformat!") .qq|')|; $onload .= qq|;setupPoints('|. $myconfig{numberformat} .qq|', '|. $locale->text("wrongformat") .qq|')|; @@ -395,18 +424,22 @@ sub form_header { print $form->parse_html_template("oe/form_header", { %TMPL_VAR }); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub form_footer { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); $form->{invtotal} = $form->{invsubtotal}; - $rows = max 2, $form->numtextrows($form->{notes}, 25, 8); - $introws = max 2, $form->numtextrows($form->{intnotes}, 35, 8); + my $rows = max 2, $form->numtextrows($form->{notes}, 25, 8); + my $introws = max 2, $form->numtextrows($form->{intnotes}, 35, 8); $rows = max $rows, $introws; $TMPL_VAR{notes} = qq||; @@ -414,23 +447,23 @@ sub form_footer { if (!$form->{taxincluded}) { - foreach $item (split / /, $form->{taxaccounts}) { + foreach my $item (split / /, $form->{taxaccounts}) { if ($form->{"${item}_base"}) { $form->{invtotal} += $form->{"${item}_total"} = $form->round_amount( $form->{"${item}_base"} * $form->{"${item}_rate"}, 2); $form->{"${item}_total"} = $form->format_amount(\%myconfig, $form->{"${item}_total"}, 2); $TMPL_VAR{tax} .= qq| - - $form->{"${item}_description"} | . $form->{"${item}_rate"} * 100 .qq|% - $form->{"${item}_total"} - |; + + $form->{"${item}_description"} | . $form->{"${item}_rate"} * 100 .qq|% + $form->{"${item}_total"} + |; } } # $form->{invsubtotal} = $form->format_amount(\%myconfig, $form->{invsubtotal}, 2, 0); # template does this } else { - foreach $item (split / /, $form->{taxaccounts}) { + foreach my $item (split / /, $form->{taxaccounts}) { if ($form->{"${item}_base"}) { $form->{"${item}_total"} = $form->round_amount( ($form->{"${item}_base"} * $form->{"${item}_rate"} / (1 + $form->{"${item}_rate"})), 2); $form->{"${item}_netto"} = $form->round_amount( ($form->{"${item}_base"} - $form->{"${item}_total"}), 2); @@ -438,14 +471,14 @@ sub form_footer { $form->{"${item}_netto"} = $form->format_amount(\%myconfig, $form->{"${item}_netto"}, 2); $TMPL_VAR{tax} .= qq| - - Enthaltene $form->{"${item}_description"} | . $form->{"${item}_rate"} * 100 .qq|% - $form->{"${item}_total"} - - - Nettobetrag - $form->{"${item}_netto"} - |; + + Enthaltene $form->{"${item}_description"} | . $form->{"${item}_rate"} * 100 .qq|% + $form->{"${item}_total"} + + + Nettobetrag + $form->{"${item}_netto"} + |; } } } @@ -454,20 +487,29 @@ sub form_footer { print $form->parse_html_template("oe/form_footer", { %TMPL_VAR, - webdav => $webdav, + webdav => $main::webdav, print_options => print_options(inline => 1), label_edit => $locale->text("Edit the $form->{type}"), label_workflow => $locale->text("Workflow $form->{type}"), + is_sales => scalar ($form->{type} =~ /^sales_/), # these vars are exported, so that the template + is_order => scalar ($form->{type} =~ /_order$/), # may determine what to show + is_sales_quo => scalar ($form->{type} =~ /sales_quotation$/), + is_req_quo => scalar ($form->{type} =~ /request_quotation$/), + is_sales_ord => scalar ($form->{type} =~ /sales_order$/), + is_pur_ord => scalar ($form->{type} =~ /purchase_order$/), }); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub update { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); my ($recursive_call) = shift; + my $form = $main::form; + my %myconfig = %main::myconfig; + check_oe_access(); # $main::lxdebug->message(0, Dumper($form)); @@ -477,22 +519,18 @@ sub update { map { $form->{$_} = $form->parse_amount(\%myconfig, $form->{$_}) } qw(exchangerate) unless $recursive_call; $form->{update} = 1; - $payment_id = $form->{payment_id} if $form->{payment_id}; - &check_name($form->{vc}); - $form->{payment_id} = $payment_id if $form->{payment_id} eq ""; - - $buysell = 'buy'; + my $buysell = 'buy'; $buysell = 'sell' if ($form->{vc} eq 'vendor'); $form->{forex} = $form->check_exchangerate(\%myconfig, $form->{currency}, $form->{transdate}, $buysell); $form->{exchangerate} = $form->{forex} if $form->{forex}; - $exchangerate = $form->{exchangerate} || 1; + my $exchangerate = $form->{exchangerate} || 1; ##################### process items ###################################### # for pricegroups - $i = $form->{rowcount}; + my $i = $form->{rowcount}; if ( ($form->{"partnumber_$i"} eq "") && ($form->{"description_$i"} eq "") && ($form->{"partsgroup_$i"} eq "")) { @@ -511,31 +549,33 @@ sub update { my $rows = scalar @{ $form->{item_list} }; # hier ist das problem fuer bug 817 $form->{discount} wird nicht durchgeschliffen - # ferner fallunterscheidung fuer verkauf oder einkauf s.a. bug 736 jb 04.05.2009 + # ferner fallunterscheidung fuer verkauf oder einkauf s.a. bug 736 jb 04.05.2009 # select discount as vendor_discount from vendor || # select discount as customer_discount from customer $form->{"discount_$i"} = $form->format_amount(\%myconfig, $form->{"$form->{vc}_discount"} * 100); + $form->{"lastcost_$i"} = $form->parse_amount(\%myconfig, $form->{"lastcost_$i"}); + if ($rows) { - $form->{"qty_$i"} = 1 unless ($form->{"qty_$i"}); + $form->{"qty_$i"} = 1 unless ($form->parse_amount(\%myconfig, $form->{"qty_$i"})); if ($rows > 1) { &select_item; - exit; + ::end_of_request(); } else { - $sellprice = $form->parse_amount(\%myconfig, $form->{"sellprice_$i"}); + my $sellprice = $form->parse_amount(\%myconfig, $form->{"sellprice_$i"}); # hier werden parts (Artikeleigenschaften) aus item_list (retrieve_item aus IS.pm) # (item wahrscheinlich synonym für parts) entsprechend in die form geschrieben ... - # Wäre dieses Mapping nicht besser in retrieve_items aufgehoben? + # Wäre dieses Mapping nicht besser in retrieve_items aufgehoben? #(Eine Funktion bekommt Daten -> ARBEIT -> Rückgabe DATEN) # Das quot sieht doch auch nach Überarbeitung aus ... (hmm retrieve_items gibt es in IS und IR) map { $form->{item_list}[$i]{$_} =~ s/\"/"/g } qw(partnumber description unit); map { $form->{"${_}_$i"} = $form->{item_list}[0]{$_} } keys %{ $form->{item_list}[0] }; - + # ... deswegen muss die prüfung, ob es sich um einen nicht rabattierfähigen artikel handelt später erfolgen (Bug 1136) $form->{"discount_$i"} = 0 if $form->{"not_discountable_$i"}; $form->{payment_id} = $form->{"part_payment_id_$i"} if $form->{"part_payment_id_$i"} ne ""; @@ -543,7 +583,8 @@ sub update { $form->{"marge_price_factor_$i"} = $form->{item_list}->[0]->{price_factor}; ($sellprice || $form->{"sellprice_$i"}) =~ /\.(\d+)/; - $decimalplaces = max 2, length $1; + my $dec_qty = length $1; + my $decimalplaces = max 2, $dec_qty; if ($sellprice) { $form->{"sellprice_$i"} = $sellprice; @@ -552,7 +593,7 @@ sub update { $form->{"sellprice_$i"} /= $exchangerate; # if there is an exchange rate adjust sellprice } - $amount = $form->{"sellprice_$i"} * $form->{"qty_$i"} * (1 - $form->{"discount_$i"} / 100); + my $amount = $form->{"sellprice_$i"} * $form->{"qty_$i"} * (1 - $form->{"discount_$i"} / 100); map { $form->{"${_}_base"} = 0 } split / /, $form->{taxaccounts}; map { $form->{"${_}_base"} += $amount } split / /, $form->{"taxaccounts_$i"}; map { $amount += ($form->{"${_}_base"} * $form->{"${_}_rate"}) } split / /, $form->{taxaccounts} if !$form->{taxincluded}; @@ -560,6 +601,7 @@ sub update { $form->{creditremaining} -= $amount; $form->{"sellprice_$i"} = $form->format_amount(\%myconfig, $form->{"sellprice_$i"}, $decimalplaces); + $form->{"lastcost_$i"} = $form->format_amount(\%myconfig, $form->{"lastcost_$i"}, $decimalplaces); $form->{"qty_$i"} = $form->format_amount(\%myconfig, $form->{"qty_$i"}, $dec_qty); # get pricegroups for parts @@ -591,11 +633,15 @@ sub update { ##################### process items ###################################### - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub search { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); @@ -643,16 +689,22 @@ sub search { $form->header(); - print $form->parse_html_template('oe/search', { %myconfig }); + print $form->parse_html_template('oe/search', { + %myconfig, + is_order => $form->{type} =~ /_order/, + }); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub create_subtotal_row { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); my ($totals, $columns, $column_alignment, $subtotal_columns, $class) = @_; + my $form = $main::form; + my %myconfig = %main::myconfig; + my $row = { map { $_ => { 'data' => '', 'class' => $class, 'align' => $column_alignment->{$_}, } } @{ $columns } }; map { $row->{$_}->{data} = $form->format_amount(\%myconfig, $totals->{$_}, 2) } @{ $subtotal_columns }; @@ -661,17 +713,22 @@ sub create_subtotal_row { map { $totals->{$_} = 0 } @{ $subtotal_columns }; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); return $row; } sub orders { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; + my $cgi = $main::cgi; check_oe_access(); - $ordnumber = ($form->{type} =~ /_order$/) ? "ordnumber" : "quonumber"; + my $ordnumber = ($form->{type} =~ /_order$/) ? "ordnumber" : "quonumber"; ($form->{ $form->{vc} }, $form->{"$form->{vc}_id"}) = split(/--/, $form->{ $form->{vc} }); @@ -691,7 +748,8 @@ sub orders { "shipvia", "globalprojectnumber", "transaction_description", "open", "delivered", "marge_total", "marge_percent", - "country", "ustid", + "vcnumber", "ustid", + "country", ); # only show checkboxes if gotten here via sales_order form. @@ -728,14 +786,14 @@ sub orders { my @hidden_variables = map { "l_${_}" } @columns; push @hidden_variables, "l_subtotal", $form->{vc}, qw(l_closed l_notdelivered open closed delivered notdelivered ordnumber quonumber transaction_description transdatefrom transdateto type vc employee_id salesman_id - reqdatefrom reqdateto); + reqdatefrom reqdateto projectnumber project_id); my $href = build_std_url('action=orders', grep { $form->{$_} } @hidden_variables); my %column_defs = ( 'ids' => { 'text' => '', }, 'transdate' => { 'text' => $locale->text('Date'), }, - 'reqdate' => { 'text' => $locale->text('Required by'), }, + 'reqdate' => { 'text' => $form->{type} =~ /_order/ ? $locale->text('Required by') : $locale->text('Valid until') }, 'id' => { 'text' => $locale->text('ID'), }, 'ordnumber' => { 'text' => $locale->text('Order'), }, 'quonumber' => { 'text' => $form->{type} eq "request_quotation" ? $locale->text('RFQ') : $locale->text('Quotation'), }, @@ -753,6 +811,7 @@ sub orders { 'delivered' => { 'text' => $locale->text('Delivered'), }, 'marge_total' => { 'text' => $locale->text('Ertrag'), }, 'marge_percent' => { 'text' => $locale->text('Ertrag prozentual'), }, + 'vcnumber' => { 'text' => $form->{vc} eq 'customer' ? $locale->text('Customer Number') : $locale->text('Vendor Number'), }, 'country' => { 'text' => $locale->text('Country'), }, 'ustid' => { 'text' => $locale->text('USt-IdNr.'), }, ); @@ -805,12 +864,13 @@ sub orders { 'attachment_basename' => $attachment_basename . strftime('_%Y%m%d', localtime time), ); $report->set_options_from_form(); + $locale->set_numberformat_wo_thousands_separator(\%myconfig) if lc($report->{options}->{output_format}) eq 'csv'; # add sort and escape callback, this one we use for the add sub $form->{callback} = $href .= "&sort=$form->{sort}"; # escape callback for href - $callback = $form->escape($href); + my $callback = $form->escape($href); my @subtotal_columns = qw(netamount amount marge_total marge_percent); @@ -821,7 +881,7 @@ sub orders { my $edit_url = build_std_url('action=edit', 'type', 'vc'); - foreach $oe (@{ $form->{OE} }) { + foreach my $oe (@{ $form->{OE} }) { map { $oe->{$_} *= $oe->{exchangerate} } @subtotal_columns; $oe->{tax} = $oe->{amount} - $oe->{netamount}; @@ -873,16 +933,19 @@ sub orders { $report->generate_with_headers(); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub check_delivered_flag { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; check_oe_access(); if (($form->{type} ne 'sales_order') && ($form->{type} ne 'purchase_order')) { - return $lxdebug->leave_sub(); + return $main::lxdebug->leave_sub(); } my $all_delivered = 0; @@ -901,11 +964,15 @@ sub check_delivered_flag { $form->{delivered} = 1 if $all_delivered; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub save_and_close { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); @@ -921,7 +988,7 @@ sub save_and_close { $form->{$idx} =~ s/^\s*//g; $form->{$idx} =~ s/\s*$//g; - $msg = ucfirst $form->{vc}; + my $msg = ucfirst $form->{vc}; $form->isblank($form->{vc}, $locale->text($msg . " missing!")); # $locale->text('Customer missing!'); @@ -932,6 +999,7 @@ sub save_and_close { &validate_items; + my $payment_id; if($form->{payment_id}) { $payment_id = $form->{payment_id}; } @@ -942,11 +1010,12 @@ sub save_and_close { $form->{payment_id} = $payment_id; } &update; - exit; + ::end_of_request(); } $form->{id} = 0 if $form->{saveasnew}; + my ($numberfld, $ordnumber, $err); # this is for the internal notes section for the [email] Subject if ($form->{type} =~ /_order$/) { if ($form->{type} eq 'sales_order') { @@ -994,19 +1063,23 @@ sub save_and_close { # saving the history if(!exists $form->{addition}) { $form->{snumbers} = qq|ordnumber_| . $form->{ordnumber}; - $form->{addition} = "SAVED"; - $form->save_history($form->dbconnect(\%myconfig)); + $form->{addition} = "SAVED"; + $form->save_history; } # /saving the history $form->redirect($form->{label} . " $form->{$ordnumber} " . $locale->text('saved!')); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub save { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); @@ -1023,7 +1096,7 @@ sub save { $form->{$idx} =~ s/^\s*//g; $form->{$idx} =~ s/\s*$//g; - $msg = ucfirst $form->{vc}; + my $msg = ucfirst $form->{vc}; $form->isblank($form->{vc}, $locale->text($msg . " missing!")); # $locale->text('Customer missing!'); @@ -1032,8 +1105,10 @@ sub save { $form->isblank("exchangerate", $locale->text('Exchangerate missing!')) if ($form->{currency} ne $form->{defaultcurrency}); + remove_emptied_rows(); &validate_items; + my $payment_id; if($form->{payment_id}) { $payment_id = $form->{payment_id}; } @@ -1044,11 +1119,13 @@ sub save { $form->{payment_id} = $payment_id; } &update; - exit; + ::end_of_request(); } $form->{id} = 0 if $form->{saveasnew}; + my ($numberfld, $ordnumber, $err); + # this is for the internal notes section for the [email] Subject if ($form->{type} =~ /_order$/) { if ($form->{type} eq 'sales_order') { @@ -1094,27 +1171,31 @@ sub save { # saving the history if(!exists $form->{addition}) { $form->{snumbers} = qq|ordnumber_| . $form->{ordnumber}; - $form->{addition} = "SAVED"; - $form->save_history($form->dbconnect(\%myconfig)); + $form->{addition} = "SAVED"; + $form->save_history; } # /saving the history $form->{simple_save} = 1; if(!$form->{print_and_save}) { - delete @{$form}{ary_diff([keys %{ $form }], [qw(login stylesheet id script type)])}; + delete @{$form}{ary_diff([keys %{ $form }], [qw(login stylesheet id script type cursor_fokus)])}; edit(); - exit; + ::end_of_request(); } - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub delete { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my $locale = $main::locale; check_oe_access(); $form->header; + my ($msg, $ordnumber); if ($form->{type} =~ /_order$/) { $msg = $locale->text('Are you sure you want to delete Order Number'); $ordnumber = 'ordnumber'; @@ -1132,7 +1213,7 @@ sub delete { # delete action variable map { delete $form->{$_} } qw(action header); - foreach $key (keys %$form) { + foreach my $key (keys %$form) { next if (($key eq 'login') || ($key eq 'password') || ('' ne ref $form->{$key})); $form->{$key} =~ s/\"/"/g; print qq|\n|; @@ -1154,14 +1235,19 @@ sub delete { |; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub delete_order_quotation { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); + my ($msg, $err); if ($form->{type} =~ /_order$/) { $msg = $locale->text('Order deleted!'); $err = $locale->text('Cannot delete order!'); @@ -1169,27 +1255,31 @@ sub delete_order_quotation { $msg = $locale->text('Quotation deleted!'); $err = $locale->text('Cannot delete quotation!'); } - if (OE->delete(\%myconfig, \%$form, $spool)){ + if (OE->delete(\%myconfig, \%$form, $main::spool)){ # saving the history if(!exists $form->{addition}) { $form->{snumbers} = qq|ordnumber_| . $form->{ordnumber}; - $form->{addition} = "DELETED"; - $form->save_history($form->dbconnect(\%myconfig)); + $form->{addition} = "DELETED"; + $form->save_history; } # /saving the history $form->info($msg); - exit(); + ::end_of_request(); } $form->error($err); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub invoice { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; check_oe_access(); - $auth->assert($form->{type} eq 'purchase_order' || $form->{type} eq 'request_quotation' ? 'vendor_invoice_edit' : 'invoice_edit'); + $main::auth->assert($form->{type} eq 'purchase_order' || $form->{type} eq 'request_quotation' ? 'vendor_invoice_edit' : 'invoice_edit'); $form->{old_salesman_id} = $form->{salesman_id}; $form->get_employee(); @@ -1214,23 +1304,24 @@ sub invoice { $form->{quodate} = $form->{transdate}; } - $payment_id = $form->{payment_id} if $form->{payment_id}; + my $payment_id = $form->{payment_id} if $form->{payment_id}; # if the name changed get new values if (&check_name($form->{vc})) { $form->{payment_id} = $payment_id if $form->{payment_id} eq ""; &update; - exit; + ::end_of_request(); } $form->{cp_id} *= 1; - for $i (1 .. $form->{rowcount}) { + for my $i (1 .. $form->{rowcount}) { for (qw(ship qty sellprice listprice basefactor)) { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if $form->{"${_}_${i}"}; } } + my ($buysell, $orddate, $exchangerate); if ( $form->{type} =~ /_order/ && $form->{currency} ne $form->{defaultcurrency}) { @@ -1242,7 +1333,7 @@ sub invoice { if (!$exchangerate) { &backorder_exchangerate($orddate, $buysell); - exit; + ::end_of_request(); } } @@ -1260,6 +1351,7 @@ sub invoice { &create_backorder; } + my ($script); if ( $form->{type} eq 'purchase_order' || $form->{type} eq 'request_quotation') { $form->{title} = $locale->text('Add Vendor Invoice'); @@ -1282,13 +1374,14 @@ sub invoice { $form->{type} = "invoice"; # locale messages - $locale = new Locale "$myconfig{countrycode}", "$script"; + $main::locale = new Locale "$myconfig{countrycode}", "$script"; + $locale = $main::locale; require "bin/mozilla/$form->{script}"; map { $form->{"select$_"} = "" } ($form->{vc}, "currency"); - $currency = $form->{currency}; + my $currency = $form->{currency}; &invoice_links; $form->{currency} = $currency; @@ -1300,13 +1393,13 @@ sub invoice { &prepare_invoice; # format amounts - for $i (1 .. $form->{rowcount}) { + for my $i (1 .. $form->{rowcount}) { $form->{"discount_$i"} = $form->format_amount(\%myconfig, $form->{"discount_$i"}); - ($dec) = ($form->{"sellprice_$i"} =~ /\.(\d+)/); + my ($dec) = ($form->{"sellprice_$i"} =~ /\.(\d+)/); $dec = length $dec; - $decimalplaces = ($dec > 2) ? $dec : 2; + my $decimalplaces = ($dec > 2) ? $dec : 2; # copy delivery date from reqdate for order -> invoice conversion $form->{"deliverydate_$i"} = $form->{"reqdate_$i"} @@ -1326,13 +1419,20 @@ sub invoice { } + # show pricegroup in newly loaded invoice when creating invoice from quotation/order + IS->get_pricegroups_for_parts(\%myconfig, \%$form); + set_pricegroup($_) for 1 .. $form->{rowcount}; + &display_form; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub backorder_exchangerate { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my $locale = $main::locale; check_oe_access(); @@ -1349,7 +1449,7 @@ sub backorder_exchangerate { # delete action variable map { delete $form->{$_} } qw(action header exchangerate); - foreach $key (keys %$form) { + foreach my $key (keys %$form) { next if (($key eq 'login') || ($key eq 'password') || ('' ne ref $form->{$key})); $form->{$key} =~ s/\"/"/g; print qq|\n|; @@ -1369,16 +1469,16 @@ sub backorder_exchangerate { - - - - - - - + + + + + + + - - + +
| . $locale->text('Currency') . qq|$form->{currency}
| . $locale->text('Date') . qq|$orddate
| . $locale->text('Currency') . qq|$form->{currency}
| . $locale->text('Date') . qq|$orddate
| . $locale->text('Exchangerate') . qq|| . $locale->text('Exchangerate') . qq|
@@ -1399,11 +1499,15 @@ sub backorder_exchangerate { |; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub save_exchangerate { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; + my $locale = $main::locale; $form->isblank("exchangerate", $locale->text('Exchangerate missing!')); $form->{exchangerate} = @@ -1414,20 +1518,26 @@ sub save_exchangerate { &invoice; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub create_backorder { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; $form->{shipped} = 1; # figure out if we need to create a backorder # items aren't saved if qty != 0 - for $i (1 .. $form->{rowcount}) { - $totalqty += $qty = $form->{"qty_$i"}; - $totalship += $ship = $form->{"ship_$i"}; + my ($totalqty, $totalship); + for my $i (1 .. $form->{rowcount}) { + my $qty = $form->{"qty_$i"}; + my $ship = $form->{"ship_$i"}; + $totalqty += $qty; + $totalship += $ship; $form->{"qty_$i"} = $qty - $ship; } @@ -1445,11 +1555,11 @@ sub create_backorder { return; } - @flds = ( + my @flds = ( qw(partnumber description qty ship unit sellprice discount id inventory_accno bin income_accno expense_accno listprice assembly taxaccounts partsgroup) ); - for $i (1 .. $form->{rowcount}) { + for my $i (1 .. $form->{rowcount}) { map { $form->{"${_}_$i"} = $form->format_amount(\%myconfig, $form->{"${_}_$i"}) @@ -1461,15 +1571,15 @@ sub create_backorder { OE->save(\%myconfig, \%$form); # rebuild rows for invoice - @a = (); - $count = 0; + my @a = (); + my $count = 0; - for $i (1 .. $form->{rowcount}) { + for my $i (1 .. $form->{rowcount}) { $form->{"qty_$i"} = $form->{"ship_$i"}; if ($form->{"qty_$i"}) { push @a, {}; - $j = $#a; + my $j = $#a; map { $a[$j]->{$_} = $form->{"${_}_$i"} } @flds; $count++; } @@ -1478,11 +1588,13 @@ sub create_backorder { $form->redo_rows(\@flds, \@a, $count, $form->{rowcount}); $form->{rowcount} = $count; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub save_as_new { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; check_oe_access(); @@ -1512,11 +1624,13 @@ sub save_as_new { &save; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub check_for_direct_delivery_yes { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; check_oe_access(); @@ -1525,11 +1639,13 @@ sub check_for_direct_delivery_yes { map { s/^CFDD_//; $form->{$_} = $form->{"CFDD_${_}"} } grep /^CFDD_/, keys %{ $form }; $form->{shipto} = 1; purchase_order(); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub check_for_direct_delivery_no { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; check_oe_access(); @@ -1537,17 +1653,20 @@ sub check_for_direct_delivery_no { delete @{$form}{grep /^shipto/, keys %{ $form }}; purchase_order(); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub check_for_direct_delivery { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; check_oe_access(); if ($form->{direct_delivery_checked} || (!$form->{shiptoname} && !$form->{shiptostreet} && !$form->{shipto_id})) { - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); return; } @@ -1564,18 +1683,23 @@ sub check_for_direct_delivery { $form->header(); print $form->parse_html_template("oe/check_for_direct_delivery"); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); - exit 0; + ::end_of_request(); } sub purchase_order { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my $locale = $main::locale; check_oe_access(); - $auth->assert('purchase_order_edit'); + $main::auth->assert('purchase_order_edit'); + $form->{sales_order_to_purchase_order} = 0; if ($form->{type} eq 'sales_order') { + $form->{sales_order_to_purchase_order} = 1; check_for_direct_delivery(); } @@ -1593,14 +1717,19 @@ sub purchase_order { &poso; - $lxdebug->leave_sub(); + delete $form->{sales_order_to_purchase_order}; + + $main::lxdebug->leave_sub(); } sub sales_order { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my $locale = $main::locale; check_oe_access(); - $auth->assert('sales_order_edit'); + $main::auth->assert('sales_order_edit'); if ($form->{type} eq "purchase_order") { delete($form->{ordnumber}); @@ -1616,14 +1745,17 @@ sub sales_order { &poso; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub poso { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; check_oe_access(); - $auth->assert('purchase_order_edit | sales_order_edit'); + $main::auth->assert('purchase_order_edit | sales_order_edit'); $form->{transdate} = $form->current_date(\%myconfig); delete $form->{duedate}; @@ -1635,10 +1767,16 @@ sub poso { $form->{old_salesman_id} = $form->{salesman_id}; # reset - map { delete $form->{$_} } qw(id subject message cc bcc printed emailed queued customer vendor creditlimit creditremaining discount tradediscount oldinvtotal delivered - ordnumber); + map { delete $form->{$_} } qw(id subject message cc bcc printed emailed queued customer vendor creditlimit creditremaining discount tradediscount oldinvtotal delivered ordnumber); - for $i (1 .. $form->{rowcount}) { + # if purchase_order was generated from sales_order, use lastcost_$i as sellprice_$i + if ( $form->{sales_order_to_purchase_order} ) { + for my $i (1 .. $form->{rowcount}) { + $form->{"sellprice_${i}"} = $form->format_amount(\%myconfig,$form->{"lastcost_${i}"}); + }; + }; + + for my $i (1 .. $form->{rowcount}) { map { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if ($form->{"${_}_${i}"}) } qw(ship qty sellprice listprice basefactor discount); } @@ -1648,35 +1786,35 @@ sub poso { map { $form->{$_} = $saved_vars{$_} } keys %saved_vars; - &prepare_order; - # prepare_order assumes that the discount is in db-notation (0.05) and not user-notation (5) - # and therefore multiplies the values by 100 in the case of reading from db or making an order from several quotation, so we convert this back into percent-notation for the user interface by multiplying with 0.01 - for $i (1 .. $form->{rowcount}) { - $form->{"discount_$i"} = $form->format_amount(\%myconfig, $form->{"discount_$i"} * 0.01); + # and therefore multiplies the values by 100 in the case of reading from db or making an order + # from several quotation, so we convert this back into percent-notation for the user interface by multiplying with 0.01 + # ergänzung 03.10.2010 muss vor prepare_order passieren (s.a. Svens Kommentar zu Bug 1017) + # das parse_amount wird oben schon ausgeführt, deswegen an dieser stelle raus (wichtig: kommawerte bei discount testen) + for my $i (1 .. $form->{rowcount}) { + $form->{"discount_$i"} /=100; }; - # format amounts - for $i (1 .. $form->{rowcount} - 1) { - map { $form->{"${_}_$i"} =~ s/\"/"/g } qw(partnumber description unit); - } - + &prepare_order; &update; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub delivery_order { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; if ($form->{type} =~ /^sales/) { - $auth->assert('sales_delivery_order_edit'); + $main::auth->assert('sales_delivery_order_edit'); $form->{vc} = 'customer'; $form->{type} = 'sales_delivery_order'; } else { - $auth->assert('purchase_delivery_order_edit'); + $main::auth->assert('purchase_delivery_order_edit'); $form->{vc} = 'vendor'; $form->{type} = 'purchase_delivery_order'; @@ -1698,11 +1836,11 @@ sub delivery_order { # reset delete @{$form}{qw(id subject message cc bcc printed emailed queued creditlimit creditremaining discount tradediscount oldinvtotal closed delivered)}; - for $i (1 .. $form->{rowcount}) { - map { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if ($form->{"${_}_${i}"}) } qw(ship qty sellprice listprice basefactor discount); + for my $i (1 .. $form->{rowcount}) { + map { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if ($form->{"${_}_${i}"}) } qw(ship qty sellprice listprice lastcost basefactor discount); } - my %old_values = map { $_ => $form->{$_} } qw(customer_id oldcustomer customer vendor_id oldvendor vendor); + my %old_values = map { $_ => $form->{$_} } qw(customer_id oldcustomer customer vendor_id oldvendor vendor shipto_id); order_links(); @@ -1712,18 +1850,18 @@ sub delivery_order { update(); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub e_mail { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; check_oe_access(); $form->{print_and_save} = 1; - $print_post = 1; - my $saved_form = save_form(); save(); @@ -1732,22 +1870,25 @@ sub e_mail { edit_e_mail(); - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub yes { - call_sub($form->{yes_nextsub}); + call_sub($main::form->{yes_nextsub}); } sub no { - call_sub($form->{no_nextsub}); + call_sub($main::form->{no_nextsub}); } ###################################################################################################### # IO ENTKOPPLUNG # ############################################################################################### sub display_form { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; + my %myconfig = %main::myconfig; check_oe_access(); @@ -1760,16 +1901,14 @@ sub display_form { } $form->{"taxaccounts"} = ""; - for my $i (1 .. $form->{"rowcount"}) { - IC->retrieve_accounts(\%myconfig, $form, $form->{"id_$i"}, $i, 1) if $form->{"id_$i"}; - } + IC->retrieve_accounts(\%myconfig, $form, map { $_ => $form->{"id_$_"} } 1 .. $form->{rowcount}); $form->{rowcount}++; $form->{"project_id_$form->{rowcount}"} = $form->{globalproject_id}; $form->language_payment(\%myconfig); - Common::webdav_folder($form) if ($webdav); + Common::webdav_folder($form) if ($main::webdav); &form_header; @@ -1778,11 +1917,13 @@ sub display_form { &form_footer; - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); } sub report_for_todo_list { - $lxdebug->enter_sub(); + $main::lxdebug->enter_sub(); + + my $form = $main::form; my $quotations = OE->transactions_for_todo_list(); my $content; @@ -1794,8 +1935,22 @@ sub report_for_todo_list { 'edit_url' => $edit_url }); } - $lxdebug->leave_sub(); + $main::lxdebug->leave_sub(); return $content; } +sub dispatcher { + my $form = $main::form; + my $locale = $main::locale; + + foreach my $action (qw(delete delivery_order e_mail invoice print purchase_order purchase_order quotation + request_for_quotation sales_order sales_order save save_and_close save_as_new ship_to update)) { + if ($form->{"action_${action}"}) { + call_sub($action); + return; + } + } + + $form->error($locale->text('No action defined.')); +}