X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=bin%2Fmozilla%2Foe.pl;h=f19a2876c1d1254b9cb05249f0e148d7ddc75915;hb=69e526ee5cfc3d153f738083b397a000c00c4468;hp=11e220a68f499be6bd2a7b4e206c01f5a7c52a77;hpb=9093d62e4e9e540618daf66cdb6e7a53ad75b2d5;p=kivitendo-erp.git diff --git a/bin/mozilla/oe.pl b/bin/mozilla/oe.pl index 11e220a68..f19a2876c 100644 --- a/bin/mozilla/oe.pl +++ b/bin/mozilla/oe.pl @@ -24,7 +24,8 @@ # GNU General Public License for more details. # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software -# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1335, USA. #====================================================================== # # Order entry module @@ -42,7 +43,6 @@ use SL::OE; use SL::IR; use SL::IS; use SL::MoreCommon qw(ary_diff restore_form save_form); -use SL::PE; use SL::ReportGenerator; use List::MoreUtils qw(uniq any none); use List::Util qw(min max reduce sum); @@ -50,9 +50,11 @@ use Data::Dumper; use SL::DB::Customer; use SL::DB::TaxZone; +use SL::DB::PaymentTerm; +use SL::DB::Vendor; +require "bin/mozilla/common.pl"; require "bin/mozilla/io.pl"; -require "bin/mozilla/arap.pl"; require "bin/mozilla/reportgenerator.pl"; use strict; @@ -240,9 +242,6 @@ sub order_links { check_oe_access(); - # get customer/vendor - $form->all_vc(\%myconfig, $form->{vc}, ($form->{vc} eq 'customer') ? "AR" : "AP"); - # retrieve order/quotation my $editing = $form->{id}; @@ -255,8 +254,6 @@ sub order_links { if $form->{rowcount} && $form->{type} eq 'sales_order' && defined $form->{customer} && $form->{customer} eq ''; - $form->{"$form->{vc}_id"} ||= $form->{"all_$form->{vc}"}->[0]->{id} if $form->{"all_$form->{vc}"}; - $form->backup_vars(qw(payment_id language_id taxzone_id salesman_id taxincluded cp_id intnotes shipto_id delivery_term_id currency)); # get customer / vendor @@ -270,18 +267,6 @@ sub order_links { $form->{forex} = $form->{exchangerate}; $form->{employee} = "$form->{employee}--$form->{employee_id}"; - # build vendor/customer drop down comatibility... don't ask - if (@{ $form->{"all_$form->{vc}"} || [] }) { - $form->{"select$form->{vc}"} = 1; - $form->{$form->{vc}} = qq|$form->{$form->{vc}}--$form->{"$form->{vc}_id"}|; - } - - $form->{"old$form->{vc}"} = $form->{$form->{vc}}; - - if ($form->{"old$form->{vc}"} !~ m/--\d+$/ && $form->{"$form->{vc}_id"}) { - $form->{"old$form->{vc}"} .= qq|--$form->{"$form->{vc}_id"}| - } - $main::lxdebug->leave_sub(); } @@ -309,6 +294,174 @@ sub prepare_order { $main::lxdebug->leave_sub(); } +sub setup_oe_action_bar { + my %params = @_; + my $form = $::form; + + my $has_active_periodic_invoice; + if ($params{obj}) { + $has_active_periodic_invoice = + $params{obj}->is_type('sales_order') + && $params{obj}->periodic_invoices_config + && $params{obj}->periodic_invoices_config->active + && ( !$params{obj}->periodic_invoices_config->end_date + || ($params{obj}->periodic_invoices_config->end_date > DateTime->today_local)) + && $params{obj}->periodic_invoices_config->get_previous_billed_period_start_date; + } + + my $allow_invoice = $params{is_req_quo} + || $params{is_pur_ord} + || ($params{is_sales_quo} && $::instance_conf->get_allow_sales_invoice_from_sales_quotation) + || ($params{is_sales_ord} && $::instance_conf->get_allow_sales_invoice_from_sales_order); + my @req_trans_desc = qw(kivi.SalesPurchase.check_transaction_description) x!!$::instance_conf->get_require_transaction_description_ps; + my @req_trans_cost_art = qw(kivi.SalesPurchase.check_transport_cost_article_presence) x!!$::instance_conf->get_transport_cost_reminder_article_number_id; + my @warn_p_invoice = qw(kivi.SalesPurchase.oe_warn_save_active_periodic_invoice) x!!$has_active_periodic_invoice; + + for my $bar ($::request->layout->get('actionbar')) { + $bar->add( + action => [ + t8('Update'), + submit => [ '#form', { action => "update" } ], + id => 'update_button', + accesskey => 'enter', + ], + + combobox => [ + action => [ + t8('Save'), + submit => [ '#form', { action => "save" } ], + checks => [ @req_trans_desc, @req_trans_cost_art, @warn_p_invoice ], + ], + action => [ + t8('Save as new'), + submit => [ '#form', { action => "save_as_new" } ], + checks => [ @req_trans_desc, @req_trans_cost_art ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + ], + action => [ + t8('Save and Close'), + submit => [ '#form', { action => "save_and_close" } ], + checks => [ @req_trans_desc, @req_trans_cost_art, @warn_p_invoice ], + ], + action => [ + t8('Delete'), + submit => [ '#form', { action => "delete" } ], + confirm => t8('Do you really want to delete this object?'), + disabled => !$form->{id} ? t8('This record has not been saved yet.') + : ( ($params{is_sales_ord} && !$::instance_conf->get_sales_order_show_delete) + || ($params{is_pur_ord} && !$::instance_conf->get_purchase_order_show_delete)) ? t8('Deleting this type of record has been disabled in the configuration.') + : undef, + ], + ], # end of combobox "Save" + + 'separator', + + combobox => [ + action => [ t8('Workflow') ], + action => [ + t8('Sales Order'), + submit => [ '#form', { action => "sales_order" } ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + only_if => $params{is_sales_quo}, + ], + action => [ + t8('Purchase Order'), + submit => [ '#form', { action => "sales_order" } ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + only_if => $params{is_req_quo}, + ], + action => [ + t8('Delivery Order'), + submit => [ '#form', { action => "delivery_order" } ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + only_if => $params{is_sales_ord} || $params{is_pur_ord}, + ], + action => [ + t8('Invoice'), + submit => [ '#form', { action => "invoice" } ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + only_if => $allow_invoice, + ], + action => [ + t8('Quotation'), + submit => [ '#form', { action => "quotation" } ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + ], + action => [ + t8('Request for Quotation'), + submit => [ '#form', { action => "reqest_for_quotation" } ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + ], + ], # end of combobox "Workflow" + + combobox => [ + action => [ t8('Export') ], + action => [ + t8('Print'), + call => [ 'kivi.SalesPurchase.show_print_dialog' ], + checks => [ @req_trans_desc ], + ], + action => [ + t8('E Mail'), + call => [ 'kivi.SalesPurchase.show_email_dialog' ], + checks => [ @req_trans_desc ], + ], + action => [ + t8('Download attachments of all parts'), + call => [ 'kivi.File.downloadOrderitemsFiles', $::form->{type}, $::form->{id} ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + only_if => $::instance_conf->get_doc_storage, + ], + ], #end of combobox "Export" + + combobox => [ + action => [ t8('more') ], + action => [ + t8('History'), + call => [ 'set_history_window', $form->{id} * 1, 'id' ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + ], + action => [ + t8('Follow-Up'), + call => [ 'follow_up_window' ], + disabled => !$form->{id} ? t8('This record has not been saved yet.') : undef, + ], + ], # end of combobox "more" + ); + } +} + +sub setup_oe_search_action_bar { + my %params = @_; + + for my $bar ($::request->layout->get('actionbar')) { + $bar->add( + action => [ + t8('Search'), + submit => [ '#form' ], + accesskey => 'enter', + ], + ); + } +} + +sub setup_oe_orders_action_bar { + my %params = @_; + + return unless $::form->{type} eq 'sales_order'; + + for my $bar ($::request->layout->get('actionbar')) { + $bar->add( + action => [ + t8('New sales order'), + submit => [ '#form', { action => 'edit' } ], + checks => [ [ 'kivi.check_if_entries_selected', '[name^=multi_id_]' ] ], + accesskey => 'enter', + ], + ); + } +} + sub form_header { $main::lxdebug->enter_sub(); my @custom_hiddens; @@ -324,17 +477,10 @@ sub form_header { # visible in form_footer too, so package local level and not my here. %TMPL_VAR = (); if ($form->{id}) { - my $obj = SL::DB::Order->new(id => $form->{id})->load; - $TMPL_VAR{warn_save_active_periodic_invoice} = - $obj->is_type('sales_order') - && $obj->periodic_invoices_config - && $obj->periodic_invoices_config->active - && ( !$obj->periodic_invoices_config->end_date - || ($obj->periodic_invoices_config->end_date > DateTime->today_local)) - && $obj->periodic_invoices_config->get_previous_billed_period_start_date; - - $TMPL_VAR{oe_obj} = $obj; + $TMPL_VAR{oe_obj} = SL::DB::Order->new(id => $form->{id})->load; } + $TMPL_VAR{vc_obj} = SL::DB::Customer->new(id => $form->{customer_id})->load if $form->{customer_id}; + $TMPL_VAR{vc_obj} = SL::DB::Vendor->new(id => $form->{vendor_id})->load if $form->{vendor_id}; $form->{defaultcurrency} = $form->get_default_currency(\%myconfig); @@ -352,12 +498,11 @@ sub form_header { my $vc = $form->{vc} eq "customer" ? "customers" : "vendors"; $form->get_lists("taxzones" => ($form->{id} ? "ALL_TAXZONES" : "ALL_ACTIVE_TAXZONES"), - "payments" => "ALL_PAYMENTS", "currencies" => "ALL_CURRENCIES", - "departments" => "ALL_DEPARTMENTS", - $vc => { key => "ALL_" . uc($vc), - limit => $myconfig{vclimit} + 1 }, "price_factors" => "ALL_PRICE_FACTORS"); + $form->{ALL_PAYMENTS} = SL::DB::Manager::PaymentTerm->get_all( where => [ or => [ obsolete => 0, id => $form->{payment_id} || undef ] ]); + + $form->{ALL_DEPARTMENTS} = SL::DB::Manager::Department->get_all; # Projects my @old_project_ids = uniq grep { $_ } map { $_ * 1 } ($form->{"globalproject_id"}, map { $form->{"project_id_$_"} } 1..$form->{"rowcount"}); @@ -396,25 +541,10 @@ sub form_header { ] ]); $TMPL_VAR{sales_employee_labels} = sub { $_[0]->{name} || $_[0]->{login} }; - $TMPL_VAR{department_labels} = sub { "$_[0]->{description}--$_[0]->{id}" }; - - # vendor/customer - $TMPL_VAR{vc_keys} = sub { "$_[0]->{name}--$_[0]->{id}" }; - $TMPL_VAR{vclimit} = $myconfig{vclimit}; - $TMPL_VAR{vc_select} = "customer_or_vendor_selection_window('$form->{vc}', '', @{[ $form->{vc} eq 'vendor' ? 1 : 0 ]}, 0)"; - push @custom_hiddens, "$form->{vc}_id"; - push @custom_hiddens, "old$form->{vc}"; - push @custom_hiddens, "select$form->{vc}"; # currencies and exchangerate - my @values = map { $_ } @{ $form->{ALL_CURRENCIES} }; - my %labels = map { $_ => $_ } @{ $form->{ALL_CURRENCIES} }; $form->{currency} = $form->{defaultcurrency} unless $form->{currency}; $TMPL_VAR{show_exchangerate} = $form->{currency} ne $form->{defaultcurrency}; - $TMPL_VAR{currencies} = NTI($cgi->popup_menu('-name' => 'currency', '-default' => $form->{"currency"}, - '-values' => \@values, '-labels' => \%labels, - '-onchange' => "document.getElementById('update_button').click();" - )) if scalar @values; push @custom_hiddens, "forex"; push @custom_hiddens, "exchangerate" if $form->{forex}; @@ -425,7 +555,7 @@ sub form_header { # business $TMPL_VAR{business_label} = ($form->{vc} eq "customer" ? $locale->text('Customer type') : $locale->text('Vendor type')); - push @custom_hiddens, "customer_klass" if $form->{vc} eq 'customer'; + push @custom_hiddens, "customer_pricegroup_id" if $form->{vc} eq 'customer'; my $credittext = $locale->text('Credit Limit exceeded!!!'); @@ -434,7 +564,7 @@ sub form_header { $TMPL_VAR{follow_up_trans_info} = ($form->{type} =~ /_quotation$/ ? $form->{quonumber} : $form->{ordnumber}) . " ($follow_up_vc)"; if ($form->{id}) { - my $follow_ups = FU->follow_ups('trans_id' => $form->{id}); + my $follow_ups = FU->follow_ups('trans_id' => $form->{id}, 'not_done' => 1); if (scalar @{ $follow_ups }) { $TMPL_VAR{num_follow_ups} = scalar @{ $follow_ups }; @@ -467,7 +597,20 @@ sub form_header { } } - $::request->{layout}->use_javascript(map { "${_}.js" } qw(kivi.SalesPurchase show_form_details show_history show_vc_details ckeditor/ckeditor ckeditor/adapters/jquery kivi.io autocomplete_customer autocomplete_part)); + $::request->{layout}->use_javascript(map { "${_}.js" } qw(kivi.SalesPurchase kivi.File kivi.Part show_form_details show_history show_vc_details ckeditor/ckeditor ckeditor/adapters/jquery kivi.io autocomplete_customer)); + + + # original snippets: + my %type_check_vars = ( + is_sales => scalar($form->{type} =~ /^sales_/), + is_order => scalar($form->{type} =~ /_order$/), + is_sales_quo => scalar($form->{type} =~ /sales_quotation$/), + is_req_quo => scalar($form->{type} =~ /request_quotation$/), + is_sales_ord => scalar($form->{type} =~ /sales_order$/), + is_pur_ord => scalar($form->{type} =~ /purchase_order$/), + ); + + setup_oe_action_bar(%type_check_vars); $form->header; if ($form->{CFDD_shipto} && $form->{CFDD_shipto_id} ) { @@ -477,28 +620,26 @@ sub form_header { push @custom_hiddens, map { "shiptocvar_" . $_->name } @{ SL::DB::Manager::CustomVariableConfig->get_all(where => [ module => 'ShipTo' ]) }; $TMPL_VAR{HIDDENS} = [ map { name => $_, value => $form->{$_} }, - qw(id action type vc formname media format proforma queued printed emailed + qw(id type vc proforma queued printed emailed title creditlimit creditremaining tradediscount business - max_dunning_level dunning_amount shiptoname shiptostreet shiptozipcode - CFDD_shipto CFDD_shipto_id shiptocity shiptocountry shiptogln shiptocontact shiptophone shiptofax - shiptodepartment_1 shiptodepartment_2 shiptoemail shiptocp_gender - message email subject cc bcc taxpart taxservice taxaccounts cursor_fokus + max_dunning_level dunning_amount + CFDD_shipto CFDD_shipto_id + taxpart taxservice taxaccounts cursor_fokus show_details useasnew), @custom_hiddens, map { $_.'_rate', $_.'_description', $_.'_taxnumber' } split / /, $form->{taxaccounts} ]; # deleted: discount %TMPL_VAR = ( %TMPL_VAR, - is_sales => scalar ($form->{type} =~ /^sales_/), # these vars are exported, so that the template - is_order => scalar ($form->{type} =~ /_order$/), # may determine what to show - is_sales_quo => scalar ($form->{type} =~ /sales_quotation$/), - is_req_quo => scalar ($form->{type} =~ /request_quotation$/), - is_sales_ord => scalar ($form->{type} =~ /sales_order$/), - is_pur_ord => scalar ($form->{type} =~ /purchase_order$/), + %type_check_vars, ); $TMPL_VAR{ORDER_PROBABILITIES} = [ map { { title => ($_ * 10) . '%', id => $_ * 10 } } (0..10) ]; + if ($type_check_vars{is_sales} && $::instance_conf->get_transport_cost_reminder_article_number_id) { + $TMPL_VAR{transport_cost_reminder_article} = SL::DB::Part->new(id => $::instance_conf->get_transport_cost_reminder_article_number_id)->load; + } + print $form->parse_html_template("oe/form_header", { %TMPL_VAR }); $main::lxdebug->leave_sub(); @@ -560,22 +701,21 @@ sub form_footer { } } + my $grossamount = $form->{invtotal}; + $form->{invtotal} = $form->round_amount( $form->{invtotal}, 2, 1); $form->{rounding} = $form->round_amount( - $form->round_amount($form->{invtotal}, 2, 1) - $form->round_amount($form->{invtotal}, 2) + $form->{invtotal} - $form->round_amount($grossamount, 2), + 2 ); - $form->{invtotal} = $form->round_amount( $form->{invtotal}, 2, 1); $form->{oldinvtotal} = $form->{invtotal}; $TMPL_VAR{ALL_DELIVERY_TERMS} = SL::DB::Manager::DeliveryTerm->get_all_sorted(); - my $tpca_reminder; - $tpca_reminder = check_transport_cost_reminder_article_number() if $::instance_conf->get_transport_cost_reminder_article_number_id; + my $print_options_html = setup_sales_purchase_print_options(); + print $form->parse_html_template("oe/form_footer", { %TMPL_VAR, - tpca_reminder => $tpca_reminder, - print_options => print_options(inline => 1), - label_edit => $locale->text("Edit the $form->{type}"), - label_workflow => $locale->text("Workflow $form->{type}"), + print_options => $print_options_html, is_sales => scalar ($form->{type} =~ /^sales_/), # these vars are exported, so that the template is_order => scalar ($form->{type} =~ /_order$/), # may determine what to show is_sales_quo => scalar ($form->{type} =~ /sales_quotation$/), @@ -601,7 +741,13 @@ sub update { $form->{update} = 1; - &check_name($form->{vc}); + my $vc = $form->{vc}; + if (($form->{"previous_${vc}_id"} || $form->{"${vc}_id"}) != $form->{"${vc}_id"}) { + $::form->{salesman_id} = SL::DB::Manager::Employee->current->id if exists $::form->{salesman_id}; + + IS->get_customer(\%myconfig, $form) if $vc eq 'customer'; + IR->get_vendor(\%myconfig, $form) if $vc eq 'vendor'; + } if (!$form->{forex}) { # read exchangerate from input field (not hidden) map { $form->{$_} = $form->parse_amount(\%myconfig, $form->{$_}) } qw(exchangerate) unless $recursive_call; @@ -767,17 +913,15 @@ sub search { $form->{ordlabel} = $locale->text('Quotation Number'); } else { - $form->show_generic_error($locale->text('oe.pl::search called with unknown type'), back_button => 1); + $form->show_generic_error($locale->text('oe.pl::search called with unknown type')); } # setup vendor / customer data - $form->all_vc(\%myconfig, $form->{vc}, ($form->{vc} eq 'customer') ? "AR" : "AP"); $form->get_lists("projects" => { "key" => "ALL_PROJECTS", "all" => 1 }, - "departments" => "ALL_DEPARTMENTS", - "$form->{vc}s" => "ALL_VC", "taxzones" => "ALL_TAXZONES", "business_types" => "ALL_BUSINESS_TYPES",); $form->{ALL_EMPLOYEES} = SL::DB::Manager::Employee->get_all_sorted(query => [ deleted => 0 ]); + $form->{ALL_DEPARTMENTS} = SL::DB::Manager::Department->get_all; $form->{CT_CUSTOM_VARIABLES} = CVar->get_configs('module' => 'CT'); ($form->{CT_CUSTOM_VARIABLES_FILTER_CODE}, @@ -790,6 +934,10 @@ sub search { $form->{ORDER_PROBABILITIES} = [ map { { title => ($_ * 10) . '%', id => $_ * 10 } } (0..10) ]; + $::request->{layout}->use_javascript(map { "${_}.js" } qw(autocomplete_project)); + + setup_oe_search_action_bar(); + $form->header(); print $form->parse_html_template('oe/search', { @@ -907,7 +1055,7 @@ sub orders { reqdatefrom reqdateto projectnumber project_id periodic_invoices_active periodic_invoices_inactive business_id shippingpoint taxzone_id reqdate_unset_or_old insertdatefrom insertdateto order_probability_op order_probability_value expected_billing_date_from expected_billing_date_to - parts_partnumber parts_description); + parts_partnumber parts_description all department_id); push @hidden_variables, map { "cvar_$_->{name}" } @ct_searchable_custom_variables; my @keys_for_url = grep { $form->{$_} } @hidden_variables; @@ -978,12 +1126,11 @@ sub orders { 'data' => $form->{OE}); my @options; - my ($department) = split m/--/, $form->{department}; push @options, $locale->text('Customer') . " : $form->{customer}" if $form->{customer}; push @options, $locale->text('Vendor') . " : $form->{vendor}" if $form->{vendor}; push @options, $locale->text('Contact Person') . " : $form->{cp_name}" if $form->{cp_name}; - push @options, $locale->text('Department') . " : $department" if $form->{department}; + push @options, $locale->text('Department') . " : $form->{department}" if $form->{department}; push @options, $locale->text('Order Number') . " : $form->{ordnumber}" if $form->{ordnumber}; push @options, $locale->text('Customer Order Number') . " : $form->{cusordnumber}" if $form->{cusordnumber}; push @options, $locale->text('Notes') . " : $form->{notes}" if $form->{notes}; @@ -1022,6 +1169,10 @@ sub orders { push @options, $locale->text('Steuersatz') . " : " . SL::DB::TaxZone->new(id => $form->{taxzone_id})->load->description; } + if ($form->{department_id}) { + push @options, $locale->text('Department') . " : " . SL::DB::Department->new(id => $form->{department_id})->load->description; + } + if (($form->{order_probability_value} || '') ne '') { push @options, $::locale->text('Order probability') . ' ' . ($form->{order_probability_op} eq 'le' ? '<=' : '>=') . ' ' . $form->{order_probability_value} . '%'; } @@ -1034,7 +1185,7 @@ sub orders { $report->set_options('top_info_text' => join("\n", @options), 'raw_top_info_text' => $form->parse_html_template('oe/orders_top'), - 'raw_bottom_info_text' => $form->parse_html_template('oe/orders_bottom', { 'SHOW_CONTINUE_BUTTON' => $allow_multiple_orders }), + 'raw_bottom_info_text' => $form->parse_html_template('oe/orders_bottom'), 'output_format' => 'HTML', 'title' => $form->{title}, 'attachment_basename' => $attachment_basename . strftime('_%Y%m%d', localtime time), @@ -1115,6 +1266,7 @@ sub orders { $report->add_separator(); $report->add_data(create_subtotal_row(\%totals, \@columns, \%column_alignment, \@subtotal_columns, 'listtotal')); + setup_oe_orders_action_bar(); $report->generate_with_headers(); $main::lxdebug->leave_sub(); @@ -1174,7 +1326,7 @@ sub save_and_close { $form->{$idx} =~ s/\s*$//g; my $msg = ucfirst $form->{vc}; - $form->isblank($form->{vc}, $locale->text($msg . " missing!")); + $form->isblank($form->{vc} . '_id', $locale->text($msg . " missing!")); # $locale->text('Customer missing!'); # $locale->text('Vendor missing!'); @@ -1184,17 +1336,14 @@ sub save_and_close { &validate_items; - my $payment_id; - if($form->{payment_id}) { - $payment_id = $form->{payment_id}; - } + my $vc = $form->{vc}; + if (($form->{"previous_${vc}_id"} || $form->{"${vc}_id"}) != $form->{"${vc}_id"}) { + $::form->{salesman_id} = SL::DB::Manager::Employee->current->id if exists $::form->{salesman_id}; - # if the name changed get new values - if (&check_name($form->{vc})) { - if($form->{payment_id} eq "") { - $form->{payment_id} = $payment_id; - } - &update; + IS->get_customer(\%myconfig, $form) if $vc eq 'customer'; + IR->get_vendor(\%myconfig, $form) if $vc eq 'vendor'; + + update(); $::dispatcher->end_request; } @@ -1281,7 +1430,7 @@ sub save { $form->{$idx} =~ s/\s*$//g; my $msg = ucfirst $form->{vc}; - $form->isblank($form->{vc}, $locale->text($msg . " missing!")); + $form->isblank($form->{vc} . '_id', $locale->text($msg . " missing!")); # $locale->text('Customer missing!'); # $locale->text('Vendor missing!'); @@ -1292,17 +1441,14 @@ sub save { remove_emptied_rows(); &validate_items; - my $payment_id; - if($form->{payment_id}) { - $payment_id = $form->{payment_id}; - } + my $vc = $form->{vc}; + if (($form->{"previous_${vc}_id"} || $form->{"${vc}_id"}) != $form->{"${vc}_id"}) { + $::form->{salesman_id} = SL::DB::Manager::Employee->current->id if exists $::form->{salesman_id}; - # if the name changed get new values - if (&check_name($form->{vc})) { - if($form->{payment_id} eq "") { - $form->{payment_id} = $payment_id; - } - &update; + IS->get_customer(\%myconfig, $form) if $vc eq 'customer'; + IR->get_vendor(\%myconfig, $form) if $vc eq 'vendor'; + + update(); $::dispatcher->end_request; } @@ -1445,15 +1591,14 @@ sub invoice { $form->{quodate} = $form->{transdate}; } - my $payment_id; - if ($form->{payment_id}) { - $payment_id = $form->{payment_id}; - } + my $vc = $form->{vc}; + if (($form->{"previous_${vc}_id"} || $form->{"${vc}_id"}) != $form->{"${vc}_id"}) { + $::form->{salesman_id} = SL::DB::Manager::Employee->current->id if exists $::form->{salesman_id}; + + IS->get_customer(\%myconfig, $form) if $vc eq 'customer'; + IR->get_vendor(\%myconfig, $form) if $vc eq 'vendor'; - # if the name changed get new values - if (&check_name($form->{vc})) { - $form->{payment_id} = $payment_id if $form->{payment_id} eq ""; - &update; + update(); $::dispatcher->end_request; } @@ -1462,7 +1607,7 @@ sub invoice { $form->{cp_id} *= 1; for my $i (1 .. $form->{rowcount}) { - for (qw(ship qty sellprice basefactor)) { + for (qw(ship qty sellprice basefactor discount)) { $form->{"${_}_${i}"} = $form->parse_amount(\%myconfig, $form->{"${_}_${i}"}) if $form->{"${_}_${i}"}; } $form->{"converted_from_orderitems_id_$i"} = delete $form->{"orderitems_id_$i"}; @@ -1519,8 +1664,6 @@ sub invoice { require "bin/mozilla/$form->{script}"; - map { $form->{"select$_"} = "" } ($form->{vc}, "currency"); - my $currency = $form->{currency}; &invoice_links; @@ -1888,27 +2031,6 @@ sub oe_delivery_order_from_order { delivery_order(); } -sub e_mail { - $main::lxdebug->enter_sub(); - - my $form = $main::form; - - check_oe_access(); - - $form->mtime_ischanged('oe','mail'); - $form->{print_and_save} = 1; - - my $saved_form = save_form(); - - save(); - - restore_form($saved_form, 0, qw(id ordnumber quonumber)); - - edit_e_mail(); - - $main::lxdebug->leave_sub(); -} - sub yes { call_sub($main::form->{yes_nextsub}); } @@ -2123,26 +2245,8 @@ sub _oe_remove_delivered_or_billed_rows { _remove_billed_or_delivered_rows(quantities => \%handled_base_qtys); } -# iterate all positions and match articlenumber -sub check_transport_cost_reminder_article_number { - $main::lxdebug->enter_sub(); - - my $form = $main::form; - - check_oe_access(); - - my $transport_article_id = $::instance_conf->get_transport_cost_reminder_article_number_id; - for my $i (1 .. $form->{rowcount}) { - return if $form->{"id_${i}"} eq $transport_article_id; - } - - # simply return the name of the part - return SL::DB::Part->new(id => $transport_article_id)->load()->partnumber; - - $main::lxdebug->leave_sub(); -} sub dispatcher { - foreach my $action (qw(delete delivery_order e_mail invoice print purchase_order quotation + foreach my $action (qw(delete delivery_order invoice print purchase_order quotation request_for_quotation sales_order save save_and_close save_as_new ship_to update)) { if ($::form->{"action_${action}"}) { call_sub($action);